1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/cert/internal/trust_store_nss.h"
#include <cert.h>
#include <certdb.h>
#include <pkcs11n.h>
#include <prtypes.h>
#include <memory>
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "crypto/scoped_test_nss_db.h"
#include "net/base/features.h"
#include "net/cert/internal/cert_issuer_source_sync_unittest.h"
#include "net/cert/internal/test_helpers.h"
#include "net/cert/scoped_nss_types.h"
#include "net/cert/x509_util.h"
#include "net/cert/x509_util_nss.h"
#include "net/test/cert_test_util.h"
#include "net/test/test_data_directory.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/boringssl/src/include/openssl/pool.h"
#include "third_party/boringssl/src/pki/parsed_certificate.h"
#include "third_party/boringssl/src/pki/trust_store.h"
namespace net {
namespace {
unsigned TrustTypeToNSSTrust(bssl::CertificateTrustType trust) {
switch (trust) {
case bssl::CertificateTrustType::DISTRUSTED:
return CERTDB_TERMINAL_RECORD;
case bssl::CertificateTrustType::UNSPECIFIED:
return 0;
case bssl::CertificateTrustType::TRUSTED_ANCHOR:
return CERTDB_TRUSTED_CA | CERTDB_VALID_CA;
case bssl::CertificateTrustType::TRUSTED_LEAF:
return CERTDB_TRUSTED | CERTDB_TERMINAL_RECORD;
case bssl::CertificateTrustType::TRUSTED_ANCHOR_OR_LEAF:
return CERTDB_TRUSTED_CA | CERTDB_VALID_CA | CERTDB_TRUSTED |
CERTDB_TERMINAL_RECORD;
}
}
std::shared_ptr<const bssl::ParsedCertificate> GetASSLTrustedBuiltinRoot() {
bssl::CertErrors parsing_errors;
ScopedCERTCertificate nss_cert = GetAnNssBuiltinSslTrustedRoot();
if (!nss_cert) {
return nullptr;
}
scoped_refptr<X509Certificate> ssl_trusted_root =
x509_util::CreateX509CertificateFromCERTCertificate(nss_cert.get());
if (!ssl_trusted_root) {
return nullptr;
}
return bssl::ParsedCertificate::Create(
bssl::UpRef(ssl_trusted_root->cert_buffer()),
x509_util::DefaultParseCertificateOptions(), &parsing_errors);
}
std::optional<unsigned> GetNSSTrustForCert(
const bssl::ParsedCertificate* cert) {
SECItem der_cert;
der_cert.data = const_cast<uint8_t*>(cert->der_cert().data());
der_cert.len = base::checked_cast<unsigned>(cert->der_cert().size());
der_cert.type = siDERCertBuffer;
ScopedCERTCertificate nss_cert(
CERT_FindCertByDERCert(CERT_GetDefaultCertDB(), &der_cert));
if (!nss_cert) {
return std::nullopt;
}
CERTCertTrust nss_cert_trust;
if (CERT_GetCertTrust(nss_cert.get(), &nss_cert_trust) != SECSuccess) {
return std::nullopt;
}
return SEC_GET_TRUST_FLAGS(&nss_cert_trust, trustSSL);
}
class TrustStoreNSSTestBase : public ::testing::Test {
public:
bssl::CertificateTrust ExpectedTrustForBuiltinAnchor() const {
return bssl::CertificateTrust::ForTrustAnchor();
}
bssl::CertificateTrust ExpectedTrustForAnchor() const {
return bssl::CertificateTrust::ForTrustAnchor()
.WithEnforceAnchorConstraints()
.WithEnforceAnchorExpiry();
}
bssl::CertificateTrust ExpectedTrustForAnchorOrLeaf() const {
return bssl::CertificateTrust::ForTrustAnchorOrLeaf()
.WithEnforceAnchorConstraints()
.WithEnforceAnchorExpiry();
}
bssl::CertificateTrust ExpectedTrustForLeaf() const {
return bssl::CertificateTrust::ForTrustedLeaf();
}
void SetUp() override {
ASSERT_TRUE(first_test_nssdb_.is_open());
ASSERT_TRUE(test_nssdb_.is_open());
ASSERT_TRUE(other_test_nssdb_.is_open());
bssl::ParsedCertificateList chain;
ReadCertChainFromFile(
"net/data/verify_certificate_chain_unittest/key-rollover/oldchain.pem",
&chain);
ASSERT_EQ(3U, chain.size());
target_ = chain[0];
oldintermediate_ = chain[1];
oldroot_ = chain[2];
ASSERT_TRUE(target_);
ASSERT_TRUE(oldintermediate_);
ASSERT_TRUE(oldroot_);
ReadCertChainFromFile(
"net/data/verify_certificate_chain_unittest/"
"key-rollover/longrolloverchain.pem",
&chain);
ASSERT_EQ(5U, chain.size());
newintermediate_ = chain[1];
newroot_ = chain[2];
newrootrollover_ = chain[3];
ASSERT_TRUE(newintermediate_);
ASSERT_TRUE(newroot_);
ASSERT_TRUE(newrootrollover_);
trust_store_nss_ = CreateTrustStoreNSS();
}
// Creates the TrustStoreNSS instance. Subclasses will customize the slot
// filtering behavior here.
virtual std::unique_ptr<TrustStoreNSS> CreateTrustStoreNSS() = 0;
std::string GetUniqueNickname() {
return "trust_store_nss_unittest" +
base::NumberToString(nickname_counter_++);
}
void AddCertToNSSSlot(const bssl::ParsedCertificate* cert,
PK11SlotInfo* slot) {
ScopedCERTCertificate nss_cert(
x509_util::CreateCERTCertificateFromBytes(cert->der_cert()));
ASSERT_TRUE(nss_cert);
SECStatus srv = PK11_ImportCert(slot, nss_cert.get(), CK_INVALID_HANDLE,
GetUniqueNickname().c_str(),
PR_FALSE /* includeTrust (unused) */);
ASSERT_EQ(SECSuccess, srv);
}
// Import `cert` into `slot` and create a trust record with `trust` type.
// Tries to ensure that the created trust record ends up in the same `slot`.
// (That isn't always the case if `cert` exists in multiple slots and
// CERT_ChangeCertTrust was just used on an arbitrary CERTCertificate handle
// for `cert`.)
void AddCertToNSSSlotWithTrust(const bssl::ParsedCertificate* cert,
PK11SlotInfo* slot,
bssl::CertificateTrustType trust) {
AddCertToNSSSlot(cert, slot);
ChangeCertTrustInSlot(cert, slot, trust);
}
void AddCertsToNSS() {
AddCertToNSSSlot(target_.get(), test_nssdb_.slot());
AddCertToNSSSlot(oldintermediate_.get(), test_nssdb_.slot());
AddCertToNSSSlot(newintermediate_.get(), test_nssdb_.slot());
AddCertToNSSSlot(oldroot_.get(), test_nssdb_.slot());
AddCertToNSSSlot(newroot_.get(), test_nssdb_.slot());
AddCertToNSSSlot(newrootrollover_.get(), test_nssdb_.slot());
// Check that the certificates can be retrieved as expected.
EXPECT_TRUE(
TrustStoreContains(target_, {newintermediate_, oldintermediate_}));
EXPECT_TRUE(TrustStoreContains(newintermediate_,
{newroot_, newrootrollover_, oldroot_}));
EXPECT_TRUE(TrustStoreContains(oldintermediate_,
{newroot_, newrootrollover_, oldroot_}));
EXPECT_TRUE(TrustStoreContains(newrootrollover_,
{newroot_, newrootrollover_, oldroot_}));
EXPECT_TRUE(
TrustStoreContains(oldroot_, {newroot_, newrootrollover_, oldroot_}));
EXPECT_TRUE(
TrustStoreContains(newroot_, {newroot_, newrootrollover_, oldroot_}));
}
// Trusts |cert|. Assumes the cert was already imported into NSS.
void TrustCert(const bssl::ParsedCertificate* cert) {
ChangeCertTrust(cert, CERTDB_TRUSTED_CA | CERTDB_VALID_CA);
}
// Trusts |cert| as a server, but not as a CA. Assumes the cert was already
// imported into NSS.
void TrustServerCert(const bssl::ParsedCertificate* cert) {
ChangeCertTrust(cert, CERTDB_TERMINAL_RECORD | CERTDB_TRUSTED);
}
// Trusts |cert| as both a server and as a CA. Assumes the cert was already
// imported into NSS.
void TrustCaAndServerCert(const bssl::ParsedCertificate* cert) {
ChangeCertTrust(cert, CERTDB_TERMINAL_RECORD | CERTDB_TRUSTED |
CERTDB_TRUSTED_CA | CERTDB_VALID_CA);
}
// Distrusts |cert|. Assumes the cert was already imported into NSS.
void DistrustCert(const bssl::ParsedCertificate* cert) {
ChangeCertTrust(cert, CERTDB_TERMINAL_RECORD);
}
void ChangeCertTrust(const bssl::ParsedCertificate* cert, int flags) {
SECItem der_cert;
der_cert.data = const_cast<uint8_t*>(cert->der_cert().data());
der_cert.len = base::checked_cast<unsigned>(cert->der_cert().size());
der_cert.type = siDERCertBuffer;
ScopedCERTCertificate nss_cert(
CERT_FindCertByDERCert(CERT_GetDefaultCertDB(), &der_cert));
ASSERT_TRUE(nss_cert);
CERTCertTrust trust = {0};
trust.sslFlags = flags;
SECStatus srv =
CERT_ChangeCertTrust(CERT_GetDefaultCertDB(), nss_cert.get(), &trust);
ASSERT_EQ(SECSuccess, srv);
}
// Change the trust for `cert` in `slot` to `trust`.
// `cert` must already exist in `slot'.
// Tries to ensure that the created trust record ends up in the same `slot`.
// (That isn't always the case if `cert` exists in multiple slots and
// CERT_ChangeCertTrust was just used on an arbitrary CERTCertificate handle
// for `cert`.)
// (An alternative approach would be to create the CKO_NSS_TRUST object
// directly using PK11_CreateManagedGenericObject, which has the advantage of
// being able to specify the slot directly, but the disadvantage that there's
// no guarantee the way the test creates the trust object matches what NSS
// actually does. See
// https://crrev.com/c/3732801/9/net/cert/internal/trust_store_nss_unittest.cc#412
// for some example code if that's ever needed.)
void ChangeCertTrustInSlot(const bssl::ParsedCertificate* cert,
PK11SlotInfo* slot,
bssl::CertificateTrustType trust) {
crypto::ScopedCERTCertList cert_list(PK11_ListCertsInSlot(slot));
ASSERT_TRUE(cert_list);
for (CERTCertListNode* node = CERT_LIST_HEAD(cert_list);
!CERT_LIST_END(node, cert_list); node = CERT_LIST_NEXT(node)) {
if (x509_util::IsSameCertificate(node->cert, cert->cert_buffer())) {
CERTCertTrust nss_trust = {0};
nss_trust.sslFlags = TrustTypeToNSSTrust(trust);
if (CERT_ChangeCertTrust(CERT_GetDefaultCertDB(), node->cert,
&nss_trust) != SECSuccess) {
ADD_FAILURE() << "CERT_ChangeCertTrust failed: " << PORT_GetError();
}
return;
}
}
ADD_FAILURE() << "cert not found in slot";
}
protected:
bool TrustStoreContains(std::shared_ptr<const bssl::ParsedCertificate> cert,
bssl::ParsedCertificateList expected_matches) {
bssl::ParsedCertificateList matches;
trust_store_nss_->SyncGetIssuersOf(cert.get(), &matches);
std::vector<std::string> name_result_matches;
for (const auto& it : matches)
name_result_matches.push_back(GetCertString(it));
std::sort(name_result_matches.begin(), name_result_matches.end());
std::vector<std::string> name_expected_matches;
for (const auto& it : expected_matches)
name_expected_matches.push_back(GetCertString(it));
std::sort(name_expected_matches.begin(), name_expected_matches.end());
if (name_expected_matches == name_result_matches)
return true;
// Print some extra information for debugging.
EXPECT_EQ(name_expected_matches, name_result_matches);
return false;
}
// Give simpler names to certificate DER (for identifying them in tests by
// their symbolic name).
std::string GetCertString(
const std::shared_ptr<const bssl::ParsedCertificate>& cert) const {
if (cert->der_cert() == oldroot_->der_cert())
return "oldroot_";
if (cert->der_cert() == newroot_->der_cert())
return "newroot_";
if (cert->der_cert() == target_->der_cert())
return "target_";
if (cert->der_cert() == oldintermediate_->der_cert())
return "oldintermediate_";
if (cert->der_cert() == newintermediate_->der_cert())
return "newintermediate_";
if (cert->der_cert() == newrootrollover_->der_cert())
return "newrootrollover_";
return cert->der_cert().AsString();
}
bool HasTrust(const bssl::ParsedCertificateList& certs,
bssl::CertificateTrust expected_trust) {
bool success = true;
for (const std::shared_ptr<const bssl::ParsedCertificate>& cert : certs) {
bssl::CertificateTrust trust = trust_store_nss_->GetTrust(cert.get());
std::string trust_string = trust.ToDebugString();
std::string expected_trust_string = expected_trust.ToDebugString();
if (trust_string != expected_trust_string) {
EXPECT_EQ(expected_trust_string, trust_string) << GetCertString(cert);
success = false;
}
}
return success;
}
std::shared_ptr<const bssl::ParsedCertificate> oldroot_;
std::shared_ptr<const bssl::ParsedCertificate> newroot_;
std::shared_ptr<const bssl::ParsedCertificate> target_;
std::shared_ptr<const bssl::ParsedCertificate> oldintermediate_;
std::shared_ptr<const bssl::ParsedCertificate> newintermediate_;
std::shared_ptr<const bssl::ParsedCertificate> newrootrollover_;
crypto::ScopedTestNSSDB first_test_nssdb_;
crypto::ScopedTestNSSDB test_nssdb_;
crypto::ScopedTestNSSDB other_test_nssdb_;
std::unique_ptr<TrustStoreNSS> trust_store_nss_;
unsigned nickname_counter_ = 0;
};
// Specifies which kind of per-slot filtering the TrustStoreNSS is supposed to
// perform in the parametrized TrustStoreNSSTestWithSlotFilterType.
enum class SlotFilterType {
kDontFilter,
kAllowSpecifiedUserSlot
};
std::string SlotFilterTypeToString(SlotFilterType slot_filter_type) {
switch (slot_filter_type) {
case SlotFilterType::kDontFilter:
return "DontFilter";
case SlotFilterType::kAllowSpecifiedUserSlot:
return "AllowSpecifiedUserSlot";
}
}
// Used for testing a TrustStoreNSS with the slot filter type specified by the
// test parameter. These tests are cases that are expected to be the same
// regardless of the slot filter type.
class TrustStoreNSSTestWithSlotFilterType
: public TrustStoreNSSTestBase,
public testing::WithParamInterface<SlotFilterType> {
public:
TrustStoreNSSTestWithSlotFilterType() = default;
~TrustStoreNSSTestWithSlotFilterType() override = default;
SlotFilterType slot_filter_type() const { return GetParam(); }
std::unique_ptr<TrustStoreNSS> CreateTrustStoreNSS() override {
switch (slot_filter_type()) {
case SlotFilterType::kDontFilter:
return std::make_unique<TrustStoreNSS>(
TrustStoreNSS::UseTrustFromAllUserSlots());
case SlotFilterType::kAllowSpecifiedUserSlot:
return std::make_unique<TrustStoreNSS>(
crypto::ScopedPK11Slot(PK11_ReferenceSlot(test_nssdb_.slot())));
}
}
};
// Without adding any certs to the NSS DB, should get no anchor results for
// any of the test certs.
TEST_P(TrustStoreNSSTestWithSlotFilterType, CertsNotPresent) {
EXPECT_TRUE(TrustStoreContains(target_, bssl::ParsedCertificateList()));
EXPECT_TRUE(
TrustStoreContains(newintermediate_, bssl::ParsedCertificateList()));
EXPECT_TRUE(TrustStoreContains(newroot_, bssl::ParsedCertificateList()));
EXPECT_TRUE(HasTrust({target_}, bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(
HasTrust({newintermediate_}, bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForUnspecified()));
}
// TrustStoreNSS should return temporary certs on Chrome OS, because on Chrome
// OS temporary certs are used to supply policy-provided untrusted authority
// certs. (See https://crbug.com/978854)
// On other platforms it's not required but doesn't hurt anything.
TEST_P(TrustStoreNSSTestWithSlotFilterType, TempCertPresent) {
ScopedCERTCertificate temp_nss_cert(
x509_util::CreateCERTCertificateFromBytes(newintermediate_->der_cert()));
EXPECT_TRUE(TrustStoreContains(target_, {newintermediate_}));
EXPECT_TRUE(HasTrust({target_}, bssl::CertificateTrust::ForUnspecified()));
}
// Independent of the specified slot-based filtering mode, built-in root certs
// should never be trusted.
TEST_P(TrustStoreNSSTestWithSlotFilterType, TrustAllowedForBuiltinRootCerts) {
auto builtin_root_cert = GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(builtin_root_cert);
EXPECT_TRUE(
HasTrust({builtin_root_cert}, bssl::CertificateTrust::ForUnspecified()));
}
// Check that ListCertsIgnoringNSSRoots and GetAllUserAddedCerts don't
// return built-in roots.
TEST_P(TrustStoreNSSTestWithSlotFilterType, ListCertsIgnoresBuiltinRoots) {
ScopedCERTCertificate root_cert = GetAnNssBuiltinSslTrustedRoot();
ASSERT_TRUE(root_cert);
for (const auto& result :
trust_store_nss_->TrustStoreNSS::ListCertsIgnoringNSSRoots()) {
EXPECT_FALSE(
x509_util::IsSameCertificate(result.cert.get(), root_cert.get()));
}
for (const auto& cert_with_trust : trust_store_nss_->GetAllUserAddedCerts()) {
EXPECT_FALSE(x509_util::IsSameCertificate(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
root_cert.get()));
}
}
// Check that GetAllUserAddedCerts doesn't return any client certs, as it is
// only supposed to return server certs.
TEST_P(TrustStoreNSSTestWithSlotFilterType, GetAllUserAddedCertsNoClientCerts) {
scoped_refptr<X509Certificate> client_cert =
ImportClientCertAndKeyFromFile(GetTestCertsDirectory(), "client_1.pem",
"client_1.pk8", test_nssdb_.slot());
ASSERT_TRUE(client_cert);
bool found = false;
for (const auto& result :
trust_store_nss_->TrustStoreNSS::ListCertsIgnoringNSSRoots()) {
found |= x509_util::IsSameCertificate(result.cert.get(), client_cert.get());
}
EXPECT_TRUE(found);
for (const auto& cert_with_trust : trust_store_nss_->GetAllUserAddedCerts()) {
EXPECT_FALSE(x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
client_cert->cert_buffer()));
}
}
// Check that GetAllUserAddedCerts will return a client cert that has had trust
// bits added for server auth.
TEST_P(TrustStoreNSSTestWithSlotFilterType,
GetAllUserAddedCertsManualTrustClientCert) {
scoped_refptr<X509Certificate> client_cert =
ImportClientCertAndKeyFromFile(GetTestCertsDirectory(), "client_1.pem",
"client_1.pk8", test_nssdb_.slot());
ASSERT_TRUE(client_cert);
std::shared_ptr<const bssl::ParsedCertificate> parsed_client_cert =
bssl::ParsedCertificate::Create(
bssl::UpRef(client_cert->cert_buffer()),
x509_util::DefaultParseCertificateOptions(), nullptr);
ASSERT_TRUE(parsed_client_cert);
TrustCert(parsed_client_cert.get());
{
bool found = false;
for (const auto& result :
trust_store_nss_->TrustStoreNSS::ListCertsIgnoringNSSRoots()) {
found |=
x509_util::IsSameCertificate(result.cert.get(), client_cert.get());
}
EXPECT_TRUE(found);
}
{
bool found = false;
for (const auto& cert_with_trust :
trust_store_nss_->GetAllUserAddedCerts()) {
found |= x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
client_cert->cert_buffer());
}
EXPECT_TRUE(found);
}
}
INSTANTIATE_TEST_SUITE_P(
All,
TrustStoreNSSTestWithSlotFilterType,
::testing::Values(SlotFilterType::kDontFilter,
SlotFilterType::kAllowSpecifiedUserSlot),
[](const testing::TestParamInfo<
TrustStoreNSSTestWithSlotFilterType::ParamType>& info) {
return SlotFilterTypeToString(info.param);
});
// Tests a TrustStoreNSS that ignores system root certs.
class TrustStoreNSSTestIgnoreSystemCerts : public TrustStoreNSSTestBase {
public:
std::unique_ptr<TrustStoreNSS> CreateTrustStoreNSS() override {
return std::make_unique<TrustStoreNSS>(
TrustStoreNSS::UseTrustFromAllUserSlots());
}
};
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UnknownCertIgnored) {
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForUnspecified()));
}
// An NSS CERTCertificate object exists for the cert, but it is not
// imported into any DB. Should be unspecified trust.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, TemporaryCertIgnored) {
ScopedCERTCertificate nss_cert(
x509_util::CreateCERTCertificateFromBytes(newroot_->der_cert()));
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForUnspecified()));
}
// Cert is added to user DB, but without explicitly calling
// CERT_ChangeCertTrust. Should be unspecified trust.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserCertWithNoTrust) {
AddCertsToNSS();
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForUnspecified()));
}
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserRootTrusted) {
AddCertsToNSS();
TrustCert(newroot_.get());
EXPECT_TRUE(HasTrust({newroot_}, ExpectedTrustForAnchor()));
}
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserRootDistrusted) {
AddCertsToNSS();
DistrustCert(newroot_.get());
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForDistrusted()));
}
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserTrustedServer) {
AddCertsToNSS();
TrustServerCert(target_.get());
EXPECT_TRUE(HasTrust({target_}, ExpectedTrustForLeaf()));
}
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserTrustedCaAndServer) {
AddCertsToNSS();
TrustCaAndServerCert(target_.get());
EXPECT_TRUE(HasTrust({target_}, ExpectedTrustForAnchorOrLeaf()));
}
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, SystemRootCertIgnored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
EXPECT_TRUE(
HasTrust({system_root}, bssl::CertificateTrust::ForUnspecified()));
}
// A system trusted root is also present in a user DB, but without any trust
// settings in the user DB. The system trust settings should not be used.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts,
SystemRootCertIgnoredWhenPresentInUserDb) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
AddCertToNSSSlot(system_root.get(), test_nssdb_.slot());
// TrustStoreNSS should see an Unspecified since we are ignoring the system
// slot.
EXPECT_TRUE(
HasTrust({system_root}, bssl::CertificateTrust::ForUnspecified()));
}
// A system trusted root is also present in a user DB, with TRUSTED_CA settings
// in the user DB. The system trust settings should not be used, but the trust
// from the user DB should be honored.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserDbTrustForSystemRootHonored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR);
// NSS should see the cert as trusted.
EXPECT_EQ(CERTDB_TRUSTED_CA | CERTDB_VALID_CA,
GetNSSTrustForCert(system_root.get()));
// TrustStoreNSS should see as TrustAnchor since the cert was trusted in the
// user slot.
EXPECT_TRUE(HasTrust({system_root}, ExpectedTrustForAnchor()));
}
// A system trusted root is also present in a user DB, with leaf trust in the
// user DB. The system trust settings should not be used, but the trust from
// the user DB should be honored.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts,
UserDbLeafTrustForSystemRootHonored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
// Add unrelated trust record to test that we find the correct one.
AddCertToNSSSlotWithTrust(newroot_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR);
// Trust the system cert as a leaf.
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_LEAF);
// Add unrelated trust record to test that we find the correct one.
AddCertToNSSSlotWithTrust(newintermediate_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
// NSS should see the cert as a trusted leaf.
EXPECT_EQ(CERTDB_TRUSTED | CERTDB_TERMINAL_RECORD,
GetNSSTrustForCert(system_root.get()));
// TrustStoreNSS should see as TrustedLeaf since the cert was trusted in the
// user slot.
EXPECT_TRUE(HasTrust({system_root}, ExpectedTrustForLeaf()));
}
// A system trusted root is also present in a user DB, with both CA and leaf
// trust in the user DB. The system trust settings should not be used, but the
// trust from the user DB should be honored.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts,
UserDbAnchorAndLeafTrustForSystemRootHonored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR_OR_LEAF);
// NSS should see the cert as both trusted leaf and CA.
EXPECT_EQ(CERTDB_TRUSTED_CA | CERTDB_VALID_CA | CERTDB_TRUSTED |
CERTDB_TERMINAL_RECORD,
GetNSSTrustForCert(system_root.get()));
// TrustStoreNSS should see as TrustAnchor since the cert was trusted in the
// user slot. The TrustStoreNSS implementation isn't able to pick up both the
// CA and Leaf trust in this case, but we don't really care.
EXPECT_TRUE(HasTrust({system_root}, ExpectedTrustForAnchor()));
}
// A system trusted root is also present in a user DB, with TERMINAL_RECORD
// settings in the user DB. The system trust settings should not be used, and
// the distrust from the user DB should be honored.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts, UserDbDistrustForSystemRootHonored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
// NSS should see the cert as distrusted.
EXPECT_EQ(CERTDB_TERMINAL_RECORD, GetNSSTrustForCert(system_root.get()));
// TrustStoreNSS should see as Distrusted since the cert was distrusted in
// the user slot.
EXPECT_TRUE(HasTrust({system_root}, bssl::CertificateTrust::ForDistrusted()));
}
// A system trusted root is also present in a user DB, with a trust object with
// no SSL trust flags set in the user DB. The system trust settings should not
// be used, and the lack of trust flags in the user DB should result in
// unspecified trust.
TEST_F(TrustStoreNSSTestIgnoreSystemCerts,
UserDbUnspecifiedTrustForSystemRootHonored) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::UNSPECIFIED);
// NSS should see the cert as unspecified trust.
EXPECT_EQ(0u, GetNSSTrustForCert(system_root.get()));
// TrustStoreNSS should see as Unspecified since the cert was marked
// unspecified in the user slot.
EXPECT_TRUE(
HasTrust({system_root}, bssl::CertificateTrust::ForUnspecified()));
}
// Tests a TrustStoreNSS that does not filter which certificates
class TrustStoreNSSTestWithoutSlotFilter : public TrustStoreNSSTestBase {
public:
std::unique_ptr<TrustStoreNSS> CreateTrustStoreNSS() override {
return std::make_unique<TrustStoreNSS>(
TrustStoreNSS::UseTrustFromAllUserSlots());
}
};
// If certs are present in NSS DB but aren't marked as trusted, should get no
// anchor results for any of the test certs.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, CertsPresentButNotTrusted) {
AddCertsToNSS();
// None of the certificates are trusted.
EXPECT_TRUE(HasTrust({oldroot_, newroot_, target_, oldintermediate_,
newintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
}
// Trust a single self-signed CA certificate.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, TrustedCA) {
AddCertsToNSS();
TrustCert(newroot_.get());
// Only one of the certificates are trusted.
EXPECT_TRUE(HasTrust(
{oldroot_, target_, oldintermediate_, newintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({newroot_}, ExpectedTrustForAnchor()));
}
// Distrust a single self-signed CA certificate.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, DistrustedCA) {
AddCertsToNSS();
DistrustCert(newroot_.get());
// Only one of the certificates are trusted.
EXPECT_TRUE(HasTrust(
{oldroot_, target_, oldintermediate_, newintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForDistrusted()));
}
// Trust a single intermediate certificate.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, TrustedIntermediate) {
AddCertsToNSS();
TrustCert(newintermediate_.get());
EXPECT_TRUE(HasTrust(
{oldroot_, newroot_, target_, oldintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({newintermediate_}, ExpectedTrustForAnchor()));
}
// Distrust a single intermediate certificate.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, DistrustedIntermediate) {
AddCertsToNSS();
DistrustCert(newintermediate_.get());
EXPECT_TRUE(HasTrust(
{oldroot_, newroot_, target_, oldintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(
HasTrust({newintermediate_}, bssl::CertificateTrust::ForDistrusted()));
}
// Trust a single server certificate.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, TrustedServer) {
AddCertsToNSS();
TrustServerCert(target_.get());
EXPECT_TRUE(HasTrust({oldroot_, newroot_, oldintermediate_, newintermediate_,
newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({target_}, ExpectedTrustForLeaf()));
}
// Trust a single certificate with both CA and server trust bits.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, TrustedCaAndServer) {
AddCertsToNSS();
TrustCaAndServerCert(target_.get());
EXPECT_TRUE(HasTrust({oldroot_, newroot_, oldintermediate_, newintermediate_,
newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({target_}, ExpectedTrustForAnchorOrLeaf()));
}
// Trust multiple self-signed CA certificates with the same name.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, MultipleTrustedCAWithSameSubject) {
AddCertsToNSS();
TrustCert(oldroot_.get());
TrustCert(newroot_.get());
EXPECT_TRUE(
HasTrust({target_, oldintermediate_, newintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({oldroot_, newroot_}, ExpectedTrustForAnchor()));
}
// Different trust settings for multiple self-signed CA certificates with the
// same name.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, DifferingTrustCAWithSameSubject) {
AddCertsToNSS();
DistrustCert(oldroot_.get());
TrustCert(newroot_.get());
EXPECT_TRUE(
HasTrust({target_, oldintermediate_, newintermediate_, newrootrollover_},
bssl::CertificateTrust::ForUnspecified()));
EXPECT_TRUE(HasTrust({oldroot_}, bssl::CertificateTrust::ForDistrusted()));
EXPECT_TRUE(HasTrust({newroot_}, ExpectedTrustForAnchor()));
}
// Check that ListCertsIgnoringNssRoots and GetAllUserAddedCerts are correctly
// looking at all slots.
TEST_F(TrustStoreNSSTestWithoutSlotFilter, ListCertsLooksAtAllSlots) {
AddCertToNSSSlotWithTrust(oldroot_.get(), first_test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
AddCertToNSSSlotWithTrust(newroot_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_LEAF);
{
bool found_newroot = false;
bool found_oldroot = false;
for (const auto& result :
trust_store_nss_->TrustStoreNSS::ListCertsIgnoringNSSRoots()) {
found_oldroot |= x509_util::IsSameCertificate(result.cert.get(),
oldroot_->cert_buffer());
found_newroot |= x509_util::IsSameCertificate(result.cert.get(),
newroot_->cert_buffer());
}
EXPECT_TRUE(found_newroot);
EXPECT_TRUE(found_oldroot);
}
{
bool found_newroot = false;
bool found_oldroot = false;
for (const auto& cert_with_trust :
trust_store_nss_->GetAllUserAddedCerts()) {
found_oldroot |= x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
oldroot_->cert_buffer());
found_newroot |= x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
newroot_->cert_buffer());
}
EXPECT_TRUE(found_newroot);
EXPECT_TRUE(found_oldroot);
}
}
// Tests for a TrustStoreNSS which does allows certificates on user slots to
// be only trusted if they are on a specific user slot.
class TrustStoreNSSTestAllowSpecifiedUserSlot : public TrustStoreNSSTestBase {
public:
TrustStoreNSSTestAllowSpecifiedUserSlot() = default;
~TrustStoreNSSTestAllowSpecifiedUserSlot() override = default;
std::unique_ptr<TrustStoreNSS> CreateTrustStoreNSS() override {
return std::make_unique<TrustStoreNSS>(
crypto::ScopedPK11Slot(PK11_ReferenceSlot(test_nssdb_.slot())));
}
};
// A certificate that is stored on a "user slot" is trusted if the
// TrustStoreNSS is allowed to trust that user slot.
TEST_F(TrustStoreNSSTestAllowSpecifiedUserSlot, CertOnUserSlot) {
AddCertToNSSSlotWithTrust(newroot_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR);
EXPECT_TRUE(HasTrust({newroot_}, ExpectedTrustForAnchor()));
}
// A certificate that is stored on a "user slot" is not trusted if the
// TrustStoreNSS is allowed to trust a user slot, but the certificate is
// stored on another user slot.
TEST_F(TrustStoreNSSTestAllowSpecifiedUserSlot, CertOnOtherUserSlot) {
AddCertToNSSSlotWithTrust(newroot_.get(), other_test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR);
EXPECT_TRUE(HasTrust({newroot_}, bssl::CertificateTrust::ForUnspecified()));
}
// The same certificate is stored in multiple user slots with different trust
// settings. Ensure that the correct trust setting is used.
TEST_F(TrustStoreNSSTestAllowSpecifiedUserSlot, CertOnMultipleSlots) {
// Add unrelated trust record to test that we find the correct one.
AddCertToNSSSlotWithTrust(newintermediate_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
AddCertToNSSSlotWithTrust(newroot_.get(), first_test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
AddCertToNSSSlotWithTrust(newroot_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_ANCHOR);
AddCertToNSSSlotWithTrust(newroot_.get(), other_test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_LEAF);
// Add unrelated trust record to test that we find the correct one.
AddCertToNSSSlotWithTrust(target_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
EXPECT_TRUE(HasTrust({newroot_}, ExpectedTrustForAnchor()));
}
// A NSS trusted root certificate is also stored in multiple user slots with
// different trust settings. Ensure that the correct trust setting is used.
TEST_F(TrustStoreNSSTestAllowSpecifiedUserSlot, SystemRootCertOnMultipleSlots) {
std::shared_ptr<const bssl::ParsedCertificate> system_root =
GetASSLTrustedBuiltinRoot();
ASSERT_TRUE(system_root);
EXPECT_EQ(CERTDB_TRUSTED_CA | CERTDB_VALID_CA,
GetNSSTrustForCert(system_root.get()));
AddCertToNSSSlotWithTrust(system_root.get(), first_test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
AddCertToNSSSlotWithTrust(system_root.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_LEAF);
AddCertToNSSSlotWithTrust(system_root.get(), other_test_nssdb_.slot(),
bssl::CertificateTrustType::UNSPECIFIED);
EXPECT_TRUE(HasTrust({system_root}, ExpectedTrustForLeaf()));
}
// Check to see ListCertsIgnoringNSSRoots and GetAllUserAddedCerts correctly
// enforce slot filters.
TEST_F(TrustStoreNSSTestAllowSpecifiedUserSlot, ListCertsFiltersBySlot) {
// Should not be in the results.
AddCertToNSSSlotWithTrust(oldroot_.get(), first_test_nssdb_.slot(),
bssl::CertificateTrustType::DISTRUSTED);
// Should be in the results.
AddCertToNSSSlotWithTrust(newroot_.get(), test_nssdb_.slot(),
bssl::CertificateTrustType::TRUSTED_LEAF);
{
bool found_newroot = false;
for (const auto& result :
trust_store_nss_->TrustStoreNSS::ListCertsIgnoringNSSRoots()) {
EXPECT_FALSE(x509_util::IsSameCertificate(result.cert.get(),
oldroot_->cert_buffer()));
found_newroot |= x509_util::IsSameCertificate(result.cert.get(),
newroot_->cert_buffer());
}
EXPECT_TRUE(found_newroot);
}
{
bool found_newroot = false;
for (const auto& cert_with_trust :
trust_store_nss_->GetAllUserAddedCerts()) {
EXPECT_FALSE(x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
oldroot_->cert_buffer()));
found_newroot |= x509_util::CryptoBufferEqual(
x509_util::CreateCryptoBuffer(cert_with_trust.cert_bytes).get(),
newroot_->cert_buffer());
}
EXPECT_TRUE(found_newroot);
}
}
// TODO(crbug.com/41468842): If the internal non-removable slot is
// relevant on Chrome OS, add a test for allowing trust for certificates
// stored on that slot.
class TrustStoreNSSTestDelegate {
public:
TrustStoreNSSTestDelegate()
: trust_store_nss_(TrustStoreNSS::UseTrustFromAllUserSlots()) {}
void AddCert(std::shared_ptr<const bssl::ParsedCertificate> cert) {
ASSERT_TRUE(test_nssdb_.is_open());
ScopedCERTCertificate nss_cert(
x509_util::CreateCERTCertificateFromBytes(cert->der_cert()));
ASSERT_TRUE(nss_cert);
SECStatus srv = PK11_ImportCert(
test_nssdb_.slot(), nss_cert.get(), CK_INVALID_HANDLE,
GetUniqueNickname().c_str(), PR_FALSE /* includeTrust (unused) */);
ASSERT_EQ(SECSuccess, srv);
}
bssl::CertIssuerSource& source() { return trust_store_nss_; }
protected:
std::string GetUniqueNickname() {
return "cert_issuer_source_nss_unittest" +
base::NumberToString(nickname_counter_++);
}
crypto::ScopedTestNSSDB test_nssdb_;
TrustStoreNSS trust_store_nss_;
unsigned int nickname_counter_ = 0;
};
INSTANTIATE_TYPED_TEST_SUITE_P(TrustStoreNSSTest2,
CertIssuerSourceSyncTest,
TrustStoreNSSTestDelegate);
// NSS doesn't normalize UTF8String values, so use the not-normalized version
// of those tests.
INSTANTIATE_TYPED_TEST_SUITE_P(TrustStoreNSSNotNormalizedTest,
CertIssuerSourceSyncNotNormalizedTest,
TrustStoreNSSTestDelegate);
} // namespace
} // namespace net
|