1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/cert/multi_threaded_cert_verifier.h"
#include <memory>
#include "base/debug/leak_annotations.h"
#include "base/files/file_path.h"
#include "base/format_macros.h"
#include "base/functional/bind.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/cert/cert_verify_proc.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/crl_set.h"
#include "net/cert/mock_cert_verifier.h"
#include "net/cert/x509_certificate.h"
#include "net/log/net_log_with_source.h"
#include "net/test/cert_test_util.h"
#include "net/test/gtest_util.h"
#include "net/test/test_data_directory.h"
#include "net/test/test_with_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/abseil-cpp/absl/strings/str_format.h"
using net::test::IsError;
using net::test::IsOk;
using testing::_;
using testing::DoAll;
using testing::Return;
namespace net {
class ChromeRootStoreData;
class CertNetFetcher;
namespace {
void FailTest(int /* result */) {
FAIL();
}
class MockCertVerifyProc : public CertVerifyProc {
public:
MockCertVerifyProc() : CertVerifyProc(CRLSet::BuiltinCRLSet()) {}
MOCK_METHOD7(VerifyInternal,
int(X509Certificate*,
const std::string&,
const std::string&,
const std::string&,
int,
CertVerifyResult*,
const NetLogWithSource&));
MOCK_CONST_METHOD0(SupportsAdditionalTrustAnchors, bool());
private:
~MockCertVerifyProc() override = default;
};
ACTION(SetCertVerifyResult) {
X509Certificate* cert = arg0;
CertVerifyResult* result = arg5;
result->Reset();
result->verified_cert = cert;
result->cert_status = CERT_STATUS_COMMON_NAME_INVALID;
}
ACTION(SetCertVerifyRevokedResult) {
X509Certificate* cert = arg0;
CertVerifyResult* result = arg5;
result->Reset();
result->verified_cert = cert;
result->cert_status = CERT_STATUS_REVOKED;
}
class SwapWithNewProcFactory : public CertVerifyProcFactory {
public:
explicit SwapWithNewProcFactory(scoped_refptr<CertVerifyProc> new_mock_proc)
: mock_verify_proc_(std::move(new_mock_proc)) {}
scoped_refptr<net::CertVerifyProc> CreateCertVerifyProc(
scoped_refptr<CertNetFetcher> cert_net_fetcher,
const CertVerifyProc::ImplParams& impl_params,
const CertVerifyProc::InstanceParams& instance_params) override {
return mock_verify_proc_;
}
protected:
~SwapWithNewProcFactory() override = default;
scoped_refptr<CertVerifyProc> mock_verify_proc_;
};
} // namespace
class MultiThreadedCertVerifierTest : public TestWithTaskEnvironment {
public:
MultiThreadedCertVerifierTest()
: mock_verify_proc_(base::MakeRefCounted<MockCertVerifyProc>()),
mock_new_verify_proc_(base::MakeRefCounted<MockCertVerifyProc>()),
verifier_(std::make_unique<MultiThreadedCertVerifier>(
mock_verify_proc_,
base::MakeRefCounted<SwapWithNewProcFactory>(
mock_new_verify_proc_))) {
EXPECT_CALL(*mock_verify_proc_, SupportsAdditionalTrustAnchors())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mock_verify_proc_, VerifyInternal(_, _, _, _, _, _, _))
.WillRepeatedly(
DoAll(SetCertVerifyResult(), Return(ERR_CERT_COMMON_NAME_INVALID)));
}
~MultiThreadedCertVerifierTest() override = default;
protected:
scoped_refptr<MockCertVerifyProc> mock_verify_proc_;
// The new verify_proc_ swapped in if the proc is updated.
scoped_refptr<MockCertVerifyProc> mock_new_verify_proc_;
std::unique_ptr<MultiThreadedCertVerifier> verifier_;
};
// Tests that the callback of a canceled request is never made.
TEST_F(MultiThreadedCertVerifierTest, CancelRequest) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_NE(static_cast<X509Certificate*>(nullptr), test_cert.get());
int error;
CertVerifyResult verify_result;
std::unique_ptr<CertVerifier::Request> request;
error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, base::BindOnce(&FailTest), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
ASSERT_TRUE(request);
request.reset();
// Issue a few more requests to the worker pool and wait for their
// completion, so that the task of the canceled request (which runs on a
// worker thread) is likely to complete by the end of this test.
TestCompletionCallback callback;
for (int i = 0; i < 5; ++i) {
error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www2.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
error = callback.WaitForResult();
}
}
// Tests that the callback of a request is never made if the |verifier_| itself
// is deleted.
TEST_F(MultiThreadedCertVerifierTest, DeleteVerifier) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_NE(static_cast<X509Certificate*>(nullptr), test_cert.get());
int error;
CertVerifyResult verify_result;
std::unique_ptr<CertVerifier::Request> request;
error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, base::BindOnce(&FailTest), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
ASSERT_TRUE(request);
verifier_.reset();
RunUntilIdle();
}
namespace {
struct CertVerifyResultHelper {
void FailTest(int /* result */) { FAIL(); }
std::unique_ptr<CertVerifier::Request> request;
};
} // namespace
// The same as the above "DeleteVerifier" test, except the callback provided
// will own the CertVerifier::Request as allowed by the CertVerifier contract.
// This is a regression test for https://crbug.com/1157562.
TEST_F(MultiThreadedCertVerifierTest, DeleteVerifierCallbackOwnsResult) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_NE(static_cast<X509Certificate*>(nullptr), test_cert.get());
int error;
CertVerifyResult verify_result;
std::unique_ptr<CertVerifyResultHelper> result_helper =
std::make_unique<CertVerifyResultHelper>();
CertVerifyResultHelper* result_helper_ptr = result_helper.get();
CompletionOnceCallback callback = base::BindOnce(
&CertVerifyResultHelper::FailTest, std::move(result_helper));
error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, std::move(callback), &result_helper_ptr->request,
NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
ASSERT_TRUE(result_helper_ptr->request);
verifier_.reset();
RunUntilIdle();
}
// Tests that a canceled request is not leaked.
TEST_F(MultiThreadedCertVerifierTest, CancelRequestThenQuit) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_NE(static_cast<X509Certificate*>(nullptr), test_cert.get());
int error;
CertVerifyResult verify_result;
TestCompletionCallback callback;
std::unique_ptr<CertVerifier::Request> request;
{
// Because shutdown intentionally doesn't join worker threads, memory may
// be leaked if the main thread shuts down before the worker thread
// completes. In particular MultiThreadedCertVerifier calls
// base::WorkerPool::PostTaskAndReply(), which leaks its "relay" when it
// can't post the reply back to the origin thread. See
// https://crbug.com/522514
ANNOTATE_SCOPED_MEMORY_LEAK;
error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
}
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
request.reset();
// Destroy |verifier_| by going out of scope.
}
// Tests propagation of configuration options into CertVerifyProc flags
TEST_F(MultiThreadedCertVerifierTest, ConvertsConfigToFlags) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_TRUE(test_cert);
const struct TestConfig {
bool CertVerifier::Config::*config_ptr;
int expected_flag;
} kTestConfig[] = {
{&CertVerifier::Config::enable_rev_checking,
CertVerifyProc::VERIFY_REV_CHECKING_ENABLED},
{&CertVerifier::Config::require_rev_checking_local_anchors,
CertVerifyProc::VERIFY_REV_CHECKING_REQUIRED_LOCAL_ANCHORS},
{&CertVerifier::Config::enable_sha1_local_anchors,
CertVerifyProc::VERIFY_ENABLE_SHA1_LOCAL_ANCHORS},
};
for (const auto& test_config : kTestConfig) {
CertVerifier::Config config;
config.*test_config.config_ptr = true;
verifier_->SetConfig(config);
EXPECT_CALL(*mock_verify_proc_,
VerifyInternal(_, _, _, _, test_config.expected_flag, _, _))
.WillRepeatedly(
DoAll(SetCertVerifyRevokedResult(), Return(ERR_CERT_REVOKED)));
CertVerifyResult verify_result;
TestCompletionCallback callback;
std::unique_ptr<CertVerifier::Request> request;
int error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
error = callback.WaitForResult();
EXPECT_TRUE(IsCertificateError(error));
EXPECT_THAT(error, IsError(ERR_CERT_REVOKED));
testing::Mock::VerifyAndClearExpectations(mock_verify_proc_.get());
}
}
// Tests propagation of CertVerifier flags into CertVerifyProc flags
TEST_F(MultiThreadedCertVerifierTest, ConvertsFlagsToFlags) {
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(GetTestCertsDirectory(), "ok_cert.pem"));
ASSERT_TRUE(test_cert);
const struct TestConfig {
int verifier_flag;
int expected_proc_flag;
} kTestConfig[] = {
{CertVerifier::VERIFY_DISABLE_NETWORK_FETCHES,
CertVerifyProc::VERIFY_DISABLE_NETWORK_FETCHES},
{CertVerifier::VERIFY_SXG_CT_REQUIREMENTS,
CertVerifyProc::VERIFY_SXG_CT_REQUIREMENTS},
};
for (const auto& test_config : kTestConfig) {
SCOPED_TRACE(absl::StrFormat("verifier_flag=%i expected_proc_flag=%i",
test_config.verifier_flag,
test_config.expected_proc_flag));
EXPECT_CALL(
*mock_verify_proc_,
VerifyInternal(_, _, _, _, test_config.expected_proc_flag, _, _))
.WillRepeatedly(
DoAll(SetCertVerifyRevokedResult(), Return(ERR_CERT_REVOKED)));
CertVerifyResult verify_result;
TestCompletionCallback callback;
std::unique_ptr<CertVerifier::Request> request;
int error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com",
test_config.verifier_flag,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
error = callback.WaitForResult();
EXPECT_TRUE(IsCertificateError(error));
EXPECT_THAT(error, IsError(ERR_CERT_REVOKED));
testing::Mock::VerifyAndClearExpectations(mock_verify_proc_.get());
}
}
// Tests swapping in new Chrome Root Store Data.
TEST_F(MultiThreadedCertVerifierTest, VerifyProcChangeChromeRootStore) {
CertVerifierObserverCounter observer_counter(verifier_.get());
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_TRUE(test_cert);
EXPECT_EQ(observer_counter.change_count(), 0u);
EXPECT_CALL(*mock_new_verify_proc_, VerifyInternal(_, _, _, _, _, _, _))
.WillRepeatedly(
DoAll(SetCertVerifyRevokedResult(), Return(ERR_CERT_REVOKED)));
verifier_->UpdateVerifyProcData(nullptr, {}, {});
EXPECT_EQ(observer_counter.change_count(), 1u);
CertVerifyResult verify_result;
TestCompletionCallback callback;
std::unique_ptr<CertVerifier::Request> request;
int error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
error = callback.WaitForResult();
EXPECT_TRUE(IsCertificateError(error));
EXPECT_THAT(error, IsError(ERR_CERT_REVOKED));
testing::Mock::VerifyAndClearExpectations(mock_verify_proc_.get());
testing::Mock::VerifyAndClearExpectations(mock_new_verify_proc_.get());
}
// Tests swapping out a new proc while a request is pending still uses
// the old proc for the old request.
TEST_F(MultiThreadedCertVerifierTest, VerifyProcChangeRequest) {
base::FilePath certs_dir = GetTestCertsDirectory();
scoped_refptr<X509Certificate> test_cert(
ImportCertFromFile(certs_dir, "ok_cert.pem"));
ASSERT_TRUE(test_cert);
CertVerifyResult verify_result;
TestCompletionCallback callback;
std::unique_ptr<CertVerifier::Request> request;
int error = verifier_->Verify(
CertVerifier::RequestParams(test_cert, "www.example.com", 0,
/*ocsp_response=*/std::string(),
/*sct_list=*/std::string()),
&verify_result, callback.callback(), &request, NetLogWithSource());
ASSERT_THAT(error, IsError(ERR_IO_PENDING));
EXPECT_TRUE(request);
verifier_->UpdateVerifyProcData(nullptr, {}, {});
error = callback.WaitForResult();
EXPECT_TRUE(IsCertificateError(error));
EXPECT_THAT(error, IsError(ERR_CERT_COMMON_NAME_INVALID));
testing::Mock::VerifyAndClearExpectations(mock_verify_proc_.get());
testing::Mock::VerifyAndClearExpectations(mock_new_verify_proc_.get());
}
} // namespace net
|