1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/dns/dns_task_results_manager.h"
#include <algorithm>
#include <memory>
#include <optional>
#include <string_view>
#include "base/check.h"
#include "base/functional/callback_forward.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "net/base/connection_endpoint_metadata.h"
#include "net/base/net_errors.h"
#include "net/dns/host_resolver_internal_result.h"
#include "net/dns/host_resolver_results_test_util.h"
#include "net/dns/https_record_rdata.h"
#include "net/test/test_with_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#include "url/scheme_host_port.h"
using ::testing::ElementsAre;
using ::testing::IsEmpty;
using ::testing::UnorderedElementsAre;
namespace net {
namespace {
class FakeDelegate : public DnsTaskResultsManager::Delegate {
public:
FakeDelegate() = default;
~FakeDelegate() override = default;
private:
void OnServiceEndpointsUpdated() override {
// Do nothing for now.
}
};
IPEndPoint MakeIPEndPoint(std::string_view ip_literal, uint16_t port = 0) {
std::optional<IPAddress> ip = IPAddress::FromIPLiteral(std::move(ip_literal));
return IPEndPoint(*ip, port);
}
std::unique_ptr<HostResolverInternalDataResult> CreateDataResult(
std::string_view domain_name,
std::vector<IPEndPoint> ip_endpoints,
DnsQueryType query_type) {
return std::make_unique<HostResolverInternalDataResult>(
std::string(domain_name), query_type, /*expiration=*/base::TimeTicks(),
/*timed_expiration=*/base::Time(),
HostResolverInternalResult::Source::kDns, std::move(ip_endpoints),
std::vector<std::string>(), std::vector<HostPortPair>());
}
std::unique_ptr<HostResolverInternalErrorResult> CreateNoData(
std::string_view domain_name,
DnsQueryType query_type) {
return std::make_unique<HostResolverInternalErrorResult>(
std::string(domain_name), query_type, /*expiration=*/base::TimeTicks(),
/*timed_expiration=*/base::Time(),
HostResolverInternalResult::Source::kDns, ERR_NAME_NOT_RESOLVED);
}
std::unique_ptr<HostResolverInternalMetadataResult> CreateMetadata(
std::string_view domain_name,
std::multimap<HttpsRecordPriority, ConnectionEndpointMetadata> metadatas) {
return std::make_unique<HostResolverInternalMetadataResult>(
std::string(domain_name), DnsQueryType::HTTPS,
/*expiration=*/base::TimeTicks(), /*timed_expiration=*/base::Time(),
HostResolverInternalResult::Source::kDns, std::move(metadatas));
}
std::unique_ptr<HostResolverInternalAliasResult> CreateAlias(
std::string_view domain_name,
DnsQueryType query_type,
std::string_view alias_target) {
return std::make_unique<HostResolverInternalAliasResult>(
std::string(domain_name), query_type, /*expiration=*/base::TimeTicks(),
/*timed_expiration=*/base::Time(),
HostResolverInternalResult::Source::kDns, std::string(alias_target));
}
std::vector<IPEndPoint> WithPort(const std::vector<IPEndPoint>& endpoints,
uint16_t port) {
std::vector<IPEndPoint> out_endpoints;
for (const auto& endpoint : endpoints) {
out_endpoints.emplace_back(endpoint.address(), port);
}
return out_endpoints;
}
static constexpr std::string_view kHostName = "www.example.com";
static constexpr std::string_view kAliasTarget1 = "alias1.example.net";
static constexpr std::string_view kAliasTarget2 = "alias2.example.net";
static const ConnectionEndpointMetadata kMetadata1(
/*supported_protocol_alpns=*/{"h3"},
/*ech_config_list=*/{},
std::string(kHostName),
{});
static const ConnectionEndpointMetadata kMetadata2(
/*supported_protocol_alpns=*/{"h2", "http/1.1"},
/*ech_config_list=*/{},
std::string(kHostName),
{});
static const std::multimap<HttpsRecordPriority, ConnectionEndpointMetadata>
kMetadatas{{1, kMetadata1}, {2, kMetadata2}, {}};
// A helper class to create a DnsTaskResultsManager.
class ManagerFactory {
public:
explicit ManagerFactory(DnsTaskResultsManager::Delegate* delegate)
: delegate_(delegate),
host_(
HostResolver::Host(url::SchemeHostPort("https", kHostName, 443))) {}
std::unique_ptr<DnsTaskResultsManager> Create() {
return std::make_unique<DnsTaskResultsManager>(
delegate_, host_, query_types_, NetLogWithSource());
}
ManagerFactory& query_types(DnsQueryTypeSet query_types) {
query_types_ = query_types;
return *this;
}
private:
raw_ptr<DnsTaskResultsManager::Delegate> delegate_;
HostResolver::Host host_;
DnsQueryTypeSet query_types_ = {DnsQueryType::A, DnsQueryType::AAAA,
DnsQueryType::HTTPS};
};
} // namespace
class DnsTaskResultsManagerTest : public TestWithTaskEnvironment {
public:
DnsTaskResultsManagerTest()
: TestWithTaskEnvironment(
base::test::TaskEnvironment::TimeSource::MOCK_TIME) {}
void SetUp() override { delegate_ = std::make_unique<FakeDelegate>(); }
protected:
ManagerFactory factory() { return ManagerFactory(delegate_.get()); }
private:
std::unique_ptr<FakeDelegate> delegate_;
};
TEST_F(DnsTaskResultsManagerTest, IsMetadataReady) {
// HTTPS RR is not queried.
std::unique_ptr<DnsTaskResultsManager> manager =
factory().query_types({DnsQueryType::A, DnsQueryType::AAAA}).Create();
ASSERT_TRUE(manager->IsMetadataReady());
// HTTPS RR is queried.
manager = factory()
.query_types(
{DnsQueryType::A, DnsQueryType::AAAA, DnsQueryType::HTTPS})
.Create();
ASSERT_FALSE(manager->IsMetadataReady());
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, /*results=*/{});
ASSERT_TRUE(manager->IsMetadataReady());
}
TEST_F(DnsTaskResultsManagerTest, IPv6NotQueried) {
std::unique_ptr<DnsTaskResultsManager> manager =
factory().query_types({DnsQueryType::A, DnsQueryType::HTTPS}).Create();
std::unique_ptr<HostResolverInternalResult> result = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)))));
EXPECT_THAT(manager->GetAliases(), UnorderedElementsAre(kHostName));
}
TEST_F(DnsTaskResultsManagerTest, IPv4First) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A comes first. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is responded. Service endpoints should be available.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv6First) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// AAAA comes first. Service endpoints should be available immediately.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result1.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
// A is responded. Service endpoints should be updated.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1"), MakeIPEndPoint("192.0.2.2")},
DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443),
MakeIPEndPoint("192.0.2.2", 443)),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv6Timedout) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A comes first. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is timed out. Service endpoints should be available after timeout.
FastForwardBy(DnsTaskResultsManager::GetResolutionDelay() +
base::Milliseconds(1));
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)))));
// AAAA is responded after timeout. Service endpoints should be updated.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv6NoDataBeforeIPv4) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// AAAA is responded with no data. Service endpoints should not be available.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateNoData(kHostName, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// A is responded. Service endpoints creation should happen without resolution
// delay.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv6NoDataAfterIPv4) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A is responded. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is responded with no data before the resolution delay timer. Service
// endpoints should be available without waiting for the timeout.
std::unique_ptr<HostResolverInternalResult> result2 =
CreateNoData(kHostName, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv6EmptyDataAfterIPv4) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A is responded. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is responded with a non-cacheable result (an empty result) before the
// resolution delay timer. Service endpoints should be available without
// waiting for the timeout.
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, IPv4AndIPv6NoData) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// AAAA is responded with no data. Service endpoints should not be available.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateNoData(kHostName, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// A is responded with no data. Service endpoints should not be available.
std::unique_ptr<HostResolverInternalResult> result2 =
CreateNoData(kHostName, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result2.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
}
TEST_F(DnsTaskResultsManagerTest, IPv4NoDataIPv6AfterResolutionDelay) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A comes first with no data. Service endpoints creation should be delayed
// and the resolution delay timer should not start.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateNoData(kHostName, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_FALSE(manager->IsResolutionDelayTimerRunningForTest());
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// The resolution delay passed. Service endpoints should not be available yet.
FastForwardBy(DnsTaskResultsManager::GetResolutionDelay() +
base::Milliseconds(1));
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is responded. Service endpoints should be updated.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result2.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, MetadataFirst) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// HTTPS comes first. Service endpoints should not be available yet since
// Chrome doesn't support ipv{4,6}hint yet.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateMetadata(kHostName, kMetadatas);
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, {result1.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
ASSERT_TRUE(manager->IsMetadataReady());
// A is responded. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result2.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is responded. Service endpoints should be available with metadatas.
std::unique_ptr<HostResolverInternalResult> result3 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result3.get()});
EXPECT_THAT(
manager->GetCurrentEndpoints(),
ElementsAre(
ExpectServiceEndpoint(ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)),
kMetadata1),
ExpectServiceEndpoint(ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)),
kMetadata2)));
}
TEST_F(DnsTaskResultsManagerTest, MetadataDifferentTargetName) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// HTTPS is responded and the target name is different from QNAME.
const ConnectionEndpointMetadata kMetadataDifferentTargetName(
/*supported_protocol_alpns=*/{"h2", "http/1.1"},
/*ech_config_list=*/{},
/*target_name=*/"other.example.net.", {});
std::unique_ptr<HostResolverInternalResult> result1 =
CreateMetadata(kHostName, {{1, kMetadataDifferentTargetName}});
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, {result1.get()});
ASSERT_TRUE(manager->IsMetadataReady());
// AAAA is responded. Service endpoints should be available without metadatas
// since the target name is different.
std::unique_ptr<HostResolverInternalResult> result2 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result2.get()});
ASSERT_TRUE(manager->IsMetadataReady());
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
}
TEST_F(DnsTaskResultsManagerTest, MetadataAfterIPv6) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// AAAA comes first. Service endpoints should be available without metadatas.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result1.get()});
ASSERT_FALSE(manager->IsMetadataReady());
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
// HTTPS is responded. Metadata should be available.
std::unique_ptr<HostResolverInternalResult> result2 =
CreateMetadata(kHostName, kMetadatas);
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, {result2.get()});
ASSERT_TRUE(manager->IsMetadataReady());
EXPECT_THAT(
manager->GetCurrentEndpoints(),
ElementsAre(
ExpectServiceEndpoint(IsEmpty(),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)),
kMetadata1),
ExpectServiceEndpoint(IsEmpty(),
ElementsAre(MakeIPEndPoint("2001:db8::1", 443)),
kMetadata2)));
}
TEST_F(DnsTaskResultsManagerTest, IPv6TimedoutAfterMetadata) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// A comes first. Service endpoints creation should be delayed.
std::unique_ptr<HostResolverInternalResult> result1 = CreateDataResult(
kHostName, {MakeIPEndPoint("192.0.2.1")}, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result1.get()});
ASSERT_FALSE(manager->IsMetadataReady());
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// HTTPS is responded. Service endpoints should not be available because
// the manager is waiting for the resolution delay and Chrome doesn't support
// ipv6hint yet.
std::unique_ptr<HostResolverInternalResult> result2 =
CreateMetadata(kHostName, kMetadatas);
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, {result2.get()});
ASSERT_TRUE(manager->IsMetadataReady());
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is timed out. Service endpoints should be available with metadatas.
FastForwardBy(DnsTaskResultsManager::GetResolutionDelay() +
base::Milliseconds(1));
ASSERT_TRUE(manager->IsMetadataReady());
EXPECT_THAT(
manager->GetCurrentEndpoints(),
ElementsAre(
ExpectServiceEndpoint(ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
IsEmpty(), kMetadata1),
ExpectServiceEndpoint(ElementsAre(MakeIPEndPoint("192.0.2.1", 443)),
IsEmpty(), kMetadata2)));
}
TEST_F(DnsTaskResultsManagerTest, IPv4NoDataIPv6TimedoutAfterMetadata) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// HTTPS is responded. Service endpoints should not be available because
// the manager is waiting for the resolution delay and Chrome doesn't support
// address hints yet.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateMetadata(kHostName, kMetadatas);
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS, {result1.get()});
ASSERT_TRUE(manager->IsMetadataReady());
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// A is responded with no address. Service endpoints should not be available
// since there are no addresses.
std::unique_ptr<HostResolverInternalResult> result2 =
CreateNoData(kHostName, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result2.get()});
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
// AAAA is timed out. Service endpoints should not be available since there
// are no addresses.
FastForwardBy(DnsTaskResultsManager::GetResolutionDelay() +
base::Milliseconds(1));
ASSERT_TRUE(manager->GetCurrentEndpoints().empty());
}
TEST_F(DnsTaskResultsManagerTest, EndpointOrdering) {
// Has both IPv4/v6 addresses and metadata.
constexpr static const std::string_view kSvcbHost1 = "svc1.example.com";
// Has both IPv4/v6 addresses but no metadata.
constexpr static const std::string_view kSvcbHost2 = "svc2.example.com";
// Only has IPv4 addresses.
constexpr static const std::string_view kSvcbHost3 = "svc3.example.com";
const std::vector<IPEndPoint> kSvcbHost1IPv4s = {MakeIPEndPoint("192.0.2.1")};
const std::vector<IPEndPoint> kSvcbHost2IPv4s = {MakeIPEndPoint("192.0.2.2")};
const std::vector<IPEndPoint> kSvcbHost3IPv4s = {MakeIPEndPoint("192.0.2.3")};
const std::vector<IPEndPoint> kSvcbHost1IPv6s = {
MakeIPEndPoint("2001:db8::1")};
const std::vector<IPEndPoint> kSvcbHost2IPv6s = {
MakeIPEndPoint("2001:db8::2")};
const ConnectionEndpointMetadata kSvcbHost1Metadata1(
/*supported_protocol_alpns=*/{"h2", "http/1.1"},
/*ech_config_list=*/{},
/*target_name=*/std::string(kSvcbHost1), {});
const ConnectionEndpointMetadata kSvcbHost1Metadata2(
/*supported_protocol_alpns=*/{"h3"},
/*ech_config_list=*/{},
/*target_name=*/std::string(kSvcbHost1), {});
const std::multimap<HttpsRecordPriority, ConnectionEndpointMetadata>
kSvcbHost1Metadatas{{1, kSvcbHost1Metadata1}, {2, kSvcbHost1Metadata2}};
struct TestData {
std::string_view host;
std::vector<IPEndPoint> ipv4_endpoints;
std::vector<IPEndPoint> ipv6_endpoints;
std::multimap<HttpsRecordPriority, ConnectionEndpointMetadata> metadatas;
};
const TestData kTestDatas[] = {
{kSvcbHost1,
/*ipv4_addresses=*/kSvcbHost1IPv4s,
/*ipv6_addresses=*/kSvcbHost1IPv6s,
/*metadatas=*/kSvcbHost1Metadatas},
{kSvcbHost2,
/*ipv4_addresses=*/kSvcbHost2IPv4s,
/*ipv6_addresses=*/kSvcbHost2IPv6s,
/*metadatas=*/{}},
{kSvcbHost3, /*ipv4_addresses=*/kSvcbHost3IPv4s,
/*ipv6_addresses=*/{}, /*metadatas=*/{}},
};
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
for (const auto& testdata : kTestDatas) {
if (!testdata.ipv4_endpoints.empty()) {
std::unique_ptr<HostResolverInternalResult> result = CreateDataResult(
testdata.host, testdata.ipv4_endpoints, DnsQueryType::A);
manager->ProcessDnsTransactionResults(DnsQueryType::A, {result.get()});
}
if (!testdata.ipv6_endpoints.empty()) {
std::unique_ptr<HostResolverInternalResult> result = CreateDataResult(
testdata.host, testdata.ipv6_endpoints, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result.get()});
}
if (!testdata.metadatas.empty()) {
std::unique_ptr<HostResolverInternalResult> result =
CreateMetadata(testdata.host, testdata.metadatas);
manager->ProcessDnsTransactionResults(DnsQueryType::HTTPS,
{result.get()});
}
}
const std::vector<ServiceEndpoint> kExpects = {
ServiceEndpoint(WithPort(kSvcbHost1IPv4s, 443),
WithPort(kSvcbHost1IPv6s, 443), kSvcbHost1Metadata1),
ServiceEndpoint(WithPort(kSvcbHost1IPv4s, 443),
WithPort(kSvcbHost1IPv6s, 443), kSvcbHost1Metadata2),
ServiceEndpoint(WithPort(kSvcbHost2IPv4s, 443),
WithPort(kSvcbHost2IPv6s, 443),
ConnectionEndpointMetadata()),
ServiceEndpoint(WithPort(kSvcbHost3IPv4s, 443), {},
ConnectionEndpointMetadata()),
};
ASSERT_EQ(manager->GetCurrentEndpoints().size(), kExpects.size());
for (size_t i = 0; i < manager->GetCurrentEndpoints().size(); ++i) {
SCOPED_TRACE(i);
EXPECT_THAT(manager->GetCurrentEndpoints()[i], kExpects[i]);
}
}
TEST_F(DnsTaskResultsManagerTest, Aliases) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
// AAAA is responded with aliases.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateAlias(kHostName, DnsQueryType::AAAA, kAliasTarget1);
std::unique_ptr<HostResolverInternalResult> result2 =
CreateAlias(kAliasTarget1, DnsQueryType::AAAA, kAliasTarget2);
std::unique_ptr<HostResolverInternalResult> result3 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(
DnsQueryType::AAAA, {result1.get(), result2.get(), result3.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
EXPECT_THAT(manager->GetAliases(),
UnorderedElementsAre(kHostName, kAliasTarget1, kAliasTarget2));
}
// Regression test for crbug.com/369232963. An IPv4 mapped IPv6 address should
// be handled without crashing.
TEST_F(DnsTaskResultsManagerTest, Ipv4MappedIpv6) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
auto ip_address = *IPAddress::FromIPLiteral("::ffff:192.0.2.1");
IPEndPoint endpoint(ConvertIPv4MappedIPv6ToIPv4(ip_address), /*port=*/0);
std::unique_ptr<HostResolverInternalResult> result =
CreateDataResult(kHostName, {endpoint}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(DnsQueryType::AAAA, {result.get()});
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
ElementsAre(MakeIPEndPoint("192.0.2.1", 443)), IsEmpty())));
}
TEST_F(DnsTaskResultsManagerTest,
AliasesAreFixedUpWhenProcessingDnsTransactionResults) {
std::unique_ptr<DnsTaskResultsManager> manager = factory().Create();
std::string_view bad_alias = "bad_alias.1";
std::string_view good_alias = "good_alias";
std::string_view funky_alias = "GOOGLE.TeSt";
// AAAA is responded with aliases.
std::unique_ptr<HostResolverInternalResult> result1 =
CreateAlias(kHostName, DnsQueryType::AAAA, kAliasTarget1);
std::unique_ptr<HostResolverInternalResult> result2 =
CreateAlias(kAliasTarget1, DnsQueryType::AAAA, kAliasTarget2);
std::unique_ptr<HostResolverInternalResult> result3 =
CreateAlias(kAliasTarget2, DnsQueryType::AAAA, bad_alias);
std::unique_ptr<HostResolverInternalResult> result4 =
CreateAlias(bad_alias, DnsQueryType::AAAA, good_alias);
std::unique_ptr<HostResolverInternalResult> result5 =
CreateAlias(good_alias, DnsQueryType::AAAA, funky_alias);
std::unique_ptr<HostResolverInternalResult> result6 = CreateDataResult(
kHostName, {MakeIPEndPoint("2001:db8::1")}, DnsQueryType::AAAA);
manager->ProcessDnsTransactionResults(
DnsQueryType::AAAA, {result1.get(), result2.get(), result3.get(),
result4.get(), result5.get(), result6.get()});
// Ensure bad_alias is removed, good_alias remains in the set, and funky_alias
// capitalization changes due to URL canonicalization.
EXPECT_THAT(manager->GetCurrentEndpoints(),
ElementsAre(ExpectServiceEndpoint(
IsEmpty(), ElementsAre(MakeIPEndPoint("2001:db8::1", 443)))));
EXPECT_THAT(manager->GetAliases(),
UnorderedElementsAre(kHostName, kAliasTarget1, kAliasTarget2,
good_alias, "google.test"));
EXPECT_TRUE(manager->GetAliases().find(std::string(bad_alias)) ==
manager->GetAliases().end());
}
} // namespace net
|