1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/dns/httpssvc_metrics.h"
#include <optional>
#include <string>
#include <string_view>
#include <tuple>
#include "base/feature_list.h"
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "net/base/features.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
// Base for testing the metrics collection code in |HttpssvcMetrics|.
class HttpssvcMetricsTest : public ::testing::TestWithParam<bool> {
public:
void SetUp() override { secure_ = GetParam(); }
std::string BuildMetricNamePrefix() const {
return base::StrCat({"Net.DNS.HTTPSSVC.RecordHttps.",
secure_ ? "Secure." : "Insecure.", "ExpectNoerror."});
}
template <typename T>
void ExpectSample(std::string_view name, std::optional<T> sample) const {
if (sample)
histo().ExpectUniqueSample(name, *sample, 1);
else
histo().ExpectTotalCount(name, 0);
}
void ExpectSample(std::string_view name,
std::optional<base::TimeDelta> sample) const {
std::optional<int64_t> sample_ms;
if (sample)
sample_ms = {sample->InMilliseconds()};
ExpectSample<int64_t>(name, sample_ms);
}
void VerifyAddressResolveTimeMetric(
std::optional<base::TimeDelta> expect_noerror_time = std::nullopt) {
const std::string kExpectNoerror =
base::StrCat({BuildMetricNamePrefix(), "ResolveTimeAddress"});
ExpectSample(kExpectNoerror, expect_noerror_time);
}
void VerifyHttpsMetricsForExpectNoerror(
std::optional<HttpssvcDnsRcode> rcode = std::nullopt,
std::optional<bool> parsable = std::nullopt,
std::optional<bool> record_with_error = std::nullopt,
std::optional<base::TimeDelta> resolve_time_https = std::nullopt,
std::optional<int> resolve_time_ratio = std::nullopt) const {
const std::string kPrefix = BuildMetricNamePrefix();
const std::string kMetricDnsRcode = base::StrCat({kPrefix, "DnsRcode"});
const std::string kMetricParsable = base::StrCat({kPrefix, "Parsable"});
const std::string kMetricRecordWithError =
base::StrCat({kPrefix, "RecordWithError"});
const std::string kMetricResolveTimeExperimental =
base::StrCat({kPrefix, "ResolveTimeExperimental"});
const std::string kMetricResolveTimeRatio =
base::StrCat({kPrefix, "ResolveTimeRatio"});
ExpectSample(kMetricDnsRcode, rcode);
ExpectSample(kMetricParsable, parsable);
ExpectSample(kMetricRecordWithError, record_with_error);
ExpectSample(kMetricResolveTimeExperimental, resolve_time_https);
ExpectSample(kMetricResolveTimeRatio, resolve_time_ratio);
}
const base::HistogramTester& histo() const { return histogram_; }
protected:
bool secure_;
private:
base::HistogramTester histogram_;
};
INSTANTIATE_TEST_SUITE_P(HttpssvcMetricsTestSimple,
HttpssvcMetricsTest,
testing::Bool() // Querying over DoH or Do53.
);
// Only record metrics for a non-HTTPS query.
TEST_P(HttpssvcMetricsTest, AddressAndExperimentalMissing) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric();
VerifyHttpsMetricsForExpectNoerror();
}
TEST_P(HttpssvcMetricsTest, AddressAndHttpsParsable) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
const base::TimeDelta kResolveTimeHttps = base::Milliseconds(15);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForHttps(HttpssvcDnsRcode::kNoError, {true}, kResolveTimeHttps);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric({kResolveTime} /* expect_noerror_time */);
VerifyHttpsMetricsForExpectNoerror(
{HttpssvcDnsRcode::kNoError} /* rcode */, {true} /* parsable */,
std::nullopt /* record_with_error */,
{kResolveTimeHttps} /* resolve_time_https */,
{15} /* resolve_time_ratio */);
}
// This test simulates an HTTPS response that includes no HTTPS records,
// but does have an error value for the RCODE.
TEST_P(HttpssvcMetricsTest, AddressAndHttpsMissingWithRcode) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
const base::TimeDelta kResolveTimeHttps = base::Milliseconds(15);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForHttps(HttpssvcDnsRcode::kNxDomain, {}, kResolveTimeHttps);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric({kResolveTime} /* expect_noerror_time */);
VerifyHttpsMetricsForExpectNoerror(
{HttpssvcDnsRcode::kNxDomain} /* rcode */, std::nullopt /* parsable */,
std::nullopt /* record_with_error */,
{kResolveTimeHttps} /* resolve_time_https */,
{15} /* resolve_time_ratio */);
}
// This test simulates an HTTPS response that includes a parsable HTTPS
// record, but also has an error RCODE.
TEST_P(HttpssvcMetricsTest, AddressAndHttpsParsableWithRcode) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
const base::TimeDelta kResolveTimeHttps = base::Milliseconds(15);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForHttps(HttpssvcDnsRcode::kNxDomain, {true}, kResolveTimeHttps);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric({kResolveTime} /* expect_noerror_time */);
VerifyHttpsMetricsForExpectNoerror(
{HttpssvcDnsRcode::kNxDomain} /* rcode */,
// "parsable" metric is omitted because the RCODE is not NOERROR.
std::nullopt /* parsable */, {true} /* record_with_error */,
{kResolveTimeHttps} /* resolve_time_https */,
{15} /* resolve_time_ratio */);
}
// This test simulates an HTTPS response that includes a mangled HTTPS
// record *and* has an error RCODE.
TEST_P(HttpssvcMetricsTest, AddressAndHttpsMangledWithRcode) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
const base::TimeDelta kResolveTimeHttps = base::Milliseconds(15);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForHttps(HttpssvcDnsRcode::kNxDomain, {false},
kResolveTimeHttps);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric({kResolveTime} /* expect_noerror_time */);
VerifyHttpsMetricsForExpectNoerror(
{HttpssvcDnsRcode::kNxDomain} /* rcode */,
// "parsable" metric is omitted because the RCODE is not NOERROR.
std::nullopt /* parsable */, {true} /* record_with_error */,
{kResolveTimeHttps} /* resolve_time_https */,
{15} /* resolve_time_ratio */);
}
// This test simulates successful address queries and an HTTPS query that
// timed out.
TEST_P(HttpssvcMetricsTest, AddressAndHttpsTimedOut) {
const base::TimeDelta kResolveTime = base::Milliseconds(10);
const base::TimeDelta kResolveTimeHttps = base::Milliseconds(15);
auto metrics = std::make_optional<HttpssvcMetrics>(secure_);
metrics->SaveForHttps(HttpssvcDnsRcode::kTimedOut, {}, kResolveTimeHttps);
metrics->SaveForAddressQuery(kResolveTime, HttpssvcDnsRcode::kNoError);
metrics.reset(); // Record the metrics to UMA.
VerifyAddressResolveTimeMetric({kResolveTime} /* expect_noerror_time */);
VerifyHttpsMetricsForExpectNoerror(
{HttpssvcDnsRcode::kTimedOut} /* rcode */,
// "parsable" metric is omitted because the RCODE is not NOERROR.
std::nullopt /* parsable */, std::nullopt /* record_with_error */,
{kResolveTimeHttps} /* resolve_time_https */,
{15} /* resolve_time_ratio */);
}
} // namespace net
|
