1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/spdy/http2_priority_dependencies.h"
#include <algorithm>
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/platform_test.h"
using ::testing::ContainerEq;
namespace net {
bool operator==(const Http2PriorityDependencies::DependencyUpdate& a,
const Http2PriorityDependencies::DependencyUpdate& b) {
return a.id == b.id && a.parent_stream_id == b.parent_stream_id &&
a.weight == b.weight && a.exclusive == b.exclusive;
}
std::ostream& operator<<(
std::ostream& os,
const std::vector<Http2PriorityDependencies::DependencyUpdate>& v) {
for (auto e : v) {
os << "{" << e.id << "," << e.parent_stream_id << "," << e.weight << ","
<< (e.exclusive ? "true" : "false") << "}";
}
return os;
}
class HttpPriorityDependencyTest : public PlatformTest {
public:
HttpPriorityDependencyTest() = default;
// Fixed priority values to use for testing.
enum {
HIGHEST = spdy::kV3HighestPriority,
MEDIUM = HIGHEST + 1,
LOW = MEDIUM + 1,
LOWEST = spdy::kV3LowestPriority,
};
spdy::SpdyStreamId GetId() { return ++next_id_; }
void TestStreamCreation(spdy::SpdyStreamId new_id,
spdy::SpdyPriority priority,
spdy::SpdyStreamId expected_parent_id) {
int expected_weight = spdy::Spdy3PriorityToHttp2Weight(priority);
spdy::SpdyStreamId parent_id = 999u;
int weight = -1;
bool exclusive = false;
dependency_state_.OnStreamCreation(new_id, priority, &parent_id, &weight,
&exclusive);
if (expected_parent_id != parent_id || !exclusive ||
expected_weight != weight) {
ADD_FAILURE() << "OnStreamCreation(" << new_id << ", " << int(priority)
<< ")\n"
<< " Got: (" << parent_id << ", " << weight << ", "
<< exclusive << ")\n"
<< " Want: (" << expected_parent_id << ", "
<< expected_weight << ", true)\n";
}
}
struct ExpectedDependencyUpdate {
spdy::SpdyStreamId id;
spdy::SpdyStreamId parent_id;
int weight;
};
void TestStreamUpdate(spdy::SpdyStreamId id,
spdy::SpdyPriority new_priority,
std::vector<ExpectedDependencyUpdate> expected) {
auto value = dependency_state_.OnStreamUpdate(id, new_priority);
std::vector<Http2PriorityDependencies::DependencyUpdate> expected_value;
for (auto e : expected) {
expected_value.push_back(
{e.id, e.parent_id, e.weight, true /* exclusive */});
}
if (value != expected_value) {
ADD_FAILURE() << "OnStreamUpdate(" << id << ", " << int(new_priority)
<< ")\n"
<< " Value: " << value << "\n"
<< " Expected: " << expected_value << "\n";
}
}
void OnStreamDestruction(spdy::SpdyStreamId id) {
dependency_state_.OnStreamDestruction(id);
}
private:
spdy::SpdyStreamId next_id_ = 0u;
Http2PriorityDependencies dependency_state_;
};
// Confirm dependencies correct for entries at the same priority.
TEST_F(HttpPriorityDependencyTest, SamePriority) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, MEDIUM, 0u);
TestStreamCreation(second_id, MEDIUM, first_id);
TestStreamCreation(third_id, MEDIUM, second_id);
}
// Confirm dependencies correct for entries at different priorities, increasing.
TEST_F(HttpPriorityDependencyTest, DifferentPriorityIncreasing) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, LOWEST, 0u);
TestStreamCreation(second_id, MEDIUM, 0u);
TestStreamCreation(third_id, HIGHEST, 0u);
}
// Confirm dependencies correct for entries at different priorities, increasing.
TEST_F(HttpPriorityDependencyTest, DifferentPriorityDecreasing) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0u);
TestStreamCreation(second_id, MEDIUM, first_id);
TestStreamCreation(third_id, LOWEST, second_id);
}
// Confirm dependencies correct if requests are completed between before
// next creation.
TEST_F(HttpPriorityDependencyTest, CompletionBeforeIssue) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0u);
OnStreamDestruction(first_id);
TestStreamCreation(second_id, MEDIUM, 0u);
OnStreamDestruction(second_id);
TestStreamCreation(third_id, LOWEST, 0u);
}
// Confirm dependencies correct if some requests are completed between before
// next creation.
TEST_F(HttpPriorityDependencyTest, SomeCompletions) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0u);
TestStreamCreation(second_id, MEDIUM, first_id);
OnStreamDestruction(second_id);
TestStreamCreation(third_id, LOWEST, first_id);
}
// A more complex example parallel to a simple web page.
TEST_F(HttpPriorityDependencyTest, Complex) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
const spdy::SpdyStreamId fourth_id = GetId();
const spdy::SpdyStreamId fifth_id = GetId();
const spdy::SpdyStreamId sixth_id = GetId();
const spdy::SpdyStreamId seventh_id = GetId();
const spdy::SpdyStreamId eighth_id = GetId();
const spdy::SpdyStreamId nineth_id = GetId();
const spdy::SpdyStreamId tenth_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0u);
TestStreamCreation(second_id, MEDIUM, first_id);
TestStreamCreation(third_id, MEDIUM, second_id);
OnStreamDestruction(first_id);
TestStreamCreation(fourth_id, MEDIUM, third_id);
TestStreamCreation(fifth_id, LOWEST, fourth_id);
TestStreamCreation(sixth_id, MEDIUM, fourth_id);
OnStreamDestruction(third_id);
TestStreamCreation(seventh_id, MEDIUM, sixth_id);
TestStreamCreation(eighth_id, LOW, seventh_id);
OnStreamDestruction(second_id);
OnStreamDestruction(fourth_id);
OnStreamDestruction(fifth_id);
OnStreamDestruction(sixth_id);
OnStreamDestruction(seventh_id);
TestStreamCreation(nineth_id, MEDIUM, 0u);
TestStreamCreation(tenth_id, HIGHEST, 0u);
}
// Confirm dependencies correct after updates with just one stream.
// All updates are no-ops.
TEST_F(HttpPriorityDependencyTest, UpdateSingleStream) {
const spdy::SpdyStreamId id = GetId();
TestStreamCreation(id, HIGHEST, 0);
std::vector<ExpectedDependencyUpdate> empty;
TestStreamUpdate(id, HIGHEST, empty);
TestStreamUpdate(id, MEDIUM, empty);
TestStreamUpdate(id, LOWEST, empty);
TestStreamUpdate(id, HIGHEST, empty);
}
// Confirm dependencies correct after updates with three streams.
TEST_F(HttpPriorityDependencyTest, UpdateThreeStreams) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId();
const spdy::SpdyStreamId third_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0);
TestStreamCreation(second_id, MEDIUM, first_id);
TestStreamCreation(third_id, LOWEST, second_id);
const int highest_weight = spdy::Spdy3PriorityToHttp2Weight(HIGHEST);
const int medium_weight = spdy::Spdy3PriorityToHttp2Weight(MEDIUM);
const int lowest_weight = spdy::Spdy3PriorityToHttp2Weight(LOWEST);
std::vector<ExpectedDependencyUpdate> empty;
// no-op: still at top.
TestStreamUpdate(first_id, HIGHEST, empty);
// no-op: still below first.
TestStreamUpdate(second_id, MEDIUM, empty);
// no-op: still below second.
TestStreamUpdate(third_id, LOWEST, empty);
// second moves to top, first moves below second.
TestStreamUpdate(
first_id, MEDIUM,
{{second_id, 0, medium_weight}, {first_id, second_id, medium_weight}});
// third moves to top.
TestStreamUpdate(third_id, HIGHEST, {{third_id, 0, highest_weight}});
// third moves to bottom.
TestStreamUpdate(
third_id, LOWEST,
{{second_id, 0, medium_weight}, {third_id, first_id, lowest_weight}});
// first moves to top.
TestStreamUpdate(
first_id, HIGHEST,
{{third_id, second_id, lowest_weight}, {first_id, 0, highest_weight}});
}
// A more complex example parallel to a simple web page with pushed responses.
TEST_F(HttpPriorityDependencyTest, UpdateComplex) {
const spdy::SpdyStreamId first_id = GetId();
const spdy::SpdyStreamId second_id = GetId(); // pushed
const spdy::SpdyStreamId third_id = GetId(); // pushed
const spdy::SpdyStreamId fourth_id = GetId();
const spdy::SpdyStreamId fifth_id = GetId();
const spdy::SpdyStreamId sixth_id = GetId();
const spdy::SpdyStreamId seventh_id = GetId();
TestStreamCreation(first_id, HIGHEST, 0u);
TestStreamCreation(second_id, LOWEST, first_id);
TestStreamCreation(third_id, LOWEST, second_id);
TestStreamCreation(fourth_id, HIGHEST, first_id);
TestStreamCreation(fifth_id, MEDIUM, fourth_id);
TestStreamCreation(sixth_id, MEDIUM, fifth_id);
TestStreamCreation(seventh_id, LOW, sixth_id);
const int highest_weight = spdy::Spdy3PriorityToHttp2Weight(HIGHEST);
const int medium_weight = spdy::Spdy3PriorityToHttp2Weight(MEDIUM);
const int lowest_weight = spdy::Spdy3PriorityToHttp2Weight(LOWEST);
// second matches a HIGHEST priority response.
// 3 moves under 7
// 2 moves under 4
TestStreamUpdate(second_id, HIGHEST,
{{third_id, seventh_id, lowest_weight},
{second_id, fourth_id, highest_weight}});
// third matches a MEDIUM priority response.
// 3 moves under 6
TestStreamUpdate(third_id, MEDIUM, {{third_id, sixth_id, medium_weight}});
}
} // namespace net
|
