1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stdint.h>
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/single_thread_task_runner.h"
#include "base/threading/simple_thread.h"
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/proxy/ppapi_proxy_test.h"
#include "ppapi/proxy/ppb_message_loop_proxy.h"
#include "ppapi/shared_impl/callback_tracker.h"
#include "ppapi/shared_impl/proxy_lock.h"
#include "ppapi/shared_impl/resource.h"
#include "ppapi/shared_impl/resource_tracker.h"
#include "ppapi/shared_impl/scoped_pp_resource.h"
#include "ppapi/shared_impl/test_globals.h"
#include "ppapi/shared_impl/tracked_callback.h"
#include "testing/gtest/include/gtest/gtest.h"
// Note, this file tests TrackedCallback which lives in ppapi/shared_impl.
// Unfortunately, we need the test to live in ppapi/proxy so that it can use
// the thread support there.
namespace ppapi {
namespace proxy {
namespace {
class CallbackThread : public base::SimpleThread {
public:
explicit CallbackThread(PP_Instance instance)
: SimpleThread("CallbackThread"), instance_(instance) {}
~CallbackThread() override {}
// base::SimpleThread overrides.
void BeforeStart() override {
ProxyAutoLock acquire;
// Create the message loop here, after PpapiGlobals has been created.
message_loop_ = new MessageLoopResource(instance_);
}
void BeforeJoin() override {
ProxyAutoLock acquire;
message_loop()->PostQuit(PP_TRUE);
message_loop_ = nullptr;
}
void Run() override {
ProxyAutoLock acquire;
// Make a local copy of message_loop_ for this thread so we can interact
// with it even after the main thread releases it.
scoped_refptr<MessageLoopResource> message_loop(message_loop_);
message_loop->AttachToCurrentThread();
// Note, run releases the lock to run events.
base::RunLoop().Run();
message_loop->DetachFromThread();
}
MessageLoopResource* message_loop() { return message_loop_.get(); }
private:
PP_Instance instance_;
scoped_refptr<MessageLoopResource> message_loop_;
};
class TrackedCallbackTest : public PluginProxyTest {
public:
TrackedCallbackTest() : thread_(pp_instance()) {}
CallbackThread& thread() { return thread_; }
private:
// PluginProxyTest overrides.
void SetUp() override {
PluginProxyTest::SetUp();
thread_.Start();
}
void TearDown() override {
thread_.Join();
PluginProxyTest::TearDown();
base::RunLoop run_loop;
run_loop.RunUntilIdle();
}
CallbackThread thread_;
};
// All valid results (PP_OK, PP_ERROR_...) are nonpositive.
const int32_t kInitializedResultValue = 1;
const int32_t kOverrideResultValue = 2;
struct CallbackRunInfo {
explicit CallbackRunInfo(base::ThreadChecker* thread_checker)
: run_count_(0),
result_(kInitializedResultValue),
completion_task_run_count_(0),
completion_task_result_(kInitializedResultValue),
thread_checker_(thread_checker),
callback_did_run_event_(
base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED) {}
void CallbackDidRun(int32_t result) {
CHECK(thread_checker_->CalledOnValidThread());
if (!run_count_)
result_ = result;
++run_count_;
callback_did_run_event_.Signal();
}
void CompletionTaskDidRun(int32_t result) {
CHECK(thread_checker_->CalledOnValidThread());
if (!completion_task_run_count_)
completion_task_result_ = result;
++completion_task_run_count_;
}
void WaitUntilCompleted() { callback_did_run_event_.Wait(); }
unsigned run_count() { return run_count_; }
int32_t result() { return result_; }
unsigned completion_task_run_count() { return completion_task_run_count_; }
int32_t completion_task_result() { return completion_task_result_; }
private:
unsigned run_count_;
int32_t result_;
unsigned completion_task_run_count_;
int32_t completion_task_result_;
// Weak; owned by the creator of CallbackRunInfo.
base::ThreadChecker* thread_checker_;
base::WaitableEvent callback_did_run_event_;
};
void TestCallback(void* user_data, int32_t result) {
CallbackRunInfo* info = static_cast<CallbackRunInfo*>(user_data);
info->CallbackDidRun(result);
}
// CallbackShutdownTest --------------------------------------------------------
class CallbackShutdownTest : public TrackedCallbackTest {
public:
CallbackShutdownTest() : info_did_run_(&thread_checker_),
info_did_abort_(&thread_checker_),
info_didnt_run_(&thread_checker_) {}
// Cases:
// (1) A callback which is run (so shouldn't be aborted on shutdown).
// (2) A callback which is aborted (so shouldn't be aborted on shutdown).
// (3) A callback which isn't run (so should be aborted on shutdown).
CallbackRunInfo& info_did_run() { return info_did_run_; } // (1)
CallbackRunInfo& info_did_abort() { return info_did_abort_; } // (2)
CallbackRunInfo& info_didnt_run() { return info_didnt_run_; } // (3)
private:
base::ThreadChecker thread_checker_;
CallbackRunInfo info_did_run_;
CallbackRunInfo info_did_abort_;
CallbackRunInfo info_didnt_run_;
};
} // namespace
// Tests that callbacks are properly aborted on module shutdown.
TEST_F(CallbackShutdownTest, DISABLED_AbortOnShutdown) {
ProxyAutoLock lock;
scoped_refptr<Resource> resource(
new Resource(OBJECT_IS_PROXY, pp_instance()));
// Set up case (1) (see above).
EXPECT_EQ(0U, info_did_run().run_count());
// TODO(dmichael): Test this on a background thread?
scoped_refptr<TrackedCallback> callback_did_run = new TrackedCallback(
resource.get(),
PP_MakeCompletionCallback(&TestCallback, &info_did_run()));
EXPECT_EQ(0U, info_did_run().run_count());
callback_did_run->Run(PP_OK);
EXPECT_EQ(1U, info_did_run().run_count());
EXPECT_EQ(PP_OK, info_did_run().result());
// Set up case (2).
EXPECT_EQ(0U, info_did_abort().run_count());
scoped_refptr<TrackedCallback> callback_did_abort = new TrackedCallback(
resource.get(),
PP_MakeCompletionCallback(&TestCallback, &info_did_abort()));
EXPECT_EQ(0U, info_did_abort().run_count());
callback_did_abort->Abort();
EXPECT_EQ(1U, info_did_abort().run_count());
EXPECT_EQ(PP_ERROR_ABORTED, info_did_abort().result());
// Set up case (3).
EXPECT_EQ(0U, info_didnt_run().run_count());
scoped_refptr<TrackedCallback> callback_didnt_run = new TrackedCallback(
resource.get(),
PP_MakeCompletionCallback(&TestCallback, &info_didnt_run()));
EXPECT_EQ(0U, info_didnt_run().run_count());
GetGlobals()->GetCallbackTrackerForInstance(pp_instance())->AbortAll();
// Check case (1).
EXPECT_EQ(1U, info_did_run().run_count());
// Check case (2).
EXPECT_EQ(1U, info_did_abort().run_count());
// Check case (3).
EXPECT_EQ(1U, info_didnt_run().run_count());
EXPECT_EQ(PP_ERROR_ABORTED, info_didnt_run().result());
}
// CallbackResourceTest --------------------------------------------------------
namespace {
class CallbackResourceTest : public TrackedCallbackTest {
public:
CallbackResourceTest() {}
};
class CallbackMockResource : public Resource {
public:
static scoped_refptr<CallbackMockResource> Create(PP_Instance instance) {
ProxyAutoLock acquire;
return scoped_refptr<CallbackMockResource>(
new CallbackMockResource(instance));
}
~CallbackMockResource() {}
// Take a reference to this resource, which will add it to the tracker.
void TakeRef() {
ProxyAutoLock acquire;
ScopedPPResource temp_resource(ScopedPPResource::PassRef(), GetReference());
EXPECT_NE(0, temp_resource.get());
reference_holder_ = temp_resource;
}
// Release it, removing it from the tracker.
void ReleaseRef() {
ProxyAutoLock acquire;
reference_holder_ = 0;
}
// Create the test callbacks on a background thread, so that we can verify
// they are run on the same thread where they were created.
void CreateCallbacksOnLoop(MessageLoopResource* loop_resource) {
ProxyAutoLock acquire;
// |thread_checker_| will bind to the background thread.
thread_checker_.DetachFromThread();
loop_resource->task_runner()->PostTask(
FROM_HERE, RunWhileLocked(base::BindOnce(
&CallbackMockResource::CreateCallbacks, this)));
}
int32_t CompletionTask(CallbackRunInfo* info, int32_t result) {
// The completion task must run on the thread where the callback was
// created, and must hold the proxy lock.
CHECK(thread_checker_.CalledOnValidThread());
ProxyLock::AssertAcquired();
// We should run before the callback.
CHECK_EQ(0U, info->run_count());
info->CompletionTaskDidRun(result);
return kOverrideResultValue;
}
void CheckInitialState() {
callbacks_created_event_.Wait();
EXPECT_EQ(0U, info_did_run_.run_count());
EXPECT_EQ(0U, info_did_run_.completion_task_run_count());
EXPECT_EQ(0U, info_did_run_with_completion_task_.run_count());
EXPECT_EQ(0U,
info_did_run_with_completion_task_.completion_task_run_count());
EXPECT_EQ(0U, info_did_abort_.run_count());
EXPECT_EQ(0U, info_did_abort_.completion_task_run_count());
EXPECT_EQ(0U, info_didnt_run_.run_count());
EXPECT_EQ(0U, info_didnt_run_.completion_task_run_count());
}
void RunCallbacks() {
callback_did_run_->Run(PP_OK);
callback_did_run_with_completion_task_->Run(PP_OK);
callback_did_abort_->Abort();
info_did_run_.WaitUntilCompleted();
info_did_run_with_completion_task_.WaitUntilCompleted();
info_did_abort_.WaitUntilCompleted();
}
void CheckIntermediateState() {
EXPECT_EQ(1U, info_did_run_.run_count());
EXPECT_EQ(PP_OK, info_did_run_.result());
EXPECT_EQ(0U, info_did_run_.completion_task_run_count());
EXPECT_EQ(1U, info_did_run_with_completion_task_.run_count());
// completion task should override the result.
EXPECT_EQ(kOverrideResultValue,
info_did_run_with_completion_task_.result());
EXPECT_EQ(1U,
info_did_run_with_completion_task_.completion_task_run_count());
EXPECT_EQ(PP_OK,
info_did_run_with_completion_task_.completion_task_result());
EXPECT_EQ(1U, info_did_abort_.run_count());
// completion task shouldn't override an abort.
EXPECT_EQ(PP_ERROR_ABORTED, info_did_abort_.result());
EXPECT_EQ(1U, info_did_abort_.completion_task_run_count());
EXPECT_EQ(PP_ERROR_ABORTED, info_did_abort_.completion_task_result());
EXPECT_EQ(0U, info_didnt_run_.completion_task_run_count());
EXPECT_EQ(0U, info_didnt_run_.run_count());
}
void CheckFinalState() {
info_didnt_run_.WaitUntilCompleted();
EXPECT_EQ(1U, info_did_run_with_completion_task_.run_count());
EXPECT_EQ(kOverrideResultValue,
info_did_run_with_completion_task_.result());
callback_did_run_with_completion_task_ = nullptr;
EXPECT_EQ(1U, info_did_run_.run_count());
EXPECT_EQ(PP_OK, info_did_run_.result());
callback_did_run_ = nullptr;
EXPECT_EQ(1U, info_did_abort_.run_count());
EXPECT_EQ(PP_ERROR_ABORTED, info_did_abort_.result());
callback_did_abort_ = nullptr;
EXPECT_EQ(1U, info_didnt_run_.run_count());
EXPECT_EQ(PP_ERROR_ABORTED, info_didnt_run_.result());
callback_didnt_run_ = nullptr;
}
private:
explicit CallbackMockResource(PP_Instance instance)
: Resource(OBJECT_IS_PROXY, instance),
info_did_run_(&thread_checker_),
info_did_run_with_completion_task_(&thread_checker_),
info_did_abort_(&thread_checker_),
info_didnt_run_(&thread_checker_),
callbacks_created_event_(
base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED) {}
void CreateCallbacks() {
// Bind thread_checker_ to the thread where we create the callbacks.
// Later, when the callback runs, it will check that it was invoked on this
// same thread.
CHECK(thread_checker_.CalledOnValidThread());
callback_did_run_ = new TrackedCallback(
this, PP_MakeCompletionCallback(&TestCallback, &info_did_run_));
// In order to test that the completion task can override the callback
// result, we need to test callbacks with and without a completion task.
callback_did_run_with_completion_task_ = new TrackedCallback(
this,
PP_MakeCompletionCallback(&TestCallback,
&info_did_run_with_completion_task_));
callback_did_run_with_completion_task_->set_completion_task(
base::BindOnce(&CallbackMockResource::CompletionTask, this,
&info_did_run_with_completion_task_));
callback_did_abort_ = new TrackedCallback(
this, PP_MakeCompletionCallback(&TestCallback, &info_did_abort_));
callback_did_abort_->set_completion_task(base::BindOnce(
&CallbackMockResource::CompletionTask, this, &info_did_abort_));
callback_didnt_run_ = new TrackedCallback(
this, PP_MakeCompletionCallback(&TestCallback, &info_didnt_run_));
callback_didnt_run_->set_completion_task(base::BindOnce(
&CallbackMockResource::CompletionTask, this, &info_didnt_run_));
callbacks_created_event_.Signal();
}
// Used to verify that the callback runs on the same thread where it is
// created.
base::ThreadChecker thread_checker_;
scoped_refptr<TrackedCallback> callback_did_run_;
CallbackRunInfo info_did_run_;
scoped_refptr<TrackedCallback> callback_did_run_with_completion_task_;
CallbackRunInfo info_did_run_with_completion_task_;
scoped_refptr<TrackedCallback> callback_did_abort_;
CallbackRunInfo info_did_abort_;
scoped_refptr<TrackedCallback> callback_didnt_run_;
CallbackRunInfo info_didnt_run_;
base::WaitableEvent callbacks_created_event_;
ScopedPPResource reference_holder_;
};
} // namespace
// Test that callbacks get aborted on the last resource unref.
TEST_F(CallbackResourceTest, DISABLED_AbortOnNoRef) {
// Test several things: Unref-ing a resource (to zero refs) with callbacks
// which (1) have been run, (2) have been aborted, (3) haven't been completed.
// Check that the uncompleted one gets aborted, and that the others don't get
// called again.
scoped_refptr<CallbackMockResource> resource_1(
CallbackMockResource::Create(pp_instance()));
resource_1->CreateCallbacksOnLoop(thread().message_loop());
resource_1->CheckInitialState();
resource_1->RunCallbacks();
resource_1->TakeRef();
resource_1->CheckIntermediateState();
// Also do the same for a second resource, and make sure that unref-ing the
// first resource doesn't much up the second resource.
scoped_refptr<CallbackMockResource> resource_2(
CallbackMockResource::Create(pp_instance()));
resource_2->CreateCallbacksOnLoop(thread().message_loop());
resource_2->CheckInitialState();
resource_2->RunCallbacks();
resource_2->TakeRef();
resource_2->CheckIntermediateState();
// Double-check that resource #1 is still okay.
resource_1->CheckIntermediateState();
// Kill resource #1, spin the message loop to run posted calls, and check that
// things are in the expected states.
resource_1->ReleaseRef();
resource_1->CheckFinalState();
resource_2->CheckIntermediateState();
// Kill resource #2.
resource_2->ReleaseRef();
resource_1->CheckFinalState();
resource_2->CheckFinalState();
{
ProxyAutoLock lock;
resource_1 = nullptr;
resource_2 = nullptr;
}
}
// Test that "resurrecting" a resource (getting a new ID for a |Resource|)
// doesn't resurrect callbacks.
TEST_F(CallbackResourceTest, DISABLED_Resurrection) {
scoped_refptr<CallbackMockResource> resource(
CallbackMockResource::Create(pp_instance()));
resource->CreateCallbacksOnLoop(thread().message_loop());
resource->CheckInitialState();
resource->RunCallbacks();
resource->TakeRef();
resource->CheckIntermediateState();
// Unref it and check that things are in the expected states.
resource->ReleaseRef();
resource->CheckFinalState();
// "Resurrect" it and check that the callbacks are still dead.
resource->TakeRef();
resource->CheckFinalState();
// Unref it again and do the same.
resource->ReleaseRef();
resource->CheckFinalState();
{
ProxyAutoLock lock;
resource = nullptr;
}
}
} // namespace proxy
} // namespace ppapi
|