1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/host/it2me/it2me_confirmation_dialog_proxy.h"
#include <memory>
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/task_environment.h"
#include "base/threading/thread.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::InvokeWithoutArgs;
namespace remoting {
namespace {
const char kTestEmailAddress[] = "faux_remote_user@chromium_test.com";
} // namespace
class StubIt2MeConfirmationDialog : public It2MeConfirmationDialog {
public:
explicit StubIt2MeConfirmationDialog(
scoped_refptr<base::SingleThreadTaskRunner> task_runner)
: task_runner_(task_runner) {}
~StubIt2MeConfirmationDialog() override {
EXPECT_TRUE(task_runner_->BelongsToCurrentThread());
}
void ReportResult(Result result) {
ASSERT_TRUE(task_runner_->BelongsToCurrentThread());
std::move(callback_).Run(result);
}
MOCK_METHOD0(OnShow, void());
// It2MeConfirmationDialog implementation.
void Show(const std::string& remote_user_email,
ResultCallback callback) override {
EXPECT_TRUE(callback_.is_null());
EXPECT_TRUE(task_runner_->BelongsToCurrentThread());
EXPECT_EQ(remote_user_email.compare(kTestEmailAddress), 0);
callback_ = std::move(callback);
OnShow();
}
private:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
ResultCallback callback_;
};
// Encapsulates a target for It2MeConfirmationDialog::ResultCallback.
class ResultCallbackTarget {
public:
explicit ResultCallbackTarget(
scoped_refptr<base::SingleThreadTaskRunner> task_runner)
: task_runner_(task_runner) {}
MOCK_METHOD1(OnDialogResult, void(It2MeConfirmationDialog::Result));
It2MeConfirmationDialog::ResultCallback MakeCallback() {
return base::BindOnce(&ResultCallbackTarget::HandleDialogResult,
base::Unretained(this));
}
private:
void HandleDialogResult(It2MeConfirmationDialog::Result result) {
EXPECT_TRUE(task_runner_->BelongsToCurrentThread());
OnDialogResult(result);
}
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
};
class It2MeConfirmationDialogProxyTest : public testing::Test {
public:
It2MeConfirmationDialogProxyTest();
~It2MeConfirmationDialogProxyTest() override;
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner() {
return task_environment_.GetMainThreadTaskRunner();
}
scoped_refptr<base::SingleThreadTaskRunner> dialog_task_runner() {
return dialog_thread_.task_runner();
}
void Run() { run_loop_.Run(); }
void Quit() { run_loop_.Quit(); }
It2MeConfirmationDialogProxy* dialog_proxy() { return dialog_proxy_.get(); }
StubIt2MeConfirmationDialog* dialog() { return dialog_; }
private:
base::test::SingleThreadTaskEnvironment task_environment_;
base::RunLoop run_loop_;
base::Thread dialog_thread_;
// |dialog_| is owned by |dialog_proxy_| but we keep an alias for testing.
// This dangling raw_ptr occurred in:
// remoting_unittests: It2MeConfirmationDialogProxyTest.Show
// https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1425645/test-results?q=ExactID%3Aninja%3A%2F%2Fremoting%3Aremoting_unittests%2FIt2MeConfirmationDialogProxyTest.Show+VHash%3A5b63361209a49b2c
raw_ptr<StubIt2MeConfirmationDialog, FlakyDanglingUntriaged> dialog_ =
nullptr;
std::unique_ptr<It2MeConfirmationDialogProxy> dialog_proxy_;
};
It2MeConfirmationDialogProxyTest::It2MeConfirmationDialogProxyTest()
: dialog_thread_("test dialog thread") {
dialog_thread_.Start();
auto dialog =
std::make_unique<StubIt2MeConfirmationDialog>(dialog_task_runner());
dialog_ = dialog.get();
dialog_proxy_ = std::make_unique<It2MeConfirmationDialogProxy>(
dialog_task_runner(), std::move(dialog));
}
It2MeConfirmationDialogProxyTest::~It2MeConfirmationDialogProxyTest() = default;
TEST_F(It2MeConfirmationDialogProxyTest, Show) {
ResultCallbackTarget callback_target(main_task_runner());
StubIt2MeConfirmationDialog* confirm_dialog = dialog();
EXPECT_CALL(*dialog(), OnShow())
.WillOnce(InvokeWithoutArgs([confirm_dialog]() {
confirm_dialog->ReportResult(It2MeConfirmationDialog::Result::CANCEL);
}));
EXPECT_CALL(callback_target,
OnDialogResult(It2MeConfirmationDialog::Result::CANCEL))
.WillOnce(
InvokeWithoutArgs(this, &It2MeConfirmationDialogProxyTest::Quit));
dialog_proxy()->Show(kTestEmailAddress, callback_target.MakeCallback());
Run();
}
} // namespace remoting
|
