File: resizing_host_observer.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (310 lines) | stat: -rw-r--r-- 11,574 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "remoting/host/resizing_host_observer.h"

#include <stdint.h>

#include <algorithm>
#include <list>
#include <utility>

#include "base/check.h"
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/time/default_tick_clock.h"
#include "base/time/tick_clock.h"
#include "remoting/base/logging.h"
#include "remoting/host/base/screen_resolution.h"
#include "remoting/host/desktop_display_info_monitor.h"
#include "remoting/host/desktop_resizer.h"
#include "remoting/proto/control.pb.h"

namespace remoting {
namespace {

// Minimum amount of time to wait between desktop resizes. Note that this
// constant is duplicated by the ResizingHostObserverTest.RateLimited
// unit-test and must be kept in sync.
const int kMinimumResizeIntervalMs = 1000;

class CandidateResolution {
 public:
  CandidateResolution(const ScreenResolution& candidate,
                      const ScreenResolution& preferred)
      : resolution_(candidate) {
    // Protect against division by zero.
    CHECK(!candidate.IsEmpty());
    DCHECK(!preferred.IsEmpty());

    // The client scale factor is the smaller of the candidate:preferred ratios
    // for width and height.
    if ((candidate.dimensions().width() > preferred.dimensions().width()) ||
        (candidate.dimensions().height() > preferred.dimensions().height())) {
      const float width_ratio =
          static_cast<float>(preferred.dimensions().width()) /
          candidate.dimensions().width();
      const float height_ratio =
          static_cast<float>(preferred.dimensions().height()) /
          candidate.dimensions().height();
      client_scale_factor_ = std::min(width_ratio, height_ratio);
    } else {
      // Since clients do not scale up, 1.0 is the maximum.
      client_scale_factor_ = 1.0;
    }

    // The aspect ratio "goodness" is defined as being the ratio of the smaller
    // of the two aspect ratios (candidate and preferred) to the larger. The
    // best aspect ratio is the one that most closely matches the preferred
    // aspect ratio (in other words, the ideal aspect ratio "goodness" is 1.0).
    // By keeping the values < 1.0, it allows ratios that differ in opposite
    // directions to be compared numerically.
    float candidate_aspect_ratio =
        static_cast<float>(candidate.dimensions().width()) /
        candidate.dimensions().height();
    float preferred_aspect_ratio =
        static_cast<float>(preferred.dimensions().width()) /
        preferred.dimensions().height();
    if (candidate_aspect_ratio > preferred_aspect_ratio) {
      aspect_ratio_goodness_ = preferred_aspect_ratio / candidate_aspect_ratio;
    } else {
      aspect_ratio_goodness_ = candidate_aspect_ratio / preferred_aspect_ratio;
    }
  }

  const ScreenResolution& resolution() const { return resolution_; }
  float client_scale_factor() const { return client_scale_factor_; }
  float aspect_ratio_goodness() const { return aspect_ratio_goodness_; }
  int64_t area() const {
    return static_cast<int64_t>(resolution_.dimensions().width()) *
           resolution_.dimensions().height();
  }

  // TODO(jamiewalch): Also compare the DPI: http://crbug.com/172405
  bool IsBetterThan(const CandidateResolution& other) const {
    // If either resolution would require down-scaling, prefer the one that
    // down-scales the least (since the client scale factor is at most 1.0,
    // this does not differentiate between resolutions that don't require
    // down-scaling).
    if (client_scale_factor() < other.client_scale_factor()) {
      return false;
    } else if (client_scale_factor() > other.client_scale_factor()) {
      return true;
    }

    // If the scale factors are the same, pick the resolution with the largest
    // area.
    if (area() < other.area()) {
      return false;
    } else if (area() > other.area()) {
      return true;
    }

    // If the areas are equal, pick the resolution with the "best" aspect ratio.
    if (aspect_ratio_goodness() < other.aspect_ratio_goodness()) {
      return false;
    } else if (aspect_ratio_goodness() > other.aspect_ratio_goodness()) {
      return true;
    }

    // All else being equal (for example, comparing 640x480 to 480x640 w.r.t.
    // 640x640), just pick the widest, since desktop UIs are typically designed
    // for landscape aspect ratios.
    return resolution().dimensions().width() >
           other.resolution().dimensions().width();
  }

 private:
  float client_scale_factor_;
  float aspect_ratio_goodness_;
  ScreenResolution resolution_;
};

}  // namespace

ResizingHostObserver::ResizingHostObserver(
    std::unique_ptr<DesktopResizer> desktop_resizer,
    bool restore)
    : desktop_resizer_(std::move(desktop_resizer)),
      restore_(restore),
      clock_(base::DefaultTickClock::GetInstance()) {}

ResizingHostObserver::~ResizingHostObserver() {
  if (restore_) {
    RestoreAllScreenResolutions();
  }
}

void ResizingHostObserver::RegisterForDisplayChanges(
    DesktopDisplayInfoMonitor& monitor) {
  monitor.AddCallback(base::BindRepeating(
      &ResizingHostObserver::OnDisplayInfoChanged, weak_factory_.GetWeakPtr()));
}

void ResizingHostObserver::SetScreenResolution(
    const ScreenResolution& resolution,
    std::optional<webrtc::ScreenId> opt_screen_id) {
  // Get the current time. This function is called exactly once for each call
  // to SetScreenResolution to simplify the implementation of unit-tests.
  base::TimeTicks now = clock_->NowTicks();

  webrtc::ScreenId screen_id;
  if (opt_screen_id) {
    screen_id = opt_screen_id.value();
  } else {
    // If SetScreenResolution() was called without any ID, the ID of the
    // single monitor should be used. If there are no monitors yet, the request
    // is remembered, to be applied when the display-info is updated.
    if (current_monitor_ids_.empty()) {
      pending_resolution_request_ = resolution;
      return;
    }
    if (current_monitor_ids_.size() == 1) {
      screen_id = *current_monitor_ids_.begin();
    } else {
      // Drop the request if there is more than 1 monitor.
      HOST_LOG << "Ignoring ambiguous resize request.";
      return;
    }
  }

  // Drop any request for an invalid screen ID.
  if (!base::Contains(current_monitor_ids_, screen_id)) {
    HOST_LOG << "Ignoring resize request for invalid monitor ID " << screen_id
             << ".";
    return;
  }

  if (resolution.IsEmpty()) {
    RestoreScreenResolution(screen_id);
    return;
  }

  // Resizing the desktop too often is probably not a good idea, so apply a
  // simple rate-limiting scheme.
  // TODO(crbug.com/40225767): Rate-limiting should only be applied to requests
  // for the same monitor.
  base::TimeTicks next_allowed_resize =
      previous_resize_time_ + base::Milliseconds(kMinimumResizeIntervalMs);

  if (now < next_allowed_resize) {
    deferred_resize_timer_.Start(
        FROM_HERE, next_allowed_resize - now,
        base::BindOnce(&ResizingHostObserver::SetScreenResolution,
                       weak_factory_.GetWeakPtr(), resolution, opt_screen_id));
    return;
  }

  // If the implementation returns any resolutions, pick the best one according
  // to the algorithm described in CandidateResolution::IsBetterThan.
  std::list<ScreenResolution> resolutions =
      desktop_resizer_->GetSupportedResolutions(resolution, screen_id);
  if (resolutions.empty()) {
    HOST_LOG << "No valid resolutions found for monitor ID " << screen_id
             << ".";
    return;
  } else {
    HOST_LOG << "Found host resolutions for monitor ID " << screen_id << ":";
    for (const auto& host_resolution : resolutions) {
      HOST_LOG << "  " << host_resolution.dimensions().width() << "x"
               << host_resolution.dimensions().height();
    }
  }
  HOST_LOG << "Choosing best candidate for client resolution: "
           << resolution.dimensions().width() << "x"
           << resolution.dimensions().height() << " [" << resolution.dpi().x()
           << ", " << resolution.dpi().y() << "]";
  CandidateResolution best_candidate(resolutions.front(), resolution);
  for (std::list<ScreenResolution>::const_iterator i = ++resolutions.begin();
       i != resolutions.end(); ++i) {
    CandidateResolution candidate(*i, resolution);
    if (candidate.IsBetterThan(best_candidate)) {
      best_candidate = candidate;
    }
  }
  ScreenResolution current_resolution =
      desktop_resizer_->GetCurrentResolution(screen_id);
  ScreenResolution best_resolution = best_candidate.resolution();

  if (!best_resolution.Equals(current_resolution)) {
    RecordOriginalResolution(current_resolution, screen_id);
    HOST_LOG << "Resizing monitor ID " << screen_id << " to "
             << best_resolution.dimensions().width() << "x"
             << best_resolution.dimensions().height() << " ["
             << best_resolution.dpi().x() << ", " << best_resolution.dpi().y()
             << "].";
    desktop_resizer_->SetResolution(best_resolution, screen_id);
  } else {
    HOST_LOG << "Not resizing monitor ID " << screen_id
             << "; desktop dimensions already "
             << best_resolution.dimensions().width() << "x"
             << best_resolution.dimensions().height() << " ["
             << best_resolution.dpi().x() << ", " << best_resolution.dpi().y()
             << "].";
  }

  // Update the time of last resize to allow it to be rate-limited.
  previous_resize_time_ = now;
}

void ResizingHostObserver::SetVideoLayout(
    const protocol::VideoLayout& video_layout) {
  desktop_resizer_->SetVideoLayout(video_layout);
}

void ResizingHostObserver::SetDisplayInfoForTesting(
    const DesktopDisplayInfo& display_info) {
  OnDisplayInfoChanged(display_info);
}

void ResizingHostObserver::SetClockForTesting(const base::TickClock* clock) {
  clock_ = clock;
}

void ResizingHostObserver::RestoreScreenResolution(webrtc::ScreenId screen_id) {
  auto iter = original_resolutions_.find(screen_id);
  if (iter != original_resolutions_.end()) {
    auto [_, original_resolution] = *iter;
    HOST_LOG << "Restoring monitor ID " << screen_id << " to "
             << original_resolution.dimensions().width() << "x"
             << original_resolution.dimensions().height() << ".";
    desktop_resizer_->RestoreResolution(original_resolution, screen_id);
    original_resolutions_.erase(iter);
  } else {
    HOST_LOG << "No original resolution found for monitor ID " << screen_id
             << ".";
  }
}

void ResizingHostObserver::RestoreAllScreenResolutions() {
  while (!original_resolutions_.empty()) {
    auto [screen_id, _] = *original_resolutions_.begin();
    RestoreScreenResolution(screen_id);
  }
}

void ResizingHostObserver::RecordOriginalResolution(
    ScreenResolution resolution,
    webrtc::ScreenId screen_id) {
  if (!base::Contains(original_resolutions_, screen_id)) {
    original_resolutions_[screen_id] = resolution;
  }
}

void ResizingHostObserver::OnDisplayInfoChanged(
    const DesktopDisplayInfo& display_info) {
  current_monitor_ids_.clear();
  for (int i = 0; i < display_info.NumDisplays(); i++) {
    current_monitor_ids_.insert(display_info.GetDisplayInfo(i)->id);
  }

  // If there was a pending resolution request for an unspecifed monitor, apply
  // it now.
  if (!pending_resolution_request_.IsEmpty()) {
    SetScreenResolution(pending_resolution_request_, std::nullopt);
    pending_resolution_request_ = {};
  }
}

}  // namespace remoting