1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <algorithm>
#include <memory>
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/mock_callback.h"
#include "net/base/net_errors.h"
#include "remoting/base/rsa_key_pair.h"
#include "remoting/protocol/auth_util.h"
#include "remoting/protocol/authenticator.h"
#include "remoting/protocol/authenticator_test_base.h"
#include "remoting/protocol/channel_authenticator.h"
#include "remoting/protocol/connection_tester.h"
#include "remoting/protocol/credentials_type.h"
#include "remoting/protocol/host_authentication_config.h"
#include "remoting/protocol/negotiating_authenticator_base.h"
#include "remoting/protocol/negotiating_client_authenticator.h"
#include "remoting/protocol/negotiating_host_authenticator.h"
#include "remoting/protocol/pairing_registry.h"
#include "remoting/protocol/protocol_mock_objects.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libjingle_xmpp/xmllite/xmlelement.h"
using testing::_;
using testing::DeleteArg;
using testing::Return;
using testing::SaveArg;
namespace remoting::protocol {
namespace {
const int kMessageSize = 100;
const int kMessages = 1;
const char kNoClientId[] = "";
const char kNoPairedSecret[] = "";
const char kTestClientName[] = "client-name";
const char kTestClientId[] = "client-id";
const char kTestHostId[] = "12345678910123456";
const char kClientJid[] = "alice@gmail.com/abc";
const char kHostJid[] = "alice@gmail.com/123";
const char kTestPairedSecret[] = "1111-2222-3333";
const char kTestPairedSecretBad[] = "4444-5555-6666";
const char kTestPin[] = "123456";
const char kTestPinBad[] = "654321";
} // namespace
class NegotiatingAuthenticatorTest : public AuthenticatorTestBase {
public:
NegotiatingAuthenticatorTest() = default;
NegotiatingAuthenticatorTest(const NegotiatingAuthenticatorTest&) = delete;
NegotiatingAuthenticatorTest& operator=(const NegotiatingAuthenticatorTest&) =
delete;
~NegotiatingAuthenticatorTest() override = default;
protected:
virtual void InitAuthenticators(const std::string& client_id,
const std::string& client_paired_secret,
const std::string& client_interactive_pin,
const std::string& host_secret) {
std::string host_secret_hash =
GetSharedSecretHash(kTestHostId, host_secret);
auto auth_config =
std::make_unique<HostAuthenticationConfig>(host_cert_, key_pair_);
auth_config->AddPairingAuth(pairing_registry_);
auth_config->AddSharedSecretAuth(host_secret_hash);
auto host = std::make_unique<NegotiatingHostAuthenticator>(
kHostJid, kClientJid, std::move(auth_config));
host_as_negotiating_authenticator_ = host.get();
host_ = std::move(host);
protocol::ClientAuthenticationConfig client_auth_config;
client_auth_config.host_id = kTestHostId;
client_auth_config.pairing_client_id = client_id;
client_auth_config.pairing_secret = client_paired_secret;
bool pairing_expected = pairing_registry_.get() != nullptr;
client_auth_config.fetch_secret_callback =
base::BindRepeating(&NegotiatingAuthenticatorTest::FetchSecret,
client_interactive_pin, pairing_expected);
client_as_negotiating_authenticator_ = new NegotiatingClientAuthenticator(
kClientJid, kHostJid, client_auth_config);
client_.reset(client_as_negotiating_authenticator_);
}
void DisableMethodOnClient(AuthenticationMethod method) {
auto* methods = &(client_as_negotiating_authenticator_->methods_);
auto iter = std::ranges::find(*methods, method);
ASSERT_TRUE(iter != methods->end());
methods->erase(iter);
}
void DisableMethodOnHost(AuthenticationMethod method) {
auto* methods = &(host_as_negotiating_authenticator_->methods_);
auto iter = std::ranges::find(*methods, method);
ASSERT_TRUE(iter != methods->end());
methods->erase(iter);
}
void CreatePairingRegistry(bool with_paired_client) {
pairing_registry_ = new SynchronousPairingRegistry(
std::make_unique<MockPairingRegistryDelegate>());
if (with_paired_client) {
PairingRegistry::Pairing pairing(base::Time(), kTestClientName,
kTestClientId, kTestPairedSecret);
pairing_registry_->AddPairing(pairing);
}
}
void SwapCurrentAuthenticator(
NegotiatingAuthenticatorBase* negotiating_authenticator,
std::unique_ptr<Authenticator> current_authenticator) {
negotiating_authenticator->current_authenticator_ =
std::move(current_authenticator);
negotiating_authenticator->ChainStateChangeAfterAcceptedWithUnderlying(
*negotiating_authenticator->current_authenticator_);
}
static void FetchSecret(
const std::string& client_secret,
bool pairing_supported,
bool pairing_expected,
const protocol::SecretFetchedCallback& secret_fetched_callback) {
secret_fetched_callback.Run(client_secret);
ASSERT_EQ(pairing_supported, pairing_expected);
}
void VerifyRejected(Authenticator::RejectionReason reason) {
ASSERT_TRUE(client_->state() == Authenticator::REJECTED ||
host_->state() == Authenticator::REJECTED);
if (client_->state() == Authenticator::REJECTED) {
ASSERT_EQ(client_->rejection_reason(), reason);
}
if (host_->state() == Authenticator::REJECTED) {
ASSERT_EQ(host_->rejection_reason(), reason);
}
}
virtual void VerifyAccepted() {
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
ASSERT_EQ(Authenticator::ACCEPTED, host_->state());
ASSERT_EQ(Authenticator::ACCEPTED, client_->state());
client_auth_ = client_->CreateChannelAuthenticator();
host_auth_ = host_->CreateChannelAuthenticator();
RunChannelAuth(false);
EXPECT_TRUE(client_socket_.get() != nullptr);
EXPECT_TRUE(host_socket_.get() != nullptr);
StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
kMessageSize, kMessages);
base::RunLoop run_loop;
tester.Start(run_loop.QuitClosure());
run_loop.Run();
tester.CheckResults();
}
AuthenticationMethod current_method() {
return client_as_negotiating_authenticator_->current_method_;
}
// Use a bare pointer because the storage is managed by the base class.
raw_ptr<NegotiatingHostAuthenticator> host_as_negotiating_authenticator_;
raw_ptr<NegotiatingClientAuthenticator> client_as_negotiating_authenticator_;
private:
scoped_refptr<PairingRegistry> pairing_registry_;
};
class NegotiatingPairingAuthenticatorTest
: public NegotiatingAuthenticatorTest {
public:
void VerifyAccepted() override {
NegotiatingAuthenticatorTest::VerifyAccepted();
EXPECT_EQ(current_method(), AuthenticationMethod::PAIRED_SPAKE2_CURVE25519);
}
};
TEST_F(NegotiatingAuthenticatorTest, SuccessfulAuthSharedSecret) {
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPin, kTestPin));
VerifyAccepted();
EXPECT_EQ(AuthenticationMethod::SHARED_SECRET_SPAKE2_CURVE25519,
current_method());
}
TEST_F(NegotiatingAuthenticatorTest, InvalidSharedSecret) {
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPinBad, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyRejected(Authenticator::RejectionReason::INVALID_CREDENTIALS);
}
TEST_F(NegotiatingAuthenticatorTest, NoCommonAuthMethod) {
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPin, kTestPinBad));
DisableMethodOnClient(AuthenticationMethod::SHARED_SECRET_SPAKE2_CURVE25519);
DisableMethodOnHost(AuthenticationMethod::SHARED_SECRET_SPAKE2_CURVE25519);
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyRejected(Authenticator::RejectionReason::NO_COMMON_AUTH_METHOD);
}
TEST_F(NegotiatingAuthenticatorTest, PairingNotSupported) {
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kTestClientId, kTestPairedSecret, kTestPin, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyAccepted();
EXPECT_EQ(AuthenticationMethod::SHARED_SECRET_SPAKE2_CURVE25519,
current_method());
}
TEST_F(NegotiatingPairingAuthenticatorTest, PairingSupportedButNotPaired) {
CreatePairingRegistry(false);
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPin, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyAccepted();
}
TEST_F(NegotiatingPairingAuthenticatorTest, PairingRevokedPinOkay) {
CreatePairingRegistry(false);
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kTestClientId, kTestPairedSecret, kTestPin, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyAccepted();
}
TEST_F(NegotiatingPairingAuthenticatorTest, PairingRevokedPinBad) {
CreatePairingRegistry(false);
ASSERT_NO_FATAL_FAILURE(InitAuthenticators(kTestClientId, kTestPairedSecret,
kTestPinBad, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyRejected(Authenticator::RejectionReason::INVALID_CREDENTIALS);
}
TEST_F(NegotiatingPairingAuthenticatorTest, PairingSucceeded) {
CreatePairingRegistry(true);
ASSERT_NO_FATAL_FAILURE(InitAuthenticators(kTestClientId, kTestPairedSecret,
kTestPinBad, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyAccepted();
}
TEST_F(NegotiatingPairingAuthenticatorTest,
PairingSucceededInvalidSecretButPinOkay) {
CreatePairingRegistry(true);
ASSERT_NO_FATAL_FAILURE(InitAuthenticators(
kTestClientId, kTestPairedSecretBad, kTestPin, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyAccepted();
}
TEST_F(NegotiatingPairingAuthenticatorTest, PairingFailedInvalidSecretAndPin) {
CreatePairingRegistry(true);
ASSERT_NO_FATAL_FAILURE(InitAuthenticators(
kTestClientId, kTestPairedSecretBad, kTestPinBad, kTestPin));
ASSERT_NO_FATAL_FAILURE(RunAuthExchange());
VerifyRejected(Authenticator::RejectionReason::INVALID_CREDENTIALS);
}
TEST_F(NegotiatingAuthenticatorTest, NotifyStateChangeAfterAccepted) {
base::MockRepeatingClosure host_state_change_after_accepted;
base::MockRepeatingClosure client_state_change_after_accepted;
ASSERT_NO_FATAL_FAILURE(
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPin, kTestPin));
host_->set_state_change_after_accepted_callback(
host_state_change_after_accepted.Get());
client_->set_state_change_after_accepted_callback(
client_state_change_after_accepted.Get());
VerifyAccepted();
// There is no client authenticator for SessionAuthz (which has
// state-change-after-accepted behavior), so we have to swap the current
// authenticators with mock ones.
auto mock_host_authenticator_owned = std::make_unique<MockAuthenticator>();
auto mock_client_authenticator_owned = std::make_unique<MockAuthenticator>();
MockAuthenticator* mock_host_authenticator =
mock_host_authenticator_owned.get();
MockAuthenticator* mock_client_authenticator =
mock_client_authenticator_owned.get();
SwapCurrentAuthenticator(host_as_negotiating_authenticator_,
std::move(mock_host_authenticator_owned));
SwapCurrentAuthenticator(client_as_negotiating_authenticator_,
std::move(mock_client_authenticator_owned));
EXPECT_CALL(*mock_host_authenticator, state())
.WillOnce(Return(Authenticator::REJECTED));
EXPECT_CALL(*mock_client_authenticator, state())
.WillOnce(Return(Authenticator::REJECTED));
EXPECT_CALL(*mock_host_authenticator, rejection_reason())
.WillOnce(
Return(Authenticator::RejectionReason::REAUTHZ_POLICY_CHECK_FAILED));
EXPECT_CALL(*mock_client_authenticator, rejection_reason())
.WillOnce(
Return(Authenticator::RejectionReason::REAUTHZ_POLICY_CHECK_FAILED));
EXPECT_CALL(host_state_change_after_accepted, Run());
EXPECT_CALL(client_state_change_after_accepted, Run());
mock_host_authenticator->NotifyStateChangeAfterAccepted();
mock_client_authenticator->NotifyStateChangeAfterAccepted();
EXPECT_EQ(host_->state(), Authenticator::REJECTED);
EXPECT_EQ(client_->state(), Authenticator::REJECTED);
EXPECT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::REAUTHZ_POLICY_CHECK_FAILED);
EXPECT_EQ(client_->rejection_reason(),
Authenticator::RejectionReason::REAUTHZ_POLICY_CHECK_FAILED);
}
TEST_F(NegotiatingAuthenticatorTest,
ReturnCorrectCredentialsTypeAndImplementingAuthenticator) {
InitAuthenticators(kNoClientId, kNoPairedSecret, kTestPin, kTestPin);
ASSERT_EQ(host_->credentials_type(), CredentialsType::UNKNOWN);
ASSERT_EQ(&host_->implementing_authenticator(), host_.get());
VerifyAccepted();
ASSERT_EQ(host_->credentials_type(), CredentialsType::SHARED_SECRET);
ASSERT_NE(&host_->implementing_authenticator(), host_.get());
}
} // namespace remoting::protocol
|
