1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/protocol/session_authz_authenticator.h"
#include <memory>
#include <optional>
#include <string_view>
#include <tuple>
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/functional/callback_forward.h"
#include "base/memory/raw_ptr.h"
#include "base/notreached.h"
#include "base/run_loop.h"
#include "base/test/gmock_callback_support.h"
#include "base/test/gmock_move_support.h"
#include "base/test/mock_callback.h"
#include "base/time/time.h"
#include "net/http/http_status_code.h"
#include "remoting/base/http_status.h"
#include "remoting/base/mock_session_authz_service_client.h"
#include "remoting/base/rsa_key_pair.h"
#include "remoting/base/session_authz_service_client.h"
#include "remoting/base/session_policies.h"
#include "remoting/proto/session_authz_service.h"
#include "remoting/protocol/authenticator.h"
#include "remoting/protocol/authenticator_test_base.h"
#include "remoting/protocol/connection_tester.h"
#include "remoting/protocol/credentials_type.h"
#include "remoting/protocol/spake2_authenticator.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace remoting::protocol {
namespace {
using testing::_;
using testing::ByMove;
using testing::Return;
constexpr std::string_view kFakeHostToken = "fake_host_token";
constexpr std::string_view kFakeSessionId = "fake_session_id";
constexpr std::string_view kFakeSessionToken = "fake_session_token";
constexpr std::string_view kFakeSharedSecret = "fake_shared_secret";
constexpr std::string_view kFakeSessionReauthToken =
"fake_session_reauth_token";
constexpr base::TimeDelta kFakeSessionReauthTokenLifetime = base::Minutes(5);
constexpr int kMessageSize = 100;
constexpr int kMessages = 1;
auto RespondGenerateHostToken() {
auto response = std::make_unique<internal::GenerateHostTokenResponseStruct>();
response->host_token = kFakeHostToken;
response->session_id = kFakeSessionId;
return base::test::RunOnceCallback<0>(HttpStatus::OK(), std::move(response));
}
auto RespondVerifySessionToken(
std::string_view session_id = kFakeSessionId,
std::string_view shared_secret = kFakeSharedSecret,
const std::optional<SessionPolicies>& session_policies = std::nullopt) {
auto response =
std::make_unique<internal::VerifySessionTokenResponseStruct>();
response->session_id = session_id;
response->shared_secret = shared_secret;
response->session_policies = session_policies;
response->session_reauth_token = kFakeSessionReauthToken;
response->session_reauth_token_lifetime = kFakeSessionReauthTokenLifetime;
return base::test::RunOnceCallback<1>(HttpStatus::OK(), std::move(response));
}
class FakeClientAuthenticator : public Authenticator {
public:
explicit FakeClientAuthenticator(const CreateBaseAuthenticatorCallback&
create_base_authenticator_callback);
~FakeClientAuthenticator() override;
// Authenticator implementation.
CredentialsType credentials_type() const override;
const Authenticator& implementing_authenticator() const override;
State state() const override;
bool started() const override;
RejectionReason rejection_reason() const override;
RejectionDetails rejection_details() const override;
void ProcessMessage(const jingle_xmpp::XmlElement* message,
base::OnceClosure resume_callback) override;
std::unique_ptr<jingle_xmpp::XmlElement> GetNextMessage() override;
const std::string& GetAuthKey() const override;
const SessionPolicies* GetSessionPolicies() const override;
std::unique_ptr<ChannelAuthenticator> CreateChannelAuthenticator()
const override;
const std::string& host_token() const { return host_token_; }
// Used to simulate an invalid message from the underlying authenticator.
void set_underlying_authenticator_message_suppressed(bool suppressed) {
underlying_authenticator_message_suppressed_ = suppressed;
}
private:
enum class SessionAuthzState {
WAITING_FOR_HOST_TOKEN,
READY_TO_SEND_SESSION_TOKEN,
AUTHORIZED,
FAILED,
};
SessionAuthzState session_authz_state_ =
SessionAuthzState::WAITING_FOR_HOST_TOKEN;
RejectionReason session_authz_rejection_reason_;
CreateBaseAuthenticatorCallback create_base_authenticator_callback_;
std::unique_ptr<Authenticator> underlying_;
std::string host_token_;
std::unique_ptr<jingle_xmpp::XmlElement> message_;
base::OnceClosure resume_callback_;
bool underlying_authenticator_message_suppressed_ = false;
};
CredentialsType FakeClientAuthenticator::credentials_type() const {
return CredentialsType::CORP_SESSION_AUTHZ;
}
const Authenticator& FakeClientAuthenticator::implementing_authenticator()
const {
return *this;
}
Authenticator::State FakeClientAuthenticator::state() const {
switch (session_authz_state_) {
case SessionAuthzState::READY_TO_SEND_SESSION_TOKEN:
return MESSAGE_READY;
case SessionAuthzState::WAITING_FOR_HOST_TOKEN:
return WAITING_MESSAGE;
case SessionAuthzState::AUTHORIZED:
return underlying_->state();
case SessionAuthzState::FAILED:
return REJECTED;
}
}
bool FakeClientAuthenticator::started() const {
return session_authz_state_ != SessionAuthzState::WAITING_FOR_HOST_TOKEN;
}
FakeClientAuthenticator::FakeClientAuthenticator(
const CreateBaseAuthenticatorCallback& create_base_authenticator_callback)
: create_base_authenticator_callback_(create_base_authenticator_callback) {}
FakeClientAuthenticator::~FakeClientAuthenticator() = default;
Authenticator::RejectionReason FakeClientAuthenticator::rejection_reason()
const {
return session_authz_state_ == SessionAuthzState::FAILED
? session_authz_rejection_reason_
: underlying_->rejection_reason();
}
Authenticator::RejectionDetails FakeClientAuthenticator::rejection_details()
const {
if (underlying_ && underlying_->state() == State::REJECTED) {
return underlying_->rejection_details();
}
return {};
}
void FakeClientAuthenticator::ProcessMessage(
const jingle_xmpp::XmlElement* message,
base::OnceClosure resume_callback) {
switch (session_authz_state_) {
case SessionAuthzState::WAITING_FOR_HOST_TOKEN:
host_token_ =
message->TextNamed(SessionAuthzAuthenticator::kHostTokenTag);
ASSERT_FALSE(host_token_.empty());
session_authz_state_ = SessionAuthzState::READY_TO_SEND_SESSION_TOKEN;
underlying_ = create_base_authenticator_callback_.Run(
std::string(kFakeSharedSecret), MESSAGE_READY);
std::move(resume_callback).Run();
return;
case SessionAuthzState::AUTHORIZED:
underlying_->ProcessMessage(message, std::move(resume_callback));
return;
default:
NOTREACHED();
}
}
std::unique_ptr<jingle_xmpp::XmlElement>
FakeClientAuthenticator::GetNextMessage() {
EXPECT_EQ(state(), MESSAGE_READY);
std::unique_ptr<jingle_xmpp::XmlElement> message;
if (underlying_ && underlying_->state() == MESSAGE_READY) {
if (underlying_authenticator_message_suppressed_) {
underlying_->GetNextMessage();
} else {
message = underlying_->GetNextMessage();
}
}
if (!message) {
message = CreateEmptyAuthenticatorMessage();
}
if (session_authz_state_ == SessionAuthzState::READY_TO_SEND_SESSION_TOKEN) {
jingle_xmpp::XmlElement* session_token_element =
new jingle_xmpp::XmlElement(
SessionAuthzAuthenticator::kSessionTokenTag);
session_token_element->SetBodyText(std::string(kFakeSessionToken));
message->AddElement(session_token_element);
session_authz_state_ = SessionAuthzState::AUTHORIZED;
}
return message;
}
const std::string& FakeClientAuthenticator::GetAuthKey() const {
EXPECT_EQ(state(), ACCEPTED);
return underlying_->GetAuthKey();
}
const SessionPolicies* FakeClientAuthenticator::GetSessionPolicies() const {
EXPECT_EQ(state(), ACCEPTED);
return nullptr;
}
std::unique_ptr<ChannelAuthenticator>
FakeClientAuthenticator::CreateChannelAuthenticator() const {
EXPECT_EQ(state(), ACCEPTED);
return underlying_->CreateChannelAuthenticator();
}
} // namespace
class SessionAuthzAuthenticatorTest : public AuthenticatorTestBase {
public:
SessionAuthzAuthenticatorTest();
~SessionAuthzAuthenticatorTest() override;
protected:
void SetUp() override;
// Caller must add an expectation for
// mock_service_client_->GenerateHostToken() and run the callback, otherwise
// this method will not return.
void StartAuthExchange();
raw_ptr<MockSessionAuthzServiceClient> mock_service_client_;
raw_ptr<SessionAuthzAuthenticator> host_authenticator_;
raw_ptr<FakeClientAuthenticator> client_authenticator_;
};
SessionAuthzAuthenticatorTest::SessionAuthzAuthenticatorTest() = default;
SessionAuthzAuthenticatorTest::~SessionAuthzAuthenticatorTest() = default;
void SessionAuthzAuthenticatorTest::SetUp() {
AuthenticatorTestBase::SetUp();
auto mock_service_client = std::make_unique<MockSessionAuthzServiceClient>();
mock_service_client_ = mock_service_client.get();
auto host_authenticator = std::make_unique<SessionAuthzAuthenticator>(
CredentialsType::CORP_SESSION_AUTHZ, std::move(mock_service_client),
base::BindRepeating(&Spake2Authenticator::CreateForHost, kHostId,
kClientId, host_cert_, key_pair_));
host_authenticator_ = host_authenticator.get();
host_ = std::move(host_authenticator);
auto client_authenticator =
std::make_unique<FakeClientAuthenticator>(base::BindRepeating(
&Spake2Authenticator::CreateForClient, kClientId, kHostId));
client_authenticator_ = client_authenticator.get();
client_ = std::move(client_authenticator);
}
void SessionAuthzAuthenticatorTest::StartAuthExchange() {
base::RunLoop run_loop;
host_authenticator_->Start(run_loop.QuitClosure());
run_loop.Run();
RunHostInitiatedAuthExchange();
}
TEST_F(SessionAuthzAuthenticatorTest, SuccessfulAuth) {
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(kFakeSessionToken, _))
.WillOnce(RespondVerifySessionToken());
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::ACCEPTED);
ASSERT_EQ(client_->state(), Authenticator::ACCEPTED);
ASSERT_EQ(client_authenticator_->host_token(), kFakeHostToken);
// Verify that authenticated channels can be created after authentication.
client_auth_ = client_->CreateChannelAuthenticator();
host_auth_ = host_->CreateChannelAuthenticator();
RunChannelAuth(false);
StreamConnectionTester tester(host_socket_.get(), client_socket_.get(),
kMessageSize, kMessages);
base::RunLoop run_loop;
tester.Start(run_loop.QuitClosure());
run_loop.Run();
tester.CheckResults();
}
TEST_F(SessionAuthzAuthenticatorTest,
AuthenticatedWithoutSessionPolicies_GetSessionPoliciesReturnsNullptr) {
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken());
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::ACCEPTED);
ASSERT_EQ(host_->GetSessionPolicies(), nullptr);
}
TEST_F(SessionAuthzAuthenticatorTest,
AuthenticatedWithSessionPolicies_GetSessionPoliciesReturnsPolicies) {
SessionPolicies policies;
policies.maximum_session_duration = base::Hours(10);
policies.curtain_required = true;
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken(kFakeSessionId, kFakeSharedSecret,
policies));
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::ACCEPTED);
ASSERT_EQ(*host_->GetSessionPolicies(), policies);
}
TEST_F(SessionAuthzAuthenticatorTest, GenerateHostToken_RpcError_Rejected) {
base::MockCallback<base::OnceClosure> mock_resume_callback;
SessionAuthzServiceClient::GenerateHostTokenCallback
generate_host_token_callback;
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(MoveArg<0>(&generate_host_token_callback));
EXPECT_CALL(mock_resume_callback, Run()).Times(0);
host_authenticator_->Start(mock_resume_callback.Get());
ASSERT_EQ(host_->state(), Authenticator::PROCESSING_MESSAGE);
EXPECT_CALL(mock_resume_callback, Run()).Times(1);
std::move(generate_host_token_callback)
.Run(HttpStatus(HttpStatus::Code::PERMISSION_DENIED, "Permission denied"),
nullptr);
ASSERT_EQ(host_->state(), Authenticator::REJECTED);
ASSERT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::AUTHZ_POLICY_CHECK_FAILED);
}
TEST_F(SessionAuthzAuthenticatorTest, VerifySessionToken_RpcError_Rejected) {
SessionAuthzServiceClient::VerifySessionTokenCallback
verify_session_token_callback;
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(MoveArg<1>(&verify_session_token_callback));
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::PROCESSING_MESSAGE);
std::move(verify_session_token_callback)
.Run(HttpStatus(HttpStatus::Code::PERMISSION_DENIED, "Permission denied"),
nullptr);
ASSERT_EQ(host_->state(), Authenticator::REJECTED);
ASSERT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::AUTHZ_POLICY_CHECK_FAILED);
}
TEST_F(SessionAuthzAuthenticatorTest,
VerifySessionToken_SessionIdMismatch_Rejected) {
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken("mismatched_session_id"));
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::REJECTED);
ASSERT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::INVALID_ACCOUNT_ID);
}
TEST_F(SessionAuthzAuthenticatorTest,
UnderlyingAuthenticator_InvalidIncomingMessage_Rejected) {
client_authenticator_->set_underlying_authenticator_message_suppressed(true);
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken());
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::REJECTED);
ASSERT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::INVALID_ARGUMENT);
}
TEST_F(SessionAuthzAuthenticatorTest,
UnderlyingAuthenticator_MismatchedSharedSecret_NotAccepted) {
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken(kFakeSessionId,
"mismatched_shared_secret"));
StartAuthExchange();
// With the mismatched shared secret, the underlying authenticator will just
// believe the client has not sent enough data to complete the key exchange.
ASSERT_NE(host_->state(), Authenticator::ACCEPTED);
}
TEST_F(SessionAuthzAuthenticatorTest, ReauthorizationFailed_Rejected) {
EXPECT_CALL(*mock_service_client_, GenerateHostToken(_))
.WillOnce(RespondGenerateHostToken());
EXPECT_CALL(*mock_service_client_, VerifySessionToken(_, _))
.WillOnce(RespondVerifySessionToken());
base::MockCallback<base::RepeatingClosure>
state_change_after_accepted_callback;
host_->set_state_change_after_accepted_callback(
state_change_after_accepted_callback.Get());
EXPECT_CALL(state_change_after_accepted_callback, Run()).Times(0);
StartAuthExchange();
ASSERT_EQ(host_->state(), Authenticator::ACCEPTED);
ASSERT_EQ(client_->state(), Authenticator::ACCEPTED);
EXPECT_CALL(*mock_service_client_,
ReauthorizeHost(kFakeSessionReauthToken, kFakeSessionId, _, _))
.WillOnce(base::test::RunOnceCallback<3>(
HttpStatus(net::HttpStatusCode::HTTP_FORBIDDEN), nullptr));
EXPECT_CALL(state_change_after_accepted_callback, Run());
task_environment_.FastForwardBy(kFakeSessionReauthTokenLifetime);
ASSERT_EQ(host_->state(), Authenticator::REJECTED);
ASSERT_EQ(host_->rejection_reason(),
Authenticator::RejectionReason::REAUTHZ_POLICY_CHECK_FAILED);
}
} // namespace remoting::protocol
|