1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "remoting/protocol/ssl_hmac_channel_authenticator.h"
#include <memory>
#include <utility>
#include "base/base64.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/run_loop.h"
#include "base/test/task_environment.h"
#include "base/test/test_timeouts.h"
#include "base/timer/timer.h"
#include "crypto/rsa_private_key.h"
#include "net/base/net_errors.h"
#include "net/cert/x509_util.h"
#include "net/test/cert_test_util.h"
#include "net/test/test_data_directory.h"
#include "remoting/base/rsa_key_pair.h"
#include "remoting/protocol/connection_tester.h"
#include "remoting/protocol/fake_session.h"
#include "remoting/protocol/p2p_stream_socket.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libjingle_xmpp/xmllite/xmlelement.h"
using testing::_;
using testing::NotNull;
using testing::SaveArg;
namespace remoting::protocol {
namespace {
const char kTestSharedSecret[] = "1234-1234-5678";
const char kTestSharedSecretBad[] = "0000-0000-0001";
class MockChannelDoneCallback {
public:
MOCK_METHOD2(OnDone, void(int error, P2PStreamSocket* socket));
};
ACTION_P2(QuitThreadOnCounter, quit_closure, counter) {
--(*counter);
EXPECT_GE(*counter, 0);
if (*counter == 0) {
std::move(quit_closure).Run();
}
}
} // namespace
class SslHmacChannelAuthenticatorTest : public testing::Test {
public:
SslHmacChannelAuthenticatorTest() = default;
SslHmacChannelAuthenticatorTest(const SslHmacChannelAuthenticatorTest&) =
delete;
SslHmacChannelAuthenticatorTest& operator=(
const SslHmacChannelAuthenticatorTest&) = delete;
~SslHmacChannelAuthenticatorTest() override = default;
protected:
void SetUp() override {
base::FilePath certs_dir(net::GetTestCertsDirectory());
base::FilePath cert_path = certs_dir.AppendASCII("unittest.selfsigned.der");
ASSERT_TRUE(base::ReadFileToString(cert_path, &host_cert_));
base::FilePath key_path = certs_dir.AppendASCII("unittest.key.bin");
std::string key_string;
ASSERT_TRUE(base::ReadFileToString(key_path, &key_string));
std::string key_base64 = base::Base64Encode(key_string);
key_pair_ = RsaKeyPair::FromString(key_base64);
ASSERT_TRUE(key_pair_.get());
}
void RunChannelAuth(int expected_client_error, int expected_host_error) {
client_fake_socket_ = std::make_unique<FakeStreamSocket>();
host_fake_socket_ = std::make_unique<FakeStreamSocket>();
client_fake_socket_->PairWith(host_fake_socket_.get());
client_auth_->SecureAndAuthenticate(
std::move(client_fake_socket_),
base::BindOnce(&SslHmacChannelAuthenticatorTest::OnClientConnected,
base::Unretained(this)));
host_auth_->SecureAndAuthenticate(
std::move(host_fake_socket_),
base::BindOnce(&SslHmacChannelAuthenticatorTest::OnHostConnected,
base::Unretained(this),
std::string("ref argument value")));
// Expect two callbacks to be called - the client callback and the host
// callback.
int callback_counter = 2;
base::RunLoop run_loop;
if (expected_client_error != net::OK) {
EXPECT_CALL(client_callback_, OnDone(expected_client_error, nullptr))
.WillOnce(QuitThreadOnCounter(run_loop.QuitWhenIdleClosure(),
&callback_counter));
} else {
EXPECT_CALL(client_callback_, OnDone(net::OK, NotNull()))
.WillOnce(QuitThreadOnCounter(run_loop.QuitWhenIdleClosure(),
&callback_counter));
}
if (expected_host_error != net::OK) {
EXPECT_CALL(host_callback_, OnDone(expected_host_error, nullptr))
.WillOnce(QuitThreadOnCounter(run_loop.QuitWhenIdleClosure(),
&callback_counter));
} else {
EXPECT_CALL(host_callback_, OnDone(net::OK, NotNull()))
.WillOnce(QuitThreadOnCounter(run_loop.QuitWhenIdleClosure(),
&callback_counter));
}
// Ensure that .Run() does not run unbounded if the callbacks are never
// called.
base::OneShotTimer shutdown_timer;
shutdown_timer.Start(FROM_HERE, TestTimeouts::action_timeout(),
run_loop.QuitWhenIdleClosure());
run_loop.Run();
}
void OnHostConnected(const std::string& ref_argument,
int error,
std::unique_ptr<P2PStreamSocket> socket) {
// Try deleting the authenticator and verify that this doesn't destroy
// reference parameters.
host_auth_.reset();
DCHECK_EQ(ref_argument, "ref argument value");
host_callback_.OnDone(error, socket.get());
host_socket_ = std::move(socket);
}
void OnClientConnected(int error, std::unique_ptr<P2PStreamSocket> socket) {
client_auth_.reset();
client_callback_.OnDone(error, socket.get());
client_socket_ = std::move(socket);
}
base::test::SingleThreadTaskEnvironment task_environment_;
scoped_refptr<RsaKeyPair> key_pair_;
std::string host_cert_;
std::unique_ptr<FakeStreamSocket> client_fake_socket_;
std::unique_ptr<FakeStreamSocket> host_fake_socket_;
std::unique_ptr<ChannelAuthenticator> client_auth_;
std::unique_ptr<ChannelAuthenticator> host_auth_;
MockChannelDoneCallback client_callback_;
MockChannelDoneCallback host_callback_;
std::unique_ptr<P2PStreamSocket> client_socket_;
std::unique_ptr<P2PStreamSocket> host_socket_;
};
// Verify that a channel can be connected using a valid shared secret.
TEST_F(SslHmacChannelAuthenticatorTest, SuccessfulAuth) {
client_auth_ = SslHmacChannelAuthenticator::CreateForClient(
host_cert_, kTestSharedSecret);
host_auth_ = SslHmacChannelAuthenticator::CreateForHost(host_cert_, key_pair_,
kTestSharedSecret);
RunChannelAuth(net::OK, net::OK);
ASSERT_TRUE(client_socket_.get() != nullptr);
ASSERT_TRUE(host_socket_.get() != nullptr);
StreamConnectionTester tester(host_socket_.get(), client_socket_.get(), 100,
2);
base::RunLoop run_loop;
tester.Start(run_loop.QuitClosure());
run_loop.Run();
tester.CheckResults();
}
// Verify that channels cannot be using invalid shared secret.
TEST_F(SslHmacChannelAuthenticatorTest, InvalidChannelSecret) {
client_auth_ = SslHmacChannelAuthenticator::CreateForClient(
host_cert_, kTestSharedSecretBad);
host_auth_ = SslHmacChannelAuthenticator::CreateForHost(host_cert_, key_pair_,
kTestSharedSecret);
RunChannelAuth(net::ERR_FAILED, net::ERR_FAILED);
ASSERT_TRUE(host_socket_.get() == nullptr);
}
// Verify that channels cannot be using invalid certificate.
TEST_F(SslHmacChannelAuthenticatorTest, InvalidCertificate) {
// Import a second certificate for the client to expect.
scoped_refptr<net::X509Certificate> host_cert2(
net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem"));
client_auth_ = SslHmacChannelAuthenticator::CreateForClient(
std::string(
net::x509_util::CryptoBufferAsStringPiece(host_cert2->cert_buffer())),
kTestSharedSecret);
host_auth_ = SslHmacChannelAuthenticator::CreateForHost(host_cert_, key_pair_,
kTestSharedSecret);
// TODO(crbug.com/41430308): The server sees
// ERR_BAD_SSL_CLIENT_AUTH_CERT because its peer (the client) alerts it with
// bad_certificate. The alert-mapping code assumes it is running on a client,
// so it translates bad_certificate to ERR_BAD_SSL_CLIENT_AUTH_CERT, which
// shouldn't be the error for a bad server certificate.
RunChannelAuth(net::ERR_CERT_INVALID, net::ERR_BAD_SSL_CLIENT_AUTH_CERT);
ASSERT_TRUE(host_socket_.get() == nullptr);
}
} // namespace remoting::protocol
|