File: compare_blink_perf.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (251 lines) | stat: -rw-r--r-- 8,497 bytes parent folder | download | duplicates (8)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// A utility to compare two runs of a style perftest, in the perftest
// output format, and compute confidence intervals. The simplest way
// to get the right information is to build a binary before and after
// changes and then run it continuously every-other for a while until
// you feel you have enough data:
//
//   rm -f old.txt new.txt; \
//   while :; do
//     taskset -c 2,4,6,8 ./out/Release/blink_perf___old \
//       --gtest_filter=StyleCalcPerfTest.\* 2>&1 | tee -a old.txt;
//     taskset -c 2,4,6,8 ./out/Release/blink_perf_tests \
//       --gtest_filter=StyleCalcPerfTest.\* 2>&1 | tee -a new.txt;
//   done
//
// and then run ./out/Release/compare_blink_perf old.txt new.txt.
// (Possibly under watch -n 1 if you want to look at data as it
// comes in, though beware of p-hacking.)
//
// TODO(sesse): Consider whether we should remove the first few
// runs, as they are frequently outliers.

#include <stdio.h>
#include <stdlib.h>

#include <algorithm>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>

#include "base/rand_util.h"
#include "base/strings/string_number_conversions.h"
#include "testing/perf/confidence/ratio_bootstrap_estimator.h"

#ifdef UNSAFE_BUFFERS_BUILD
// Not used with untrusted inputs.
#pragma allow_unsafe_buffers
#endif

using std::max;
using std::min;
using std::numeric_limits;
using std::pair;
using std::sort;
using std::string;
using std::unordered_map;
using std::vector;

namespace {

string BeautifyCategory(const string& category) {
  if (category == "BlinkStyleInitialCalcTime") {
    return "Initial style (µs)";
  } else if (category == "BlinkStyleRecalcTime") {
    return "Recalc style (µs)";
  } else if (category == "BlinkStyleParseTime") {
    return "Parse (µs)";
  } else {
    return category;
  }
}

bool CodeUnitCompareIgnoringASCIICaseLessThan(const string& a,
                                              const string& b) {
  return lexicographical_compare(
      a.begin(), a.end(), b.begin(), b.end(),
      [](char c1, char c2) { return std::tolower(c1) < std::tolower(c2); });
}

// The structure is e.g. BlinkStyleParseTime -> Video -> [100 us, 90 us, ...]
unordered_map<string, unordered_map<string, vector<double>>> ReadFile(
    const char* filename) {
  unordered_map<string, unordered_map<string, vector<double>>> measurements;

  FILE* fp = fopen(filename, "r");
  if (fp == nullptr) {
    perror(filename);
    exit(1);
  }
  while (!feof(fp)) {
    char buf[4096];
    if (fgets(buf, sizeof(buf), fp) == nullptr) {
      break;
    }
    string str(buf);
    if (str.length() > 1 && str[str.length() - 1] == '\n') {
      str.resize(str.length() - 1);
    }
    if (str.length() > 1 && str[str.length() - 1] == '\r') {
      str.resize(str.length() - 1);
    }

    // A result line looks like: *RESULT BlinkStyleParseTime: Video= 11061 us
    vector<string> cols{""};
    for (char ch : str) {
      if (ch == ' ') {
        cols.push_back("");
      } else {
        cols.back().push_back(ch);
      }
    }
    if (cols.size() != 5 || cols[0] != "*RESULT" || !cols[1].ends_with(":") ||
        !cols[2].ends_with("=") || cols[4] != "us") {
      continue;
    }

    string category = cols[1];
    category.resize(category.length() - 1);
    category = BeautifyCategory(category);

    string benchmark = cols[2];
    benchmark.resize(benchmark.length() - 1);

    double val;
    if (!base::StringToDouble(cols[3], &val)) {
      continue;
    }
    measurements[category][benchmark].push_back(val);
  }

  fclose(fp);
  return measurements;
}

// Find the number of trials, for display.
void FindNumberOfTrials(
    const unordered_map<string, unordered_map<string, vector<double>>>&
        measurements,
    unsigned& min_num_trials,
    unsigned& max_num_trials) {
  for (const auto& [category, entry] : measurements) {
    for (const auto& [benchmark, samples] : entry) {
      min_num_trials = min<unsigned>(min_num_trials, samples.size());
      max_num_trials = max<unsigned>(max_num_trials, samples.size());
    }
  }
}

struct Label {
  string benchmark;
  size_t data_index;
};

}  // namespace

int main(int argc, char** argv) {
  if (argc != 3) {
    fprintf(stderr, "USAGE: compare_blink_perf OLD_LOG NEW_LOG\n");
    exit(1);
  }

  unordered_map<string, unordered_map<string, vector<double>>> before =
      ReadFile(argv[1]);
  unordered_map<string, unordered_map<string, vector<double>>> after =
      ReadFile(argv[2]);

  unsigned min_num_trials = numeric_limits<unsigned>::max();
  unsigned max_num_trials = numeric_limits<unsigned>::min();
  FindNumberOfTrials(before, min_num_trials, max_num_trials);
  FindNumberOfTrials(after, min_num_trials, max_num_trials);
  if (min_num_trials == max_num_trials) {
    printf("%u trial(s) on each side.\n", min_num_trials);
  } else {
    printf("%u–%u trial(s) on each side.\n", min_num_trials, max_num_trials);
  }

  // Now pair up the data. (The estimator treats them as unpaired,
  // but currently needs them to be of the same length within a single
  // benchmark.) We do one run per category, so that we can get
  // geometric means over them (RatioBootstrapEstimator doesn't support
  // arbitrary grouping).
  vector<string> sorted_categories;
  for (const auto& [category, entry] : before) {
    sorted_categories.push_back(category);
  }
  sort(sorted_categories.begin(), sorted_categories.end(),
       [](const string& a, const string& b) {
         return CodeUnitCompareIgnoringASCIICaseLessThan(a, b);
       });
  for (const string& category : sorted_categories) {
    vector<Label> labels;
    vector<vector<RatioBootstrapEstimator::Sample>> data;
    for (const auto& [benchmark, before_samples] :
         before.find(category)->second) {
      const auto after_entry = after.find(category);
      if (after_entry == after.end()) {
        continue;
      }
      const auto after_samples = after_entry->second.find(benchmark);
      if (after_samples == after_entry->second.end()) {
        continue;
      }

      vector<RatioBootstrapEstimator::Sample> samples;
      for (unsigned i = 0;
           i < std::min(before_samples.size(), after_samples->second.size());
           ++i) {
        samples.push_back({before_samples[i], after_samples->second[i]});
      }
      labels.emplace_back(Label{benchmark, data.size()});
      data.push_back(std::move(samples));
    }

    RatioBootstrapEstimator estimator(base::RandUint64());
    const unsigned kNumResamples = 2000;
    vector<RatioBootstrapEstimator::Estimate> estimates =
        estimator.ComputeRatioEstimates(data, kNumResamples,
                                        /*confidence_level=*/0.95,
                                        /*compute_geometric_mean=*/true);

    // Sort the labels for display.
    sort(labels.begin(), labels.end(), [](const Label& a, const Label& b) {
      return CodeUnitCompareIgnoringASCIICaseLessThan(a.benchmark, b.benchmark);
    });

    printf("\n");
    printf("%-20s %9s %9s %7s %17s\n", category.c_str(), "Before", "After",
           "Perf", "95% CI (BCa)");
    printf(
        "=================== ========= ========= ======= "
        "=================\n");
    for (const Label& label : labels) {
      // RatioBootstrapEstimator doesn't give us the plain means, so compute
      // that by hand.
      double sum_before = 0.0, sum_after = 0.0;
      for (const RatioBootstrapEstimator::Sample& sample :
           data[label.data_index]) {
        sum_before += sample.before;
        sum_after += sample.after;
      }
      double mean_before = sum_before / data[label.data_index].size();
      double mean_after = sum_after / data[label.data_index].size();

      const RatioBootstrapEstimator::Estimate& estimate =
          estimates[label.data_index];
      printf("%-19s %9.0f %9.0f %+6.1f%%  [%+5.1f%%, %+5.1f%%]\n",
             label.benchmark.c_str(), mean_before, mean_after,
             100.0 * (estimate.point_estimate - 1.0),
             100.0 * (estimate.lower - 1.0), 100.0 * (estimate.upper - 1.0));
    }

    const RatioBootstrapEstimator::Estimate& estimate = estimates[data.size()];
    printf("%-19s %9s %9s %+6.1f%%  [%+5.1f%%, %+5.1f%%]\n", "Geometric mean",
           "", "", 100.0 * (estimate.point_estimate - 1.0),
           100.0 * (estimate.lower - 1.0), 100.0 * (estimate.upper - 1.0));
  }
}