1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925
|
#!/usr/bin/env vpython3
# Copyright 2020 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import itertools
import tempfile
from typing import Iterable, Set
import unittest
from unittest import mock
# vpython-provided modules.
# pylint: disable=import-error
import six
from pyfakefs import fake_filesystem_unittest
# pylint: enable=import-error
# //testing imports.
from unexpected_passes_common import data_types
from unexpected_passes_common import result_output
from unexpected_passes_common import unittest_utils as uu
# //third_party/blink/tools imports.
from blinkpy.w3c import buganizer
# Protected access is allowed for unittests.
# pylint: disable=protected-access
NON_WILDCARD = data_types.WildcardType.NON_WILDCARD
def CreateTextOutputPermutations(text: str, inputs: Iterable[str]) -> Set[str]:
"""Creates permutations of |text| filled with the contents of |inputs|.
Some output ordering is not guaranteed, so this acts as a way to generate
all possible outputs instead of manually listing them.
Args:
text: A string containing a single string field to format.
inputs: An iterable of strings to permute.
Returns:
A set of unique permutations of |text| filled with |inputs|. E.g. if |text|
is '1%s2' and |inputs| is ['a', 'b'], the return value will be
set(['1ab2', '1ba2']).
"""
permutations = set()
for p in itertools.permutations(inputs):
permutations.add(text % ''.join(p))
return permutations
class ConvertUnmatchedResultsToStringDictUnittest(unittest.TestCase):
def testEmptyResults(self) -> None:
"""Tests that providing empty results is a no-op."""
self.assertEqual(result_output._ConvertUnmatchedResultsToStringDict({}), {})
def testMinimalData(self) -> None:
"""Tests that everything functions when minimal data is provided."""
unmatched_results = {
'builder': [
data_types.Result('foo', [], 'Failure', 'step', 'build_id'),
],
}
expected_output = {
'foo': {
'builder': {
'step': [
'Got "Failure" on http://ci.chromium.org/b/build_id with '
'tags []',
],
},
},
}
output = result_output._ConvertUnmatchedResultsToStringDict(
unmatched_results)
self.assertEqual(output, expected_output)
def testRegularData(self) -> None:
"""Tests that everything functions when regular data is provided."""
unmatched_results = {
'builder': [
data_types.Result('foo', ['win', 'intel'], 'Failure', 'step_name',
'build_id')
],
}
# TODO(crbug.com/40177248): Hard-code the tag string once only Python 3 is
# supported.
expected_output = {
'foo': {
'builder': {
'step_name': [
'Got "Failure" on http://ci.chromium.org/b/build_id with '
'tags [%s]' % ' '.join(set(['win', 'intel'])),
]
}
}
}
output = result_output._ConvertUnmatchedResultsToStringDict(
unmatched_results)
self.assertEqual(output, expected_output)
class ConvertTestExpectationMapToStringDictUnittest(unittest.TestCase):
def testEmptyMap(self) -> None:
"""Tests that providing an empty map is a no-op."""
self.assertEqual(
result_output._ConvertTestExpectationMapToStringDict(
data_types.TestExpectationMap()), {})
def testSemiStaleMap(self) -> None:
"""Tests that everything functions when regular data is provided."""
expectation_map = data_types.TestExpectationMap({
'expectation_file':
data_types.ExpectationBuilderMap({
data_types.Expectation('foo/test', ['win', 'intel'], [
'RetryOnFailure'
], NON_WILDCARD):
data_types.BuilderStepMap({
'builder':
data_types.StepBuildStatsMap({
'all_pass':
uu.CreateStatsWithPassFails(2, 0),
'all_fail':
uu.CreateStatsWithPassFails(0, 2),
'some_pass':
uu.CreateStatsWithPassFails(1, 1),
}),
}),
data_types.Expectation('foo/test', ['linux', 'intel'], [
'RetryOnFailure'
], NON_WILDCARD):
data_types.BuilderStepMap({
'builder':
data_types.StepBuildStatsMap({
'all_pass':
uu.CreateStatsWithPassFails(2, 0),
}),
}),
data_types.Expectation('foo/test', ['mac', 'intel'], [
'RetryOnFailure'
], NON_WILDCARD):
data_types.BuilderStepMap({
'builder':
data_types.StepBuildStatsMap({
'all_fail':
uu.CreateStatsWithPassFails(0, 2),
}),
}),
}),
})
# TODO(crbug.com/40177248): Remove the Python 2 version once we are fully
# switched to Python 3.
if six.PY2:
expected_output = {
'expectation_file': {
'foo/test': {
'"RetryOnFailure" expectation on "win intel"': {
'builder': {
'Fully passed in the following': [
'all_pass (2/2 passed)',
],
'Never passed in the following': [
'all_fail (0/2 passed)',
],
'Partially passed in the following': {
'some_pass (1/2 passed)': [
data_types.BuildLinkFromBuildId('build_id0'),
],
},
},
},
'"RetryOnFailure" expectation on "intel linux"': {
'builder': {
'Fully passed in the following': [
'all_pass (2/2 passed)',
],
},
},
'"RetryOnFailure" expectation on "mac intel"': {
'builder': {
'Never passed in the following': [
'all_fail (0/2 passed)',
],
},
},
},
},
}
else:
# Set ordering does not appear to be stable between test runs, as we can
# get either order of tags. So, generate them now instead of hard coding
# them.
linux_tags = ' '.join(set(['linux', 'intel']))
win_tags = ' '.join(set(['win', 'intel']))
mac_tags = ' '.join(set(['mac', 'intel']))
expected_output = {
'expectation_file': {
'foo/test': {
'"RetryOnFailure" expectation on "%s"' % linux_tags: {
'builder': {
'Fully passed in the following': [
'all_pass (2/2 passed)',
],
},
},
'"RetryOnFailure" expectation on "%s"' % win_tags: {
'builder': {
'Fully passed in the following': [
'all_pass (2/2 passed)',
],
'Partially passed in the following': {
'some_pass (1/2 passed)': [
data_types.BuildLinkFromBuildId('build_id0'),
],
},
'Never passed in the following': [
'all_fail (0/2 passed)',
],
},
},
'"RetryOnFailure" expectation on "%s"' % mac_tags: {
'builder': {
'Never passed in the following': [
'all_fail (0/2 passed)',
],
},
},
},
},
}
str_dict = result_output._ConvertTestExpectationMapToStringDict(
expectation_map)
self.assertEqual(str_dict, expected_output)
class ConvertUnusedExpectationsToStringDictUnittest(unittest.TestCase):
def testEmptyDict(self) -> None:
"""Tests that nothing blows up when given an empty dict."""
self.assertEqual(result_output._ConvertUnusedExpectationsToStringDict({}),
{})
def testBasic(self) -> None:
"""Basic functionality test."""
unused = {
'foo_file': [
data_types.Expectation('foo/test', ['win', 'nvidia'],
['Failure', 'Timeout'], NON_WILDCARD),
],
'bar_file': [
data_types.Expectation('bar/test', ['win'], ['Failure'],
NON_WILDCARD),
data_types.Expectation('bar/test2', ['win'], ['RetryOnFailure'],
NON_WILDCARD)
],
}
if six.PY2:
expected_output = {
'foo_file': [
'[ win nvidia ] foo/test [ Failure Timeout ]',
],
'bar_file': [
'[ win ] bar/test [ Failure ]',
'[ win ] bar/test2 [ RetryOnFailure ]',
],
}
else:
# Set ordering does not appear to be stable between test runs, as we can
# get either order of tags. So, generate them now instead of hard coding
# them.
tags = ' '.join(['nvidia', 'win'])
results = ' '.join(['Failure', 'Timeout'])
expected_output = {
'foo_file': [
'[ %s ] foo/test [ %s ]' % (tags, results),
],
'bar_file': [
'[ win ] bar/test [ Failure ]',
'[ win ] bar/test2 [ RetryOnFailure ]',
],
}
self.assertEqual(
result_output._ConvertUnusedExpectationsToStringDict(unused),
expected_output)
class HtmlToFileUnittest(fake_filesystem_unittest.TestCase):
def setUp(self) -> None:
self.setUpPyfakefs()
self._file_handle = tempfile.NamedTemporaryFile(delete=False, mode='w')
self._filepath = self._file_handle.name
def testLinkifyString(self) -> None:
"""Test for _LinkifyString()."""
self._file_handle.close()
s = 'a'
self.assertEqual(result_output._LinkifyString(s), 'a')
s = 'http://a'
self.assertEqual(result_output._LinkifyString(s),
'<a href="http://a">http://a</a>')
s = 'link to http://a, click it'
self.assertEqual(result_output._LinkifyString(s),
'link to <a href="http://a">http://a</a>, click it')
def testRecursiveHtmlToFileExpectationMap(self) -> None:
"""Tests _RecursiveHtmlToFile() with an expectation map as input."""
expectation_map = {
'foo': {
'"RetryOnFailure" expectation on "win intel"': {
'builder': {
'Fully passed in the following': [
'all_pass (2/2)',
],
'Never passed in the following': [
'all_fail (0/2)',
],
'Partially passed in the following': {
'some_pass (1/2)': [
data_types.BuildLinkFromBuildId('build_id0'),
],
},
},
},
},
}
result_output._RecursiveHtmlToFile(expectation_map, self._file_handle)
self._file_handle.close()
# pylint: disable=line-too-long
# TODO(crbug.com/40177248): Remove the Python 2 version once we've fully
# switched to Python 3.
if six.PY2:
expected_output = """\
<button type="button" class="collapsible_group">foo</button>
<div class="content">
<button type="button" class="collapsible_group">"RetryOnFailure" expectation on "win intel"</button>
<div class="content">
<button type="button" class="collapsible_group">builder</button>
<div class="content">
<button type="button" class="collapsible_group">Never passed in the following</button>
<div class="content">
<p>all_fail (0/2)</p>
</div>
<button type="button" class="highlighted_collapsible_group">Fully passed in the following</button>
<div class="content">
<p>all_pass (2/2)</p>
</div>
<button type="button" class="collapsible_group">Partially passed in the following</button>
<div class="content">
<button type="button" class="collapsible_group">some_pass (1/2)</button>
<div class="content">
<p><a href="http://ci.chromium.org/b/build_id0">http://ci.chromium.org/b/build_id0</a></p>
</div>
</div>
</div>
</div>
</div>
"""
else:
expected_output = """\
<button type="button" class="collapsible_group">foo</button>
<div class="content">
<button type="button" class="collapsible_group">"RetryOnFailure" expectation on "win intel"</button>
<div class="content">
<button type="button" class="collapsible_group">builder</button>
<div class="content">
<button type="button" class="highlighted_collapsible_group">Fully passed in the following</button>
<div class="content">
<p>all_pass (2/2)</p>
</div>
<button type="button" class="collapsible_group">Never passed in the following</button>
<div class="content">
<p>all_fail (0/2)</p>
</div>
<button type="button" class="collapsible_group">Partially passed in the following</button>
<div class="content">
<button type="button" class="collapsible_group">some_pass (1/2)</button>
<div class="content">
<p><a href="http://ci.chromium.org/b/build_id0">http://ci.chromium.org/b/build_id0</a></p>
</div>
</div>
</div>
</div>
</div>
"""
# pylint: enable=line-too-long
expected_output = _Dedent(expected_output)
with open(self._filepath) as f:
self.assertEqual(f.read(), expected_output)
def testRecursiveHtmlToFileUnmatchedResults(self) -> None:
"""Tests _RecursiveHtmlToFile() with unmatched results as input."""
unmatched_results = {
'foo': {
'builder': {
None: [
'Expected "" on http://ci.chromium.org/b/build_id, got '
'"Failure" with tags []',
],
'step_name': [
'Expected "Failure RetryOnFailure" on '
'http://ci.chromium.org/b/build_id, got '
'"Failure" with tags [win intel]',
]
},
},
}
result_output._RecursiveHtmlToFile(unmatched_results, self._file_handle)
self._file_handle.close()
# pylint: disable=line-too-long
# Order is not guaranteed, so create permutations.
expected_template = """\
<button type="button" class="collapsible_group">foo</button>
<div class="content">
<button type="button" class="collapsible_group">builder</button>
<div class="content">
%s
</div>
</div>
"""
values = [
"""\
<button type="button" class="collapsible_group">None</button>
<div class="content">
<p>Expected "" on <a href="http://ci.chromium.org/b/build_id">http://ci.chromium.org/b/build_id</a>, got "Failure" with tags []</p>
</div>
""",
"""\
<button type="button" class="collapsible_group">step_name</button>
<div class="content">
<p>Expected "Failure RetryOnFailure" on <a href="http://ci.chromium.org/b/build_id">http://ci.chromium.org/b/build_id</a>, got "Failure" with tags [win intel]</p>
</div>
""",
]
expected_output = CreateTextOutputPermutations(expected_template, values)
# pylint: enable=line-too-long
expected_output = [_Dedent(e) for e in expected_output]
with open(self._filepath) as f:
self.assertIn(f.read(), expected_output)
class PrintToFileUnittest(fake_filesystem_unittest.TestCase):
def setUp(self) -> None:
self.setUpPyfakefs()
self._file_handle = tempfile.NamedTemporaryFile(delete=False, mode='w')
self._filepath = self._file_handle.name
def testRecursivePrintToFileExpectationMap(self) -> None:
"""Tests RecursivePrintToFile() with an expectation map as input."""
expectation_map = {
'foo': {
'"RetryOnFailure" expectation on "win intel"': {
'builder': {
'Fully passed in the following': [
'all_pass (2/2)',
],
'Never passed in the following': [
'all_fail (0/2)',
],
'Partially passed in the following': {
'some_pass (1/2)': [
data_types.BuildLinkFromBuildId('build_id0'),
],
},
},
},
},
}
result_output.RecursivePrintToFile(expectation_map, 0, self._file_handle)
self._file_handle.close()
# TODO(crbug.com/40177248): Keep the Python 3 version once we are fully
# switched.
if six.PY2:
expected_output = """\
foo
"RetryOnFailure" expectation on "win intel"
builder
Never passed in the following
all_fail (0/2)
Fully passed in the following
all_pass (2/2)
Partially passed in the following
some_pass (1/2)
http://ci.chromium.org/b/build_id0
"""
else:
expected_output = """\
foo
"RetryOnFailure" expectation on "win intel"
builder
Fully passed in the following
all_pass (2/2)
Never passed in the following
all_fail (0/2)
Partially passed in the following
some_pass (1/2)
http://ci.chromium.org/b/build_id0
"""
with open(self._filepath) as f:
self.assertEqual(f.read(), expected_output)
def testRecursivePrintToFileUnmatchedResults(self) -> None:
"""Tests RecursivePrintToFile() with unmatched results as input."""
unmatched_results = {
'foo': {
'builder': {
None: [
'Expected "" on http://ci.chromium.org/b/build_id, got '
'"Failure" with tags []',
],
'step_name': [
'Expected "Failure RetryOnFailure" on '
'http://ci.chromium.org/b/build_id, got '
'"Failure" with tags [win intel]',
]
},
},
}
result_output.RecursivePrintToFile(unmatched_results, 0, self._file_handle)
self._file_handle.close()
# pylint: disable=line-too-long
# Order is not guaranteed, so create permutations.
expected_template = """\
foo
builder%s
"""
values = [
"""
None
Expected "" on http://ci.chromium.org/b/build_id, got "Failure" with tags []\
""",
"""
step_name
Expected "Failure RetryOnFailure" on http://ci.chromium.org/b/build_id, got "Failure" with tags [win intel]\
""",
]
expected_output = CreateTextOutputPermutations(expected_template, values)
# pylint: enable=line-too-long
with open(self._filepath) as f:
self.assertIn(f.read(), expected_output)
class OutputResultsUnittest(fake_filesystem_unittest.TestCase):
def setUp(self) -> None:
self.setUpPyfakefs()
self._file_handle = tempfile.NamedTemporaryFile(delete=False, mode='w')
self._filepath = self._file_handle.name
def testOutputResultsUnsupportedFormat(self) -> None:
"""Tests that passing in an unsupported format is an error."""
with self.assertRaises(RuntimeError):
result_output.OutputResults(data_types.TestExpectationMap(),
data_types.TestExpectationMap(),
data_types.TestExpectationMap(), {}, {},
'asdf')
def testOutputResultsSmoketest(self) -> None:
"""Test that nothing blows up when outputting."""
# yapf: disable
expectation_map = data_types.TestExpectationMap({
'foo':
data_types.ExpectationBuilderMap({
data_types.Expectation(
'foo', ['win', 'intel'], 'RetryOnFailure', NON_WILDCARD):
data_types.BuilderStepMap({
'stale':
data_types.StepBuildStatsMap({
'all_pass':
uu.CreateStatsWithPassFails(2, 0),
}),
}),
data_types.Expectation('foo', ['linux'], 'Failure', NON_WILDCARD):
data_types.BuilderStepMap({
'semi_stale':
data_types.StepBuildStatsMap({
'all_pass':
uu.CreateStatsWithPassFails(2, 0),
'some_pass':
uu.CreateStatsWithPassFails(1, 1),
'none_pass':
uu.CreateStatsWithPassFails(0, 2),
}),
}),
data_types.Expectation('foo', ['mac'], 'Failure', NON_WILDCARD):
data_types.BuilderStepMap({
'active':
data_types.StepBuildStatsMap({
'none_pass':
uu.CreateStatsWithPassFails(0, 2),
}),
}),
}),
})
# yapf: enable
unmatched_results = {
'builder': [
data_types.Result('foo', ['win', 'intel'], 'Failure', 'step_name',
'build_id'),
],
}
unmatched_expectations = {
'foo_file': [
data_types.Expectation('foo', ['linux'], 'RetryOnFailure',
NON_WILDCARD),
],
}
stale, semi_stale, active = expectation_map.SplitByStaleness()
result_output.OutputResults(stale, semi_stale, active, {}, {}, 'print',
self._file_handle)
result_output.OutputResults(stale, semi_stale, active, unmatched_results,
{}, 'print', self._file_handle)
result_output.OutputResults(stale, semi_stale, active, {},
unmatched_expectations, 'print',
self._file_handle)
result_output.OutputResults(stale, semi_stale, active, unmatched_results,
unmatched_expectations, 'print',
self._file_handle)
result_output.OutputResults(stale, semi_stale, active, {}, {}, 'html',
self._file_handle)
result_output.OutputResults(stale, semi_stale, active, unmatched_results,
{}, 'html', self._file_handle)
result_output.OutputResults(stale, semi_stale, active, {},
unmatched_expectations, 'html',
self._file_handle)
result_output.OutputResults(stale, semi_stale, active, unmatched_results,
unmatched_expectations, 'html',
self._file_handle)
class OutputAffectedUrlsUnittest(fake_filesystem_unittest.TestCase):
def setUp(self) -> None:
self.setUpPyfakefs()
self._file_handle = tempfile.NamedTemporaryFile(delete=False, mode='w')
self._filepath = self._file_handle.name
def testOutput(self) -> None:
"""Tests that the output is correct."""
urls = [
'https://crbug.com/1234',
'https://crbug.com/angleproject/1234',
'http://crbug.com/2345',
'crbug.com/3456',
'b/9999',
]
orphaned_urls = ['https://crbug.com/1234', 'crbug.com/3456']
result_output._OutputAffectedUrls(urls, orphaned_urls, self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs: '
'https://crbug.com/1234 '
'https://crbug.com/angleproject/1234 '
'http://crbug.com/2345 '
'https://crbug.com/3456 '
'https://b/9999\n'
'Closable bugs: '
'https://crbug.com/1234 '
'https://crbug.com/3456\n'))
class OutputUrlsForClDescriptionUnittest(fake_filesystem_unittest.TestCase):
def setUp(self) -> None:
self.setUpPyfakefs()
self._file_handle = tempfile.NamedTemporaryFile(delete=False, mode='w')
self._filepath = self._file_handle.name
def testSingleLine(self) -> None:
"""Tests when all bugs can fit on a single line."""
urls = [
'crbug.com/1234',
'https://crbug.com/angleproject/2345',
'b/9999',
]
result_output._OutputUrlsForClDescription(urls, [], self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 9999, 1234, angleproject:2345\n'))
def testBugLimit(self) -> None:
"""Tests that only a certain number of bugs are allowed per line."""
urls = [
'crbug.com/1',
'crbug.com/2',
'crbug.com/3',
'crbug.com/4',
'crbug.com/5',
'crbug.com/6',
]
result_output._OutputUrlsForClDescription(urls, [], self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 1, 2, 3, 4, 5\n'
'Bug: 6\n'))
def testLengthLimit(self) -> None:
"""Tests that only a certain number of characters are allowed per line."""
urls = [
'crbug.com/averylongprojectthatwillgooverthelinelength/1',
'crbug.com/averylongprojectthatwillgooverthelinelength/2',
]
result_output._OutputUrlsForClDescription(urls, [], self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(),
('Affected bugs for CL description:\n'
'Bug: averylongprojectthatwillgooverthelinelength:1\n'
'Bug: averylongprojectthatwillgooverthelinelength:2\n'))
project_name = (result_output.MAX_CHARACTERS_PER_CL_LINE - len('Bug: ') -
len(':1, 2')) * 'a'
urls = [
'crbug.com/%s/1' % project_name,
'crbug.com/2',
]
with open(self._filepath, 'w') as f:
result_output._OutputUrlsForClDescription(urls, [], f)
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 2, %s:1\n' % project_name))
project_name += 'a'
urls = [
'crbug.com/%s/1' % project_name,
'crbug.com/2',
]
with open(self._filepath, 'w') as f:
result_output._OutputUrlsForClDescription(urls, [], f)
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 2\nBug: %s:1\n' % project_name))
def testSingleBugOverLineLimit(self) -> None:
"""Tests the behavior when a single bug by itself is over the line limit."""
project_name = result_output.MAX_CHARACTERS_PER_CL_LINE * 'a'
urls = [
'crbug.com/%s/1' % project_name,
'crbug.com/2',
]
result_output._OutputUrlsForClDescription(urls, [], self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 2\n'
'Bug: %s:1\n' % project_name))
def testOrphanedBugs(self) -> None:
"""Tests that orphaned bugs are output properly alongside affected ones."""
urls = [
'crbug.com/1',
'crbug.com/2',
'crbug.com/3',
]
orphaned_urls = ['crbug.com/2']
result_output._OutputUrlsForClDescription(urls, orphaned_urls,
self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 1, 3\n'
'Fixed: 2\n'))
def testOnlyOrphanedBugs(self) -> None:
"""Tests output when all affected bugs are orphaned bugs."""
urls = [
'crbug.com/1',
'crbug.com/2',
]
orphaned_urls = [
'crbug.com/1',
'crbug.com/2',
]
result_output._OutputUrlsForClDescription(urls, orphaned_urls,
self._file_handle)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Fixed: 1, 2\n'))
def testNoAutoCloseBugs(self):
"""Tests behavior when not auto closing bugs."""
urls = [
'crbug.com/0',
'crbug.com/1',
]
orphaned_urls = [
'crbug.com/0',
]
mock_buganizer = MockBuganizerClient()
with mock.patch.object(result_output,
'_GetBuganizerClient',
return_value=mock_buganizer):
result_output._OutputUrlsForClDescription(urls,
orphaned_urls,
self._file_handle,
auto_close_bugs=False)
self._file_handle.close()
with open(self._filepath) as f:
self.assertEqual(f.read(), ('Affected bugs for CL description:\n'
'Bug: 1\n'
'Bug: 0\n'))
mock_buganizer.NewComment.assert_called_once_with(
'crbug.com/0', result_output.BUGANIZER_COMMENT)
class MockBuganizerClient:
def __init__(self):
self.comment_list = []
self.NewComment = mock.Mock()
def GetIssueComments(self, _) -> list:
return self.comment_list
class PostCommentsToOrphanedBugsUnittest(unittest.TestCase):
def setUp(self):
self._buganizer_client = MockBuganizerClient()
self._buganizer_patcher = mock.patch.object(
result_output,
'_GetBuganizerClient',
return_value=self._buganizer_client)
self._buganizer_patcher.start()
self.addCleanup(self._buganizer_patcher.stop)
def testBasic(self):
"""Tests the basic/happy path scenario."""
self._buganizer_client.comment_list.append({'comment': 'Not matching'})
result_output._PostCommentsToOrphanedBugs(
['crbug.com/0', 'crbug.com/angleproject/0'])
self.assertEqual(self._buganizer_client.NewComment.call_count, 2)
self._buganizer_client.NewComment.assert_any_call(
'crbug.com/0', result_output.BUGANIZER_COMMENT)
self._buganizer_client.NewComment.assert_any_call(
'crbug.com/angleproject/0', result_output.BUGANIZER_COMMENT)
def testNoDuplicateComments(self):
"""Tests that duplicate comments are not posted on bugs."""
self._buganizer_client.comment_list.append(
{'comment': result_output.BUGANIZER_COMMENT})
result_output._PostCommentsToOrphanedBugs(
['crbug.com/0', 'crbug.com/angleproject/0'])
self._buganizer_client.NewComment.assert_not_called()
def testInvalidBugUrl(self):
"""Tests behavior when a non-crbug URL is provided."""
with mock.patch.object(self._buganizer_client,
'GetIssueComments',
side_effect=buganizer.BuganizerError):
with self.assertLogs(level='WARNING') as log_manager:
result_output._PostCommentsToOrphanedBugs(['somesite.com/0'])
for message in log_manager.output:
if 'Could not fetch or add comments for somesite.com/0' in message:
break
else:
self.fail('Did not find expected log message')
self._buganizer_client.NewComment.assert_not_called()
def testServiceDiscoveryError(self):
"""Tests behavior when service discovery fails."""
with mock.patch.object(result_output,
'_GetBuganizerClient',
side_effect=buganizer.BuganizerError):
with self.assertLogs(level='ERROR') as log_manager:
result_output._PostCommentsToOrphanedBugs(['crbug.com/0'])
for message in log_manager.output:
if ('Encountered error when authenticating, cannot post '
'comments') in message:
break
else:
self.fail('Did not find expected log message')
def testGetIssueCommentsError(self):
"""Tests behavior when GetIssueComments encounters an error."""
with mock.patch.object(self._buganizer_client,
'GetIssueComments',
side_effect=({
'error': ':('
}, [{
'comment': 'Not matching'
}])):
with self.assertLogs(level='ERROR') as log_manager:
result_output._PostCommentsToOrphanedBugs(
['crbug.com/0', 'crbug.com/1'])
for message in log_manager.output:
if 'Failed to get comments from crbug.com/0: :(' in message:
break
else:
self.fail('Did not find expected log message')
self._buganizer_client.NewComment.assert_called_once_with(
'crbug.com/1', result_output.BUGANIZER_COMMENT)
def testGetIssueCommentsUnspecifiedError(self):
"""Tests behavior when GetIssueComments encounters an unspecified error."""
with mock.patch.object(self._buganizer_client,
'GetIssueComments',
side_effect=({}, [{
'comment': 'Not matching'
}])):
with self.assertLogs(level='ERROR') as log_manager:
result_output._PostCommentsToOrphanedBugs(
['crbug.com/0', 'crbug.com/1'])
for message in log_manager.output:
if ('Failed to get comments from crbug.com/0: error not provided'
in message):
break
else:
self.fail('Did not find expected log message')
self._buganizer_client.NewComment.assert_called_once_with(
'crbug.com/1', result_output.BUGANIZER_COMMENT)
def _Dedent(s: str) -> str:
output = ''
for line in s.splitlines(True):
output += line.lstrip()
return output
if __name__ == '__main__':
unittest.main(verbosity=2)
|