File: pressure_observer_test.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (374 lines) | stat: -rw-r--r-- 15,799 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "third_party/blink/renderer/modules/compute_pressure/pressure_observer.h"

#include "base/run_loop.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/renderer/bindings/core/v8/native_value_traits.h"
#include "third_party/blink/renderer/bindings/core/v8/script_function.h"
#include "third_party/blink/renderer/bindings/core/v8/script_promise.h"
#include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_testing.h"
#include "third_party/blink/renderer/bindings/modules/v8/v8_pressure_observer_options.h"
#include "third_party/blink/renderer/bindings/modules/v8/v8_pressure_record.h"
#include "third_party/blink/renderer/bindings/modules/v8/v8_pressure_state.h"
#include "third_party/blink/renderer/modules/compute_pressure/pressure_observer_test_utils.h"
#include "third_party/blink/renderer/modules/compute_pressure/pressure_record.h"
#include "third_party/blink/renderer/platform/bindings/exception_state.h"
#include "third_party/blink/renderer/platform/heap/garbage_collected.h"
#include "third_party/blink/renderer/platform/testing/task_environment.h"
#include "third_party/blink/renderer/platform/testing/unit_test_helpers.h"
#include "third_party/blink/renderer/platform/wtf/wtf_size_t.h"
#include "v8/include/v8.h"

using device::mojom::blink::PressureState;

namespace blink {

namespace {

// Constants to modify ChangeRateMonitor settings for deterministic test.
constexpr uint64_t kChangeCount = 2;
constexpr base::TimeDelta kDelayTime = base::Seconds(1);
constexpr base::TimeDelta kPenaltyDuration = base::Seconds(4);

class ClosureRunnerCallable final : public ScriptFunction {
 public:
  explicit ClosureRunnerCallable(base::OnceClosure callback)
      : callback_(std::move(callback)) {}

  ScriptValue Call(ScriptState*, ScriptValue) override {
    if (callback_) {
      std::move(callback_).Run();
    }
    return ScriptValue();
  }

 private:
  base::OnceClosure callback_;
};

// Helper class for WaitForPromiseFulfillment(). It provides a
// function that invokes |callback| when a ScriptPromise is resolved.
class ThenClosureRunner final
    : public ThenCallable<IDLUndefined, ThenClosureRunner> {
 public:
  explicit ThenClosureRunner(base::OnceClosure callback)
      : callback_(std::move(callback)) {}

  void React(ScriptState*) {
    if (callback_) {
      std::move(callback_).Run();
    }
  }

 private:
  base::OnceClosure callback_;
};

// Helper class expected to be used as a PressureObserver callback (i.e.
// PressureUpdateCallback). When invoked, it takes the |changes| array passed as
// a first argument to the callback and stores its elements, which can later be
// retrieved by the pressure_records() method.
//
// This is similar to the following in JS:
//
// let pressure_records = [];
// const PressureRecordAccumulator = (changes) => {
//   pressure_records = pressure_records.concat(changes);
// }
// /* Later on */
// const observer = new PressureObserver(PressureRecordAccumulator);
class PressureRecordAccumulator final : public ScriptFunction {
 public:
  ScriptValue Call(ScriptState*, ScriptValue script_value) override {
    {
      NonThrowableExceptionState exception_state;
      const auto& updates =
          NativeValueTraits<IDLSequence<PressureRecord>>::NativeValue(
              script_value.GetIsolate(), script_value.V8Value(),
              exception_state);
      pressure_records_.AppendVector(updates);
    }
    return ScriptValue();
  }

  const auto& pressure_records() const { return pressure_records_; }

  void Trace(Visitor* visitor) const override {
    visitor->Trace(pressure_records_);
    ScriptFunction::Trace(visitor);
  }

 private:
  HeapVector<Member<PressureRecord>> pressure_records_;
};

void WaitForPromiseFulfillment(ScriptState* script_state,
                               ScriptPromise<IDLUndefined> promise) {
  base::RunLoop run_loop;
  promise.Then(script_state,
               MakeGarbageCollected<ThenClosureRunner>(run_loop.QuitClosure()));
  // Execute pending microtasks, otherwise it can take a few seconds for the
  // promise to resolve.
  script_state->GetContext()->GetMicrotaskQueue()->PerformCheckpoint(
      script_state->GetIsolate());
  run_loop.Run();
}

}  // namespace

TEST(PressureObserverTest, RateObfuscationMitigation) {
  test::TaskEnvironment task_environment(
      base::test::TaskEnvironment::TimeSource::MOCK_TIME);

  FakePressureService pressure_service;
  ComputePressureTestingContext scope(&pressure_service);

  auto* pressure_record_accumulator =
      MakeGarbageCollected<PressureRecordAccumulator>();
  auto* callback = V8PressureUpdateCallback::Create(
      pressure_record_accumulator->ToV8Function(scope.GetScriptState()));

  constexpr size_t kNumPressureStates =
      static_cast<size_t>(PressureState::kMaxValue) + 1U;
  constexpr std::array<device::mojom::blink::PressureState, kNumPressureStates>
      kPressureStates = {
          PressureState::kNominal,
          PressureState::kFair,
          PressureState::kSerious,
          PressureState::kCritical,
      };
  constexpr base::TimeDelta kSamplingInterval = base::Milliseconds(200);
  constexpr base::TimeDelta kSmallInterval = base::Milliseconds(100);

  auto* observer = PressureObserver::Create(callback);
  // Add 1 to kNumPressureStats because we want to initially send kNumPressure
  // updates without triggering the rate obfuscation mitigations.
  observer->change_rate_monitor_for_testing()
      .set_change_count_threshold_for_testing(kNumPressureStates + 1U);
  observer->change_rate_monitor_for_testing().set_penalty_duration_for_testing(
      kPenaltyDuration);

  auto* options = PressureObserverOptions::Create();
  options->setSampleInterval(kSamplingInterval.InMilliseconds());
  auto promise = observer->observe(
      scope.GetScriptState(), V8PressureSource(V8PressureSource::Enum::kCpu),
      options, scope.GetExceptionState());
  WaitForPromiseFulfillment(scope.GetScriptState(), promise);

  // Fast-forward by any positive amount of time just so that any
  // base::TimeTicks::Now() invocation differs from the original value recorded
  // by ChangeRateMonitor when it was created by PressureObserver.
  task_environment.FastForwardBy(kSmallInterval);

  const auto& pressure_records =
      pressure_record_accumulator->pressure_records();

  // First test sending updates without triggering the rate obfuscation
  // mitigation. We send kNumPressureStates updates and verify that they were
  // sent without delay.
  {
    for (wtf_size_t i = 0; i < kPressureStates.size(); ++i) {
      // None of these updates trigger the rate obfuscation mitigations because
      // of the value we passed to set_change_count_threshold_for_testing(), so
      // they are all dispatched immediately even if we do not advance time.
      EXPECT_EQ(pressure_records.size(), i);
      const auto& state = kPressureStates[i];
      pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
          device::mojom::blink::PressureSource::kCpu, state,
          /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));
      task_environment.FastForwardBy(base::Milliseconds(0));
      EXPECT_EQ(pressure_records.size(), i + 1);

      // Advance time nonetheless so that the next update is sent with a more
      // recent timestamp.
      task_environment.FastForwardBy(kSamplingInterval);
    }
    ASSERT_EQ(pressure_records.size(), kNumPressureStates);

    // While here, check that PressureRecord.time is recorded properly for each
    // update. The difference between each timestamp should be
    // kSamplingInterval, which is how much we fast-forwarded by in the loop
    // above.
    for (wtf_size_t i = 0; i < (pressure_records.size() - 1U); ++i) {
      EXPECT_EQ(pressure_records[i + 1]->time() - pressure_records[i]->time(),
                kSamplingInterval.InMilliseconds());
    }
  }

  // Test the rate obfuscation mitigation. At this point, we have sent
  // kNumPressureStates updates and therefore activated the rate obfuscation
  // mitigation for future updates.
  {
    const wtf_size_t original_callback_count = pressure_records.size();

    // This update will not be sent immediately and will be queued by the rate
    // obfuscation code instead.
    pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
        device::mojom::blink::PressureSource::kCpu, PressureState::kNominal,
        /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));
    task_environment.FastForwardBy(base::Milliseconds(0));
    EXPECT_EQ(pressure_records.size(), original_callback_count);

    // Advancing by a delta smaller than kPenaltyDuration (4000ms) also does
    // not send any updates.
    task_environment.FastForwardBy(kSamplingInterval);
    EXPECT_EQ(pressure_records.size(), original_callback_count);

    // Test the what happens when an update is sent while we are already under
    // penalty: the new update must replace the previously queued one.
    pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
        device::mojom::blink::PressureSource::kCpu, PressureState::kFair,
        /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));

    // If we advance another 200ms, we are still 3600s short of the penalty
    // duration, after which we will finally send an update.
    task_environment.FastForwardBy(kSamplingInterval);
    EXPECT_EQ(pressure_records.size(), original_callback_count);
    // Advance the remaining 3600s to get out of the penalty. This is
    // kPenaltyDuration minus the two FastForwardBy(kSamplingInterval) calls we
    // have made.
    task_environment.FastForwardBy(kPenaltyDuration - kSamplingInterval * 2);
    const wtf_size_t new_callback_count = original_callback_count + 1U;
    ASSERT_EQ(pressure_records.size(), new_callback_count);

    // Verify that the update sent is the second one, not the first.
    // We compare strings to make the output easier to compare in case of error.
    EXPECT_EQ(pressure_records.back()->state().AsString(),
              V8PressureState(V8PressureState::Enum::kFair).AsString());
    // This update was sent after fast-forwarding by 100ms once and by 200ms 5
    // times.
    EXPECT_EQ(pressure_records.back()->time(),
              (kSmallInterval + (5 * kSamplingInterval)).InMilliseconds());
  }

  // Check that the rate obfuscation mitigation has been reset and not in place
  // anymore.
  {
    const wtf_size_t original_callback_count = pressure_records.size();

    // Send an update and verify it has been delivered with no delay again.
    pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
        device::mojom::blink::PressureSource::kCpu, PressureState::kSerious,
        /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));
    task_environment.FastForwardBy(base::Milliseconds(0));
    EXPECT_EQ(pressure_records.size(), original_callback_count + 1U);
    EXPECT_EQ(pressure_records.back()->state().AsString(),
              V8PressureState(V8PressureState::Enum::kSerious).AsString());
  }

  observer->disconnect();
}

TEST(PressureObserverTest, PressureObserverDisconnectBeforePenaltyEnd) {
  test::TaskEnvironment task_environment(
      base::test::TaskEnvironment::TimeSource::MOCK_TIME);

  FakePressureService pressure_service;
  ComputePressureTestingContext scope(&pressure_service);

  base::RunLoop callback_run_loop;

  auto* callback_function = MakeGarbageCollected<ClosureRunnerCallable>(
      callback_run_loop.QuitClosure());
  auto* callback = V8PressureUpdateCallback::Create(
      callback_function->ToV8Function(scope.GetScriptState()));

  V8PressureSource source(V8PressureSource::Enum::kCpu);
  auto* options = PressureObserverOptions::Create();
  auto* observer = PressureObserver::Create(callback);
  auto promise = observer->observe(scope.GetScriptState(), source, options,
                                   scope.GetExceptionState());

  WaitForPromiseFulfillment(scope.GetScriptState(), promise);

  observer->change_rate_monitor_for_testing().set_change_count_threshold_for_testing(
      kChangeCount);
  observer->change_rate_monitor_for_testing().set_penalty_duration_for_testing(
      kPenaltyDuration);

  // First update.
  task_environment.FastForwardBy(kDelayTime);
  pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
      device::mojom::blink::PressureSource::kCpu, PressureState::kCritical,
      /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));

  callback_run_loop.Run();

  // Second update triggering the penalty.
  task_environment.FastForwardBy(kDelayTime);
  pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
      device::mojom::blink::PressureSource::kCpu, PressureState::kNominal,
      /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));

  // The number of seconds here should not exceed the penalty time, we just
  // want to run some code like OnUpdate() but not the pending delayed task
  // that it should have created.
  task_environment.FastForwardBy(kDelayTime);

  observer->disconnect();
  // This should not crash.
  // The number of seconds here together with the previous FastForwardBy() call
  // needs to exceed the chosen penalty time.
  task_environment.FastForwardBy(kPenaltyDuration);
}

TEST(PressureObserverTest, PressureObserverUnobserveBeforePenaltyEnd) {
  test::TaskEnvironment task_environment(
      base::test::TaskEnvironment::TimeSource::MOCK_TIME);

  FakePressureService pressure_service;
  ComputePressureTestingContext scope(&pressure_service);

  base::RunLoop callback_run_loop;

  auto* callback_function = MakeGarbageCollected<ClosureRunnerCallable>(
      callback_run_loop.QuitClosure());
  auto* callback = V8PressureUpdateCallback::Create(
      callback_function->ToV8Function(scope.GetScriptState()));

  V8PressureSource source(V8PressureSource::Enum::kCpu);
  auto* options = PressureObserverOptions::Create();
  auto* observer = PressureObserver::Create(callback);
  auto promise = observer->observe(scope.GetScriptState(), source, options,
                                   scope.GetExceptionState());

  WaitForPromiseFulfillment(scope.GetScriptState(), promise);

  observer->change_rate_monitor_for_testing().set_change_count_threshold_for_testing(
      kChangeCount);
  observer->change_rate_monitor_for_testing().set_penalty_duration_for_testing(
      kPenaltyDuration);

  // First update.
  task_environment.FastForwardBy(kDelayTime);
  pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
      device::mojom::blink::PressureSource::kCpu, PressureState::kNominal,
      /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));

  callback_run_loop.Run();

  // Second update triggering the penalty.
  task_environment.FastForwardBy(kDelayTime);
  pressure_service.SendUpdate(mojom::blink::WebPressureUpdate::New(
      device::mojom::blink::PressureSource::kCpu, PressureState::kCritical,
      /*own_contribution_estimate=*/0.5, base::TimeTicks::Now()));

  // The number of seconds here should not exceed the penalty time, we just
  // want to run some code like OnUpdate() but not the pending delayed task
  // that it should have created.
  task_environment.FastForwardBy(kDelayTime);

  observer->unobserve(source);
  // This should not crash.
  // The number of seconds here together with the previous FastForwardBy() call
  // needs to exceed the chosen penalty time.
  task_environment.FastForwardBy(kPenaltyDuration);
}

}  // namespace blink