File: simple-invalid-iterators.cpp

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (39 lines) | stat: -rw-r--r-- 1,196 bytes parent folder | download | duplicates (6)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <algorithm>
#include <vector>

void IteratorUsedAfterErase(std::vector<int>& v) {
  auto it = std::begin(v);
  for (; it != std::end(v); ++it) {
    // Note that this access is valid, because we theoretically always check it
    // against `end` before going here.
    if (*it > 3) {
      // Calling `erase` invalidates `it`, and the next loop iteration will use
      // it via `++it`.
      // To fix this error:
      // it = v.erase(it);
      v.erase(it);
    }
  }
}

void IteratorUsedAfterPushBack(std::vector<int>& v) {
  auto it = std::begin(v);
  // Note that `*it == 3` is valid here because we first checked it against
  // `end`.
  if (it != std::end(v) && *it == 3) {
    // Similarly here, push_back invalidates all the previous iterators.
    v.push_back(4);
  }
  // Invalid because we might have entered the condition block.
  ++it;
}

void IteratorsMismatched(std::vector<int>& v1, std::vector<int>& v2) {
  auto it = std::find(std::begin(v1), std::end(v1), 3);

  // Invalid because mismatched iterators.
  v2.erase(it);
}