1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "Util.h"
#include "clang/AST/ASTConsumer.h"
#include "clang/Basic/DiagnosticSema.h"
#include "clang/Frontend/CompilerInstance.h"
#include "clang/Frontend/FrontendAction.h"
#include "clang/Frontend/FrontendPluginRegistry.h"
#include "clang/Lex/Pragma.h"
#include "llvm/ADT/StringMap.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/MemoryBuffer.h"
namespace chrome_checker {
enum Disposition {
kSkip = 0, // Do not check for any unsafe operations.
kSkipLibc, // Check for unsafe buffers but not unsafe libc calls.
kCheck, // Check for both unsafe buffers and unsafe libc calls.
};
// Stores whether the filename (key) should be checked for errors.
// If the filename is not present, the choice is up to the plugin to
// determine from the path prefixes control file.
llvm::StringMap<Disposition> g_checked_files_cache;
struct CheckFilePrefixes {
// `buffer` owns the memory for the strings in `prefix_map`.
std::unique_ptr<llvm::MemoryBuffer> buffer;
std::map<llvm::StringRef, char> prefix_map;
bool check_buffers = true;
bool check_libc_calls = false;
};
class UnsafeBuffersDiagnosticConsumer : public clang::DiagnosticConsumer {
public:
UnsafeBuffersDiagnosticConsumer(clang::DiagnosticsEngine* engine,
clang::DiagnosticConsumer* next,
clang::CompilerInstance* instance,
CheckFilePrefixes check_file_prefixes)
: engine_(engine),
next_(next),
instance_(instance),
check_file_prefixes_(std::move(check_file_prefixes)),
diag_note_link_(engine_->getCustomDiagID(
clang::DiagnosticsEngine::Level::Note,
"See //docs/unsafe_buffers.md for help.")) {}
~UnsafeBuffersDiagnosticConsumer() override = default;
void clear() override {
if (next_) {
next_->clear();
NumErrors = next_->getNumErrors();
NumWarnings = next_->getNumWarnings();
}
}
void BeginSourceFile(const clang::LangOptions& opts,
const clang::Preprocessor* pp) override {
if (next_) {
next_->BeginSourceFile(opts, pp);
NumErrors = next_->getNumErrors();
NumWarnings = next_->getNumWarnings();
}
}
void EndSourceFile() override {
if (next_) {
next_->EndSourceFile();
NumErrors = next_->getNumErrors();
NumWarnings = next_->getNumWarnings();
}
}
void finish() override {
if (next_) {
next_->finish();
NumErrors = next_->getNumErrors();
NumWarnings = next_->getNumWarnings();
}
}
bool IncludeInDiagnosticCounts() const override {
return next_ && next_->IncludeInDiagnosticCounts();
}
void HandleDiagnostic(clang::DiagnosticsEngine::Level level,
const clang::Diagnostic& diag) override {
const unsigned diag_id = diag.getID();
if (inside_handle_diagnostic_) {
// Avoid handling the diagnostics which we emit in here.
return PassthroughDiagnostic(level, diag);
}
// The `-Runsafe-buffer-usage-in-container` warning gets enabled along with
// `-Runsafe-buffer-usage`, but it's a hardcoded warning about std::span
// constructor. We don't want to emit these, we instead want the span ctor
// (and our own base::span ctor) to be marked [[clang::unsafe_buffer_usage]]
// and have that work: https://github.com/llvm/llvm-project/issues/80482
if (diag_id == clang::diag::warn_unsafe_buffer_usage_in_container) {
return;
}
// Drop the note saying "pass -fsafe-buffer-usage-suggestions to receive
// code hardening suggestions" since that's not simple for Chrome devs to
// do anyway. We can provide a GN variable in the future and point to that
// if needed, or just turn it on always in this plugin, if desired.
if (diag_id == clang::diag::note_safe_buffer_usage_suggestions_disabled) {
return;
}
const bool is_buffers_diagnostic =
diag_id == clang::diag::warn_unsafe_buffer_variable ||
diag_id == clang::diag::warn_unsafe_buffer_operation ||
diag_id == clang::diag::note_unsafe_buffer_operation ||
diag_id == clang::diag::note_unsafe_buffer_variable_fixit_group ||
diag_id == clang::diag::note_unsafe_buffer_variable_fixit_together ||
diag_id == clang::diag::note_safe_buffer_debug_mode;
const bool is_libc_diagnostic =
diag_id == clang::diag::warn_unsafe_buffer_libc_call ||
diag_id == clang::diag::note_unsafe_buffer_printf_call;
const bool ignore_diagnostic =
(is_buffers_diagnostic && !check_file_prefixes_.check_buffers) ||
(is_libc_diagnostic && !check_file_prefixes_.check_libc_calls);
if (ignore_diagnostic) {
return;
}
const bool handle_diagnostic =
(is_buffers_diagnostic && check_file_prefixes_.check_buffers) ||
(is_libc_diagnostic && check_file_prefixes_.check_libc_calls);
if (!handle_diagnostic) {
return PassthroughDiagnostic(level, diag);
}
// Note that we promote from Remark directly to Error, rather than to
// Warning, as -Werror will not get applied to whatever we choose here.
const auto elevated_level =
(is_libc_diagnostic ||
diag_id == clang::diag::warn_unsafe_buffer_variable ||
diag_id == clang::diag::warn_unsafe_buffer_operation)
? (engine_->getWarningsAsErrors()
? clang::DiagnosticsEngine::Level::Error
: clang::DiagnosticsEngine::Level::Warning)
: clang::DiagnosticsEngine::Level::Note;
const clang::SourceManager& sm = instance_->getSourceManager();
const clang::SourceLocation loc = diag.getLocation();
// -Wunsage-buffer-usage errors are omitted conditionally based on what file
// they are coming from.
auto disposition = FileHasSafeBuffersWarnings(sm, loc);
if (disposition == kSkip ||
(is_libc_diagnostic && disposition == kSkipLibc)) {
return;
}
// More selectively filter the libc calls we enforce.
if (is_libc_diagnostic && IsIgnoredLibcFunction(diag)) {
return;
}
// Elevate the Remark to a Warning, and pass along its Notes without
// changing them. Otherwise, do nothing, and the Remark (and its notes)
// will not be displayed.
//
// We don't count warnings/errors in this DiagnosticConsumer, so we don't
// call up to the base class here. Instead, whenever we pass through to
// the `next_` DiagnosticConsumer, we record its counts.
//
// Construct the StoredDiagnostic before Clear() or we get bad data from
// `diag`.
auto stored = clang::StoredDiagnostic(elevated_level, diag);
inside_handle_diagnostic_ = true;
engine_->Report(stored);
if (elevated_level != clang::DiagnosticsEngine::Level::Note) {
// For each warning, we inject our own Note as well, pointing to docs.
engine_->Report(loc, diag_note_link_);
}
inside_handle_diagnostic_ = false;
}
private:
void PassthroughDiagnostic(clang::DiagnosticsEngine::Level level,
const clang::Diagnostic& diag) {
if (next_) {
next_->HandleDiagnostic(level, diag);
NumErrors = next_->getNumErrors();
NumWarnings = next_->getNumWarnings();
}
}
// Depending on where the diagnostic is coming from, we may ignore it or
// cause it to generate a warning.
Disposition FileHasSafeBuffersWarnings(const clang::SourceManager& sm,
clang::SourceLocation loc) {
// ClassifySourceLocation() does not report kMacro as the location unless it
// happens to be inside a scratch buffer, which not all macro use does. For
// the unsafe-buffers warning, we want the SourceLocation where the macro is
// expanded to always be the decider about whether to fire a warning or not.
//
// The reason we do this is that the expansion site should be wrapped in
// UNSAFE_BUFFERS() if the unsafety is warranted. It can be done inside the
// macro itself too (in which case the warning will not fire), but the
// finest control is always at each expansion site.
while (loc.isMacroID()) {
loc = sm.getExpansionLoc(loc);
}
// TODO(crbug.com/40284755): Expand this diagnostic to more code. It should
// include everything except kSystem eventually.
LocationClassification loc_class =
ClassifySourceLocation(instance_->getHeaderSearchOpts(), sm, loc);
switch (loc_class) {
case LocationClassification::kSystem:
return kSkip;
case LocationClassification::kGenerated:
return kSkip;
case LocationClassification::kThirdParty:
case LocationClassification::kChromiumThirdParty:
case LocationClassification::kFirstParty:
case LocationClassification::kBlink:
case LocationClassification::kMacro:
break;
}
// We default to everything opting into checks (except categories that early
// out above) unless it is removed by the paths control file or by pragma.
// TODO(danakj): It would be an optimization to find a way to avoid creating
// a std::string here.
std::string filename = GetFilename(sm, loc, FilenameLocationType::kExactLoc,
FilenamesFollowPresumed::kNo);
// Avoid searching `check_file_prefixes_` more than once for a file.
auto cache_it = g_checked_files_cache.find(filename);
if (cache_it != g_checked_files_cache.end()) {
return cache_it->second;
}
llvm::StringRef cmp_filename = filename;
// If the path is absolute, drop the prefix up to the current working
// directory. Some mac machines are passing absolute paths to source files,
// but it's the absolute path to the build directory (the current working
// directory here) then a relative path from there.
llvm::SmallVector<char> cwd;
if (llvm::sys::fs::current_path(cwd).value() == 0) {
if (cmp_filename.consume_front(llvm::StringRef(cwd.data(), cwd.size()))) {
cmp_filename.consume_front("/");
}
}
// Drop the ../ prefixes.
while (cmp_filename.consume_front("./") ||
cmp_filename.consume_front("../"))
continue;
Disposition should_check = kCheck;
while (!cmp_filename.empty()) {
auto it = check_file_prefixes_.prefix_map.find(cmp_filename);
if (it != check_file_prefixes_.prefix_map.end()) {
should_check = it->second == '+' ? kCheck : kSkip;
break;
}
cmp_filename = llvm::sys::path::parent_path(cmp_filename);
}
g_checked_files_cache.insert({filename, should_check});
return should_check;
}
bool IsIgnoredLibcFunction(const clang::Diagnostic& diag) const {
// The unsafe libc calls warning is a wee bit overzealous about
// functions which might result in a OOB read only.
if (diag.getNumArgs() < 1) {
return false;
}
if (diag.getArgKind(0) !=
clang::DiagnosticsEngine::ArgumentKind::ak_nameddecl) {
return false;
}
auto* decl = reinterpret_cast<clang::NamedDecl*>(diag.getRawArg(0));
llvm::StringRef name = decl->getName();
return name == "strlen" || name == "wcslen" || name == "atoi" ||
name == "atof";
}
// Used to prevent recursing into HandleDiagnostic() when we're emitting a
// diagnostic from that function.
bool inside_handle_diagnostic_ = false;
clang::DiagnosticsEngine* engine_;
clang::DiagnosticConsumer* next_;
clang::CompilerInstance* instance_;
CheckFilePrefixes check_file_prefixes_;
unsigned diag_note_link_;
};
class UnsafeBuffersASTConsumer : public clang::ASTConsumer {
public:
UnsafeBuffersASTConsumer(clang::CompilerInstance* instance,
CheckFilePrefixes check_file_prefixes)
: instance_(instance) {
// Replace the DiagnosticConsumer with our own that sniffs diagnostics and
// can omit them.
clang::DiagnosticsEngine& engine = instance_->getDiagnostics();
old_client_ = engine.getClient();
old_owned_client_ = engine.takeClient();
engine.setClient(
new UnsafeBuffersDiagnosticConsumer(&engine, old_client_, instance_,
std::move(check_file_prefixes)),
/*owned=*/true);
// Enable the -Wunsafe-buffer-usage warning as a remark. This prevents it
// from stopping compilation, even with -Werror. If we see the remark go by,
// we can re-emit it as a warning for the files we want to include in the
// check.
engine.setSeverityForGroup(clang::diag::Flavor::WarningOrError,
"unsafe-buffer-usage",
clang::diag::Severity::Remark);
// Enable the -Wunsafe-buffer-usage-in-libc-call warning as a remark. This
// prevents it from stopping compilation, even with -Werror. If we see the
// remark go by, we can re-emit it as a warning for the files we want to
// include in the check.
engine.setSeverityForGroup(clang::diag::Flavor::WarningOrError,
"unsafe-buffer-usage-in-libc-call",
clang::diag::Severity::Remark);
}
~UnsafeBuffersASTConsumer() {
// Restore the original DiagnosticConsumer that we replaced with our own.
clang::DiagnosticsEngine& engine = instance_->getDiagnostics();
if (old_owned_client_) {
engine.setClient(old_owned_client_.release(),
/*owned=*/true);
} else {
engine.setClient(old_client_, /*owned=*/false);
}
}
private:
clang::CompilerInstance* instance_;
clang::DiagnosticConsumer* old_client_;
std::unique_ptr<clang::DiagnosticConsumer> old_owned_client_;
};
class UnsafeBuffersASTAction : public clang::PluginASTAction {
public:
std::unique_ptr<clang::ASTConsumer> CreateASTConsumer(
clang::CompilerInstance& instance,
llvm::StringRef ref) override {
assert(!moved_prefixes_); // This would mean we move the prefixes twice.
moved_prefixes_ = true;
// The ASTConsumer can outlive `this`, so we can't give it references to
// members here and must move the `check_file_prefixes_` vector instead.
return std::make_unique<UnsafeBuffersASTConsumer>(
&instance, std::move(check_file_prefixes_));
}
bool ParseArgs(const clang::CompilerInstance& instance,
const std::vector<std::string>& args) override {
bool found_file_arg = false;
for (const auto& arg : args) {
// Nothing should follow the unsafe buffers path positional argument.
if (found_file_arg) {
llvm::errs()
<< "[unsafe-buffers] Extra argument to unsafe-buffers plugin: '"
<< arg << ". Usage: [SWITCHES] PATH_TO_CHECK_FILE'\n";
return false;
}
// Switches, if any, would go here.
// Anything not recognized as a switch is the unsafe buffer paths file.
found_file_arg = true;
if (!LoadCheckFilePrefixes(arg)) {
llvm::errs() << "[unsafe-buffers] Failed to load paths from file '"
<< arg << "'\n";
return false;
}
}
return true;
}
bool LoadCheckFilePrefixes(std::string_view path) {
if (auto buffer = llvm::MemoryBuffer::getFileAsStream(path)) {
check_file_prefixes_.buffer = std::move(buffer.get());
} else {
llvm::errs() << "[unsafe-buffers] Error reading file: '"
<< buffer.getError().message() << "'\n";
return false;
}
// Parse out the paths into `check_file_prefixes_`.
//
// The file format is as follows:
// * `#` introduces a comment until the end of the line.
// * Empty lines are ignored.
// * A line beginning with a `.` lists diagnostics to enable. These
// are comma-separated and currently allow: `buffers`, `libc`.
// * Every other line is a path prefix from the source tree root using
// unix-style delimiters.
// * Each line either removes a path from checks or adds a path to checks.
// * If the line starts with `+` paths matching the line will be added.
// * If the line starts with `-` paths matching the line will removed.
// * Other starting characters are not allowed.
// * Paths naming directories match the entire sub-directory. For instance
// `+a/b/` will match the file at `//a/b/c.h` but will *not* match
// `//other/a/b/c.h`.
// * Paths naming files match the single file and look like `+a/b/c.h`.
// * Trailing slashes for directories are recommended, but not enforced.
// * The longest (most specific) match takes precedence.
// * Files that do not match any of the prefixes file will be checked.
// * Duplicate entries are not allowed and produce compilation errors.
//
// Example:
// ```
// # A file of path prefixes.
// # Matches anything under the directory //foo/bar, opting them into
// # checks.
// +foo/bar/
// # Avoids checks in the //my directory.
// -my/
// # Matches a specific file at //my/file.cc, overriding the `-my/` above
// # for this one file.
// +my/file.cc
//
llvm::StringRef string = check_file_prefixes_.buffer->getBuffer();
while (!string.empty()) {
auto [line, remainder] = string.split('\n');
string = remainder;
auto [active, comment] = line.split('#');
active = active.trim();
if (active.empty()) {
continue;
}
char symbol = active[0u];
if (symbol == '.') {
// A "dot" line contains directives to enable.
if (active.contains("buffers")) {
check_file_prefixes_.check_buffers = true;
}
if (active.contains("libc")) {
check_file_prefixes_.check_libc_calls = true;
}
continue;
}
if (symbol != '+' && symbol != '-') {
llvm::errs() << "[unsafe-buffers] Invalid line in paths file, must "
<< "start with +/-: '" << line << "'\n";
return false;
}
llvm::StringRef prefix = active.substr(1u).rtrim('/');
if (prefix.empty()) {
llvm::errs() << "[unsafe-buffers] Invalid line in paths file, path "
<< "must immediately follow +/-: '" << line << "'\n";
return false;
}
auto [ignore, was_inserted] =
check_file_prefixes_.prefix_map.insert({prefix, symbol});
if (!was_inserted) {
llvm::errs() << "[unsafe-buffers] Duplicate entry in paths file "
"for '"
<< line << "'\n";
return false;
}
}
return true;
}
private:
CheckFilePrefixes check_file_prefixes_;
bool moved_prefixes_ = false;
};
class AllowUnsafeBuffersPragmaHandler : public clang::PragmaHandler {
public:
static constexpr char kName[] = "allow_unsafe_buffers";
AllowUnsafeBuffersPragmaHandler() : clang::PragmaHandler(kName) {}
void HandlePragma(clang::Preprocessor& preprocessor,
clang::PragmaIntroducer introducer,
clang::Token& token) override {
// TODO(danakj): It would be an optimization to find a way to avoid creating
// a std::string here.
std::string filename =
GetFilename(preprocessor.getSourceManager(), introducer.Loc,
FilenameLocationType::kExpansionLoc);
// The pragma opts the file out of checks.
g_checked_files_cache.insert({filename, kSkip});
}
};
class AllowUnsafeLibcPragmaHandler : public clang::PragmaHandler {
public:
static constexpr char kName[] = "allow_unsafe_libc_calls";
AllowUnsafeLibcPragmaHandler() : clang::PragmaHandler(kName) {}
void HandlePragma(clang::Preprocessor& preprocessor,
clang::PragmaIntroducer introducer,
clang::Token& token) override {
// TODO(danakj): It would be an optimization to find a way to avoid creating
// a std::string here.
std::string filename =
GetFilename(preprocessor.getSourceManager(), introducer.Loc,
FilenameLocationType::kExpansionLoc);
// The pragma opts the file into checks.
g_checked_files_cache.insert({filename, kSkipLibc});
}
};
static clang::FrontendPluginRegistry::Add<UnsafeBuffersASTAction> X1(
"unsafe-buffers",
"Enforces -Wunsafe-buffer-usage during incremental rollout");
static clang::PragmaHandlerRegistry::Add<AllowUnsafeBuffersPragmaHandler> X2(
AllowUnsafeBuffersPragmaHandler::kName,
"Avoid reporting unsafe-buffer-usage warnings in the file");
static clang::PragmaHandlerRegistry::Add<AllowUnsafeLibcPragmaHandler> X3(
AllowUnsafeLibcPragmaHandler::kName,
"Avoid reporting unsafe-libc-call warnings in the file");
} // namespace chrome_checker
|