File: temp-passed-as-raw-arg-original.cc

package info (click to toggle)
chromium 139.0.7258.127-1
  • links: PTS, VCS
  • area: main
  • in suites:
  • size: 6,122,068 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (24 lines) | stat: -rw-r--r-- 693 bytes parent folder | download | duplicates (14) 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
 
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "scoped_refptr.h"

struct Foo {
  int dummy;
};

// A temporary scoped_refptr is passed as a raw pointer function argument. Since
// temporaries are destroyed at the end of the full expression, this is 'safe'
// and could be rewritten to use get(). However, the tool just skips this case
// This should be rare enough that manual intervention is sufficient, since
// seeing this pattern probably indicates a code smell.
scoped_refptr<Foo> GetBuggyFoo() {
  return new Foo;
}

void Bar(Foo* f);

void UseBuggyFoo() {
  Bar(GetBuggyFoo());
}