1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <type_traits>
namespace not_blink {
void function(int x) {}
class Class {
public:
void method() {}
virtual void virtualMethod() {}
template <typename T>
void methodTemplate(T) {}
template <typename T>
static void staticMethodTemplate(T) {}
};
template <typename T>
void functionTemplate(T x) {}
template <typename T = Class>
void functionTemplate2() {
T::staticMethodTemplate(123);
}
template <typename T = Class>
class TemplatedClass {
public:
void anotherMethod() { T::staticMethodTemplate(123); }
};
} // not_blink
namespace blink {
bool functionNotMarkedConstexpr(int a) {
return a == 4 || a == 10;
}
template <typename T>
bool templatedFunctionNotMarkedConstexpr(T t) {
return !!t;
}
int g_globalNumber;
template <typename T, int number>
void F() {
// These are const but hacker_case so we leave them alone.
const int maybe_a_const = sizeof(T);
const int is_a_const = number;
// These are const expressions so they get a k prefix.
const int maybeAConstToo = sizeof(T);
const int isAConstToo = number;
// These are built from calls to functions which produces inconsistent
// results so they should not be considered const to be safe.
const bool fromAMethod = functionNotMarkedConstexpr(number);
const bool fromATemplatedMethod = templatedFunctionNotMarkedConstexpr(number);
// A complex statement of const things is const.
const bool complexConst = number || (number + 1);
// A complex statement with a non-const thing is not const.
const bool complexNotConst = number || (g_globalNumber + 1);
// A const built from other consts is a const.
const bool constFromAConst = complexConst || number;
}
template <int number, typename... T>
void F() {
// These are const but hacker_case so we leave them alone.
const int maybe_a_const = sizeof...(T);
const int is_a_const = number;
// These are const expressions so they get a k prefix.
const int maybeAConstToo = sizeof...(T);
const int isAConstToo = number;
}
namespace test_member_in_template {
template <typename T>
class HasAMember {
public:
HasAMember() {}
HasAMember(const T&) {}
void usesMember() { const int notConst = m_i; }
void alsoUsesMember();
private:
int m_i;
};
template <typename T>
void HasAMember<T>::alsoUsesMember() {
const int notConst = m_i;
}
template <typename T>
static void basedOnSubType(const HasAMember<T>& t) {
const HasAMember<T> problematicNotConst(t);
}
void Run() {
HasAMember<int>().usesMember();
basedOnSubType<int>(HasAMember<int>());
enum E { A };
basedOnSubType<E>(HasAMember<E>());
}
}
namespace test_template_arg_is_function {
void f(int x) {}
template <typename T, void g(T)>
void h(T x) {
g(x);
}
void test() {
// f should be rewritten.
h<int, f>(0);
// Non-Blink should stay the same.
h<int, not_blink::function>(1);
// The int one makes the methods called from F() considered as constexpr, and
// can be collapsed to not have template arguments before it reaches the AST.
F<int, 10>();
// The enum one makes them not constexpr, as it doesn't collapse away the
// template stuff as much. This can lead to conflicting decisions about
// the names inside F() vs the above instantiation.
enum E { A };
F<E, 11>();
}
} // namespace test_template_arg_is_function
namespace test_template_arg_is_method {
class Class {
public:
void method() {}
};
template <typename T, void (T::*g)()>
void h(T&& x) {
(x.*g)();
}
void test() {
// method should be rewritten.
h<Class, &Class::method>(Class());
// Non-Blink should stay the same.
h<not_blink::Class, ¬_blink::Class::method>(not_blink::Class());
}
} // namespace test_template_arg_is_method
namespace test_template_arg_is_function_template {
namespace nested {
template <typename T>
void f(T) {}
}
template <typename T, void g(T)>
void h(T x) {
g(x);
}
void test() {
// f should be rewritten.
h<int, nested::f>(0);
// Non-Blink should stay the same.
h<int, not_blink::functionTemplate>(1);
}
} // namespace test_template_arg_is_function_template
namespace test_template_arg_is_method_template_in_non_member_context {
struct Class {
template <typename T>
static void f(T) {}
};
template <typename T, void g(T)>
void h(T x) {
g(x);
}
void test() {
// f should be rewritten.
h<int, Class::f>(0);
// Non-Blink should stay the same.
h<int, not_blink::Class::staticMethodTemplate>(1);
}
} // test_template_arg_is_method_template_in_non_member_context
namespace test_inherited_field {
template <typename T>
class BaseClass {
public:
unsigned long m_size;
};
template <typename T>
class DerivedClass : protected BaseClass<T> {
private:
using Base = BaseClass<T>;
// https://crbug.com/640016: Need to rewrite |m_size| into |size_|.
using Base::m_size;
void method() { m_size = 123; }
};
} // namespace test_inherited_field
namespace test_template_arg_is_method_template_in_member_context {
struct Class {
template <typename T>
static void f(T) {}
};
struct Class2 {
template <typename T>
void f(T x) {
// f should be rewritten.
Class c;
c.f(x);
// Non-Blink should stay the same.
not_blink::Class c2;
c2.method(x);
}
};
} // namespace test_template_arg_is_method_template_in_member_context
namespace test_unnamed_arg {
template <typename T>
class Class {
public:
// Test for https://crbug.com/598141 - shouldn't rewrite
// ...int);
// into
// ...intdata_size;
void f(int);
};
template <typename T>
void Class<T>::f(int dataSize){};
void foo() {
Class<char>().f(123);
};
} // namespace test_unnamed_arg
namespace cxx_dependent_scope_member_expr_testing {
class PartitionAllocator {
public:
static void method() {}
};
template <typename Allocator = PartitionAllocator>
class Vector {
public:
// https://crbug.com/582315: |Allocator::method| is a
// CXXDependentScopeMemberExpr.
void anotherMethod() {
if (std::is_class<Allocator>::value) // Shouldn't rename |value|
Allocator::method(); // Should rename |method| -> |Method|.
}
};
template <typename Allocator = PartitionAllocator>
void test() {
// https://crbug.com/582315: |Allocator::method| is a
// DependentScopeDeclRefExpr.
if (std::is_class<Allocator>::value) // Shouldn't rename |value|.
Allocator::method(); // Should rename |method|.
}
class InterceptingCanvasBase : public ::not_blink::Class {
public:
virtual void virtualMethodInBlink(){};
};
template <typename DerivedCanvas>
class InterceptingCanvas : public InterceptingCanvasBase {
public:
void virtualMethod() override {
this->Class::virtualMethod(); // https://crbug.com/582315#c19
this->InterceptingCanvasBase::virtualMethodInBlink();
}
};
template <typename T>
class ThreadSpecific {
public:
T* operator->();
operator T*();
};
template <typename T>
inline ThreadSpecific<T>::operator T*() {
return nullptr;
}
template <typename T>
inline T* ThreadSpecific<T>::operator->() {
return operator T*();
}
class Class {
public:
virtual void virtualMethodInBlink() {}
};
} // namespace cxx_dependent_scope_member_expr_testing
namespace blocklisting_of_renaming_of_begin_method {
template <typename T>
class IntrusiveHeap {
public:
// https://crbug.com/672353: |begin| shouldn't be rewritten to |Begin|.
const T* begin() const { return nullptr; }
};
} // namespace blocklisting_of_renaming_of_begin_method
namespace specializations {
template <unsigned long sizeOfValue>
int toV8SignedIntegerInternal(long value);
template <>
int toV8SignedIntegerInternal<4>(long value) {
return 123 + value;
}
template <>
int toV8SignedIntegerInternal<8>(long value) {
return 456 + value;
}
int toV8(int value) {
return toV8SignedIntegerInternal<sizeof value>(value);
}
int toV8(long value) {
return toV8SignedIntegerInternal<sizeof value>(value);
}
} // namespace specializations
} // namespace blink
namespace not_blink {
namespace cxx_dependent_scope_member_expr_testing {
class Base : public ::blink::cxx_dependent_scope_member_expr_testing::Class {
public:
virtual void virtualMethod() {}
};
template <typename T>
class Derived : public Base {
public:
void virtualMethod() override {
this->Class::virtualMethodInBlink();
this->Base::virtualMethod();
}
};
} // namespace cxx_dependent_scope_member_expr_testing
namespace blink_methods_called_from_mojo_traits_are_not_rewritten {
template <typename V>
struct MapTraits;
template <typename V>
struct MapTraits<blink::test_unnamed_arg::Class<V>> {
static void SetToEmpty(blink::test_unnamed_arg::Class<V>* output) {
// Need to rewrite |f| to |F| below (because this method name
// does get rewritten when processing blink::test_unnamed_arg::Class).
// See also https://crbug.com/670434.
output->f(123);
}
};
} // namespace blink_methods_called_from_mojo_traits_are_not_rewritten
} // namespace not_blink
|