1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
# Copyright 2024 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import unittest
import dwa_xml_validations
import xml.dom.minidom
class DwaXmlValidationTest(unittest.TestCase):
def toDwaConfig(self, xml_string: str) -> xml.dom.minidom.Element:
dom = xml.dom.minidom.parseString(xml_string)
[dwa_config] = dom.getElementsByTagName('dwa-configuration')
return dwa_config
def testEventsHaveOwners(self) -> None:
dwa_config = self.toDwaConfig("""
<dwa-configuration>
<event name="Event1">
<owner>dev@chromium.org</owner>
</event>
</dwa-configuration>
""".strip())
validator = dwa_xml_validations.DwaXmlValidation(dwa_config)
success, errors = validator.checkEventsHaveOwners()
self.assertTrue(success)
self.assertListEqual([], errors)
def testEventsMissingOwners(self) -> None:
dwa_config = self.toDwaConfig("""
<dwa-configuration>
<event name="Event1"/>
<event name="Event2">
<owner></owner>
</event>
<event name="Event3">
<owner>johndoe</owner>
</event>
</dwa-configuration>
""".strip())
expected_errors = [
"<owner> tag is required for event 'Event1'.",
"<owner> tag for event 'Event2' should not be empty.",
"<owner> tag for event 'Event3' expects a Chromium or Google email "
"address.",
]
validator = dwa_xml_validations.DwaXmlValidation(dwa_config)
success, errors = validator.checkEventsHaveOwners()
self.assertFalse(success)
self.assertListEqual(expected_errors, errors)
def testMetricHasUndefinedEnum(self) -> None:
dwa_config = self.toDwaConfig("""
<dwa-configuration>
<event name="Event1">
<metric name="Metric2" enum="FeatureObserver"/>
</event>
<event name="Event2">
<metric name="Metric1" enum="BadEnum"/>
<metric name="Metric2" enum="FeatureObserver"/>
<metric name="Metric3"/>
<metric name="Metric4"/>
</event>
</dwa-configuration>
""".strip())
expected_errors = [
"Unknown enum BadEnum in dwa metric Event2:Metric1.",
]
validator = dwa_xml_validations.DwaXmlValidation(dwa_config)
success, errors = validator.checkMetricTypeIsSpecified()
self.assertFalse(success)
self.assertListEqual(expected_errors, errors)
if __name__ == '__main__':
unittest.main()
|
