1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ui/views/window/dialog_delegate.h"
#include <stddef.h>
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "build/build_config.h"
#include "ui/base/hit_test.h"
#include "ui/base/mojom/dialog_button.mojom.h"
#include "ui/base/mojom/window_show_state.mojom.h"
#include "ui/events/event_processor.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/bubble/bubble_border.h"
#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/controls/button/label_button.h"
#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/style/platform_style.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/test/views_test_utils.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/widget/widget.h"
#if BUILDFLAG(IS_MAC)
#include "ui/base/test/scoped_fake_full_keyboard_access.h"
#endif
namespace views {
class TestDialog : public DialogDelegateView {
public:
TestDialog() {
DialogDelegate::set_draggable(true);
input_ = AddChildView(std::make_unique<views::Textfield>());
}
TestDialog(const TestDialog&) = delete;
TestDialog& operator=(const TestDialog&) = delete;
~TestDialog() override = default;
void Init() {
// Add the accelerator before being added to the widget hierarchy (before
// DCV has registered its accelerator) to make sure accelerator handling is
// not dependent on the order of AddAccelerator calls.
EXPECT_FALSE(GetWidget());
AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
}
// WidgetDelegate overrides:
bool ShouldShowWindowTitle() const override { return !title_.empty(); }
bool ShouldShowCloseButton() const override { return show_close_button_; }
// DialogDelegateView overrides:
gfx::Size CalculatePreferredSize(
const SizeBounds& /*available_size*/) const override {
return gfx::Size(200, 200);
}
bool AcceleratorPressed(const ui::Accelerator& accelerator) override {
return should_handle_escape_;
}
std::u16string GetWindowTitle() const override { return title_; }
View* GetInitiallyFocusedView() override { return input_; }
// DialogDelegate overrides:
bool ShouldAllowKeyEventsDuringInputProtection() const override {
return should_allow_key_events_during_input_protection_;
}
void TearDown() {
input_ = nullptr;
GetWidget()->Close();
}
void set_title(const std::u16string& title) { title_ = title; }
void set_show_close_button(bool show_close) {
show_close_button_ = show_close;
}
void set_should_handle_escape(bool should_handle_escape) {
should_handle_escape_ = should_handle_escape;
}
void set_should_allow_key_events_during_input_protection(bool value) {
should_allow_key_events_during_input_protection_ = value;
}
views::Textfield* input() { return input_; }
private:
raw_ptr<views::Textfield> input_ = nullptr;
std::u16string title_;
bool show_close_button_ = true;
bool should_handle_escape_ = false;
bool should_allow_key_events_during_input_protection_ = true;
};
namespace {
class DialogTest : public ViewsTestBase {
public:
DialogTest() = default;
DialogTest(const DialogTest&) = delete;
DialogTest& operator=(const DialogTest&) = delete;
~DialogTest() override = default;
void SetUp() override {
ViewsTestBase::SetUp();
// These tests all expect to use a custom frame on the dialog so they can
// control hit-testing and other behavior. Custom frames are only supported
// with a parent widget, so create the parent widget here.
parent_widget_ = CreateTestWidget(Widget::InitParams::CLIENT_OWNS_WIDGET);
parent_widget_->Show();
InitializeDialog();
ShowDialog();
}
void TearDown() override {
dialog_raw_.ExtractAsDangling()->TearDown();
parent_widget_.reset();
ViewsTestBase::TearDown();
}
void InitializeDialog() {
if (dialog_) {
dialog_->TearDown();
}
dialog_ = std::make_unique<TestDialog>();
dialog_->Init();
dialog_raw_ = dialog_.get();
dialog_->SetAcceptCallback(
base::BindLambdaForTesting([&]() { accepted_ = true; }));
dialog_->SetCancelCallback(
base::BindLambdaForTesting([&]() { cancelled_ = true; }));
dialog_->SetCloseCallback(
base::BindLambdaForTesting([&]() { closed_ = true; }));
}
views::Widget* CreateDialogWidget(std::unique_ptr<WidgetDelegate> dialog) {
views::Widget* widget = DialogDelegate::CreateDialogWidget(
std::move(dialog), GetContext(), parent_widget_->GetNativeView());
return widget;
}
void ShowDialog() { CreateDialogWidget(std::move(dialog_))->Show(); }
void SimulateKeyPress(ui::KeyboardCode key) {
ui::KeyEvent event(ui::EventType::kKeyPressed, key, ui::EF_NONE);
if (dialog()->GetFocusManager()->OnKeyEvent(event)) {
dialog()->GetWidget()->OnKeyEvent(&event);
}
}
TestDialog* dialog() const { return dialog_raw_; }
views::Widget* parent_widget() { return parent_widget_.get(); }
protected:
bool accepted_ = false;
bool cancelled_ = false;
bool closed_ = false;
private:
std::unique_ptr<views::Widget> parent_widget_;
std::unique_ptr<TestDialog> dialog_;
raw_ptr<TestDialog> dialog_raw_ = nullptr;
};
} // namespace
TEST_F(DialogTest, InputIsInitiallyFocused) {
EXPECT_EQ(dialog()->input(), dialog()->GetFocusManager()->GetFocusedView());
}
TEST_F(DialogTest, OkButtonAccepts) {
EXPECT_FALSE(accepted_);
SimulateKeyPress(ui::VKEY_RETURN);
EXPECT_TRUE(accepted_);
}
TEST_F(DialogTest, EscButtonClosesDialogWithCloseButtonWithoutCallingCancel) {
// Showing the close button should be sufficient to call close on Esc (even if
// there's no close callback), we verify this by making sure that Cancel
// doesn't get called as best-effort verification.
dialog()->set_show_close_button(true);
dialog()->SetCloseCallback(base::OnceClosure());
EXPECT_FALSE(cancelled_);
SimulateKeyPress(ui::VKEY_ESCAPE);
EXPECT_FALSE(cancelled_);
}
TEST_F(DialogTest, EscButtonClosesWithCloseCallback) {
// The dialog's close callback should be called even if there's no close-x.
// See crbug.com/1245127.
dialog()->set_show_close_button(false);
EXPECT_FALSE(closed_);
SimulateKeyPress(ui::VKEY_ESCAPE);
EXPECT_TRUE(closed_);
}
TEST_F(DialogTest, EscButtonCancelsWithoutCloseAction) {
// If there's no close-x or close callback then the cancelled action should be
// called.
dialog()->SetCloseCallback(base::OnceClosure());
dialog()->set_show_close_button(false);
EXPECT_FALSE(cancelled_);
SimulateKeyPress(ui::VKEY_ESCAPE);
EXPECT_TRUE(cancelled_);
}
TEST_F(DialogTest, ReturnDirectedToOkButtonPlatformStyle) {
const ui::KeyEvent return_event(ui::EventType::kKeyPressed, ui::VKEY_RETURN,
ui::EF_NONE);
if (PlatformStyle::kReturnClicksFocusedControl) {
EXPECT_TRUE(dialog()->GetOkButton()->OnKeyPressed(return_event));
EXPECT_TRUE(accepted_);
} else {
EXPECT_FALSE(dialog()->GetOkButton()->OnKeyPressed(return_event));
EXPECT_FALSE(accepted_);
// If the return key press was not directed *specifically* to the Ok button,
// it would bubble upwards here, reach the dialog, and accept it. The
// OkButtonAccepts test above covers that behavior.
}
}
TEST_F(DialogTest, ReturnDirectedToCancelButtonPlatformBehavior) {
const ui::KeyEvent return_event(ui::EventType::kKeyPressed, ui::VKEY_RETURN,
ui::EF_NONE);
if (PlatformStyle::kReturnClicksFocusedControl) {
EXPECT_TRUE(dialog()->GetCancelButton()->OnKeyPressed(return_event));
EXPECT_TRUE(cancelled_);
} else {
EXPECT_FALSE(dialog()->GetCancelButton()->OnKeyPressed(return_event));
EXPECT_FALSE(cancelled_);
// If the return key press was not directed *specifically* to the Ok button,
// it would bubble upwards here, reach the dialog, and accept it. The
// OkButtonAccepts test above covers that behavior.
}
}
// Unlike the previous two tests, this test simulates a key press at the level
// of the dialog's Widget, so the return-to-close-dialog behavior does happen.
TEST_F(DialogTest, ReturnOnCancelButtonPlatformBehavior) {
dialog()->GetCancelButton()->RequestFocus();
SimulateKeyPress(ui::VKEY_RETURN);
if (PlatformStyle::kReturnClicksFocusedControl) {
EXPECT_TRUE(cancelled_);
} else {
EXPECT_TRUE(accepted_);
}
}
TEST_F(DialogTest, CanOverrideEsc) {
dialog()->set_should_handle_escape(true);
SimulateKeyPress(ui::VKEY_ESCAPE);
EXPECT_FALSE(cancelled_);
EXPECT_FALSE(closed_);
}
TEST_F(DialogTest, RemoveDefaultButton) {
// Removing buttons from the dialog here should not cause a crash on close.
delete dialog()->GetOkButton();
delete dialog()->GetCancelButton();
}
TEST_F(DialogTest, HitTest_HiddenTitle) {
// Ensure that BubbleFrameView hit-tests as expected when the title is hidden.
const NonClientView* view = dialog()->GetWidget()->non_client_view();
BubbleFrameView* frame = static_cast<BubbleFrameView*>(view->frame_view());
constexpr struct {
const int point;
const int hit;
} kCases[] = {
{0, HTTRANSPARENT},
{10, HTCAPTION},
{20, HTNOWHERE},
{50, HTCLIENT /* Space is reserved for the close button. */},
{60, HTCLIENT},
{1000, HTNOWHERE},
};
for (const auto test_case : kCases) {
gfx::Point point(test_case.point, test_case.point);
EXPECT_EQ(test_case.hit, frame->NonClientHitTest(point))
<< " at point " << test_case.point;
}
}
TEST_F(DialogTest, HitTest_HiddenTitleNoCloseButton) {
InitializeDialog();
dialog()->set_show_close_button(false);
ShowDialog();
const NonClientView* view = dialog()->GetWidget()->non_client_view();
BubbleFrameView* frame = static_cast<BubbleFrameView*>(view->frame_view());
constexpr struct {
const int point;
const int hit;
} kCases[] = {
{0, HTTRANSPARENT}, {10, HTCAPTION}, {20, HTCLIENT},
{50, HTCLIENT}, {60, HTCLIENT}, {1000, HTNOWHERE},
};
for (const auto test_case : kCases) {
gfx::Point point(test_case.point, test_case.point);
EXPECT_EQ(test_case.hit, frame->NonClientHitTest(point))
<< " at point " << test_case.point;
}
}
TEST_F(DialogTest, HitTest_WithTitle) {
// Ensure that BubbleFrameView hit-tests as expected when the title is shown
// and the modal type is something other than not modal.
const NonClientView* view = dialog()->GetWidget()->non_client_view();
dialog()->set_title(u"Title");
dialog()->GetWidget()->UpdateWindowTitle();
dialog()->GetWidget()->LayoutRootViewIfNecessary();
BubbleFrameView* frame = static_cast<BubbleFrameView*>(view->frame_view());
constexpr struct {
const int point;
const int hit;
} kCases[] = {
{0, HTTRANSPARENT}, {10, HTCAPTION}, {20, HTCAPTION},
{50, HTCLIENT}, {60, HTCLIENT}, {1000, HTNOWHERE},
};
for (const auto test_case : kCases) {
gfx::Point point(test_case.point, test_case.point);
EXPECT_EQ(test_case.hit, frame->NonClientHitTest(point))
<< " at point " << test_case.point;
}
}
TEST_F(DialogTest, HitTest_CloseButton) {
const NonClientView* view = dialog()->GetWidget()->non_client_view();
dialog()->set_show_close_button(true);
BubbleFrameView* frame = static_cast<BubbleFrameView*>(view->frame_view());
frame->ResetWindowControls();
const gfx::Rect close_button_bounds = frame->close_button()->bounds();
#if BUILDFLAG(IS_WIN)
// On Win, a native tooltip is generated when HTCLOSE is returned.
// Since we are using views tooltip, do not return |HTCLOSE| to avoid double
// tooltips.
EXPECT_NE(HTCLOSE,
frame->NonClientHitTest(close_button_bounds.CenterPoint()));
#else
EXPECT_EQ(HTCLOSE,
frame->NonClientHitTest(close_button_bounds.CenterPoint()));
#endif
}
TEST_F(DialogTest, BoundsAccommodateTitle) {
auto dialog2_owned = std::make_unique<TestDialog>();
TestDialog* dialog2 = dialog2_owned.get();
dialog2->set_title(u"Title");
CreateDialogWidget(std::move(dialog2_owned));
// Remove the close button so it doesn't influence the bounds if it's taller
// than the title.
dialog()->set_show_close_button(false);
dialog2->set_show_close_button(false);
dialog()->GetWidget()->non_client_view()->ResetWindowControls();
dialog2->GetWidget()->non_client_view()->ResetWindowControls();
EXPECT_FALSE(dialog()->ShouldShowWindowTitle());
EXPECT_TRUE(dialog2->ShouldShowWindowTitle());
// Titled dialogs have taller initial frame bounds than untitled dialogs.
View* frame1 = dialog()->GetWidget()->non_client_view()->frame_view();
View* frame2 = dialog2->GetWidget()->non_client_view()->frame_view();
EXPECT_LT(frame1->GetPreferredSize({}).height(),
frame2->GetPreferredSize({}).height());
// Giving the default test dialog a title will yield the same bounds.
dialog()->set_title(u"Title");
EXPECT_TRUE(dialog()->ShouldShowWindowTitle());
dialog()->GetWidget()->UpdateWindowTitle();
EXPECT_EQ(frame1->GetPreferredSize({}).height(),
frame2->GetPreferredSize({}).height());
dialog2->TearDown();
}
TEST_F(DialogTest, ActualBoundsMatchPreferredBounds) {
dialog()->set_title(
u"La la la look at me I'm a really really long title that needs to be "
u"really really long so that the title will multiline wrap.");
dialog()->GetWidget()->UpdateWindowTitle();
views::View* root_view = dialog()->GetWidget()->GetRootView();
gfx::Size preferred_size(root_view->GetPreferredSize({}));
EXPECT_FALSE(preferred_size.IsEmpty());
root_view->SizeToPreferredSize();
views::test::RunScheduledLayout(root_view);
EXPECT_EQ(preferred_size, root_view->size());
}
// Tests default focus is assigned correctly when showing a new dialog.
TEST_F(DialogTest, InitialFocus) {
EXPECT_TRUE(dialog()->input()->HasFocus());
EXPECT_EQ(dialog()->input(), dialog()->GetFocusManager()->GetFocusedView());
}
// A dialog for testing initial focus with only an OK button.
class InitialFocusTestDialog : public DialogDelegateView {
public:
InitialFocusTestDialog() {
DialogDelegate::SetButtons(static_cast<int>(ui::mojom::DialogButton::kOk));
}
InitialFocusTestDialog(const InitialFocusTestDialog&) = delete;
InitialFocusTestDialog& operator=(const InitialFocusTestDialog&) = delete;
~InitialFocusTestDialog() override = default;
};
// If the Widget can't be activated while the initial focus View is requesting
// focus, test it is still able to receive focus once the Widget is activated.
TEST_F(DialogTest, InitialFocusWithDeactivatedWidget) {
auto dialog_owned = std::make_unique<InitialFocusTestDialog>();
InitialFocusTestDialog* dialog = dialog_owned.get();
Widget* dialog_widget = CreateDialogWidget(std::move(dialog_owned));
// Set the initial focus while the Widget is unactivated to prevent the
// initially focused View from receiving focus. Use a minimised state here to
// prevent the Widget from being activated while this happens.
dialog_widget->SetInitialFocus(ui::mojom::WindowShowState::kMinimized);
// Nothing should be focused, because the Widget is still deactivated.
EXPECT_EQ(nullptr, dialog_widget->GetFocusManager()->GetFocusedView());
EXPECT_EQ(dialog->GetOkButton(),
dialog_widget->GetFocusManager()->GetStoredFocusView());
dialog_widget->Show();
// After activation, the initially focused View should have focus as intended.
EXPECT_EQ(dialog->GetOkButton(),
dialog_widget->GetFocusManager()->GetFocusedView());
EXPECT_TRUE(dialog->GetOkButton()->HasFocus());
dialog_widget->CloseNow();
}
// If the initially focused View provided is unfocusable, check the next
// available focusable View is focused.
TEST_F(DialogTest, UnfocusableInitialFocus) {
#if BUILDFLAG(IS_MAC)
// On Mac, make all buttons unfocusable by turning off full keyboard access.
// This is the more common configuration, and if a dialog has a focusable
// textfield, tree or table, that should obtain focus instead.
ui::test::ScopedFakeFullKeyboardAccess::GetInstance()
->set_full_keyboard_access_state(false);
#endif
auto dialog_owned =
std::make_unique<DialogDelegateView>(DialogDelegateView::CreatePassKey());
DialogDelegateView* dialog = dialog_owned.get();
Textfield* textfield = dialog->AddChildView(std::make_unique<Textfield>());
Widget* dialog_widget = CreateDialogWidget(std::move(dialog_owned));
#if !BUILDFLAG(IS_MAC)
// For non-Mac, turn off focusability on all the dialog's buttons manually.
// This achieves the same effect as disabling full keyboard access.
dialog->GetOkButton()->SetFocusBehavior(View::FocusBehavior::NEVER);
dialog->GetCancelButton()->SetFocusBehavior(View::FocusBehavior::NEVER);
dialog->GetBubbleFrameView()->close_button()->SetFocusBehavior(
View::FocusBehavior::NEVER);
#endif
// On showing the dialog, the initially focused View will be the OK button.
// Since it is no longer focusable, focus should advance to the next focusable
// View, which is |textfield|.
dialog_widget->Show();
EXPECT_TRUE(textfield->HasFocus());
EXPECT_EQ(textfield, dialog->GetFocusManager()->GetFocusedView());
dialog_widget->CloseNow();
}
TEST_F(DialogTest, ButtonEnableUpdatesState) {
test::WidgetTest::WidgetAutoclosePtr widget(
CreateDialogWidget(std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey())));
auto* dialog = static_cast<DialogDelegateView*>(widget->widget_delegate());
EXPECT_TRUE(dialog->GetOkButton()->GetEnabled());
dialog->SetButtonEnabled(ui::mojom::DialogButton::kOk, false);
dialog->DialogModelChanged();
EXPECT_FALSE(dialog->GetOkButton()->GetEnabled());
}
TEST_F(DialogTest, CanOverrideShouldAllowKeyEventsDuringInputProtection) {
dialog()->set_should_allow_key_events_during_input_protection(true);
EXPECT_TRUE(dialog()->ShouldAllowKeyEventsDuringInputProtection());
dialog()->set_should_allow_key_events_during_input_protection(false);
EXPECT_FALSE(dialog()->ShouldAllowKeyEventsDuringInputProtection());
}
using DialogDelegateCloseTest = ViewsTestBase;
TEST_F(DialogDelegateCloseTest, AnyCallbackInhibitsDefaultClose) {
DialogDelegateView dialog;
bool cancelled = false;
bool accepted = false;
dialog.SetCancelCallback(
base::BindLambdaForTesting([&]() { cancelled = true; }));
dialog.SetAcceptCallback(
base::BindLambdaForTesting([&]() { accepted = true; }));
// At this point DefaultClose() would invoke either Accept() or Cancel().
EXPECT_TRUE(dialog.Close());
EXPECT_FALSE(cancelled);
EXPECT_FALSE(accepted);
}
TEST_F(DialogDelegateCloseTest,
RecursiveCloseFromAcceptCallbackDoesNotTriggerSecondCallback) {
DialogDelegateView dialog;
bool closed = false;
bool accepted = false;
dialog.SetCloseCallback(base::BindLambdaForTesting([&]() { closed = true; }));
dialog.SetAcceptCallback(base::BindLambdaForTesting([&]() {
accepted = true;
dialog.Close();
}));
EXPECT_TRUE(dialog.Accept());
EXPECT_TRUE(accepted);
EXPECT_FALSE(closed);
}
class TestDialogDelegateView : public DialogDelegateView {
public:
TestDialogDelegateView(bool* accepted, bool* cancelled)
: accepted_(accepted), cancelled_(cancelled) {}
~TestDialogDelegateView() override = default;
private:
bool Accept() override {
*(accepted_) = true;
return true;
}
bool Cancel() override {
*(cancelled_) = true;
return true;
}
raw_ptr<bool> accepted_;
raw_ptr<bool> cancelled_;
};
TEST_F(DialogDelegateCloseTest, OldClosePathDoesNotDoubleClose) {
bool accepted = false;
bool cancelled = false;
auto dialog_owned =
std::make_unique<TestDialogDelegateView>(&accepted, &cancelled);
TestDialogDelegateView* dialog = dialog_owned.get();
Widget* widget = DialogDelegate::CreateDialogWidget(
std::move(dialog_owned), GetContext(), gfx::NativeView());
widget->Show();
views::test::WidgetDestroyedWaiter destroyed_waiter(widget);
dialog->AcceptDialog();
destroyed_waiter.Wait();
EXPECT_TRUE(accepted);
EXPECT_FALSE(cancelled);
}
TEST_F(DialogDelegateCloseTest, CloseParentWidgetDoesNotInvokeCloseCallback) {
auto dialog_owned =
std::make_unique<DialogDelegateView>(DialogDelegateView::CreatePassKey());
DialogDelegateView* dialog = dialog_owned.get();
std::unique_ptr<Widget> parent =
CreateTestWidget(Widget::InitParams::CLIENT_OWNS_WIDGET);
Widget* widget = DialogDelegate::CreateDialogWidget(
std::move(dialog_owned), GetContext(), parent->GetNativeView());
bool closed = false;
dialog->SetCloseCallback(
base::BindLambdaForTesting([&closed]() { closed = true; }));
views::test::WidgetDestroyedWaiter parent_waiter(parent.get());
views::test::WidgetDestroyedWaiter dialog_waiter(widget);
parent->Close();
parent_waiter.Wait();
dialog_waiter.Wait();
EXPECT_FALSE(closed);
}
TEST_F(DialogTest, AcceptCallbackWithCloseDoesNotClose) {
test::WidgetTest::WidgetAutoclosePtr widget(
CreateDialogWidget(std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey())));
auto* dialog = static_cast<DialogDelegateView*>(widget->widget_delegate());
bool accepted = false;
dialog->SetAcceptCallbackWithClose(base::BindLambdaForTesting([&]() {
accepted = true;
return false;
}));
EXPECT_FALSE(widget->IsClosed());
dialog->AcceptDialog();
EXPECT_FALSE(widget->IsClosed());
EXPECT_TRUE(accepted);
}
TEST_F(DialogTest, AcceptCallbackWithCloseDoesClose) {
test::WidgetTest::WidgetAutoclosePtr widget(
CreateDialogWidget(std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey())));
auto* dialog = static_cast<DialogDelegateView*>(widget->widget_delegate());
bool accepted = false;
dialog->SetAcceptCallbackWithClose(base::BindLambdaForTesting([&]() {
accepted = true;
return true;
}));
EXPECT_FALSE(widget->IsClosed());
dialog->AcceptDialog();
EXPECT_TRUE(widget->IsClosed());
EXPECT_TRUE(accepted);
}
TEST_F(DialogTest, CancelCallbackWithCloseDoesNotClose) {
test::WidgetTest::WidgetAutoclosePtr widget(
CreateDialogWidget(std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey())));
auto* dialog = static_cast<DialogDelegateView*>(widget->widget_delegate());
bool canceled = false;
dialog->SetCancelCallbackWithClose(base::BindLambdaForTesting([&]() {
canceled = true;
return false;
}));
EXPECT_FALSE(widget->IsClosed());
dialog->CancelDialog();
EXPECT_FALSE(widget->IsClosed());
EXPECT_TRUE(canceled);
}
TEST_F(DialogTest, CancelCallbackWithCloseDoesClose) {
test::WidgetTest::WidgetAutoclosePtr widget(
CreateDialogWidget(std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey())));
auto* dialog = static_cast<DialogDelegateView*>(widget->widget_delegate());
bool canceled = false;
dialog->SetCancelCallbackWithClose(base::BindLambdaForTesting([&]() {
canceled = true;
return true;
}));
EXPECT_FALSE(widget->IsClosed());
dialog->CancelDialog();
EXPECT_TRUE(widget->IsClosed());
EXPECT_TRUE(canceled);
}
class MakeCloseSynchronousTest : public DialogTest {
public:
void CreateSynchronousCloseWidget() {
std::unique_ptr<DialogDelegateView> delegate =
std::make_unique<DialogDelegateView>(
DialogDelegateView::CreatePassKey());
synchronous_close_view_ = delegate.get();
delegate->SetOwnershipOfNewWidget(Widget::InitParams::CLIENT_OWNS_WIDGET);
synchronous_close_widget_ = base::WrapUnique(
DialogDelegate::CreateDialogWidget(std::move(delegate), GetContext(),
parent_widget()->GetNativeView()));
synchronous_close_widget_->MakeCloseSynchronous(base::BindOnce(
&MakeCloseSynchronousTest::OverrideClose, base::Unretained(this)));
synchronous_close_widget_->Show();
}
void OverrideClose(Widget::ClosedReason) {
synchronous_close_view_ = nullptr;
synchronous_close_widget_.reset();
}
// Owned by synchronous_close_widget_
raw_ptr<DialogDelegateView> synchronous_close_view_;
std::unique_ptr<Widget> synchronous_close_widget_;
};
// Check that unique_ptr is reset on call to Close().
TEST_F(MakeCloseSynchronousTest, Close) {
CreateSynchronousCloseWidget();
synchronous_close_widget_->Close();
EXPECT_FALSE(synchronous_close_widget_);
}
// Check that there are no issues resetting the unique_ptr as usual.
TEST_F(MakeCloseSynchronousTest, Reset) {
// Reset with same helper method.
CreateSynchronousCloseWidget();
OverrideClose(Widget::ClosedReason::kUnspecified);
}
// Check that unique_ptr is reset on call to Accept().
TEST_F(MakeCloseSynchronousTest, Accept) {
CreateSynchronousCloseWidget();
ui::KeyEvent event(ui::EventType::kKeyPressed, ui::VKEY_RETURN, ui::EF_NONE);
if (synchronous_close_view_->GetFocusManager()->OnKeyEvent(event)) {
synchronous_close_view_->GetWidget()->OnKeyEvent(&event);
}
EXPECT_FALSE(synchronous_close_widget_);
}
} // namespace views
|