1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/351564777): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "ui/wm/core/cursor_util.h"
#include <array>
#include <optional>
#include "base/numerics/safe_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/base/cursor/cursor.h"
#include "ui/base/cursor/cursor_size.h"
#include "ui/base/cursor/mojom/cursor_type.mojom-shared.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/resource/resource_scale_factor.h"
#include "ui/display/display.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/geometry/skia_conversions.h"
namespace wm {
namespace {
using ::ui::mojom::CursorType;
// Parameterized test for cursor bitmaps with premultiplied and unpremultiplied
// alpha.
class CursorUtilTest : public testing::TestWithParam<bool> {
public:
SkColor GetPixelColor() {
return GetParam() ? SkColorSetARGB(128, 255, 0, 0)
: SkColorSetARGB(128, 128, 0, 0);
}
SkImageInfo GetImageInfo() {
return GetParam() ? SkImageInfo::MakeN32(10, 5, kUnpremul_SkAlphaType)
: SkImageInfo::MakeN32(10, 5, kPremul_SkAlphaType);
}
};
TEST_P(CursorUtilTest, ScaleAndRotate) {
const SkColor pixel_color = GetPixelColor();
SkBitmap bitmap;
bitmap.setInfo(GetImageInfo());
bitmap.allocPixels();
bitmap.eraseColor(pixel_color);
gfx::Point hotpoint(3, 4);
ScaleAndRotateCursorBitmapAndHotpoint(1.0f, display::Display::ROTATE_0,
&bitmap, &hotpoint);
EXPECT_EQ(10, bitmap.width());
EXPECT_EQ(5, bitmap.height());
EXPECT_EQ("3,4", hotpoint.ToString());
EXPECT_EQ(pixel_color, bitmap.pixmap().getColor(0, 0));
ScaleAndRotateCursorBitmapAndHotpoint(1.0f, display::Display::ROTATE_90,
&bitmap, &hotpoint);
EXPECT_EQ(5, bitmap.width());
EXPECT_EQ(10, bitmap.height());
EXPECT_EQ("1,3", hotpoint.ToString());
EXPECT_EQ(pixel_color, bitmap.pixmap().getColor(0, 0));
ScaleAndRotateCursorBitmapAndHotpoint(2.0f, display::Display::ROTATE_180,
&bitmap, &hotpoint);
EXPECT_EQ(10, bitmap.width());
EXPECT_EQ(20, bitmap.height());
EXPECT_EQ("8,14", hotpoint.ToString());
EXPECT_EQ(pixel_color, bitmap.pixmap().getColor(0, 0));
ScaleAndRotateCursorBitmapAndHotpoint(1.0f, display::Display::ROTATE_270,
&bitmap, &hotpoint);
EXPECT_EQ(20, bitmap.width());
EXPECT_EQ(10, bitmap.height());
EXPECT_EQ("14,2", hotpoint.ToString());
EXPECT_EQ(pixel_color, bitmap.pixmap().getColor(0, 0));
}
INSTANTIATE_TEST_SUITE_P(All, CursorUtilTest, testing::Bool());
TEST(CursorUtil, GetCursorData) {
// Data from `kNormalCursorResourceData` and `kLargeCursorResourceData`.
constexpr struct {
CursorType cursor;
std::array<gfx::Size, 2> size; // indexed by cursor size.
gfx::Point hotspot[2][2]; // indexed by cursor size and scale.
} kCursorTestCases[] = {
{CursorType::kPointer,
{gfx::Size(25, 25), gfx::Size(64, 64)},
{{gfx::Point(4, 4), gfx::Point(7, 7)},
{gfx::Point(10, 10), gfx::Point(20, 20)}}},
{CursorType::kWait,
{gfx::Size(16, 16), gfx::Size(16, 16)},
{{gfx::Point(7, 7), gfx::Point(14, 14)},
{gfx::Point(7, 7), gfx::Point(14, 14)}}},
};
for (const float scale : {0.8f, 1.0f, 1.3f, 1.5f, 2.0f, 2.5f}) {
SCOPED_TRACE(testing::Message() << "scale " << scale);
for (const auto size : {ui::CursorSize::kNormal, ui::CursorSize::kLarge}) {
SCOPED_TRACE(testing::Message()
<< "size " << base::checked_cast<int>(scale));
for (const auto& test : kCursorTestCases) {
SCOPED_TRACE(test.cursor);
static constexpr auto kDefaultRotation = display::Display::ROTATE_0;
const auto pointer_data =
GetCursorData(test.cursor, size, scale, std::nullopt,
kDefaultRotation, SK_ColorBLACK);
ASSERT_TRUE(pointer_data);
ASSERT_GT(pointer_data->bitmaps.size(), 0u);
EXPECT_EQ(gfx::SkISizeToSize(pointer_data->bitmaps[0].dimensions()),
gfx::ScaleToFlooredSize(
test.size[base::checked_cast<int>(size)], scale));
const float resource_scale = ui::GetScaleForResourceScaleFactor(
ui::GetSupportedResourceScaleFactorForRescale(scale));
EXPECT_EQ(pointer_data->hotspot,
gfx::ScaleToFlooredPoint(
test.hotspot[base::checked_cast<int>(size)]
[base::checked_cast<int>(resource_scale) - 1],
scale / resource_scale));
}
}
}
}
// Tests cursor bitmap is correct after size rescaling.
TEST(CursorUtil, GetCursorDataWithTargetCursorSize) {
// Data from `kLargeCursorResourceData`.
constexpr struct {
CursorType cursor;
gfx::Size size; // large cursor size in dip
std::array<gfx::Point, 2> hotspot; // hotspot in px, indexed by scale.
} kCursorTestCases[] = {{CursorType::kPointer,
gfx::Size(64, 64),
{gfx::Point(10, 10), gfx::Point(20, 20)}},
{CursorType::kWait,
gfx::Size(16, 16),
{gfx::Point(7, 7), gfx::Point(14, 14)}}};
for (const float scale : {0.8f, 1.0f, 1.3f, 1.5f, 2.0f, 2.5f}) {
SCOPED_TRACE(testing::Message() << "scale " << scale);
for (const auto& test : kCursorTestCases) {
SCOPED_TRACE(test.cursor);
static constexpr auto kDefaultRotation = display::Display::ROTATE_0;
for (const auto& target_cursor_size_in_px :
{ui::kMinLargeCursorSize, ui::kMaxLargeCursorSize}) {
const float resource_scale = ui::GetScaleForResourceScaleFactor(
ui::GetSupportedResourceScaleFactorForRescale(scale));
const auto pointer_data =
GetCursorData(test.cursor, ui::CursorSize::kLarge, scale,
std::make_optional(target_cursor_size_in_px),
kDefaultRotation, SK_ColorBLACK);
ASSERT_TRUE(pointer_data);
ASSERT_GT(pointer_data->bitmaps.size(), 0u);
// `target_cursor_size_in_px` should be the height of the final size of
// cursor.
const gfx::Size actual_cursor_size_in_px =
gfx::SkISizeToSize(pointer_data->bitmaps[0].dimensions());
EXPECT_EQ(actual_cursor_size_in_px.height(), target_cursor_size_in_px);
const gfx::Point actual_hotspot_in_px = pointer_data->hotspot;
const float rescale = static_cast<float>(target_cursor_size_in_px) /
static_cast<float>(test.size.height());
const gfx::Point expected_hotspot_in_dip = gfx::ScaleToFlooredPoint(
test.hotspot[base::checked_cast<int>(resource_scale) - 1],
1 / resource_scale);
const gfx::Point expected_hotspot_in_px =
gfx::ScaleToFlooredPoint(expected_hotspot_in_dip, rescale);
EXPECT_EQ(actual_hotspot_in_px, expected_hotspot_in_px);
}
}
}
}
// Tests cursor bitmap is correct after applying color on it.
TEST(CursorUtil, GetCursorDataWithColor) {
const struct {
SkColor cursor_color; // Set the cursor to this color.
SkColor not_found; // Spot-check: This color shouldn't be in the cursor.
SkColor found; // Spot-check: This color should be in the cursor.
CursorType cursor_type;
} kColorTestCases[] = {
// Cursors should still have white.
{SK_ColorMAGENTA, SK_ColorBLUE, SK_ColorWHITE, CursorType::kHand},
{SK_ColorBLUE, SK_ColorMAGENTA, SK_ColorWHITE, CursorType::kCell},
{SK_ColorGREEN, SK_ColorBLUE, SK_ColorWHITE, CursorType::kNoDrop},
// Also cursors should still have transparent.
{SK_ColorRED, SK_ColorGREEN, SK_ColorTRANSPARENT, CursorType::kPointer},
// The no drop cursor has red in it, check it's still there:
// Most of the cursor should be colored, but the red part shouldn't be
// re-colored.
{SK_ColorBLUE, SK_ColorGREEN, SkColorSetRGB(173, 8, 8),
CursorType::kNoDrop},
// Similarly, the copy cursor has green in it.
{SK_ColorBLUE, SK_ColorRED, SkColorSetRGB(19, 137, 16),
CursorType::kCopy},
};
for (const auto& test : kColorTestCases) {
auto pointer_data = GetCursorData(
test.cursor_type, ui::CursorSize::kNormal, 1.0f, std::nullopt,
display::Display::ROTATE_0, test.cursor_color);
const SkBitmap bitmap = pointer_data->bitmaps[0];
// We should find `cursor_color` pixels in the cursor, but no black or
// |not_found| color pixels. All black pixels are recolored.
// We should also find |found| color.
bool has_color = false;
bool has_not_found_color = false;
bool has_found_color = false;
bool has_black = false;
for (int x = 0; x < bitmap.width(); ++x) {
for (int y = 0; y < bitmap.height(); ++y) {
SkColor color = bitmap.getColor(x, y);
if (color == test.cursor_color) {
has_color = true;
} else if (color == test.not_found) {
has_not_found_color = true;
} else if (color == test.found) {
has_found_color = true;
} else if (color == SK_ColorBLACK) {
has_black = true;
}
}
}
EXPECT_TRUE(has_color);
EXPECT_TRUE(has_found_color);
EXPECT_FALSE(has_not_found_color);
EXPECT_FALSE(has_black);
}
}
} // namespace
} // namespace wm
|
