1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/dialogs/settings_overridden_dialog.h"
#include <optional>
#include "base/memory/raw_ptr.h"
#include "chrome/browser/ui/extensions/extensions_dialogs.h"
#include "chrome/browser/ui/extensions/settings_overridden_dialog_controller.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/test_with_browser_view.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
#include "ui/views/window/dialog_delegate.h"
using DialogResult = SettingsOverriddenDialogController::DialogResult;
namespace {
struct DialogState {
bool shown = false;
std::optional<DialogResult> result;
};
// A dialog controller that updates the provided DialogState when the dialog
// is interacted with.
class TestDialogController : public SettingsOverriddenDialogController {
public:
explicit TestDialogController(DialogState* state)
: state_(state), show_params_{u"Dialog Title", u"Dialog Body"} {}
TestDialogController(const TestDialogController&) = delete;
TestDialogController& operator=(const TestDialogController&) = delete;
~TestDialogController() override = default;
private:
bool ShouldShow() override { return true; }
ShowParams GetShowParams() override { return show_params_; }
void OnDialogShown() override {
EXPECT_FALSE(state_->shown) << "OnDialogShown() called more than once!";
state_->shown = true;
}
void HandleDialogResult(DialogResult result) override {
state_->result = result;
}
const raw_ptr<DialogState> state_;
const ShowParams show_params_;
};
} // namespace
class SettingsOverriddenDialogViewUnitTest : public TestWithBrowserView {
public:
SettingsOverriddenDialogViewUnitTest() = default;
SettingsOverriddenDialogViewUnitTest(
const SettingsOverriddenDialogViewUnitTest&) = delete;
const SettingsOverriddenDialogViewUnitTest& operator=(
const SettingsOverriddenDialogViewUnitTest&) = delete;
~SettingsOverriddenDialogViewUnitTest() override = default;
views::Widget* ShowDialog(DialogState* state) {
auto controller = std::make_unique<TestDialogController>(state);
EXPECT_FALSE(state->shown);
views::NamedWidgetShownWaiter waiter(
views::test::AnyWidgetTestPasskey{},
kExtensionSettingsOverriddenDialogName);
extensions::ShowSettingsOverriddenDialog(std::move(controller),
browser_view()->browser());
views::Widget* dialog = waiter.WaitIfNeededAndGet();
EXPECT_TRUE(state->shown);
return dialog;
}
};
TEST_F(SettingsOverriddenDialogViewUnitTest, DialogResult_ChangeSettingsBack) {
DialogState state;
views::Widget* dialog = ShowDialog(&state);
views::test::WidgetDestroyedWaiter dialog_waiter(dialog);
dialog->widget_delegate()->AsDialogDelegate()->AcceptDialog();
dialog_waiter.Wait();
ASSERT_TRUE(state.result);
EXPECT_EQ(DialogResult::kChangeSettingsBack, state.result);
}
TEST_F(SettingsOverriddenDialogViewUnitTest, DialogResult_KeepNewSettings) {
DialogState state;
views::Widget* dialog = ShowDialog(&state);
views::test::WidgetDestroyedWaiter dialog_waiter(dialog);
dialog->widget_delegate()->AsDialogDelegate()->CancelDialog();
dialog_waiter.Wait();
ASSERT_TRUE(state.result);
EXPECT_EQ(DialogResult::kKeepNewSettings, state.result);
}
TEST_F(SettingsOverriddenDialogViewUnitTest, DialogResult_DismissDialog) {
DialogState state;
views::Widget* dialog = ShowDialog(&state);
views::test::WidgetDestroyedWaiter dialog_waiter(dialog);
dialog->Close();
dialog_waiter.Wait();
ASSERT_TRUE(state.result);
EXPECT_EQ(DialogResult::kDialogDismissed, state.result);
}
TEST_F(SettingsOverriddenDialogViewUnitTest, DialogResult_CloseParentWidget) {
DialogState state;
views::Widget* dialog = ShowDialog(&state);
views::test::WidgetDestroyedWaiter dialog_waiter(dialog);
dialog->CloseNow();
dialog_waiter.Wait();
ASSERT_TRUE(state.result);
EXPECT_EQ(DialogResult::kDialogClosedWithoutUserAction, state.result);
}
|
