1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/bookmarks/android/bookmark_bridge.h"
#include <memory>
#include <string>
#include "base/android/jni_android.h"
#include "base/android/scoped_java_ref.h"
#include "base/memory/weak_ptr.h"
#include "base/test/bind.h"
#include "base/test/mock_callback.h"
#include "base/test/simple_test_clock.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
#include "chrome/browser/partnerbookmarks/partner_bookmarks_reader.h"
#include "chrome/browser/reading_list/android/reading_list_manager.h"
#include "chrome/browser/reading_list/android/reading_list_manager_impl.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_node.h"
#include "components/bookmarks/browser/bookmark_utils.h"
#include "components/bookmarks/common/android/bookmark_id.h"
#include "components/bookmarks/common/android/bookmark_type.h"
#include "components/bookmarks/managed/managed_bookmark_service.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/reading_list/core/dual_reading_list_model.h"
#include "components/reading_list/core/fake_reading_list_model_storage.h"
#include "components/reading_list/core/reading_list_model_impl.h"
#include "components/signin/public/base/consent_level.h"
#include "components/signin/public/identity_manager/identity_test_environment.h"
#include "components/sync/base/storage_type.h"
#include "components/sync/base/user_selectable_type.h"
#include "components/sync/engine/data_type_activation_response.h"
#include "components/sync/model/client_tag_based_data_type_processor.h"
#include "components/sync/model/data_type_activation_request.h"
#include "components/sync/test/mock_commit_queue.h"
#include "components/sync/test/test_sync_user_settings.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/android/gurl_android.h"
#include "url/gurl.h"
using base::android::AttachCurrentThread;
using base::android::JavaParamRef;
using bookmarks::BookmarkModel;
using bookmarks::BookmarkNode;
using bookmarks::ManagedBookmarkService;
using bookmarks::android::JavaBookmarkIdGetId;
using testing::IsNull;
using testing::NotNull;
// Unit tests for `BookmarkBridge`.
class BookmarkBridgeTest : public testing::Test {
public:
BookmarkBridgeTest() = default;
~BookmarkBridgeTest() override = default;
// testing::Test
void SetUp() override {
// Setup the profile, and service factories.
profile_manager_ = std::make_unique<TestingProfileManager>(
TestingBrowserProcess::GetGlobal());
ASSERT_TRUE(profile_manager_->SetUp());
profile_ = profile_manager_->CreateTestingProfile(
"BookmarkBridgeTest", /*testing_factories=*/{
TestingProfile::TestingFactory{
BookmarkModelFactory::GetInstance(),
BookmarkModelFactory::GetDefaultFactory()},
TestingProfile::TestingFactory{
ManagedBookmarkServiceFactory::GetInstance(),
ManagedBookmarkServiceFactory::GetDefaultFactory()}});
// Setup bookmark sources from their factories.
managed_bookmark_service_ =
ManagedBookmarkServiceFactory::GetForProfile(profile_);
partner_bookmarks_shim_ =
PartnerBookmarksShim::BuildForBrowserContext(profile_);
identity_test_environment_ =
std::make_unique<signin::IdentityTestEnvironment>();
CreateBookmarkBridge(/*enable_account_bookmarks=*/false);
}
void TearDown() override {
bookmark_bridge_.reset();
profile_manager_.reset();
}
BookmarkModel* bookmark_model() { return bookmark_model_.get(); }
BookmarkBridge* bookmark_bridge() { return bookmark_bridge_.get(); }
ReadingListManager* local_or_syncable_reading_list_manager() {
return bookmark_bridge_->GetLocalOrSyncableReadingListManagerForTesting();
}
ReadingListManager* account_reading_list_manager() {
return bookmark_bridge_
->GetAccountReadingListManagerIfAvailableForTesting();
}
signin::IdentityTestEnvironment* identity_test_environment() {
return identity_test_environment_.get();
}
const BookmarkNode* AddURL(const BookmarkNode* parent,
size_t index,
const std::u16string& title,
const GURL& url) {
return bookmark_model()->AddURL(parent, index, title, url,
/*meta_info=*/nullptr, clock_.Now());
}
void StartSyncing() {
std::unique_ptr<syncer::DataTypeActivationResponse> activation_response;
base::RunLoop loop;
syncer::DataTypeActivationRequest request;
request.error_handler = base::DoNothing();
dual_reading_list_model_->GetSyncControllerDelegateForTransportMode()
->OnSyncStarting(
request, base::BindLambdaForTesting(
[&](std::unique_ptr<syncer::DataTypeActivationResponse>
response) {
activation_response = std::move(response);
loop.Quit();
}));
loop.Run();
activation_response->type_processor->ConnectSync(
std::make_unique<testing::NiceMock<syncer::MockCommitQueue>>());
// After this update initial sync is for sure done.
sync_pb::DataTypeState state;
state.set_initial_sync_state(
sync_pb::DataTypeState_InitialSyncState_INITIAL_SYNC_DONE);
activation_response->type_processor->OnUpdateReceived(
state, {}, /*gc_directive=*/std::nullopt);
task_environment_.RunUntilIdle();
}
void CreateBookmarkBridge(bool enable_account_bookmarks,
bool load_reading_list_model = true) {
bookmark_bridge_.reset();
base::WeakPtr<FakeReadingListModelStorage>
local_or_syncable_model_storage_ptr;
auto local_or_syncable_reading_list_model = CreateReadingListModel(
syncer::StorageType::kUnspecified, local_or_syncable_model_storage_ptr);
base::WeakPtr<FakeReadingListModelStorage>
account_reading_list_model_storage_ptr;
auto account_reading_list_model = CreateReadingListModel(
syncer::StorageType::kAccount, account_reading_list_model_storage_ptr);
if (load_reading_list_model) {
EXPECT_TRUE(
local_or_syncable_model_storage_ptr->TriggerLoadCompletion() &&
account_reading_list_model_storage_ptr->TriggerLoadCompletion());
}
dual_reading_list_model_ =
std::make_unique<reading_list::DualReadingListModel>(
std::move(local_or_syncable_reading_list_model),
std::move(account_reading_list_model));
std::unique_ptr<bookmarks::TestBookmarkClient> bookmark_client =
std::make_unique<bookmarks::TestBookmarkClient>();
BookmarkNode* managed_node = bookmark_client->EnableManagedNode();
managed_node->SetTitle(u"Managed bookmarks");
bookmark_model_ =
std::make_unique<bookmarks::BookmarkModel>(std::move(bookmark_client));
bookmark_model_->LoadEmptyForTest();
bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_.get());
if (enable_account_bookmarks) {
bookmark_model_->CreateAccountPermanentFolders();
if (load_reading_list_model) {
// If the `account_reading_list_model` is not loaded, StartSyncing()
// will run into failure.
StartSyncing();
}
}
bookmark_bridge_ = std::make_unique<BookmarkBridge>(
profile_, bookmark_model_.get(), managed_bookmark_service_,
dual_reading_list_model_.get(), partner_bookmarks_shim_,
identity_test_environment_->identity_manager());
bookmark_bridge_->LoadEmptyPartnerBookmarkShimForTesting(
AttachCurrentThread());
partner_bookmarks_shim_->SetPartnerBookmarksRoot(
PartnerBookmarksReader::CreatePartnerBookmarksRootForTesting());
}
protected:
std::unique_ptr<ReadingListModelImpl> CreateReadingListModel(
syncer::StorageType storage_type,
base::WeakPtr<FakeReadingListModelStorage>& storage_ptr) {
auto storage = std::make_unique<FakeReadingListModelStorage>();
storage_ptr = storage->AsWeakPtr();
auto reading_list_model = std::make_unique<ReadingListModelImpl>(
std::move(storage), storage_type,
storage_type == syncer::StorageType::kAccount
? syncer::WipeModelUponSyncDisabledBehavior::kAlways
: syncer::WipeModelUponSyncDisabledBehavior::kNever,
&clock_);
return reading_list_model;
}
base::SimpleTestClock clock_;
content::BrowserTaskEnvironment task_environment_;
raw_ptr<Profile> profile_;
raw_ptr<ManagedBookmarkService> managed_bookmark_service_;
raw_ptr<PartnerBookmarksShim> partner_bookmarks_shim_;
std::unique_ptr<BookmarkModel> bookmark_model_;
std::unique_ptr<TestingProfileManager> profile_manager_;
std::unique_ptr<reading_list::DualReadingListModel> dual_reading_list_model_;
std::unique_ptr<BookmarkBridge> bookmark_bridge_;
std::unique_ptr<signin::IdentityTestEnvironment> identity_test_environment_;
};
TEST_F(BookmarkBridgeTest,
TestAccountModelAvailabilityChangeUponChangesInSyncState) {
CreateBookmarkBridge(/*enable_account_bookmarks*/ true);
ASSERT_THAT(account_reading_list_manager(), NotNull());
dual_reading_list_model_->GetSyncControllerDelegateForTransportMode()
->OnSyncStopping(syncer::CLEAR_METADATA);
EXPECT_THAT(account_reading_list_manager(), IsNull());
StartSyncing();
EXPECT_THAT(account_reading_list_manager(), NotNull());
}
TEST_F(BookmarkBridgeTest, TestGetMostRecentlyAddedUserBookmarkIdForUrl) {
GURL url = GURL("http://foo.com");
// The first call will have no result.
ASSERT_EQ(
nullptr,
bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(url));
// Verify that the last bookmark that was added is the result.
AddURL(bookmark_model()->other_node(), 0, u"first", url);
clock_.Advance(base::Seconds(1));
AddURL(bookmark_model()->other_node(), 0, u"second", url);
clock_.Advance(base::Seconds(1));
auto* recently_added =
AddURL(bookmark_model()->other_node(), 0, u"third", url);
clock_.Advance(base::Seconds(1));
ASSERT_EQ(
recently_added,
bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(url));
// Add to the reading list and verify that it's the most recently added.
recently_added = local_or_syncable_reading_list_manager()->Add(url, "fourth");
ASSERT_EQ(
recently_added,
bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(url));
}
TEST_F(BookmarkBridgeTest,
TestGetMostRecentlyAddedUserBookmarkIdForUrlBeforeReadingListLoads) {
CreateBookmarkBridge(/*enable_account_bookmarks*/ false,
/*load_reading_list_model*/ false);
ASSERT_FALSE(local_or_syncable_reading_list_manager()->IsLoaded());
EXPECT_THAT(bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(
GURL("http://foo.com")),
IsNull());
}
TEST_F(
BookmarkBridgeTest,
TestGetMostRecentlyAddedUserBookmarkIdForUrlBeforeReadingListLoadsWithAccountBookmarks) {
CreateBookmarkBridge(/*enable_account_bookmarks*/ true,
/*load_reading_list_model*/ false);
ASSERT_FALSE(local_or_syncable_reading_list_manager()->IsLoaded());
// When the account_reading_list_model is not loaded, sync will not start,
// which means `account_reading_list_manager` will be null.
ASSERT_THAT(account_reading_list_manager(), IsNull());
EXPECT_THAT(bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(
GURL("http://foo.com")),
IsNull());
}
TEST_F(BookmarkBridgeTest, TestIsBookmarked) {
JNIEnv* const env = AttachCurrentThread();
GURL url = GURL("http://foo.com");
ASSERT_FALSE(bookmark_bridge()->IsBookmarked(env, url));
AddURL(bookmark_model()->other_node(), 0, u"foo", url);
ASSERT_TRUE(bookmark_bridge()->IsBookmarked(env, url));
bookmark_model()->RemoveAllUserBookmarks(FROM_HERE);
ASSERT_FALSE(bookmark_bridge()->IsBookmarked(env, url));
local_or_syncable_reading_list_manager()->Add(url, "bar");
ASSERT_TRUE(bookmark_bridge()->IsBookmarked(env, url));
}
TEST_F(BookmarkBridgeTest, TestGetTopLevelFolderIds) {
std::vector<const BookmarkNode*> folders =
bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
// The 2 folders should be: mobile bookmarks, reading list.
EXPECT_EQ(2u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_EQ(u"Reading list", folders[1]->GetTitle());
// When forcing visibility, all top-level folders should be visible.
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::ALL);
// The 4 folders should be: mobile bookmarks, bookmarks bar, other bookmarks,
// and reading list.
EXPECT_EQ(4u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_EQ(u"Bookmarks bar", folders[1]->GetTitle());
EXPECT_EQ(u"Other bookmarks", folders[2]->GetTitle());
EXPECT_EQ(u"Reading list", folders[3]->GetTitle());
// Adding a bookmark to the bookmark bar will include it in the top level
// folders that are returned.
AddURL(bookmark_model()->bookmark_bar_node(), 0, u"first",
GURL("http://foo.com"));
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
EXPECT_EQ(3u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_EQ(u"Bookmarks bar", folders[1]->GetTitle());
EXPECT_EQ(u"Reading list", folders[2]->GetTitle());
}
TEST_F(BookmarkBridgeTest, AccountFoldersNullWhileNotEnabled) {
JNIEnv* const env = AttachCurrentThread();
EXPECT_TRUE(bookmark_bridge()->GetAccountMobileFolderId(env).is_null());
EXPECT_TRUE(bookmark_bridge()->GetAccountOtherFolderId(env).is_null());
EXPECT_TRUE(bookmark_bridge()->GetAccountDesktopFolderId(env).is_null());
EXPECT_TRUE(bookmark_bridge()->GetAccountReadingListFolder(env).is_null());
}
// TODO(crbug.com/41481802): Also enable bookmark account folders here.
TEST_F(BookmarkBridgeTest, TestGetTopLevelFolderIdsAccountActive) {
CreateBookmarkBridge(/*enable_account_bookmarks=*/true);
// There should be 3 folders: Mobile bookmarks, reading list, and the local
// mobile bookmarks folder (which contains partner bookmarks).
std::vector<const BookmarkNode*> folders =
bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
EXPECT_EQ(3u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[0]));
EXPECT_EQ(u"Reading list", folders[1]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[1]));
EXPECT_EQ(u"Mobile bookmarks", folders[2]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[0]));
// When there are no partner bookmarks, the local mobile node will be hidden.
partner_bookmarks_shim_->SetPartnerBookmarksRoot(nullptr);
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
EXPECT_EQ(2u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[0]));
EXPECT_EQ(u"Reading list", folders[1]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[1]));
// All account and some local folders should be included when forcing
// visibility.
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::ALL);
EXPECT_EQ(6u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[0]));
EXPECT_EQ(u"Bookmarks bar", folders[1]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[1]));
EXPECT_EQ(u"Other bookmarks", folders[2]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[2]));
EXPECT_EQ(u"Reading list", folders[3]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[3]));
EXPECT_EQ(u"Mobile bookmarks", folders[4]->GetTitle());
EXPECT_FALSE(bookmark_bridge()->IsAccountBookmarkImpl(folders[4]));
EXPECT_EQ(u"Reading list", folders[5]->GetTitle());
EXPECT_FALSE(bookmark_bridge()->IsAccountBookmarkImpl(folders[5]));
// Adding a bookmark to the bookmark bar will include it in the top level
// folders that are returned.
AddURL(bookmark_model()->bookmark_bar_node(), 0, u"first",
GURL("http://foo.com"));
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
// Adding a bookmark node to mobile bookmarks will include it in the list.
AddURL(bookmark_model()->mobile_node(), 0, u"second", GURL("http://foo.com"));
// Adding to the local reading list will include it in the list.
local_or_syncable_reading_list_manager()->Add(GURL("http://foo.com"),
"third");
folders = bookmark_bridge()->GetTopLevelFolderIdsImpl(
/*force_visible_mask=*/BookmarkNodeMaskBit::NONE);
EXPECT_EQ(5u, folders.size());
EXPECT_EQ(u"Mobile bookmarks", folders[0]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[0]));
EXPECT_EQ(u"Reading list", folders[1]->GetTitle());
EXPECT_TRUE(bookmark_bridge()->IsAccountBookmarkImpl(folders[1]));
EXPECT_EQ(u"Mobile bookmarks", folders[2]->GetTitle());
EXPECT_FALSE(bookmark_bridge()->IsAccountBookmarkImpl(folders[2]));
EXPECT_EQ(u"Bookmarks bar", folders[3]->GetTitle());
EXPECT_FALSE(bookmark_bridge()->IsAccountBookmarkImpl(folders[3]));
EXPECT_EQ(u"Reading list", folders[4]->GetTitle());
EXPECT_FALSE(bookmark_bridge()->IsAccountBookmarkImpl(folders[4]));
}
TEST_F(BookmarkBridgeTest, AccountFoldersNonNullWhileEnabled) {
CreateBookmarkBridge(/*enable_account_bookmarks=*/true);
JNIEnv* const env = AttachCurrentThread();
EXPECT_FALSE(bookmark_bridge()->GetAccountMobileFolderId(env).is_null());
EXPECT_FALSE(bookmark_bridge()->GetAccountOtherFolderId(env).is_null());
EXPECT_FALSE(bookmark_bridge()->GetAccountDesktopFolderId(env).is_null());
EXPECT_FALSE(bookmark_bridge()->GetAccountReadingListFolder(env).is_null());
}
TEST_F(BookmarkBridgeTest, GetChildIdsMobileShowsPartner) {
std::vector<const BookmarkNode*> children =
bookmark_bridge()->GetChildIdsImpl(bookmark_model()->mobile_node());
ASSERT_EQ(1u, children.size());
ASSERT_EQ(partner_bookmarks_shim_->GetPartnerBookmarksRoot(), children[0]);
ASSERT_EQ(bookmarks::BookmarkType::BOOKMARK_TYPE_PARTNER,
bookmark_bridge()->GetBookmarkType(children[0]));
partner_bookmarks_shim_->SetPartnerBookmarksRoot(nullptr);
children =
bookmark_bridge()->GetChildIdsImpl(bookmark_model()->mobile_node());
ASSERT_EQ(0u, children.size());
}
TEST_F(BookmarkBridgeTest, GetUnreadCountLocalOrSyncable) {
GURL url = GURL("http://foo.com");
local_or_syncable_reading_list_manager()->Add(url, "foo");
local_or_syncable_reading_list_manager()->Add(GURL("http://bar.com"), "bar");
JNIEnv* const env = AttachCurrentThread();
ASSERT_EQ(2, bookmark_bridge()->GetUnreadCount(
env, JavaParamRef<jobject>(
env, bookmark_bridge()
->GetLocalOrSyncableReadingListFolder(env)
.obj())));
local_or_syncable_reading_list_manager()->SetReadStatus(url, true);
ASSERT_EQ(1, bookmark_bridge()->GetUnreadCount(
env, JavaParamRef<jobject>(
env, bookmark_bridge()
->GetLocalOrSyncableReadingListFolder(env)
.obj())));
}
TEST_F(BookmarkBridgeTest, SetReadStatus) {
CreateBookmarkBridge(/*enable_account_bookmarks=*/true);
GURL url1 = GURL("http://foo.com");
GURL url2 = GURL("http://bar.com");
const bookmarks::BookmarkNode* local1 =
local_or_syncable_reading_list_manager()->Add(url1, "foo");
const bookmarks::BookmarkNode* local2 =
local_or_syncable_reading_list_manager()->Add(url2, "bar");
const bookmarks::BookmarkNode* acc1 =
account_reading_list_manager()->Add(url1, "foo");
bookmark_bridge()->SetReadStatusImpl(url1, true);
bookmark_bridge()->SetReadStatusImpl(url2, true);
ASSERT_TRUE(local_or_syncable_reading_list_manager()->GetReadStatus(local1));
ASSERT_TRUE(local_or_syncable_reading_list_manager()->GetReadStatus(local2));
ASSERT_TRUE(account_reading_list_manager()->GetReadStatus(acc1));
const bookmarks::BookmarkNode* acc2 =
account_reading_list_manager()->Add(url2, "bar");
ASSERT_FALSE(account_reading_list_manager()->GetReadStatus(acc2));
bookmark_bridge()->SetReadStatusImpl(url1, false);
bookmark_bridge()->SetReadStatusImpl(url2, false);
ASSERT_FALSE(local_or_syncable_reading_list_manager()->GetReadStatus(local1));
ASSERT_FALSE(local_or_syncable_reading_list_manager()->GetReadStatus(local2));
ASSERT_FALSE(account_reading_list_manager()->GetReadStatus(acc1));
ASSERT_FALSE(account_reading_list_manager()->GetReadStatus(acc2));
}
// Test that the correct type, parent node, etc are returned for account
// reading list nodes.
TEST_F(BookmarkBridgeTest, TestAccountReadingListNodes) {
CreateBookmarkBridge(/*enable_account_bookmarks=*/true);
GURL url = GURL("http://foo.com");
local_or_syncable_reading_list_manager()->Add(url, "foo");
const BookmarkNode* local_rl_node =
bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(url);
EXPECT_EQ(bookmarks::BOOKMARK_TYPE_READING_LIST,
bookmark_bridge()->GetBookmarkType(local_rl_node));
EXPECT_EQ(local_or_syncable_reading_list_manager()->GetRoot(),
local_rl_node->parent());
EXPECT_EQ(local_rl_node->parent(),
bookmark_bridge()->GetParentNode(local_rl_node));
clock_.Advance(base::Seconds(1));
ASSERT_THAT(account_reading_list_manager(), NotNull());
account_reading_list_manager()->Add(url, "foo");
const BookmarkNode* account_rl_node =
bookmark_bridge()->GetMostRecentlyAddedUserBookmarkIdForUrlImpl(url);
EXPECT_EQ(bookmarks::BOOKMARK_TYPE_READING_LIST,
bookmark_bridge()->GetBookmarkType(account_rl_node));
EXPECT_EQ(account_reading_list_manager()->GetRoot(),
account_rl_node->parent());
EXPECT_EQ(account_rl_node->parent(),
bookmark_bridge()->GetParentNode(account_rl_node));
}
TEST_F(BookmarkBridgeTest, TestSearchBookmarks) {
CreateBookmarkBridge(/*enable_account_bookmarks=*/true);
GURL url = GURL("http://foo.com");
ASSERT_THAT(account_reading_list_manager(), NotNull());
account_reading_list_manager()->Add(url, "foo");
local_or_syncable_reading_list_manager()->Add(url, "foo");
local_or_syncable_reading_list_manager()->Add(url, "baz");
power_bookmarks::PowerBookmarkQueryFields query1;
query1.word_phrase_query = std::make_unique<std::u16string>(u"foo");
std::vector<const BookmarkNode*> results1 =
bookmark_bridge()->SearchBookmarksImpl(query1, 999);
EXPECT_EQ(2u, results1.size());
power_bookmarks::PowerBookmarkQueryFields query2;
query2.word_phrase_query = std::make_unique<std::u16string>(u"baz");
std::vector<const BookmarkNode*> results2 =
bookmark_bridge()->SearchBookmarksImpl(query2, 999);
EXPECT_EQ(1u, results2.size());
}
TEST_F(BookmarkBridgeTest, TestMoveBookmark) {
GURL url = GURL("http://foo.com");
const BookmarkNode* node =
AddURL(bookmark_model()->other_node(), 0, u"test", url);
bookmark_bridge()->MoveBookmarkImpl(node, bookmarks::BOOKMARK_TYPE_NORMAL,
bookmark_model()->bookmark_bar_node(),
bookmarks::BOOKMARK_TYPE_NORMAL, 0);
// Get children of new parent and verify it has the node in it.
std::vector<const BookmarkNode*> children =
bookmark_bridge()->GetChildIdsImpl(bookmark_model()->bookmark_bar_node());
ASSERT_EQ(1u, children.size());
ASSERT_EQ(children[0], node);
// Get children of old parent and verify it has no nodes.
children = bookmark_bridge()->GetChildIdsImpl(bookmark_model()->other_node());
ASSERT_EQ(0u, children.size());
}
TEST_F(BookmarkBridgeTest, TestMoveBookmarkToOwnParentReturnsEarly) {
GURL url = GURL("http://foo.com");
const BookmarkNode* node =
AddURL(bookmark_model()->other_node(), 0, u"test", url);
bookmark_bridge()->MoveBookmarkImpl(node, bookmarks::BOOKMARK_TYPE_NORMAL,
bookmark_model()->other_node(),
bookmarks::BOOKMARK_TYPE_NORMAL, 0);
// Early return means we don't hit a DCHECK.
}
TEST_F(BookmarkBridgeTest, TestMoveBookmarkToReadingList) {
GURL url = GURL("http://foo.com");
const std::u16string title = u"test";
const BookmarkNode* node =
AddURL(bookmark_model()->other_node(), 0, title, url);
bookmark_bridge()->MoveBookmarkImpl(
node, bookmarks::BOOKMARK_TYPE_NORMAL,
local_or_syncable_reading_list_manager()->GetRoot(),
bookmarks::BOOKMARK_TYPE_READING_LIST, 0);
// Get children of new parent and verify it has the node in it.
std::vector<const BookmarkNode*> children =
bookmark_bridge()->GetChildIdsImpl(
local_or_syncable_reading_list_manager()->GetRoot());
ASSERT_EQ(1u, children.size());
ASSERT_EQ(children[0]->GetTitle(), title);
ASSERT_EQ(children[0]->url(), url);
// Get children of old parent and verify it has no nodes.
children = bookmark_bridge()->GetChildIdsImpl(bookmark_model()->other_node());
ASSERT_EQ(0u, children.size());
}
TEST_F(BookmarkBridgeTest, TestMoveBookmarkToReadingListAddFails) {
GURL url = GURL("chrome://newtab");
const std::u16string title = u"native page";
const BookmarkNode* node =
AddURL(bookmark_model()->other_node(), 0, title, url);
bookmark_bridge()->MoveBookmarkImpl(
node, bookmarks::BOOKMARK_TYPE_NORMAL,
local_or_syncable_reading_list_manager()->GetRoot(),
bookmarks::BOOKMARK_TYPE_READING_LIST, 0);
// Get children of new parent and verify it hasn't been moved
std::vector<const BookmarkNode*> children =
bookmark_bridge()->GetChildIdsImpl(
local_or_syncable_reading_list_manager()->GetRoot());
ASSERT_EQ(0u, children.size());
// Get children of old parent and verify the original bookmark is still there.
children = bookmark_bridge()->GetChildIdsImpl(bookmark_model()->other_node());
ASSERT_EQ(1u, children.size());
ASSERT_EQ(children[0]->GetTitle(), title);
ASSERT_EQ(children[0]->url(), url);
}
TEST_F(BookmarkBridgeTest, TestMoveReadingListToBookmark) {
GURL url = GURL("http://foo.com");
const std::u16string title = u"test";
const BookmarkNode* node =
local_or_syncable_reading_list_manager()->Add(url, "test");
bookmark_bridge()->MoveBookmarkImpl(node,
bookmarks::BOOKMARK_TYPE_READING_LIST,
bookmark_model()->bookmark_bar_node(),
bookmarks::BOOKMARK_TYPE_NORMAL, 0);
// Get children of new parent and verify it has the node in it.
std::vector<const BookmarkNode*> children =
bookmark_bridge()->GetChildIdsImpl(bookmark_model()->bookmark_bar_node());
ASSERT_EQ(1u, children.size());
ASSERT_EQ(children[0]->GetTitle(), title);
ASSERT_EQ(children[0]->url(), url);
// Get children of old parent and verify it has no nodes.
children = bookmark_bridge()->GetChildIdsImpl(
local_or_syncable_reading_list_manager()->GetRoot());
ASSERT_EQ(0u, children.size());
}
|