1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/memory/raw_ptr.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/browser_test.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/views/controls/webview/webview.h"
#include "ui/views/focus/focus_manager.h"
#include "ui/views/view.h"
#include "ui/views/view_utils.h"
#include "url/gurl.h"
const char kSimplePage[] = "/focus/page_with_focus.html";
class BrowserViewFocusTest : public InProcessBrowserTest {
public:
BrowserViewFocusTest() = default;
BrowserViewFocusTest(const BrowserViewFocusTest&) = delete;
BrowserViewFocusTest& operator=(const BrowserViewFocusTest&) = delete;
~BrowserViewFocusTest() override = default;
bool IsViewFocused(ViewID vid) {
return ui_test_utils::IsViewFocused(browser(), vid);
}
};
IN_PROC_BROWSER_TEST_F(BrowserViewFocusTest, BrowsersRememberFocus) {
ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
ASSERT_TRUE(embedded_test_server()->Start());
// First we navigate to our test page.
GURL url = embedded_test_server()->GetURL(kSimplePage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
gfx::NativeWindow window = browser()->window()->GetNativeWindow();
// The focus should be on the Tab contents.
ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
// Now hide the window, show it again, the focus should not have changed.
ui_test_utils::HideNativeWindow(window);
ASSERT_TRUE(ui_test_utils::ShowAndFocusNativeWindow(window));
ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
chrome::FocusLocationBar(browser());
ASSERT_TRUE(IsViewFocused(VIEW_ID_OMNIBOX));
// Hide the window, show it again, the focus should not have changed.
ui_test_utils::HideNativeWindow(window);
ASSERT_TRUE(ui_test_utils::ShowAndFocusNativeWindow(window));
ASSERT_TRUE(IsViewFocused(VIEW_ID_OMNIBOX));
// The rest of this test does not make sense on Linux because the behavior
// of Activate() is not well defined and can vary by window manager.
#if BUILDFLAG(IS_WIN)
// Open a new browser window.
Browser* browser2 =
Browser::Create(Browser::CreateParams(browser()->profile(), true));
ASSERT_TRUE(browser2);
chrome::AddTabAt(browser2, GURL(), -1, true);
browser2->window()->Show();
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser2, url));
gfx::NativeWindow window2 = browser2->window()->GetNativeWindow();
BrowserView* browser_view2 = BrowserView::GetBrowserViewForBrowser(browser2);
ASSERT_TRUE(browser_view2);
const views::Widget* widget2 =
views::Widget::GetWidgetForNativeWindow(window2);
ASSERT_TRUE(widget2);
const views::FocusManager* focus_manager2 = widget2->GetFocusManager();
ASSERT_TRUE(focus_manager2);
EXPECT_EQ(browser_view2->contents_web_view(),
focus_manager2->GetFocusedView());
// Switch to the 1st browser window, focus should still be on the location
// bar and the second browser should have nothing focused.
browser()->window()->Activate();
ASSERT_TRUE(IsViewFocused(VIEW_ID_OMNIBOX));
EXPECT_EQ(nullptr, focus_manager2->GetFocusedView());
// Switch back to the second browser, focus should still be on the page.
browser2->window()->Activate();
views::Widget* widget = views::Widget::GetWidgetForNativeWindow(window);
ASSERT_TRUE(widget);
EXPECT_EQ(nullptr, widget->GetFocusManager()->GetFocusedView());
EXPECT_EQ(browser_view2->contents_web_view(),
focus_manager2->GetFocusedView());
// Close the 2nd browser to avoid a DCHECK().
browser_view2->Close();
#endif
}
// Helper class that tracks view classes receiving focus.
class FocusedViewClassRecorder : public views::FocusChangeListener {
public:
explicit FocusedViewClassRecorder(views::FocusManager* focus_manager)
: focus_manager_(focus_manager) {
focus_manager_->AddFocusChangeListener(this);
}
FocusedViewClassRecorder(const FocusedViewClassRecorder&) = delete;
FocusedViewClassRecorder& operator=(const FocusedViewClassRecorder&) = delete;
~FocusedViewClassRecorder() override {
focus_manager_->RemoveFocusChangeListener(this);
}
bool GetHasFocusedOnNonWebView() { return has_focused_on_non_webview_; }
int GetFocusChangeCount() { return focus_change_count; }
private:
// Inherited from views::FocusChangeListener
void OnDidChangeFocus(views::View* focused_before,
views::View* focused_now) override {
if (focused_now) {
if (!views::IsViewClass<views::WebView>(focused_now)) {
// Focused views could be destroyed. Track what we want to test for when
// OnDidChangeFocus is called.
has_focused_on_non_webview_ = true;
}
}
focus_change_count++;
}
raw_ptr<views::FocusManager> focus_manager_;
bool has_focused_on_non_webview_ = false;
int focus_change_count = 0;
};
// Switching tabs does not focus views unexpectedly.
// (bug http://crbug.com/791757, bug http://crbug.com/777051)
IN_PROC_BROWSER_TEST_F(BrowserViewFocusTest, TabChangesAvoidSpuriousFocus) {
ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
ASSERT_TRUE(embedded_test_server()->Start());
// First we navigate to our test page.
GURL url = embedded_test_server()->GetURL(kSimplePage);
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
// Create another tab.
ASSERT_TRUE(AddTabAtIndex(1, url, ui::PAGE_TRANSITION_TYPED));
// Begin recording focus changes.
gfx::NativeWindow window = browser()->window()->GetNativeWindow();
views::Widget* widget = views::Widget::GetWidgetForNativeWindow(window);
views::FocusManager* focus_manager = widget->GetFocusManager();
FocusedViewClassRecorder focus_change_recorder(focus_manager);
// Switch tabs using ctrl+tab.
ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, true,
false, false, false));
// Everything that was focused on must be a WebView.
EXPECT_FALSE(focus_change_recorder.GetHasFocusedOnNonWebView());
EXPECT_EQ(focus_change_recorder.GetFocusChangeCount(), 2);
}
|
