1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chromeos/components/quick_answers/quick_answers_client.h"
#include <memory>
#include <string>
#include <utility>
#include "base/memory/scoped_refptr.h"
#include "base/test/task_environment.h"
#include "chromeos/components/quick_answers/public/cpp/quick_answers_prefs.h"
#include "chromeos/components/quick_answers/quick_answers_model.h"
#include "chromeos/components/quick_answers/test/quick_answers_test_base.h"
#include "chromeos/components/quick_answers/test/test_helpers.h"
#include "chromeos/components/quick_answers/utils/quick_answers_utils.h"
#include "services/data_decoder/public/cpp/test_support/in_process_data_decoder.h"
#include "services/network/public/cpp/resource_request.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/test/test_url_loader_factory.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace quick_answers {
namespace {
class TestResultLoader : public ResultLoader {
public:
TestResultLoader(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
ResultLoaderDelegate* delegate)
: ResultLoader(url_loader_factory, delegate) {}
// ResultLoader:
void BuildRequest(const PreprocessedOutput& preprocessed_output,
BuildRequestCallback callback) const override {
return std::move(callback).Run(std::make_unique<network::ResourceRequest>(),
std::string());
}
void ProcessResponse(const PreprocessedOutput& preprocessed_output,
std::unique_ptr<std::string> response_body,
ResponseParserCallback complete_callback) override {}
};
class MockResultLoader : public TestResultLoader {
public:
MockResultLoader(
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory,
ResultLoaderDelegate* delegate)
: TestResultLoader(url_loader_factory, delegate) {
ON_CALL(*this, Fetch)
.WillByDefault([this](const PreprocessedOutput& preprocessed_output) {
// `ResultLoader::Fetch` has a fail-safe CHECK for consent_status.
// Delegate to `TestResultLoader` to trigger the check.
TestResultLoader::Fetch(preprocessed_output);
});
}
MockResultLoader(const MockResultLoader&) = delete;
MockResultLoader& operator=(const MockResultLoader&) = delete;
// TestResultLoader:
MOCK_METHOD1(Fetch, void(const PreprocessedOutput&));
};
MATCHER_P(QuickAnswersRequestWithOutputEqual, quick_answers_request, "") {
return (
arg.selected_text == quick_answers_request.selected_text &&
arg.preprocessed_output.intent_info.intent_type ==
quick_answers_request.preprocessed_output.intent_info.intent_type &&
arg.preprocessed_output.intent_info.intent_text ==
quick_answers_request.preprocessed_output.intent_info.intent_text &&
arg.preprocessed_output.query ==
quick_answers_request.preprocessed_output.query);
}
class MockIntentGenerator : public IntentGenerator {
public:
explicit MockIntentGenerator(IntentGeneratorCallback complete_callback)
: IntentGenerator(/*spell_checker=*/nullptr,
std::move(complete_callback)) {}
MockIntentGenerator(const MockIntentGenerator&) = delete;
MockIntentGenerator& operator=(const MockIntentGenerator&) = delete;
// IntentGenerator:
MOCK_METHOD1(GenerateIntent, void(const QuickAnswersRequest&));
};
} // namespace
class QuickAnswersClientTest : public QuickAnswersTestBase {
public:
QuickAnswersClientTest() = default;
QuickAnswersClientTest(const QuickAnswersClientTest&) = delete;
QuickAnswersClientTest& operator=(const QuickAnswersClientTest&) = delete;
~QuickAnswersClientTest() override = default;
// QuickAnswersTestBase:
void SetUp() override {
QuickAnswersTestBase::SetUp();
mock_delegate_ = std::make_unique<MockQuickAnswersDelegate>();
test_shared_loader_factory_ =
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&test_url_loader_factory_);
client_ = std::make_unique<QuickAnswersClient>(test_shared_loader_factory_,
mock_delegate_.get());
result_loader_factory_callback_ = base::BindRepeating(
&QuickAnswersClientTest::CreateResultLoader, base::Unretained(this));
intent_generator_factory_callback_ = base::BindRepeating(
&QuickAnswersClientTest::CreateIntentGenerator, base::Unretained(this));
mock_intent_generator_ = std::make_unique<MockIntentGenerator>(
base::BindOnce(&QuickAnswersClientTest::IntentGeneratorTestCallback,
base::Unretained(this)));
}
void TearDown() override {
QuickAnswersClient::SetResultLoaderFactoryForTesting(nullptr);
QuickAnswersClient::SetIntentGeneratorFactoryForTesting(nullptr);
client_.reset();
QuickAnswersTestBase::TearDown();
}
void IntentGeneratorTestCallback(const IntentInfo& intent_info) {}
protected:
std::unique_ptr<ResultLoader> CreateResultLoader() {
return std::move(mock_result_loader_);
}
std::unique_ptr<IntentGenerator> CreateIntentGenerator() {
return std::move(mock_intent_generator_);
}
base::test::TaskEnvironment task_environment_;
std::unique_ptr<QuickAnswersClient> client_;
std::unique_ptr<MockQuickAnswersDelegate> mock_delegate_;
std::unique_ptr<MockResultLoader> mock_result_loader_;
std::unique_ptr<MockIntentGenerator> mock_intent_generator_;
network::TestURLLoaderFactory test_url_loader_factory_;
scoped_refptr<network::SharedURLLoaderFactory> test_shared_loader_factory_;
QuickAnswersClient::ResultLoaderFactoryCallback
result_loader_factory_callback_;
QuickAnswersClient::IntentGeneratorFactoryCallback
intent_generator_factory_callback_;
IntentGenerator::IntentGeneratorCallback intent_generator_callback_;
};
TEST_F(QuickAnswersClientTest, NetworkError) {
// Verify that OnNetworkError is called.
EXPECT_CALL(*mock_delegate_, OnNetworkError());
EXPECT_CALL(*mock_delegate_, OnQuickAnswerReceived(::testing::_)).Times(0);
client_->OnNetworkError();
}
TEST_F(QuickAnswersClientTest, SendRequest) {
fake_quick_answers_state()->AsyncSetConsentStatus(
quick_answers::prefs::ConsentStatus::kAccepted);
std::unique_ptr<QuickAnswersRequest> quick_answers_request =
std::make_unique<QuickAnswersRequest>();
quick_answers_request->selected_text = "sel";
// Verify that |GenerateIntent| is called.
EXPECT_CALL(*mock_intent_generator_,
GenerateIntent(QuickAnswersRequestEqual(*quick_answers_request)));
QuickAnswersClient::SetIntentGeneratorFactoryForTesting(
&intent_generator_factory_callback_);
mock_result_loader_ =
std::make_unique<MockResultLoader>(test_shared_loader_factory_, nullptr);
EXPECT_CALL(*mock_result_loader_,
Fetch(PreprocessedOutputEqual(PreprocessRequest(
IntentInfo("sel", IntentType::kDictionary)))));
QuickAnswersClient::SetResultLoaderFactoryForTesting(
&result_loader_factory_callback_);
client_->SendRequest(*quick_answers_request);
client_->IntentGeneratorCallback(*quick_answers_request, /*skip_fetch=*/false,
IntentInfo("sel", IntentType::kDictionary));
std::unique_ptr<QuickAnswer> quick_answer = std::make_unique<QuickAnswer>();
quick_answer->first_answer_row.push_back(
std::make_unique<QuickAnswerResultText>("answer"));
std::unique_ptr<QuickAnswersSession> quick_answers_session =
std::make_unique<QuickAnswersSession>();
quick_answers_session->quick_answer = std::move(quick_answer);
EXPECT_CALL(*mock_delegate_, OnQuickAnswerReceived(testing::Pointer(
testing::Eq(quick_answers_session.get()))));
client_->OnQuickAnswerReceived(std::move(quick_answers_session));
}
TEST_F(QuickAnswersClientTest, SendRequestForPreprocessing) {
// Make the status to kUnknown as this test case is for pre-process.
fake_quick_answers_state()->AsyncSetConsentStatus(
quick_answers::prefs::ConsentStatus::kUnknown);
std::unique_ptr<QuickAnswersRequest> quick_answers_request =
std::make_unique<QuickAnswersRequest>();
quick_answers_request->selected_text = "sel";
// Verify that |GenerateIntent| is called.
EXPECT_CALL(*mock_intent_generator_,
GenerateIntent(QuickAnswersRequestEqual(*quick_answers_request)));
QuickAnswersClient::SetIntentGeneratorFactoryForTesting(
&intent_generator_factory_callback_);
mock_result_loader_ =
std::make_unique<MockResultLoader>(test_shared_loader_factory_, nullptr);
EXPECT_CALL(*mock_result_loader_, Fetch(::testing::_)).Times(0);
QuickAnswersClient::SetResultLoaderFactoryForTesting(
&result_loader_factory_callback_);
client_->SendRequestForPreprocessing(*quick_answers_request);
}
TEST_F(QuickAnswersClientTest, FetchQuickAnswers) {
fake_quick_answers_state()->AsyncSetConsentStatus(
quick_answers::prefs::ConsentStatus::kAccepted);
std::unique_ptr<QuickAnswersRequest> quick_answers_request =
std::make_unique<QuickAnswersRequest>();
quick_answers_request->preprocessed_output.query = "Define sel";
mock_result_loader_ =
std::make_unique<MockResultLoader>(test_shared_loader_factory_, nullptr);
EXPECT_CALL(*mock_result_loader_,
Fetch(PreprocessedOutputEqual(
quick_answers_request->preprocessed_output)));
QuickAnswersClient::SetResultLoaderFactoryForTesting(
&result_loader_factory_callback_);
client_->FetchQuickAnswers(*quick_answers_request);
}
TEST_F(QuickAnswersClientTest, PreprocessDefinitionIntent) {
// Make the status to kUnknown as this test case is for pre-process.
fake_quick_answers_state()->AsyncSetConsentStatus(
quick_answers::prefs::ConsentStatus::kUnknown);
std::unique_ptr<QuickAnswersRequest> quick_answers_request =
std::make_unique<QuickAnswersRequest>();
quick_answers_request->selected_text = "unfathomable";
// Verify that |OnRequestPreprocessFinished| is called.
std::unique_ptr<QuickAnswersRequest> processed_request =
std::make_unique<QuickAnswersRequest>();
processed_request->selected_text = "unfathomable";
PreprocessedOutput expected_processed_output;
expected_processed_output.intent_info.intent_text = "unfathomable";
expected_processed_output.query = "Define unfathomable";
expected_processed_output.intent_info.intent_type = IntentType::kDictionary;
processed_request->preprocessed_output = expected_processed_output;
EXPECT_CALL(*mock_delegate_,
OnRequestPreprocessFinished(
QuickAnswersRequestWithOutputEqual(*processed_request)));
// Simulate pre-process callback, i.e. skip_fetch=true.
client_->IntentGeneratorCallback(
*quick_answers_request, /*skip_fetch=*/true,
IntentInfo("unfathomable", IntentType::kDictionary));
}
TEST_F(QuickAnswersClientTest, PreprocessUnitConversionIntent) {
// Make the status to kUnknown as this test case is for pre-process.
fake_quick_answers_state()->AsyncSetConsentStatus(
quick_answers::prefs::ConsentStatus::kUnknown);
std::unique_ptr<QuickAnswersRequest> quick_answers_request =
std::make_unique<QuickAnswersRequest>();
quick_answers_request->selected_text = "20ft";
// Verify that |OnRequestPreprocessFinished| is called.
std::unique_ptr<QuickAnswersRequest> processed_request =
std::make_unique<QuickAnswersRequest>();
processed_request->selected_text = "20ft";
PreprocessedOutput expected_processed_output;
expected_processed_output.intent_info.intent_text = "20ft";
expected_processed_output.query = "Convert:20ft";
expected_processed_output.intent_info.intent_type = IntentType::kUnit;
processed_request->preprocessed_output = expected_processed_output;
EXPECT_CALL(*mock_delegate_,
OnRequestPreprocessFinished(
QuickAnswersRequestWithOutputEqual(*processed_request)));
// Simulate pre-process callback, i.e. skip_fetch=true.
client_->IntentGeneratorCallback(*quick_answers_request, /*skip_fetch=*/true,
IntentInfo("20ft", IntentType::kUnit));
}
} // namespace quick_answers
|
