1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <map>
#include "base/functional/callback.h"
#include "base/memory/weak_ptr.h"
#include "components/services/app_service/public/cpp/app_types.h"
#include "components/services/app_service/public/cpp/icon_coalescer.h"
#include "components/services/app_service/public/cpp/icon_types.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/image/image_skia_rep.h"
class AppsIconCoalescerTest : public testing::Test {
protected:
using UniqueReleaser = std::unique_ptr<apps::IconLoader::Releaser>;
class FakeIconLoader : public apps::IconLoader {
public:
int NumLoadIconFromIconKeyCalls() { return num_load_calls_; }
int NumLoadIconFromIconKeyCallsComplete() {
return num_load_calls_ - pending_callbacks_.size();
}
int NumLoadIconFromIconKeyCallsPending() {
return pending_callbacks_.size();
}
int NumPendingReleases() { return num_pending_releases_; }
void SetCallBackImmediately(bool b) { call_back_immediately_ = b; }
void CallBack(const std::string& app_id) {
auto iter = pending_callbacks_.find(app_id);
if (iter != pending_callbacks_.end()) {
std::move(iter->second).Run(NewIconValuePtr());
pending_callbacks_.erase(iter);
} else {
NOTREACHED() << "No pending callback for app_id=" << app_id;
}
}
private:
std::unique_ptr<Releaser> LoadIconFromIconKey(
const std::string& id,
const apps::IconKey& icon_key,
apps::IconType icon_type,
int32_t size_hint_in_dip,
bool allow_placeholder_icon,
apps::LoadIconCallback callback) override {
num_load_calls_++;
if (call_back_immediately_) {
num_load_calls_complete_++;
std::move(callback).Run(NewIconValuePtr());
} else {
pending_callbacks_.insert(std::make_pair(id, std::move(callback)));
}
num_pending_releases_++;
return std::make_unique<IconLoader::Releaser>(
nullptr, base::BindOnce(&FakeIconLoader::OnRelease,
weak_ptr_factory_.GetWeakPtr()));
}
apps::IconValuePtr NewIconValuePtr() {
auto iv = std::make_unique<apps::IconValue>();
iv->icon_type = apps::IconType::kUncompressed;
iv->uncompressed =
gfx::ImageSkia(gfx::ImageSkiaRep(gfx::Size(1, 1), 1.0f));
iv->is_placeholder_icon = false;
return iv;
}
void OnRelease() { num_pending_releases_--; }
bool call_back_immediately_ = false;
int num_load_calls_ = 0;
int num_load_calls_complete_ = 0;
int num_pending_releases_ = 0;
std::multimap<std::string, apps::LoadIconCallback> pending_callbacks_;
base::WeakPtrFactory<FakeIconLoader> weak_ptr_factory_{this};
};
UniqueReleaser LoadIcon(apps::IconLoader* loader,
const std::string& app_id,
int* counter,
int delta) {
return loader->LoadIcon(
app_id, apps::IconType::kUncompressed,
/*size_hint_in_dip=*/1, /*allow_placeholder_icon=*/false,
base::BindOnce([](int* counter, int delta,
apps::IconValuePtr icon) { *counter += delta; },
counter, delta));
}
};
TEST_F(AppsIconCoalescerTest, CallBackImmediately) {
FakeIconLoader fake;
fake.SetCallBackImmediately(true);
apps::IconCoalescer coalescer(&fake);
int counter = 0;
UniqueReleaser releaser = LoadIcon(&coalescer, "the_app_id", &counter, 1000);
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(1000, counter);
EXPECT_EQ(1, fake.NumPendingReleases());
releaser.reset();
EXPECT_EQ(0, fake.NumPendingReleases());
}
TEST_F(AppsIconCoalescerTest, CallBackDelayedAndAfterRelease) {
FakeIconLoader fake;
apps::IconCoalescer coalescer(&fake);
int counter = 0;
UniqueReleaser releaser = LoadIcon(&coalescer, "the_app_id", &counter, 1000);
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(0, counter);
EXPECT_EQ(1, fake.NumPendingReleases());
fake.CallBack("the_app_id");
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(1000, counter);
EXPECT_EQ(1, fake.NumPendingReleases());
releaser.reset();
EXPECT_EQ(0, fake.NumPendingReleases());
}
TEST_F(AppsIconCoalescerTest, CallBackDelayedAndBeforeRelease) {
FakeIconLoader fake;
apps::IconCoalescer coalescer(&fake);
int counter = 0;
UniqueReleaser releaser = LoadIcon(&coalescer, "the_app_id", &counter, 1000);
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(0, counter);
EXPECT_EQ(1, fake.NumPendingReleases());
// Even though we release our claim on the outer IconLoader::Releaser (from
// the IconCoalescer), the inner IconLoader::Releaser (from the
// FakeIconLoader) isn't released while the callback's still pending.
releaser.reset();
EXPECT_EQ(1, fake.NumPendingReleases());
fake.CallBack("the_app_id");
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(1000, counter);
EXPECT_EQ(0, fake.NumPendingReleases());
}
TEST_F(AppsIconCoalescerTest, MultipleAppIDs) {
FakeIconLoader fake;
apps::IconCoalescer coalescer(&fake);
int ant_counter = 0;
int bat_counter = 0;
int cat_counter = 0;
int dog_counter = 0;
int emu_counter = 0;
UniqueReleaser a1 = LoadIcon(&coalescer, "ant", &ant_counter, 10);
UniqueReleaser b1 = LoadIcon(&coalescer, "bat", &bat_counter, 100);
UniqueReleaser c1 = LoadIcon(&coalescer, "cat", &cat_counter, 1000);
EXPECT_EQ(3, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(3, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(0, ant_counter);
EXPECT_EQ(0, bat_counter);
EXPECT_EQ(0, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(0, emu_counter);
UniqueReleaser c2 = LoadIcon(&coalescer, "cat", &cat_counter, 2000);
UniqueReleaser d1 = LoadIcon(&coalescer, "dog", &dog_counter, 10000);
UniqueReleaser c4 = LoadIcon(&coalescer, "cat", &cat_counter, 4000);
UniqueReleaser b2 = LoadIcon(&coalescer, "bat", &bat_counter, 200);
EXPECT_EQ(4, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(4, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(0, ant_counter);
EXPECT_EQ(0, bat_counter);
EXPECT_EQ(0, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(0, emu_counter);
fake.CallBack("ant");
fake.CallBack("cat");
EXPECT_EQ(4, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(2, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(2, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(10, ant_counter);
EXPECT_EQ(0, bat_counter);
EXPECT_EQ(7000, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(0, emu_counter);
UniqueReleaser a4 = LoadIcon(&coalescer, "ant", &ant_counter, 40);
UniqueReleaser b4 = LoadIcon(&coalescer, "bat", &bat_counter, 400);
UniqueReleaser a2 = LoadIcon(&coalescer, "ant", &ant_counter, 20);
EXPECT_EQ(5, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(2, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(3, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(10, ant_counter);
EXPECT_EQ(0, bat_counter);
EXPECT_EQ(7000, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(0, emu_counter);
// 5 NumLoadIconFromIconKeyCalls, without any releases, means 5
// NumPendingReleases: {a1}, {a2, a4}, {b*}, {c*} and {d*}. The "a"s are two
// different groups, as they are separated by a `fake.Callback("ant")` line.
EXPECT_EQ(5, fake.NumPendingReleases());
fake.CallBack("ant");
// We treat the "b"s differently, releasing them (resetting the
// UniqueReleaser, aka unique_ptr<IconLoader::Releaser>) *before* (not
// *after) we tickle fake.CallBack. Still, the inner-most releaser isn't let
// go until both (1) all outer releasers are dropped and (2) the inner
// IconLoader has actually called back.
EXPECT_EQ(5, fake.NumPendingReleases());
b1.reset();
b2.reset();
b4.reset();
EXPECT_EQ(5, fake.NumPendingReleases());
fake.CallBack("bat");
EXPECT_EQ(4, fake.NumPendingReleases());
EXPECT_EQ(5, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(4, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(70, ant_counter);
EXPECT_EQ(700, bat_counter);
EXPECT_EQ(7000, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(0, emu_counter);
// Even though we configure the fake to call back immediately, the next two
// "dog" calls still wait for the previous (pending) "dog" call. The next
// three "emu" calls lead to three (immediate) calls on the fake.
fake.SetCallBackImmediately(true);
EXPECT_EQ(4, fake.NumPendingReleases());
UniqueReleaser d2 = LoadIcon(&coalescer, "dog", &dog_counter, 20000);
UniqueReleaser d4 = LoadIcon(&coalescer, "dog", &dog_counter, 40000);
EXPECT_EQ(4, fake.NumPendingReleases());
UniqueReleaser e1 = LoadIcon(&coalescer, "emu", &emu_counter, 100000);
UniqueReleaser e2 = LoadIcon(&coalescer, "emu", &emu_counter, 200000);
UniqueReleaser e4 = LoadIcon(&coalescer, "emu", &emu_counter, 400000);
EXPECT_EQ(7, fake.NumPendingReleases());
EXPECT_EQ(8, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(7, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(1, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(70, ant_counter);
EXPECT_EQ(700, bat_counter);
EXPECT_EQ(7000, cat_counter);
EXPECT_EQ(0, dog_counter);
EXPECT_EQ(700000, emu_counter);
fake.CallBack("dog");
EXPECT_EQ(8, fake.NumLoadIconFromIconKeyCalls());
EXPECT_EQ(8, fake.NumLoadIconFromIconKeyCallsComplete());
EXPECT_EQ(0, fake.NumLoadIconFromIconKeyCallsPending());
EXPECT_EQ(70, ant_counter);
EXPECT_EQ(700, bat_counter);
EXPECT_EQ(7000, cat_counter);
EXPECT_EQ(70000, dog_counter);
EXPECT_EQ(700000, emu_counter);
// As mentioned above, {a1} and {a2, a4} are different groups.
EXPECT_EQ(7, fake.NumPendingReleases());
a1.reset();
EXPECT_EQ(6, fake.NumPendingReleases());
a2.reset();
EXPECT_EQ(6, fake.NumPendingReleases());
a4.reset();
EXPECT_EQ(5, fake.NumPendingReleases());
// {c*} and {d*} are each one group, but {e1}, {e2} and {e4} are three
// separate groups.
EXPECT_EQ(5, fake.NumPendingReleases());
c1.reset();
EXPECT_EQ(5, fake.NumPendingReleases());
c2.reset();
EXPECT_EQ(5, fake.NumPendingReleases());
c4.reset();
EXPECT_EQ(4, fake.NumPendingReleases());
d1.reset();
EXPECT_EQ(4, fake.NumPendingReleases());
d2.reset();
EXPECT_EQ(4, fake.NumPendingReleases());
d4.reset();
EXPECT_EQ(3, fake.NumPendingReleases());
e1.reset();
EXPECT_EQ(2, fake.NumPendingReleases());
e2.reset();
EXPECT_EQ(1, fake.NumPendingReleases());
e4.reset();
EXPECT_EQ(0, fake.NumPendingReleases());
}
|