1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/services/quarantine/quarantine.h"
#import <ApplicationServices/ApplicationServices.h>
#import <Foundation/Foundation.h>
#include "base/apple/bridging.h"
#include "base/apple/foundation_util.h"
#include "base/apple/scoped_cftyperef.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/run_loop.h"
#include "base/strings/sys_string_conversions.h"
#include "base/test/task_environment.h"
#include "components/services/quarantine/common_mac.h"
#include "components/services/quarantine/test_support.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "url/gurl.h"
namespace quarantine {
namespace {
void CheckQuarantineResult(base::OnceClosure quit_closure,
QuarantineFileResult result,
QuarantineFileResult expected_result) {
EXPECT_EQ(expected_result, result);
std::move(quit_closure).Run();
}
class QuarantineMacTest : public testing::Test {
public:
// The trailing / is intentional and needed to match the
// SanitizeUrlForQuarantine() output.
QuarantineMacTest()
: source_url_("http://www.source.example.com/"),
referrer_url_("http://www.referrer.example.com/") {}
protected:
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_TRUE(
base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &test_file_));
file_url_ = base::apple::FilePathToNSURL(test_file_);
NSDictionary* properties = @{
static_cast<NSString*>(kLSQuarantineAgentBundleIdentifierKey) :
@"com.google.Chrome",
static_cast<NSString*>(kLSQuarantineAgentNameKey) : @"Google Chrome.app",
@"kLSQuarantineIsOwnedByCurrentUserKey" : @(1)
};
NSError* error = nullptr;
bool success = [file_url_ setResourceValue:properties
forKey:NSURLQuarantinePropertiesKey
error:&error];
ASSERT_TRUE(success) << error.localizedDescription;
}
base::test::SingleThreadTaskEnvironment task_environment_;
base::ScopedTempDir temp_dir_;
base::FilePath test_file_;
const GURL source_url_;
const GURL referrer_url_;
__strong NSURL* file_url_;
};
TEST_F(QuarantineMacTest, CheckMetadataSetCorrectly) {
base::RunLoop run_loop;
QuarantineFile(test_file_, source_url_, referrer_url_,
/*request_initiator=*/std::nullopt, "",
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(IsFileQuarantined(test_file_, source_url_, referrer_url_));
}
TEST_F(QuarantineMacTest, SetMetadataMultipleTimes) {
{
base::RunLoop run_loop;
QuarantineFile(
test_file_, source_url_, referrer_url_,
/*request_initiator=*/std::nullopt, "",
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
}
{
base::RunLoop run_loop;
GURL dummy_url("http://www.dummy.example.com");
QuarantineFile(
test_file_, dummy_url, dummy_url,
/*request_initiator=*/std::nullopt, "",
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(IsFileQuarantined(test_file_, source_url_, referrer_url_));
}
}
TEST_F(QuarantineMacTest, IsFileQuarantined_NoFile) {
base::FilePath does_not_exist = temp_dir_.GetPath().AppendASCII("a.jar");
EXPECT_FALSE(IsFileQuarantined(does_not_exist, GURL(), GURL()));
}
TEST_F(QuarantineMacTest, IsFileQuarantined_NoAnnotationsOnFile) {
ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &test_file_));
EXPECT_FALSE(IsFileQuarantined(test_file_, GURL(), GURL()));
}
TEST_F(QuarantineMacTest, IsFileQuarantined_SourceUrlOnly) {
base::RunLoop run_loop;
QuarantineFile(test_file_, source_url_, GURL(),
/*request_initiator=*/std::nullopt, std::string(),
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(IsFileQuarantined(test_file_, source_url_, GURL()));
EXPECT_TRUE(IsFileQuarantined(test_file_, GURL(), GURL()));
EXPECT_TRUE(IsFileQuarantined(test_file_, GURL(), referrer_url_));
}
TEST_F(QuarantineMacTest, IsFileQuarantined_FullMetadata) {
base::RunLoop run_loop;
QuarantineFile(test_file_, source_url_, referrer_url_,
/*request_initiator=*/std::nullopt, std::string(),
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(IsFileQuarantined(test_file_, GURL(), GURL()));
EXPECT_TRUE(IsFileQuarantined(test_file_, source_url_, GURL()));
EXPECT_TRUE(IsFileQuarantined(test_file_, source_url_, referrer_url_));
EXPECT_TRUE(IsFileQuarantined(test_file_, GURL(), referrer_url_));
}
TEST_F(QuarantineMacTest, IsFileQuarantined_Sanitize) {
base::RunLoop run_loop;
GURL host_url{"https://user:pass@example.com/foo/bar?x#y"};
GURL host_url_clean{"https://example.com/foo/bar?x#y"};
GURL referrer_url{"https://user:pass@example.com/foo/index?x#y"};
GURL referrer_url_clean{"https://example.com/foo/index?x#y"};
QuarantineFile(test_file_, host_url, referrer_url,
/*request_initiator=*/std::nullopt, std::string(),
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(
IsFileQuarantined(test_file_, host_url_clean, referrer_url_clean));
}
TEST_F(QuarantineMacTest, IsFileQuarantined_AgentBundleIdentifier) {
base::RunLoop run_loop;
QuarantineFile(test_file_, source_url_, referrer_url_,
/*request_initiator=*/std::nullopt, "",
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
NSDictionary* properties = GetQuarantineProperties(test_file_);
ASSERT_TRUE(properties);
NSMutableDictionary* mutable_properties = [properties mutableCopy];
[mutable_properties
removeObjectForKey:static_cast<NSString*>(
kLSQuarantineAgentBundleIdentifierKey)];
NSError* error = nullptr;
BOOL success = [file_url_ setResourceValue:mutable_properties
forKey:NSURLQuarantinePropertiesKey
error:&error];
ASSERT_TRUE(success) << error.localizedDescription;
EXPECT_FALSE(IsFileQuarantined(test_file_, source_url_, referrer_url_));
}
TEST_F(QuarantineMacTest, NoWhereFromsKeyIfNoURLs) {
base::RunLoop run_loop;
QuarantineFile(test_file_, GURL(), GURL(), /*request_initiator=*/std::nullopt,
std::string(),
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
NSString* file_path = base::apple::FilePathToNSString(test_file_);
ASSERT_NE(nullptr, file_path);
base::apple::ScopedCFTypeRef<MDItemRef> md_item(
MDItemCreate(kCFAllocatorDefault, base::apple::NSToCFPtrCast(file_path)));
if (!md_item) {
// The quarantine code ignores it if adding origin metadata fails. If for
// some reason MDItemCreate fails (which it seems to do on the bots, not
// sure why) just stop on the test.
return;
}
base::apple::ScopedCFTypeRef<CFTypeRef> attr(
MDItemCopyAttribute(md_item.get(), kMDItemWhereFroms));
EXPECT_FALSE(attr);
}
TEST_F(QuarantineMacTest, RequestInitiatorReplacesSourceUrl) {
base::RunLoop run_loop;
QuarantineFile(test_file_, GURL("data://text/html,payload"), referrer_url_,
/*request_initiator=*/
url::Origin::Create(GURL("http://www.source.example.com/")),
"",
base::BindOnce(&CheckQuarantineResult, run_loop.QuitClosure(),
QuarantineFileResult::OK));
run_loop.Run();
EXPECT_TRUE(IsFileQuarantined(
test_file_, GURL("http://www.source.example.com/"), referrer_url_));
}
} // namespace
} // namespace quarantine
|
