File: unzip_unittest.cc

package info (click to toggle)
chromium 139.0.7258.127-2
  • links: PTS, VCS
  • area: main
  • in suites: forky
  • size: 6,122,156 kB
  • sloc: cpp: 35,100,771; ansic: 7,163,530; javascript: 4,103,002; python: 1,436,920; asm: 946,517; xml: 746,709; pascal: 187,653; perl: 88,691; sh: 88,436; objc: 79,953; sql: 51,488; cs: 44,583; fortran: 24,137; makefile: 22,147; tcl: 15,277; php: 13,980; yacc: 8,984; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (446 lines) | stat: -rw-r--r-- 14,819 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/services/unzip/public/cpp/unzip.h"

#include <cstdint>
#include <string_view>
#include <utility>

#include "base/base_paths.h"
#include "base/files/file_enumerator.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/callback_helpers.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "components/services/unzip/unzipper_impl.h"
#include "mojo/public/cpp/bindings/receiver_set.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace unzip {
namespace {

base::FilePath GetArchivePath(std::string_view archive_name) {
  base::FilePath path;
  EXPECT_TRUE(base::PathService::Get(base::DIR_SRC_TEST_DATA_ROOT, &path));
  return path.AppendASCII("components")
      .AppendASCII("test")
      .AppendASCII("data")
      .AppendASCII("unzip_service")
      .AppendASCII(archive_name);
}

// Counts the number of files under |dir|. If |some_files_empty| is not null,
// sets it to true if at least one of the files is empty.
int CountFiles(const base::FilePath& dir, bool* some_files_empty = nullptr) {
  int file_count = 0;
  base::FileEnumerator file_enumerator(dir, /*recursive=*/true,
                                       base::FileEnumerator::FILES);
  for (base::FilePath path = file_enumerator.Next(); !path.empty();
       path = file_enumerator.Next()) {
    std::optional<int64_t> file_size = base::GetFileSize(path);

    if (some_files_empty != nullptr && file_size.has_value() &&
        file_size.value() == 0) {
      *some_files_empty = true;
      some_files_empty = nullptr;  // So we don't check files again.
    }

    file_count++;
  }

  return file_count;
}

class UnzipTest : public testing::Test {
 public:
  UnzipTest() = default;
  ~UnzipTest() override = default;

  // Unzips |zip_file| into |output_dir| and returns true if the unzip was
  // successful. Only extract files for which |filter_callback| returns true, if
  // it is provided.
  bool DoUnzip(const base::FilePath& zip_file,
               const base::FilePath& output_dir,
               UnzipFilterCallback filter_callback = unzip::AllContents()) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());

    base::RunLoop run_loop;
    bool result = false;

    Unzip(std::move(unzipper), zip_file, output_dir,
          unzip::mojom::UnzipOptions::New(), std::move(filter_callback),
          base::DoNothing(), base::BindLambdaForTesting([&](bool success) {
            result = success;
            run_loop.QuitClosure().Run();
          }));

    run_loop.Run();
    return result;
  }

  // Unzips |zip_file| into |output_dir| and returns true if the unzip was
  // successful. |options| hosts parameters for the unpack.
  bool DoUnzipWithOptions(const base::FilePath& zip_file,
                          const base::FilePath& output_dir,
                          mojom::UnzipOptionsPtr options) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());

    base::RunLoop run_loop;
    bool result = false;

    Unzip(std::move(unzipper), zip_file, output_dir, std::move(options),
          AllContents(), base::BindLambdaForTesting([&](uint64_t) {}),
          base::BindLambdaForTesting([&](bool success) {
            result = success;
            run_loop.QuitClosure().Run();
          }));

    run_loop.Run();
    return result;
  }

  Encoding DoDetectEncoding(const base::FilePath& zip_file) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());

    base::RunLoop run_loop;
    Encoding result = UNKNOWN_ENCODING;

    DetectEncodingCallback result_callback =
        base::BindLambdaForTesting([&](const Encoding encoding) {
          result = encoding;
          run_loop.QuitClosure().Run();
        });

    DetectEncoding(std::move(unzipper), zip_file, std::move(result_callback));
    run_loop.Run();
    return result;
  }

  mojom::Info DoGetExtractedInfo(const base::FilePath& zip_file) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());

    base::RunLoop run_loop;
    mojom::Info result;

    GetExtractedInfoCallback result_callback =
        base::BindLambdaForTesting([&](mojom::InfoPtr info) {
          result = *info;
          run_loop.QuitClosure().Run();
        });

    GetExtractedInfo(std::move(unzipper), zip_file, std::move(result_callback));
    run_loop.Run();
    return result;
  }

  uint64_t DoGetProgressSize(const base::FilePath& zip_file,
                             const base::FilePath& output_dir) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());

    base::RunLoop run_loop;
    uint64_t bytes = 0;

    Unzip(std::move(unzipper), zip_file, output_dir,
          unzip::mojom::UnzipOptions::New("auto", ""), AllContents(),
          base::BindLambdaForTesting([&](uint64_t written_bytes) {
            bytes = written_bytes;
            run_loop.QuitClosure().Run();
          }),
          base::BindLambdaForTesting(
              [&](bool) { run_loop.QuitClosure().Run(); }));

    run_loop.Run();
    return bytes;
  }

  bool DoDecodeXz(const base::FilePath& in_file,
                  const base::FilePath& out_file) {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());
    bool result = false;
    base::RunLoop run_loop;
    DecodeXz(std::move(unzipper), in_file, out_file,
             base::BindLambdaForTesting([&](bool success) {
               result = success;
               run_loop.Quit();
             }));
    run_loop.Run();
    return result;
  }

 protected:
  void SetUp() override {
    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
    unzip_dir_ = temp_dir_.GetPath();
  }

  base::test::TaskEnvironment task_environment_;

  base::ScopedTempDir temp_dir_;
  base::FilePath unzip_dir_;

  unzip::UnzipperImpl unzipper_;
  mojo::ReceiverSet<mojom::Unzipper> receivers_;
};

TEST_F(UnzipTest, UnzipAbsentArchive) {
  EXPECT_FALSE(DoUnzip(GetArchivePath("absent_archive.zip"), unzip_dir_));

  // No files should have been extracted.
  EXPECT_EQ(0, CountFiles(unzip_dir_));
}

TEST_F(UnzipTest, UnzipBadArchive) {
  EXPECT_FALSE(DoUnzip(GetArchivePath("bad_archive.zip"), unzip_dir_));

  // No files should have been extracted.
  EXPECT_EQ(0, CountFiles(unzip_dir_));
}

TEST_F(UnzipTest, UnzipWrongCrc) {
  EXPECT_FALSE(DoUnzip(GetArchivePath("Wrong CRC.zip"), unzip_dir_));

  // No files should have been extracted.
  EXPECT_EQ(0, CountFiles(unzip_dir_));
}

TEST_F(UnzipTest, UnzipGoodArchive) {
  EXPECT_TRUE(DoUnzip(GetArchivePath("good_archive.zip"), unzip_dir_));

  // Sanity check that the right number of files have been extracted and that
  // they are not empty.
  bool some_files_empty = false;
  EXPECT_EQ(8, CountFiles(unzip_dir_, &some_files_empty));
  EXPECT_FALSE(some_files_empty);
}

TEST_F(UnzipTest, UnzipGoodArchiveWithExtraBytes) {
  EXPECT_TRUE(DoUnzip(GetArchivePath("good_archive_prefixed.zip"), unzip_dir_));
  bool some_files_empty = false;
  EXPECT_EQ(8, CountFiles(unzip_dir_, &some_files_empty));
  EXPECT_FALSE(some_files_empty);
}

TEST_F(UnzipTest, UnzipBadArchiveHang) {
  // Don't hang trying to open this bad archive.
  EXPECT_FALSE(DoUnzip(GetArchivePath("bad_archive_hang.zip"), unzip_dir_));
  EXPECT_EQ(0, CountFiles(unzip_dir_));
}

TEST_F(UnzipTest, UnzipZip64) {
  EXPECT_TRUE(DoUnzip(GetArchivePath("good_zip64.zip"), unzip_dir_));
  bool some_files_empty = false;
  EXPECT_EQ(1, CountFiles(unzip_dir_, &some_files_empty));
  EXPECT_FALSE(some_files_empty);
}

TEST_F(UnzipTest, UnzipZip64WithExtraBytes) {
  EXPECT_TRUE(DoUnzip(GetArchivePath("good_zip64_prefixed.zip"), unzip_dir_));
  bool some_files_empty = false;
  EXPECT_EQ(1, CountFiles(unzip_dir_, &some_files_empty));
  EXPECT_FALSE(some_files_empty);
}

TEST_F(UnzipTest, UnzipWithFilter) {
  EXPECT_TRUE(DoUnzip(GetArchivePath("good_archive.zip"), unzip_dir_,
                      base::BindRepeating([](const base::FilePath& path) {
                        return path.MatchesExtension(FILE_PATH_LITERAL(".txt"));
                      })));

  // It should only have kept the 2 text files from the archive.
  bool some_files_empty = false;
  EXPECT_EQ(2, CountFiles(unzip_dir_, &some_files_empty));
  EXPECT_FALSE(some_files_empty);
}

// Checks that the Unzipper service does not overwrite an existing file.
TEST_F(UnzipTest, DuplicatedNames) {
  EXPECT_FALSE(DoUnzip(GetArchivePath("Duplicate Filenames.zip"), unzip_dir_));

  // Check that the first file was correctly extracted.
  std::string content;
  EXPECT_TRUE(
      base::ReadFileToString(unzip_dir_.AppendASCII("Simple.txt"), &content));
  EXPECT_EQ("Simple 1\n", content);

  // Check that no other file was extracted.
  EXPECT_EQ(1, CountFiles(unzip_dir_));
}

TEST_F(UnzipTest, DetectEncodingAbsentArchive) {
  EXPECT_EQ(UNKNOWN_ENCODING,
            DoDetectEncoding(GetArchivePath("absent_archive.zip")));
}

TEST_F(UnzipTest, DetectEncodingBadArchive) {
  EXPECT_EQ(UNKNOWN_ENCODING,
            DoDetectEncoding(GetArchivePath("bad_archive.zip")));
}

TEST_F(UnzipTest, DetectEncodingAscii) {
  EXPECT_EQ(Encoding::ASCII_7BIT,
            DoDetectEncoding(GetArchivePath("good_archive.zip")));
}

// See https://crbug.com/903664
TEST_F(UnzipTest, DetectEncodingUtf8) {
  EXPECT_EQ(Encoding::UTF8,
            DoDetectEncoding(GetArchivePath("UTF8 (Bug 903664).zip")));
}

// See https://crbug.com/1287893
TEST_F(UnzipTest, DetectEncodingSjis) {
  for (const std::string_view name : {
           "SJIS 00.zip",
           "SJIS 01.zip",
           "SJIS 02.zip",
           "SJIS 03.zip",
           "SJIS 04.zip",
           "SJIS 05.zip",
           "SJIS 06.zip",
           "SJIS 07.zip",
           "SJIS 08.zip",
           "SJIS 09.zip",
           "SJIS 10.zip",
           "SJIS 11.zip",
           "SJIS 12.zip",
           "SJIS 13.zip",
       }) {
    EXPECT_EQ(Encoding::JAPANESE_SHIFT_JIS,
              DoDetectEncoding(GetArchivePath(name)));
  }
}

TEST_F(UnzipTest, GetExtractedSize) {
  mojom::Info result = DoGetExtractedInfo(GetArchivePath("good_archive.zip"));
  EXPECT_TRUE(result.size_is_valid);
  EXPECT_EQ(137, static_cast<int64_t>(result.size));
}

TEST_F(UnzipTest, GetExtractedSizeBrokenArchive) {
  mojom::Info result = DoGetExtractedInfo(GetArchivePath("bad_archive.zip"));
  EXPECT_FALSE(result.size_is_valid);
}

TEST_F(UnzipTest, UnzipWithOptions) {
  unzip::mojom::UnzipOptionsPtr options =
      unzip::mojom::UnzipOptions::New("auto", "");
  EXPECT_TRUE(DoUnzipWithOptions(GetArchivePath("good_archive.zip"), unzip_dir_,
                                 std::move(options)));

  // 8 files should have been extracted.
  bool some_files_empty = false;
  EXPECT_EQ(8, CountFiles(unzip_dir_, &some_files_empty));
}

TEST_F(UnzipTest, GetExtractedProgressSize) {
  uint64_t result =
      DoGetProgressSize(GetArchivePath("good_archive.zip"), unzip_dir_);
  // Check: first file extracted is 23 bytes long.
  EXPECT_EQ(23ul, result);
}

TEST_F(UnzipTest, ExtractEncrypted) {
  mojom::Info result =
      DoGetExtractedInfo(GetArchivePath("encrypted_archive.zip"));
  EXPECT_TRUE(result.is_encrypted);

  unzip::mojom::UnzipOptionsPtr options =
      unzip::mojom::UnzipOptions::New("auto", "fake_password");
  EXPECT_TRUE(DoUnzipWithOptions(GetArchivePath("encrypted_archive.zip"),
                                 unzip_dir_, std::move(options)));

  // Check: 5 files should have been extracted.
  bool some_files_empty = false;
  EXPECT_EQ(5, CountFiles(unzip_dir_, &some_files_empty));
}

TEST_F(UnzipTest, DetectAESArchive) {
  mojom::Info result =
      DoGetExtractedInfo(GetArchivePath("DifferentEncryptions.zip"));
  EXPECT_TRUE(result.uses_aes_encryption);
}

TEST_F(UnzipTest, DecodeXz_Success) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  ASSERT_TRUE(DoDecodeXz(GetArchivePath("file1.xz"), out));
  EXPECT_EQ(ReadFileToBytes(out), ReadFileToBytes(GetArchivePath("file1")));
  ASSERT_TRUE(base::DeleteFile(out));
  ASSERT_TRUE(DoDecodeXz(GetArchivePath("bd646.xz"), out));
  EXPECT_EQ(ReadFileToBytes(out), ReadFileToBytes(GetArchivePath("bd646")));
}

TEST_F(UnzipTest, DecodeXz_DontReplaceExistingOutfile) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  ASSERT_TRUE(base::WriteFile(out, "data"));
  ASSERT_FALSE(DoDecodeXz(GetArchivePath("file1.xz"), out));
  std::string out_contents;
  ASSERT_TRUE(base::ReadFileToString(out, &out_contents));
  EXPECT_EQ(out_contents, "data");
}

TEST_F(UnzipTest, DecodeXz_MissingInput) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  EXPECT_FALSE(DoDecodeXz(GetArchivePath("doesnotexist"), out));
  EXPECT_FALSE(base::PathExists(out));
}

TEST_F(UnzipTest, DecodeXz_BadFormat) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  EXPECT_FALSE(DoDecodeXz(GetArchivePath("file1"), out));
  EXPECT_FALSE(base::PathExists(out));
}

TEST_F(UnzipTest, DecodeXz_Cancel) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  base::FilePath in = GetArchivePath("file1.xz");
  mojo::PendingRemote<mojom::Unzipper> unzipper;
  receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());
  base::RunLoop run_loop;
  DecodeXz(std::move(unzipper), in, out,
           base::BindLambdaForTesting([&](bool success) {
             EXPECT_FALSE(success);
             run_loop.Quit();
           }))
      .Run();
  run_loop.Run();
  EXPECT_FALSE(base::PathExists(out));
}

TEST_F(UnzipTest, DecodeXz_CancelAfterReturn) {
  base::FilePath out = unzip_dir_.AppendASCII("out");
  base::FilePath in = GetArchivePath("file1.xz");
  base::OnceClosure cancellation;
  int call_count = 0;
  {
    mojo::PendingRemote<mojom::Unzipper> unzipper;
    receivers_.Add(&unzipper_, unzipper.InitWithNewPipeAndPassReceiver());
    base::RunLoop run_loop;
    cancellation = DecodeXz(std::move(unzipper), in, out,
                            base::BindLambdaForTesting([&](bool success) {
                              EXPECT_TRUE(success);
                              ++call_count;
                              run_loop.Quit();
                            }));
    run_loop.Run();
    EXPECT_EQ(call_count, 1);
  }
  std::move(cancellation).Run();
  base::RunLoop run_loop;
  run_loop.RunUntilIdle();
  EXPECT_EQ(call_count, 1);
}

}  // namespace
}  // namespace unzip