1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "components/webui/flags/flags_state.h"
#include <algorithm>
#include <memory>
#include <string_view>
#include <utility>
#include "base/containers/contains.h"
#include "base/containers/span.h"
#include "base/feature_list.h"
#include "base/feature_list_buildflags.h"
#include "base/functional/callback.h"
#include "base/logging.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/field_trial_params.h"
#include "base/stl_util.h"
#include "base/strings/strcat.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_tokenizer.h"
#include "base/strings/string_util.h"
#include "base/strings/to_string.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "build/build_config.h"
#include "components/variations/field_trial_config/field_trial_util.h"
#include "components/variations/variations_associated_data.h"
#include "components/variations/variations_switches.h"
#include "components/webui/flags/feature_entry.h"
#include "components/webui/flags/flags_storage.h"
#include "components/webui/flags/flags_ui_switches.h"
#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
#include "url/origin.h"
#if BUILDFLAG(IS_ANDROID)
#include "components/cached_flags/android/jni_delegate_impl.h"
#endif
namespace flags_ui {
namespace internal {
const char kTrialGroupAboutFlags[] = "AboutFlags";
} // namespace internal
namespace {
// Separator used for origin list values. The list of origins provided from
// the command line or from the text input in chrome://flags are concatenated
// using this separator. The value is then appended as a command line switch
// and saved in the dictionary pref (kAboutFlagsOriginLists).
// E.g. --isolate_origins=http://example1.net,http://example2.net
const char kOriginListValueSeparator[] = ",";
const struct {
unsigned bit;
const char* const name;
} kBitsToOs[] = {
{kOsMac, "Mac"}, {kOsWin, "Windows"},
{kOsLinux, "Linux"}, {kOsCrOS, "ChromeOS"},
{kOsAndroid, "Android"}, {kOsCrOSOwnerOnly, "ChromeOS (owner only)"},
{kOsIos, "iOS"}, {kOsFuchsia, "Fuchsia"},
};
// Adds a |StringValue| to |list| for each platform where |bitmask| indicates
// whether the entry is available on that platform.
void AddOsStrings(unsigned bitmask, base::Value::List* list) {
for (const auto& entry : kBitsToOs) {
if (bitmask & entry.bit) {
list->Append(entry.name);
}
}
}
// Returns true if none of this entry's options have been enabled.
bool IsDefaultValue(const FeatureEntry& entry,
const std::set<std::string>& enabled_entries) {
switch (entry.type) {
case FeatureEntry::SINGLE_VALUE:
case FeatureEntry::SINGLE_DISABLE_VALUE:
case FeatureEntry::ORIGIN_LIST_VALUE:
case FeatureEntry::STRING_VALUE:
return enabled_entries.count(entry.internal_name) == 0;
case FeatureEntry::MULTI_VALUE:
case FeatureEntry::ENABLE_DISABLE_VALUE:
case FeatureEntry::FEATURE_VALUE:
case FeatureEntry::FEATURE_WITH_PARAMS_VALUE:
#if BUILDFLAG(IS_CHROMEOS)
case FeatureEntry::PLATFORM_FEATURE_NAME_VALUE:
case FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE:
#endif // BUILDFLAG(IS_CHROMEOS)
for (int i = 0; i < entry.NumOptions(); ++i) {
if (enabled_entries.count(entry.NameForOption(i)) > 0) {
return false;
}
}
return true;
}
NOTREACHED();
}
// Returns the Value::List representing the choice data in the specified entry.
base::Value::List CreateOptionsData(
const FeatureEntry& entry,
const std::set<std::string>& enabled_entries) {
DCHECK(entry.type == FeatureEntry::MULTI_VALUE ||
entry.type == FeatureEntry::ENABLE_DISABLE_VALUE ||
entry.type == FeatureEntry::FEATURE_VALUE ||
entry.type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE
#if BUILDFLAG(IS_CHROMEOS)
|| entry.type == FeatureEntry::PLATFORM_FEATURE_NAME_VALUE ||
entry.type == FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE
#endif // BUILDFLAG(IS_CHROMEOS)
);
base::Value::List result;
for (int i = 0; i < entry.NumOptions(); ++i) {
base::Value::Dict dict;
const std::string name = entry.NameForOption(i);
dict.Set("internal_name", name);
dict.Set("description", entry.DescriptionForOption(i));
dict.Set("selected", enabled_entries.count(name) > 0);
result.Append(std::move(dict));
}
return result;
}
// Registers variation parameters specified by |feature_variation_params| for
// the field trial named |feature_trial_name|, unless a group for this trial has
// already been created (e.g. via command-line switches that take precedence
// over about:flags). In the trial, the function creates a new constant group
// with the given |trail_group| name.
base::FieldTrial* RegisterFeatureVariationParameters(
const std::string& feature_trial_name,
const std::map<std::string, std::string>& feature_variation_params,
const std::string& trial_group) {
bool success = base::AssociateFieldTrialParams(
feature_trial_name, trial_group, feature_variation_params);
if (!success) {
return nullptr;
}
// Successful association also means that no group is created and selected
// for the trial, yet. Thus, create the trial to select the group. This way,
// the parameters cannot get overwritten in later phases (such as from the
// server).
base::FieldTrial* trial =
base::FieldTrialList::CreateFieldTrial(feature_trial_name, trial_group);
if (!trial) {
DLOG(WARNING) << "Could not create the trial " << feature_trial_name
<< " with group " << trial_group;
}
return trial;
}
// Returns true if |value| is safe to include in a command line string in the
// form of --flag=value.
bool IsSafeValue(const std::string& value) {
// Punctuation characters at the end ("-", ".", ":", "/") are allowed because
// origins can contain those (e.g. http://example.test). Comma is allowed
// because it's used as the separator character.
static const char kAllowedChars[] =
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
"abcdefghijklmnopqrstuvwxyz"
"0123456789"
"-.:/,";
return value.find_first_not_of(kAllowedChars) == std::string::npos;
}
// Sanitizes |value| which contains a list of origins separated by whitespace
// and/or comma. The sanitized vector of origins is intended to be added to the
// command line, so this is a security critical operation: The sanitized value
// must have no whitespaces, each individual origin must be separated by a
// comma, and each origin must represent a url::Origin(). The list is not
// reordered.
std::vector<std::string> TokenizeOriginList(const std::string& value) {
const std::string input = base::CollapseWhitespaceASCII(value, false);
// Allow both space and comma as separators.
const std::string delimiters = " ,";
base::StringTokenizer tokenizer(input, delimiters);
std::vector<std::string> origin_strings;
while (tokenizer.GetNext()) {
std::string_view token = tokenizer.token_piece();
DCHECK(!token.empty());
const GURL url(token);
if (!url.is_valid() ||
(!url.SchemeIsHTTPOrHTTPS() && !url.SchemeIsWSOrWSS())) {
continue;
}
const std::string origin = url::Origin::Create(url).Serialize();
if (!IsSafeValue(origin)) {
continue;
}
origin_strings.push_back(origin);
}
return origin_strings;
}
// Combines the origin lists contained in |value1| and |value2| separated by
// commas. The lists are concatenated, with invalid or duplicate origins
// removed.
std::string CombineAndSanitizeOriginLists(const std::string& value1,
const std::string& value2) {
std::set<std::string> seen_origins;
std::vector<std::string> origin_vector;
for (const std::string& list : {value1, value2}) {
for (const std::string& origin : TokenizeOriginList(list)) {
if (!base::Contains(seen_origins, origin)) {
origin_vector.push_back(origin);
seen_origins.insert(origin);
}
}
}
const std::string result =
base::JoinString(origin_vector, kOriginListValueSeparator);
CHECK(IsSafeValue(result));
return result;
}
// Returns the sanitized combined origin list by concatenating the command line
// and the pref values. Invalid or duplicate origins are dropped.
std::string GetCombinedOriginListValue(const FlagsStorage& flags_storage,
const base::CommandLine& command_line,
const std::string& internal_entry_name,
const std::string& command_line_switch) {
const std::string existing_value =
command_line.GetSwitchValueASCII(command_line_switch);
const std::string new_value =
flags_storage.GetOriginListFlag(internal_entry_name);
return CombineAndSanitizeOriginLists(existing_value, new_value);
}
std::string GetCombinedStringValue(const FlagsStorage& flags_storage,
const base::CommandLine& command_line,
const std::string& internal_entry_name,
const std::string& command_line_switch) {
const std::string existing_value =
command_line.GetSwitchValueASCII(command_line_switch);
const std::string new_value =
flags_storage.GetStringFlag(internal_entry_name);
if (new_value.empty()) {
return existing_value;
}
return new_value;
}
#if BUILDFLAG(IS_CHROMEOS)
// Removes the specified command line switch (if present).
void RemoveCommandLineSwitch(base::CommandLine* current_cl,
const std::string& switch_to_remove) {
base::CommandLine new_cl(current_cl->GetProgram());
const base::CommandLine::SwitchMap switches = current_cl->GetSwitches();
for (const auto& it : switches) {
const auto& switch_name = it.first;
const auto& switch_value = it.second;
if (switch_name != switch_to_remove) {
if (switch_value.empty()) {
new_cl.AppendSwitch(switch_name);
} else {
new_cl.AppendSwitchNative(switch_name, switch_value);
}
}
}
*current_cl = new_cl;
}
// ChromeOS does not call ConvertFlagsToSwitches on startup (see
// ChromeFeatureListCreator::ConvertFlagsToSwitches() for details) so the
// command line cannot be updated using pref values. Instead, this method
// modifies it on the fly when the user makes a change.
void DidModifyOriginListFlag(const FlagsStorage& flags_storage,
const FeatureEntry& entry) {
base::CommandLine* current_cl = base::CommandLine::ForCurrentProcess();
const std::string new_value = GetCombinedOriginListValue(
flags_storage, *current_cl, entry.internal_name,
entry.switches.command_line_switch);
RemoveCommandLineSwitch(current_cl, entry.switches.command_line_switch);
const std::string sanitized =
CombineAndSanitizeOriginLists(std::string(), new_value);
current_cl->AppendSwitchASCII(entry.switches.command_line_switch, sanitized);
}
// ChromeOS does not call ConvertFlagsToSwitches on startup (see
// ChromeFeatureListCreator::ConvertFlagsToSwitches() for details) so the
// command line cannot be updated using pref values. Instead, this method
// modifies it on the fly when the user makes a change.
void DidModifyStringFlag(const FlagsStorage& flags_storage,
const FeatureEntry& entry) {
base::CommandLine* current_cl = base::CommandLine::ForCurrentProcess();
const std::string new_value =
GetCombinedStringValue(flags_storage, *current_cl, entry.internal_name,
entry.switches.command_line_switch);
RemoveCommandLineSwitch(current_cl, entry.switches.command_line_switch);
current_cl->AppendSwitchASCII(entry.switches.command_line_switch, new_value);
}
#endif
} // namespace
struct FlagsState::SwitchEntry {
// Corresponding base::Feature to toggle.
std::string feature_name;
// If |feature_name| is not empty, the state (enable/disabled) to set.
bool feature_state;
// The name of the switch to add.
std::string switch_name;
// If |switch_name| is not empty, the value of the switch to set.
std::string switch_value;
// If |variation_id| is not empty, variation id value to set.
// In the format of VariationsIdsProvider::ForceVariationIds().
std::string variation_id;
SwitchEntry() : feature_state(false) {}
};
bool FlagsState::Delegate::ShouldExcludeFlag(const FlagsStorage* state,
const FeatureEntry& entry) {
return false;
}
FlagsState::Delegate::Delegate() = default;
FlagsState::Delegate::~Delegate() = default;
FlagsState::FlagsState(base::span<const FeatureEntry> feature_entries,
FlagsState::Delegate* delegate)
: feature_entries_(feature_entries),
needs_restart_(false),
delegate_(delegate)
#if BUILDFLAG(IS_ANDROID)
,
jni_delegate_(std::make_unique<cached_flags::JniDelegateImpl>())
#endif
{
}
FlagsState::~FlagsState() = default;
void FlagsState::ConvertFlagsToSwitches(
FlagsStorage* flags_storage,
base::CommandLine* command_line,
SentinelsMode sentinels,
const char* enable_features_flag_name,
const char* disable_features_flag_name) {
std::set<std::string> enabled_entries;
std::map<std::string, SwitchEntry> name_to_switch_map;
GenerateFlagsToSwitchesMapping(flags_storage, *command_line, &enabled_entries,
&name_to_switch_map);
AddSwitchesToCommandLine(enabled_entries, name_to_switch_map, sentinels,
command_line, enable_features_flag_name,
disable_features_flag_name);
}
void FlagsState::GetSwitchesAndFeaturesFromFlags(
FlagsStorage* flags_storage,
std::set<std::string>* switches,
std::set<std::string>* features,
std::set<std::string>* variation_ids) const {
std::set<std::string> enabled_entries;
std::map<std::string, SwitchEntry> name_to_switch_map;
GenerateFlagsToSwitchesMapping(flags_storage,
*base::CommandLine::ForCurrentProcess(),
&enabled_entries, &name_to_switch_map);
for (const std::string& entry_name : enabled_entries) {
const auto& entry_it = name_to_switch_map.find(entry_name);
CHECK(entry_it != name_to_switch_map.end());
const SwitchEntry& entry = entry_it->second;
if (!entry.switch_name.empty()) {
switches->insert("--" + entry.switch_name);
}
if (!entry.feature_name.empty()) {
if (entry.feature_state) {
features->insert(entry.feature_name + ":enabled");
} else {
features->insert(entry.feature_name + ":disabled");
}
if (!entry.variation_id.empty()) {
variation_ids->insert(entry.variation_id);
}
}
}
}
bool FlagsState::IsRestartNeededToCommitChanges() {
return needs_restart_;
}
void FlagsState::SetFeatureEntryEnabled(FlagsStorage* flags_storage,
const std::string& internal_name,
bool enable) {
size_t at_index = internal_name.find(testing::kMultiSeparator);
if (at_index != std::string::npos) {
DCHECK(enable);
// We're being asked to enable a multi-choice entry. Disable the
// currently selected choice.
DCHECK_NE(at_index, 0u);
const std::string entry_name = internal_name.substr(0, at_index);
SetFeatureEntryEnabled(flags_storage, entry_name, false);
// And enable the new choice, if it is not the default first choice.
if (internal_name != entry_name + "@0") {
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
std::set<std::string> prev_enabled_entries(enabled_entries);
needs_restart_ |= enabled_entries.insert(internal_name).second;
SetFlags(flags_storage, enabled_entries, prev_enabled_entries);
}
return;
}
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
std::set<std::string> prev_enabled_entries(enabled_entries);
const FeatureEntry* e = FindFeatureEntryByName(internal_name);
DCHECK(e);
if (e->type == FeatureEntry::SINGLE_VALUE ||
e->type == FeatureEntry::ORIGIN_LIST_VALUE ||
e->type == FeatureEntry::STRING_VALUE) {
if (enable) {
needs_restart_ |= enabled_entries.insert(internal_name).second;
} else {
needs_restart_ |= (enabled_entries.erase(internal_name) > 0);
}
#if BUILDFLAG(IS_CHROMEOS)
// If a string or origin list was enabled or disabled, update the command
// line flag.
if (enable) {
if (e->type == FeatureEntry::ORIGIN_LIST_VALUE) {
DidModifyOriginListFlag(*flags_storage, *e);
} else if (e->type == FeatureEntry::STRING_VALUE) {
DidModifyStringFlag(*flags_storage, *e);
}
}
#endif
} else if (e->type == FeatureEntry::SINGLE_DISABLE_VALUE) {
if (!enable) {
needs_restart_ |= enabled_entries.insert(internal_name).second;
} else {
needs_restart_ |= (enabled_entries.erase(internal_name) > 0);
}
} else {
if (enable) {
// Enable the first choice.
needs_restart_ |= enabled_entries.insert(e->NameForOption(0)).second;
} else {
// Find the currently enabled choice and disable it.
for (int i = 0; i < e->NumOptions(); ++i) {
std::string choice_name = e->NameForOption(i);
if (enabled_entries.find(choice_name) != enabled_entries.end()) {
needs_restart_ = true;
enabled_entries.erase(choice_name);
// Continue on just in case there's a bug and more than one
// entry for this choice was enabled.
}
}
}
}
SetFlags(flags_storage, enabled_entries, prev_enabled_entries);
}
void FlagsState::SetOriginListFlag(const std::string& internal_name,
const std::string& value,
FlagsStorage* flags_storage) {
const std::string new_value =
CombineAndSanitizeOriginLists(std::string(), value);
flags_storage->SetOriginListFlag(internal_name, new_value);
#if BUILDFLAG(IS_CHROMEOS)
const FeatureEntry* entry = FindFeatureEntryByName(internal_name);
DCHECK(entry);
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
const bool enabled = base::Contains(enabled_entries, entry->internal_name);
if (enabled) {
DidModifyOriginListFlag(*flags_storage, *entry);
}
#endif
}
void FlagsState::SetStringFlag(const std::string& internal_name,
const std::string& value,
FlagsStorage* flags_storage) {
flags_storage->SetStringFlag(internal_name, value);
#if BUILDFLAG(IS_CHROMEOS)
const FeatureEntry* entry = FindFeatureEntryByName(internal_name);
DCHECK(entry);
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
const bool enabled = base::Contains(enabled_entries, entry->internal_name);
if (enabled) {
DidModifyStringFlag(*flags_storage, *entry);
}
#endif
}
void FlagsState::RemoveFlagsSwitches(
base::CommandLine::SwitchMap* switch_list) {
for (const auto& entry : flags_switches_) {
switch_list->erase(entry.first);
}
// If feature entries were added to --enable-features= or --disable-features=
// lists, remove them here while preserving existing values.
for (const auto& entry : appended_switches_) {
const auto& switch_name = entry.first;
const auto& switch_added_values = entry.second;
// The below is either a std::string or a std::u16string based on platform.
const auto& existing_value = (*switch_list)[switch_name];
#if BUILDFLAG(IS_WIN)
const std::string existing_value_utf8 = base::WideToUTF8(existing_value);
#else
const std::string& existing_value_utf8 = existing_value;
#endif
std::vector<std::string_view> features =
base::FeatureList::SplitFeatureListString(existing_value_utf8);
std::vector<std::string_view> remaining_features;
// For any featrue name in |features| that is not in |switch_added_values| -
// i.e. it wasn't added by about_flags code, add it to |remaining_features|.
for (const auto& feature : features) {
if (!base::Contains(switch_added_values, std::string(feature))) {
remaining_features.push_back(feature);
}
}
// Either remove the flag entirely if |remaining_features| is empty, or set
// the new list.
if (remaining_features.empty()) {
switch_list->erase(switch_name);
} else {
std::string switch_value = base::JoinString(remaining_features, ",");
#if BUILDFLAG(IS_WIN)
(*switch_list)[switch_name] = base::UTF8ToWide(switch_value);
#else
(*switch_list)[switch_name] = switch_value;
#endif
}
}
}
void FlagsState::ResetAllFlags(FlagsStorage* flags_storage) {
needs_restart_ = true;
std::set<std::string> prev_enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &prev_enabled_entries);
std::set<std::string> no_entries;
SetFlags(flags_storage, no_entries, prev_enabled_entries);
}
void FlagsState::Reset() {
needs_restart_ = false;
flags_switches_.clear();
appended_switches_.clear();
}
std::vector<std::string> FlagsState::RegisterAllFeatureVariationParameters(
FlagsStorage* flags_storage,
base::FeatureList* feature_list) {
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlagsForCurrentPlatform(flags_storage, &enabled_entries);
return RegisterEnabledFeatureVariationParameters(
feature_entries_, enabled_entries, internal::kTrialGroupAboutFlags,
feature_list);
}
// static
std::vector<std::string> FlagsState::RegisterEnabledFeatureVariationParameters(
const base::span<const FeatureEntry>& feature_entries,
const std::set<std::string>& enabled_entries,
const std::string& trial_group,
base::FeatureList* feature_list) {
std::vector<std::string> variation_ids;
std::map<std::string, std::set<std::string>> enabled_features_by_trial_name;
std::map<std::string, std::map<std::string, std::string>>
params_by_trial_name;
// First collect all the data for each trial.
for (const FeatureEntry& entry : feature_entries) {
if (entry.type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE
#if BUILDFLAG(IS_CHROMEOS)
|| entry.type == FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE
#endif // BUILDFLAG(IS_CHROMEOS)
) {
for (int j = 0; j < entry.NumOptions(); ++j) {
if (entry.StateForOption(j) == FeatureEntry::FeatureState::ENABLED &&
enabled_entries.count(entry.NameForOption(j))) {
std::string trial_name;
if (entry.type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
trial_name = entry.feature.feature_trial_name;
// The user has chosen to enable the feature by this option.
enabled_features_by_trial_name[trial_name].insert(
entry.feature.feature->name);
}
#if BUILDFLAG(IS_CHROMEOS)
else {
trial_name = entry.platform_feature_name.feature_trial_name;
// The user has chosen to enable the feature by this option.
enabled_features_by_trial_name[trial_name].insert(
entry.platform_feature_name.name);
}
#endif // BUILDFLAG(IS_CHROMEOS)
const FeatureEntry::FeatureVariation* variation =
entry.VariationForOption(j);
if (!variation) {
continue;
}
// The selected variation is non-default, collect its params & id.
for (int i = 0; i < variation->num_params; ++i) {
auto insert_result = params_by_trial_name[trial_name].insert(
std::make_pair(variation->params[i].param_name,
variation->params[i].param_value));
DCHECK(insert_result.second)
<< "Multiple values for the same parameter '"
<< variation->params[i].param_name
<< "' are specified in chrome://flags!";
}
if (variation->variation_id) {
variation_ids.push_back(variation->variation_id);
}
}
}
}
}
// Now create the trials and associate the features to them.
for (const auto& kv : enabled_features_by_trial_name) {
const std::string& trial_name = kv.first;
const std::set<std::string>& trial_features = kv.second;
base::FieldTrial* field_trial = RegisterFeatureVariationParameters(
trial_name, params_by_trial_name[trial_name], trial_group);
if (!field_trial) {
continue;
}
for (const std::string& feature_name : trial_features) {
feature_list->RegisterFieldTrialOverride(
feature_name,
base::FeatureList::OverrideState::OVERRIDE_ENABLE_FEATURE,
field_trial);
}
}
return variation_ids;
}
void FlagsState::GetFlagFeatureEntries(
FlagsStorage* flags_storage,
FlagAccess access,
base::Value::List& supported_entries,
base::Value::List& unsupported_entries,
base::RepeatingCallback<bool(const FeatureEntry&)> skip_feature_entry) {
DCHECK(flags_storage);
std::set<std::string> enabled_entries;
GetSanitizedEnabledFlags(flags_storage, &enabled_entries);
int current_platform = GetCurrentPlatform();
for (const FeatureEntry& entry : feature_entries_) {
if (skip_feature_entry.Run(entry)) {
continue;
}
base::Value::Dict data;
data.Set("internal_name", entry.internal_name);
data.Set("name", entry.visible_name);
data.Set("description", entry.visible_description);
base::Value::List supported_platforms;
AddOsStrings(entry.supported_platforms, &supported_platforms);
data.Set("supported_platforms", std::move(supported_platforms));
// True if the switch is not currently passed.
bool is_default_value = IsDefaultValue(entry, enabled_entries);
data.Set("is_default", is_default_value);
if (!entry.links.empty()) {
base::Value::List links;
for (auto* link : entry.links) {
links.Append(link);
}
data.Set("links", std::move(links));
}
switch (entry.type) {
case FeatureEntry::SINGLE_VALUE:
case FeatureEntry::SINGLE_DISABLE_VALUE:
data.Set(
"enabled",
(!is_default_value && entry.type == FeatureEntry::SINGLE_VALUE) ||
(is_default_value &&
entry.type == FeatureEntry::SINGLE_DISABLE_VALUE));
break;
case FeatureEntry::ORIGIN_LIST_VALUE:
data.Set("enabled", !is_default_value);
data.Set("origin_list_value",
GetCombinedOriginListValue(
*flags_storage, *base::CommandLine::ForCurrentProcess(),
entry.internal_name, entry.switches.command_line_switch));
break;
case FeatureEntry::STRING_VALUE:
data.Set("enabled", !is_default_value);
data.Set("string_value",
GetCombinedStringValue(
*flags_storage, *base::CommandLine::ForCurrentProcess(),
entry.internal_name, entry.switches.command_line_switch));
break;
case FeatureEntry::MULTI_VALUE:
case FeatureEntry::ENABLE_DISABLE_VALUE:
case FeatureEntry::FEATURE_VALUE:
case FeatureEntry::FEATURE_WITH_PARAMS_VALUE:
#if BUILDFLAG(IS_CHROMEOS)
case FeatureEntry::PLATFORM_FEATURE_NAME_VALUE:
case FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE:
#endif // BUILDFLAG(IS_CHROMEOS)
data.Set("options", CreateOptionsData(entry, enabled_entries));
break;
}
bool supported = (entry.supported_platforms & current_platform) != 0;
#if BUILDFLAG(IS_CHROMEOS)
if (access == kOwnerAccessToFlags &&
(entry.supported_platforms & kOsCrOSOwnerOnly) != 0) {
supported = true;
}
#if BUILDFLAG(ENABLE_BANNED_BASE_FEATURE_PREFIX)
if ((entry.type == FeatureEntry::PLATFORM_FEATURE_NAME_VALUE ||
entry.type == FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE) &&
!base::StartsWith(entry.platform_feature_name.name,
BUILDFLAG(BANNED_BASE_FEATURE_PREFIX))) {
LOG(ERROR) << "mising required prefix for "
<< entry.platform_feature_name.name;
supported = false;
}
#endif // BUILDFLAG(ENABLED_BANNED_BASE_FEATURE_PREFIX)
#endif // BUILDFLAG(IS_CHROMEOS)
if (supported) {
supported_entries.Append(std::move(data));
} else {
unsupported_entries.Append(std::move(data));
}
}
}
// static
unsigned short FlagsState::GetCurrentPlatform() {
#if BUILDFLAG(IS_IOS)
return kOsIos;
#elif BUILDFLAG(IS_MAC)
return kOsMac;
#elif BUILDFLAG(IS_WIN)
return kOsWin;
#elif BUILDFLAG(IS_CHROMEOS)
return kOsCrOS;
#elif BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_OPENBSD)
return kOsLinux;
#elif BUILDFLAG(IS_ANDROID)
return kOsAndroid;
#elif BUILDFLAG(IS_FUCHSIA)
return kOsFuchsia;
#else
#error Unknown platform
#endif
}
void FlagsState::AddSwitchMapping(
const std::string& key,
const std::string& switch_name,
const std::string& switch_value,
std::map<std::string, SwitchEntry>* name_to_switch_map) const {
DCHECK(!base::Contains(*name_to_switch_map, key));
SwitchEntry* entry = &(*name_to_switch_map)[key];
entry->switch_name = switch_name;
entry->switch_value = switch_value;
}
void FlagsState::AddFeatureMapping(
const std::string& key,
const std::string& feature_name,
bool feature_state,
const std::string& variation_id,
std::map<std::string, SwitchEntry>* name_to_switch_map) const {
DCHECK(!base::Contains(*name_to_switch_map, key));
SwitchEntry* entry = &(*name_to_switch_map)[key];
entry->feature_name = feature_name;
entry->feature_state = feature_state;
entry->variation_id = variation_id;
}
void FlagsState::AddSwitchesToCommandLine(
const std::set<std::string>& enabled_entries,
const std::map<std::string, SwitchEntry>& name_to_switch_map,
SentinelsMode sentinels,
base::CommandLine* command_line,
const char* enable_features_flag_name,
const char* disable_features_flag_name) {
std::map<std::string, bool> feature_switches;
if (sentinels == kAddSentinels) {
command_line->AppendSwitch(switches::kFlagSwitchesBegin);
flags_switches_[switches::kFlagSwitchesBegin] = std::string();
}
std::vector<std::string> variation_ids;
for (const std::string& entry_name : enabled_entries) {
const auto& entry_it = name_to_switch_map.find(entry_name);
if (entry_it == name_to_switch_map.end()) {
NOTREACHED();
}
const SwitchEntry& entry = entry_it->second;
if (!entry.feature_name.empty()) {
feature_switches[entry.feature_name] = entry.feature_state;
if (!entry.variation_id.empty()) {
variation_ids.push_back(entry.variation_id);
}
} else if (!entry.switch_name.empty()) {
command_line->AppendSwitchASCII(entry.switch_name, entry.switch_value);
flags_switches_[entry.switch_name] = entry.switch_value;
}
// If an entry doesn't match either of the above, then it is likely the
// default entry for a FEATURE_VALUE entry. Safe to ignore.
}
if (!feature_switches.empty()) {
MergeFeatureCommandLineSwitch(feature_switches, enable_features_flag_name,
true, command_line);
MergeFeatureCommandLineSwitch(feature_switches, disable_features_flag_name,
false, command_line);
}
if (!variation_ids.empty()) {
MergeVariationIdsCommandLineSwitch(variation_ids, command_line);
}
if (sentinels == kAddSentinels) {
command_line->AppendSwitch(switches::kFlagSwitchesEnd);
flags_switches_[switches::kFlagSwitchesEnd] = std::string();
}
}
void FlagsState::MergeFeatureCommandLineSwitch(
const std::map<std::string, bool>& feature_switches,
const char* switch_name,
bool feature_state,
base::CommandLine* command_line) {
std::string original_switch_value =
command_line->GetSwitchValueASCII(switch_name);
std::vector<std::string_view> features =
base::FeatureList::SplitFeatureListString(original_switch_value);
// Only add features that don't already exist in the lists.
// Note: The base::Contains() call results in O(n^2) performance, but in
// practice n should be very small.
for (const auto& entry : feature_switches) {
if (entry.second == feature_state &&
!base::Contains(features, entry.first)) {
features.push_back(entry.first);
appended_switches_[switch_name].insert(entry.first);
}
}
// Update the switch value only if it didn't change. This avoids setting an
// empty list or duplicating the same list (since AppendSwitch() adds the
// switch to the end but doesn't remove previous ones).
std::string switch_value = base::JoinString(features, ",");
if (switch_value != original_switch_value) {
command_line->AppendSwitchASCII(switch_name, switch_value);
}
}
void FlagsState::MergeVariationIdsCommandLineSwitch(
const std::vector<std::string>& variation_ids,
base::CommandLine* command_line) {
DCHECK(!variation_ids.empty());
std::string variation_ids_switch = command_line->GetSwitchValueASCII(
variations::switches::kForceVariationIds);
// At this point, the switch value is guaranteed to change since
// |variation_ids| is not empty. Hence, we do not conditionally update the
// switch value, as is done in FlagsState::MergeFeatureCommandLineSwitch().
// Note that it is an error to try to set the same variation id in multiple
// ways.
command_line->AppendSwitchASCII(
variations::switches::kForceVariationIds,
base::StrCat({variation_ids_switch,
variation_ids_switch.empty() ? "" : ",",
base::JoinString(variation_ids, ",")}));
}
std::set<std::string> FlagsState::SanitizeList(
const FlagsStorage* storage,
const std::set<std::string>& enabled_entries,
int platform_mask) const {
std::set<std::string> new_enabled_entries;
// For each entry in |enabled_entries|, check whether it exists in the list
// of supported features. Remove those that don't. Note: Even though this is
// an O(n^2) search, this is more efficient than creating a set from
// |feature_entries_| first because |feature_entries_| is large and
// |enabled_entries| should generally be small/empty.
for (const std::string& entry_name : enabled_entries) {
if (IsSupportedFeature(storage, entry_name, platform_mask)) {
new_enabled_entries.insert(entry_name);
}
}
return new_enabled_entries;
}
void FlagsState::GetSanitizedEnabledFlags(FlagsStorage* flags_storage,
std::set<std::string>* result) const {
std::set<std::string> enabled_entries = flags_storage->GetFlags();
std::set<std::string> new_enabled_entries =
SanitizeList(flags_storage, enabled_entries, -1);
if (new_enabled_entries.size() != enabled_entries.size()) {
SetFlags(flags_storage, new_enabled_entries, enabled_entries);
}
result->swap(new_enabled_entries);
}
void FlagsState::GetSanitizedEnabledFlagsForCurrentPlatform(
FlagsStorage* flags_storage,
std::set<std::string>* result) const {
// TODO(asvitkine): Consider making GetSanitizedEnabledFlags() do the platform
// filtering by default so that we don't need two calls to SanitizeList().
GetSanitizedEnabledFlags(flags_storage, result);
int platform_mask = GetCurrentPlatform();
#if BUILDFLAG(IS_CHROMEOS)
platform_mask |= kOsCrOSOwnerOnly;
#endif
std::set<std::string> platform_entries =
SanitizeList(flags_storage, *result, platform_mask);
result->swap(platform_entries);
}
void FlagsState::GenerateFlagsToSwitchesMapping(
FlagsStorage* flags_storage,
const base::CommandLine& command_line,
std::set<std::string>* enabled_entries,
std::map<std::string, SwitchEntry>* name_to_switch_map) const {
GetSanitizedEnabledFlagsForCurrentPlatform(flags_storage, enabled_entries);
if (enabled_entries->empty()) {
return;
}
for (const FeatureEntry& entry : feature_entries_) {
switch (entry.type) {
case FeatureEntry::SINGLE_VALUE:
case FeatureEntry::SINGLE_DISABLE_VALUE:
AddSwitchMapping(entry.internal_name,
entry.switches.command_line_switch,
entry.switches.command_line_value, name_to_switch_map);
break;
case FeatureEntry::ORIGIN_LIST_VALUE: {
// Combine the existing command line value with the user provided list.
// This is done to retain the existing list from the command line when
// the browser is restarted. Otherwise, the user provided list would
// overwrite the list provided from the command line.
const std::string origin_list_value = GetCombinedOriginListValue(
*flags_storage, command_line, entry.internal_name,
entry.switches.command_line_switch);
AddSwitchMapping(entry.internal_name,
entry.switches.command_line_switch, origin_list_value,
name_to_switch_map);
break;
}
case FeatureEntry::STRING_VALUE: {
const std::string string_value = GetCombinedStringValue(
*flags_storage, command_line, entry.internal_name,
entry.switches.command_line_switch);
AddSwitchMapping(entry.internal_name,
entry.switches.command_line_switch, string_value,
name_to_switch_map);
break;
}
case FeatureEntry::MULTI_VALUE:
for (int j = 0; j < entry.NumOptions(); ++j) {
AddSwitchMapping(entry.NameForOption(j),
entry.ChoiceForOption(j).command_line_switch,
entry.ChoiceForOption(j).command_line_value,
name_to_switch_map);
}
break;
case FeatureEntry::ENABLE_DISABLE_VALUE:
AddSwitchMapping(entry.NameForOption(0), std::string(), std::string(),
name_to_switch_map);
AddSwitchMapping(entry.NameForOption(1),
entry.switches.command_line_switch,
entry.switches.command_line_value, name_to_switch_map);
AddSwitchMapping(
entry.NameForOption(2), entry.switches.disable_command_line_switch,
entry.switches.disable_command_line_value, name_to_switch_map);
break;
case FeatureEntry::FEATURE_VALUE:
case FeatureEntry::FEATURE_WITH_PARAMS_VALUE:
#if BUILDFLAG(IS_CHROMEOS)
case FeatureEntry::PLATFORM_FEATURE_NAME_VALUE:
case FeatureEntry::PLATFORM_FEATURE_NAME_WITH_PARAMS_VALUE:
#endif // BUILDFLAG(IS_CHROMEOS)
for (int j = 0; j < entry.NumOptions(); ++j) {
FeatureEntry::FeatureState state = entry.StateForOption(j);
if (state == FeatureEntry::FeatureState::DEFAULT) {
AddFeatureMapping(entry.NameForOption(j), std::string(), false,
std::string(), name_to_switch_map);
} else {
const FeatureEntry::FeatureVariation* variation =
entry.VariationForOption(j);
std::string feature_name;
if (entry.type == FeatureEntry::FEATURE_VALUE ||
entry.type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
feature_name = entry.feature.feature->name;
}
#if BUILDFLAG(IS_CHROMEOS)
else {
feature_name = entry.platform_feature_name.name;
}
#endif // BUILDFLAG(IS_CHROMEOS)
std::vector<std::string> params_value;
std::string variation_id;
if (variation) {
feature_name.append(":");
for (int i = 0; i < variation->num_params; ++i) {
std::string param_name =
variations::EscapeValue(variation->params[i].param_name);
std::string param_value =
variations::EscapeValue(variation->params[i].param_value);
params_value.push_back(
param_name.append("/").append(param_value));
}
if (variation->variation_id) {
variation_id = variation->variation_id;
}
}
AddFeatureMapping(
entry.NameForOption(j),
feature_name.append(base::JoinString(params_value, "/")),
state == FeatureEntry::FeatureState::ENABLED, variation_id,
name_to_switch_map);
}
}
break;
}
}
}
const FeatureEntry* FlagsState::FindFeatureEntryByName(
const std::string& internal_name) const {
for (const FeatureEntry& entry : feature_entries_) {
if (entry.internal_name == internal_name) {
return &entry;
}
}
return nullptr;
}
bool FlagsState::IsSupportedFeature(const FlagsStorage* storage,
const std::string& name,
int platform_mask) const {
for (const auto& entry : feature_entries_) {
DCHECK(entry.IsValid());
if (!(entry.supported_platforms & platform_mask)) {
continue;
}
if (!entry.InternalNameMatches(name)) {
continue;
}
if (delegate_ && delegate_->ShouldExcludeFlag(storage, entry)) {
continue;
}
return true;
}
return false;
}
void FlagsState::SetFlags(
FlagsStorage* flags_storage,
const std::set<std::string>& enabled_flags,
const std::set<std::string>& prev_enabled_flags) const {
flags_storage->SetFlags(enabled_flags);
#if BUILDFLAG(IS_ANDROID)
// feature name -> feature value
// TODO(crbug.com/392871545): Change the type of this to
// std::map<std::string, bool> once Jni Autoboxing is working.
std::map<std::string, std::string> features;
// feature name -> (param name -> param value)
std::map<std::string, std::map<std::string, std::string>> feature_params;
// Handle flags that have been set to "Enabled" or "Disabled".
for (const std::string& flag : enabled_flags) {
size_t at_index = flag.find(testing::kMultiSeparator);
std::string feature_internal_name = flag.substr(0, at_index);
const flags_ui::FeatureEntry* entry =
FindFeatureEntryByName(feature_internal_name);
// Since this flag is currently enabled, we know for sure that we can find
// its feature entry using its internal name.
CHECK(entry);
if (entry->type == FeatureEntry::FEATURE_VALUE ||
entry->type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
std::string feature_name = entry->feature.feature->name;
std::string feature_option_str = flag.substr(at_index + 1);
int feature_option;
bool result = base::StringToInt(feature_option_str, &feature_option);
DCHECK(result);
FeatureEntry::FeatureState feature_state =
entry->StateForOption(feature_option);
bool feature_value =
(feature_state == FeatureEntry::FeatureState::ENABLED);
std::string feature_value_string = base::ToString(feature_value);
features[feature_name] = feature_value_string;
if (entry->type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
feature_params[feature_name] = std::map<std::string, std::string>();
std::map<std::string, std::string>& cur_feature_params =
feature_params[feature_name];
const FeatureEntry::FeatureVariation* feature_variations =
entry->VariationForOption(feature_option);
if (!feature_variations) {
// When this line is reached, the feature must be set to either
// "Enabled" (without parameters) or "Disabled". Both of these options
// are associated with an empty set of parameters. Hence the key
// feature_name is mapped to an empty map in feature_params.
continue;
}
for (int i = 0; i < feature_variations->num_params; i++) {
FeatureEntry::FeatureParam feature_param =
feature_variations->params[i];
std::string param_name = std::string(feature_param.param_name);
std::string param_value = std::string(feature_param.param_value);
cur_feature_params[param_name] = param_value;
}
}
}
}
jni_delegate_->CacheNativeFlagsImmediately(features);
jni_delegate_->CacheFeatureParamsImmediately(feature_params);
// a list of feature names for which we need to erase the
// Java cached values of the associated features
std::vector<std::string> features_to_erase;
// a list of feature names for which we need to erase the
// Java cached values of the associated feature params
std::vector<std::string> feature_params_to_erase;
// Handle flags that have been switched to "Default".
for (const std::string& flag : prev_enabled_flags) {
if (enabled_flags.find(flag) == enabled_flags.end()) {
size_t at_index = flag.find(testing::kMultiSeparator);
std::string feature_internal_name = flag.substr(0, at_index);
const flags_ui::FeatureEntry* entry =
FindFeatureEntryByName(feature_internal_name);
// Since this flag is enabled previously but not enabled right now, it is
// possible that we have removed this flag from the codebase. Therefore,
// if we cannot find the feature entry, we just move on.
if (entry == nullptr) {
continue;
}
if (entry->type == FeatureEntry::FEATURE_VALUE ||
entry->type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
std::string feature_name = entry->feature.feature->name;
features_to_erase.push_back(feature_name);
if (entry->type == FeatureEntry::FEATURE_WITH_PARAMS_VALUE) {
feature_params_to_erase.push_back(feature_name);
}
}
}
}
jni_delegate_->EraseNativeFlagCachedValues(features_to_erase);
jni_delegate_->EraseFeatureParamCachedValues(feature_params_to_erase);
#endif
}
} // namespace flags_ui
|