1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/public/browser/webui_config_map.h"
#include <string_view>
#include "content/public/browser/web_ui_controller.h"
#include "content/public/browser/webui_config.h"
#include "content/public/test/scoped_web_ui_controller_factory_registration.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace content {
namespace {
constexpr const char kChromeFoo[] = "chrome://foo";
constexpr const char kChromeBar[] = "chrome://bar";
constexpr const char kChromeUntrustedFoo[] = "chrome-untrusted://foo";
constexpr const char kChromeUntrustedBar[] = "chrome-untrusted://bar";
// A valid BrowserContext is not needed for these tests.
BrowserContext* kBrowserContext = nullptr;
class TestConfig : public WebUIConfig {
public:
TestConfig(std::string_view scheme, std::string_view host)
: WebUIConfig(scheme, host) {}
~TestConfig() override = default;
std::unique_ptr<WebUIController> CreateWebUIController(
WebUI* web_ui,
const GURL& url) override {
// Unused in these tests.
return nullptr;
}
};
} // namespace
TEST(WebUIConfigTest, AddAndRemoveChromeUrl) {
auto& map = WebUIConfigMap::GetInstance();
size_t initial_size = map.GetWebUIConfigList(nullptr).size();
auto chrome_config = std::make_unique<TestConfig>("chrome", "foo");
auto* chrome_config_ptr = chrome_config.get();
map.AddWebUIConfig(std::move(chrome_config));
EXPECT_EQ(initial_size + 1, map.GetWebUIConfigList(nullptr).size());
EXPECT_EQ(chrome_config_ptr,
map.GetConfig(kBrowserContext, GURL(kChromeFoo)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeBar)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeUntrustedFoo)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeUntrustedBar)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeBar)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeUntrustedFoo)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeUntrustedBar)));
auto removed_config = map.RemoveConfig(GURL(kChromeFoo));
EXPECT_EQ(removed_config.get(), chrome_config_ptr);
EXPECT_EQ(initial_size, map.GetWebUIConfigList(nullptr).size());
}
TEST(WebUIConfigTest, AddAndRemoteChromeUntrustedUrl) {
auto& map = WebUIConfigMap::GetInstance();
size_t initial_size = map.GetWebUIConfigList(nullptr).size();
auto untrusted_config =
std::make_unique<TestConfig>("chrome-untrusted", "foo");
auto* untrusted_config_ptr = untrusted_config.get();
map.AddUntrustedWebUIConfig(std::move(untrusted_config));
EXPECT_EQ(initial_size + 1, map.GetWebUIConfigList(nullptr).size());
EXPECT_EQ(untrusted_config_ptr,
map.GetConfig(kBrowserContext, GURL(kChromeUntrustedFoo)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeUntrustedBar)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeFoo)));
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, GURL(kChromeBar)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeUntrustedBar)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeFoo)));
EXPECT_EQ(nullptr, map.RemoveConfig(GURL(kChromeBar)));
auto removed_config = map.RemoveConfig(GURL(kChromeUntrustedFoo));
EXPECT_EQ(removed_config.get(), untrusted_config_ptr);
EXPECT_EQ(initial_size, map.GetWebUIConfigList(nullptr).size());
}
class WebUiConfigDeathTest : public testing::Test,
public ::testing::WithParamInterface<const char*> {
public:
WebUiConfigDeathTest() = default;
WebUiConfigDeathTest(const WebUiConfigDeathTest&) = delete;
WebUiConfigDeathTest& operator=(const WebUiConfigDeathTest&) = delete;
~WebUiConfigDeathTest() override = default;
};
// Regression test for https://crbug.com/1464456.
TEST_P(WebUiConfigDeathTest, GetAndRemoveNonChromeUrls) {
auto& map = WebUIConfigMap::GetInstance();
ScopedWebUIConfigRegistration chrome_config(
std::make_unique<TestConfig>("chrome", "foo"));
ScopedWebUIConfigRegistration untrusted_config(
std::make_unique<TestConfig>("chrome-untrusted", "foo"));
const GURL url(GetParam());
EXPECT_EQ(nullptr, map.GetConfig(kBrowserContext, url));
EXPECT_DEATH_IF_SUPPORTED(map.RemoveConfig(url), "");
}
INSTANTIATE_TEST_SUITE_P(
/* no prefix */,
WebUiConfigDeathTest,
::testing::Values(
// filesystem: URLs
"filesystem:chrome://foo/external/file.txt",
"filesystem:chrome-untrusted://foo/external/file.txt",
// blob: URLS
"blob:chrome://foo/GUID",
"blob:chrome-untrusted://foo/GUID",
// HTTP/HTTPS URLS
"http://foo.com",
"https://foo.com"));
} // namespace content
|
