1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/common/manifest_handlers/csp_info.h"
#include <string_view>
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/values_test_util.h"
#include "components/version_info/channel.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/features/feature_channel.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_test.h"
namespace extensions {
namespace {
namespace errors = manifest_errors;
namespace keys = manifest_keys;
std::string GetInvalidManifestKeyError(std::string_view key) {
return ErrorUtils::FormatErrorMessage(errors::kInvalidManifestKey, key);
}
const char kDefaultSandboxedPageCSP[] =
"sandbox allow-scripts allow-forms allow-popups allow-modals; "
"script-src 'self' 'unsafe-inline' 'unsafe-eval'; child-src 'self';";
const char kDefaultExtensionPagesCSP[] =
"script-src 'self' blob: filesystem:; "
"object-src 'self' blob: filesystem:;";
const char kDefaultSecureCSP[] = "script-src 'self';";
} // namespace
using CSPInfoUnitTest = ManifestTest;
TEST_F(CSPInfoUnitTest, SandboxedPages) {
// Sandboxed pages specified, no custom CSP value.
scoped_refptr<Extension> extension1(
LoadAndExpectSuccess("sandboxed_pages_valid_1.json"));
// No sandboxed pages.
scoped_refptr<Extension> extension2(
LoadAndExpectSuccess("sandboxed_pages_valid_2.json"));
// Sandboxed pages specified with a custom CSP value.
scoped_refptr<Extension> extension3(
LoadAndExpectSuccess("sandboxed_pages_valid_3.json"));
// Sandboxed pages specified with wildcard, no custom CSP value.
scoped_refptr<Extension> extension4(
LoadAndExpectSuccess("sandboxed_pages_valid_4.json"));
// Sandboxed pages specified with filename wildcard, no custom CSP value.
scoped_refptr<Extension> extension5(
LoadAndExpectSuccess("sandboxed_pages_valid_5.json"));
// Sandboxed pages specified for a platform app with a custom CSP.
scoped_refptr<Extension> extension6(
LoadAndExpectSuccess("sandboxed_pages_valid_6.json"));
// Sandboxed pages specified for a platform app with no custom CSP.
scoped_refptr<Extension> extension7(
LoadAndExpectSuccess("sandboxed_pages_valid_7.json"));
const char kCustomSandboxedCSP[] =
"sandbox; script-src 'self'; child-src 'self';";
EXPECT_EQ(kDefaultSandboxedPageCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension1.get(), "/test"));
EXPECT_EQ(
kDefaultExtensionPagesCSP,
CSPInfo::GetResourceContentSecurityPolicy(extension1.get(), "/none"));
EXPECT_EQ(
kDefaultExtensionPagesCSP,
CSPInfo::GetResourceContentSecurityPolicy(extension2.get(), "/test"));
EXPECT_EQ(kCustomSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension3.get(), "/test"));
EXPECT_EQ(
kDefaultExtensionPagesCSP,
CSPInfo::GetResourceContentSecurityPolicy(extension3.get(), "/none"));
EXPECT_EQ(kDefaultSandboxedPageCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension4.get(), "/test"));
EXPECT_EQ(kDefaultSandboxedPageCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension5.get(), "/path/test.ext"));
EXPECT_EQ(
kDefaultExtensionPagesCSP,
CSPInfo::GetResourceContentSecurityPolicy(extension5.get(), "/test"));
EXPECT_EQ(kCustomSandboxedCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension6.get(), "/test"));
EXPECT_EQ(kDefaultSandboxedPageCSP, CSPInfo::GetResourceContentSecurityPolicy(
extension7.get(), "/test"));
const Testcase testcases[] = {
Testcase("sandboxed_pages_invalid_1.json",
errors::kInvalidSandboxedPagesList),
Testcase("sandboxed_pages_invalid_2.json", errors::kInvalidSandboxedPage),
Testcase("sandboxed_pages_invalid_3.json",
GetInvalidManifestKeyError(keys::kSandboxedPagesCSP)),
Testcase("sandboxed_pages_invalid_4.json",
GetInvalidManifestKeyError(keys::kSandboxedPagesCSP)),
Testcase("sandboxed_pages_invalid_5.json",
GetInvalidManifestKeyError(keys::kSandboxedPagesCSP))};
RunTestcases(testcases, EXPECT_TYPE_ERROR);
}
TEST_F(CSPInfoUnitTest, CSPStringKey) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("csp_string_valid.json");
ASSERT_TRUE(extension);
EXPECT_EQ("script-src 'self'; default-src 'none';",
CSPInfo::GetExtensionPagesCSP(extension.get()));
// Manifest V2 extensions bypass the main world CSP in their isolated worlds.
std::optional<std::string> isolated_world_csp =
CSPInfo::GetIsolatedWorldCSP(*extension);
ASSERT_TRUE(isolated_world_csp);
EXPECT_TRUE(isolated_world_csp->empty());
RunTestcase(Testcase("csp_invalid_1.json", GetInvalidManifestKeyError(
keys::kContentSecurityPolicy)),
EXPECT_TYPE_ERROR);
}
TEST_F(CSPInfoUnitTest, CSPDictionary_ExtensionPages) {
static constexpr struct {
const char* file_name;
const char* csp;
} cases[] = {{"csp_dictionary_valid_1.json", "default-src 'none'"},
{"csp_dictionary_valid_2.json",
"worker-src 'self'; script-src; default-src 'self'"},
{"csp_empty_dictionary_valid.json", kDefaultSecureCSP}};
for (const auto& test_case : cases) {
SCOPED_TRACE(base::StringPrintf("Testing %s.", test_case.file_name));
scoped_refptr<Extension> extension =
LoadAndExpectSuccess(test_case.file_name);
ASSERT_TRUE(extension.get());
EXPECT_EQ(test_case.csp, CSPInfo::GetExtensionPagesCSP(extension.get()));
}
const Testcase testcases[] = {
Testcase("csp_invalid_2.json",
GetInvalidManifestKeyError(
keys::kContentSecurityPolicy_ExtensionPagesPath)),
Testcase("csp_invalid_3.json",
GetInvalidManifestKeyError(
keys::kContentSecurityPolicy_ExtensionPagesPath)),
Testcase(
"csp_missing_src.json",
ErrorUtils::FormatErrorMessage(
errors::kInvalidCSPMissingSecureSrc,
keys::kContentSecurityPolicy_ExtensionPagesPath, "script-src")),
Testcase("csp_insecure_src.json",
ErrorUtils::FormatErrorMessage(
errors::kInvalidCSPInsecureValueError,
keys::kContentSecurityPolicy_ExtensionPagesPath,
"'unsafe-eval'", "worker-src")),
};
RunTestcases(testcases, EXPECT_TYPE_ERROR);
}
// Tests the requirements for object-src specifications.
TEST_F(CSPInfoUnitTest, ObjectSrcRequirements) {
enum class ManifestVersion {
kMV2,
kMV3,
};
static constexpr char kManifestV3Template[] =
R"({
"name": "Test Extension",
"manifest_version": 3,
"version": "0.1",
"content_security_policy": {
"extension_pages": "%s"
}
})";
static constexpr char kManifestV2Template[] =
R"({
"name": "Test Extension",
"manifest_version": 2,
"version": "0.1",
"content_security_policy": "%s"
})";
auto get_manifest = [](ManifestVersion version, const char* input) {
return base::test::ParseJsonDict(
version == ManifestVersion::kMV2
? base::StringPrintf(kManifestV2Template, input)
: base::StringPrintf(kManifestV3Template, input));
};
static constexpr struct {
ManifestVersion version;
const char* csp;
} kPassingTestcases[] = {
// object-src doesn't need to be explicitly specified in manifest V3.
{ManifestVersion::kMV3, "script-src 'self'"},
{ManifestVersion::kMV3, "default-src 'self'"},
// Secure object-src specifications are allowed.
{ManifestVersion::kMV3, "script-src 'self'; object-src 'self'"},
{ManifestVersion::kMV3, "script-src 'self'; object-src 'none'"},
{ManifestVersion::kMV3,
("script-src 'self'; object-src 'self'; frame-src 'self'; default-src "
"https://google.com")},
// Even though the object-src in the example below is effectively
// https://google.com (because it falls back to the default-src), we
// still allow it so that developers don't need to explicitly specify an
// object-src just because they specified a default-src. The minimum CSP
// (which includes `object-src 'self'`) still kicks in and prevents any
// insecure use.
{ManifestVersion::kMV3,
"script-src 'self'; default-src https://google.com"},
// In Manifest V2, object-src must be specified (if it's omitted, we add
// it; see `kWarningTestcases` below).
// Note: in MV2, our parsing will implicitly also add a trailing semicolon
// if one isn't provided, so we always add one here so that the final CSP
// matches.
{ManifestVersion::kMV2, "script-src 'self'; object-src 'self';"},
{ManifestVersion::kMV2, "script-src 'self'; object-src 'none';"},
{ManifestVersion::kMV2,
("script-src 'self'; object-src 'self'; frame-src 'self'; default-src "
"https://google.com;")},
// Manifest V2 allows (secure) remote object-src specifications.
{ManifestVersion::kMV2,
"script-src 'self'; object-src https://google.com;"},
{ManifestVersion::kMV2,
"script-src 'self'; default-src https://google.com;"},
};
for (const auto& testcase : kPassingTestcases) {
SCOPED_TRACE(testcase.csp);
ManifestData manifest_data(get_manifest(testcase.version, testcase.csp));
scoped_refptr<const Extension> extension =
LoadAndExpectSuccess(manifest_data);
ASSERT_TRUE(extension);
EXPECT_EQ(testcase.csp, CSPInfo::GetExtensionPagesCSP(extension.get()));
}
static constexpr struct {
ManifestVersion version;
const char* csp;
const char* expected_error;
} kFailingTestcases[] = {
// If an object-src *is* specified, it must be secure and must not allow
// remotely-hosted code (in MV3).
{ManifestVersion::kMV3,
"script-src 'self'; object-src https://google.com",
"*Insecure CSP value \"https://google.com\" in directive 'object-src'."},
};
for (const auto& testcase : kFailingTestcases) {
SCOPED_TRACE(testcase.csp);
ManifestData manifest_data(get_manifest(testcase.version, testcase.csp));
LoadAndExpectError(manifest_data, testcase.expected_error);
}
static constexpr struct {
ManifestVersion version;
const char* csp;
const char* expected_warning;
const char* effective_csp;
} kWarningTestcases[] = {
// In MV2, if an object-src is not provided, we will warn and synthesize
// one.
{ManifestVersion::kMV2, "script-src 'self'",
("'content_security_policy': CSP directive 'object-src' must be "
"specified (either explicitly, or implicitly via 'default-src') "
"and must allowlist only secure resources."),
"script-src 'self'; object-src 'self';"},
// Similarly, if an insecure (e.g. http) object-src is provided, we simply
// ignore it.
{ManifestVersion::kMV2, "script-src 'self'; object-src http://google.com",
("'content_security_policy': Ignored insecure CSP value "
"\"http://google.com\" in directive 'object-src'."),
"script-src 'self'; object-src;"}};
for (const auto& testcase : kWarningTestcases) {
// Special case: In MV2, if the developer doesn't provide an object-src, we
// insert one ('self') and emit a warning.
ManifestData manifest_data(get_manifest(testcase.version, testcase.csp));
scoped_refptr<const Extension> extension =
LoadAndExpectWarning(manifest_data, testcase.expected_warning);
ASSERT_TRUE(extension);
EXPECT_EQ(testcase.effective_csp,
CSPInfo::GetExtensionPagesCSP(extension.get()));
}
}
TEST_F(CSPInfoUnitTest, AllowWasmInMV3) {
struct {
const char* file_name;
const char* csp;
} cases[] = {{"csp_dictionary_with_wasm.json",
"worker-src 'self' 'wasm-unsafe-eval'; default-src 'self'"},
{"csp_dictionary_with_unsafe_wasm.json",
"worker-src 'self' 'wasm-unsafe-eval'; default-src 'self'"},
{"csp_dictionary_empty_v3.json", "script-src 'self';"},
{"csp_dictionary_valid_1.json", "default-src 'none'"},
{"csp_omitted_mv2.json", kDefaultExtensionPagesCSP}};
for (const auto& test_case : cases) {
SCOPED_TRACE(base::StringPrintf("Testing %s.", test_case.file_name));
scoped_refptr<Extension> extension =
LoadAndExpectSuccess(test_case.file_name);
ASSERT_TRUE(extension.get());
EXPECT_EQ(test_case.csp, CSPInfo::GetExtensionPagesCSP(extension.get()));
}
}
TEST_F(CSPInfoUnitTest, CSPDictionary_Sandbox) {
ScopedCurrentChannel channel(version_info::Channel::UNKNOWN);
const char kCustomSandboxedCSP[] =
"sandbox; script-src https://www.google.com";
const char kCustomExtensionPagesCSP[] = "script-src; object-src;";
struct {
const char* file_name;
const char* resource_path;
const char* expected_csp;
} success_cases[] = {
{"sandbox_dictionary_1.json", "/test", kCustomSandboxedCSP},
{"sandbox_dictionary_1.json", "/index", kDefaultSecureCSP},
{"sandbox_dictionary_2.json", "/test", kDefaultSandboxedPageCSP},
{"sandbox_dictionary_2.json", "/index", kCustomExtensionPagesCSP},
};
for (const auto& test_case : success_cases) {
SCOPED_TRACE(base::StringPrintf("%s with path %s", test_case.file_name,
test_case.resource_path));
scoped_refptr<Extension> extension =
LoadAndExpectSuccess(test_case.file_name);
ASSERT_TRUE(extension);
EXPECT_EQ(test_case.expected_csp,
CSPInfo::GetResourceContentSecurityPolicy(
extension.get(), test_case.resource_path));
}
const Testcase testcases[] = {
{"sandbox_both_keys.json", errors::kSandboxPagesCSPKeyNotAllowed},
{"sandbox_csp_with_dictionary.json",
errors::kSandboxPagesCSPKeyNotAllowed},
{"sandbox_invalid_type.json",
GetInvalidManifestKeyError(
keys::kContentSecurityPolicy_SandboxedPagesPath)},
{"unsandboxed_csp.json",
GetInvalidManifestKeyError(
keys::kContentSecurityPolicy_SandboxedPagesPath)}};
RunTestcases(testcases, EXPECT_TYPE_ERROR);
}
// Ensures that using a dictionary for the keys::kContentSecurityPolicy manifest
// key is mandatory for manifest v3 extensions and that defaults are applied
// correctly.
TEST_F(CSPInfoUnitTest, CSPDictionaryMandatoryForV3) {
LoadAndExpectError("csp_invalid_type_v3.json",
GetInvalidManifestKeyError(keys::kContentSecurityPolicy));
const char* default_case_filenames[] = {"csp_dictionary_empty_v3.json",
"csp_dictionary_missing_v3.json"};
// First, run through with loading the extensions as packed extensions.
for (const char* filename : default_case_filenames) {
SCOPED_TRACE(filename);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess(filename, mojom::ManifestLocation::kInternal);
ASSERT_TRUE(extension);
std::optional<std::string> isolated_world_csp =
CSPInfo::GetIsolatedWorldCSP(*extension);
ASSERT_TRUE(isolated_world_csp);
std::string expected_csp = base::StringPrintf(
"script-src 'self' 'wasm-unsafe-eval' 'inline-speculation-rules' "
"%s; object-src 'self';",
extension->dynamic_url().spec().c_str());
EXPECT_EQ(expected_csp, *isolated_world_csp);
EXPECT_EQ(kDefaultSandboxedPageCSP,
CSPInfo::GetSandboxContentSecurityPolicy(extension.get()));
EXPECT_EQ(kDefaultSecureCSP,
CSPInfo::GetExtensionPagesCSP(extension.get()));
EXPECT_EQ(
CSPHandler::GetMinimumMV3CSPForTesting(),
*CSPInfo::GetMinimumCSPToAppend(*extension, "not_sandboxed.html"));
}
// Repeat the test, loading the extensions as unpacked extensions.
// The minimum CSP we append (and thus the isolated world CSP) should be
// different, while the other CSPs should remain the same.
for (const char* filename : default_case_filenames) {
SCOPED_TRACE(filename);
scoped_refptr<Extension> extension =
LoadAndExpectSuccess(filename, mojom::ManifestLocation::kUnpacked);
ASSERT_TRUE(extension);
std::optional<std::string> isolated_world_csp =
CSPInfo::GetIsolatedWorldCSP(*extension);
ASSERT_TRUE(isolated_world_csp);
std::string expected_csp = base::StringPrintf(
"script-src 'self' 'wasm-unsafe-eval' 'inline-speculation-rules' "
"http://localhost:* http://127.0.0.1:* %s; object-src 'self';",
extension->dynamic_url().spec().c_str());
EXPECT_EQ(expected_csp, *isolated_world_csp);
EXPECT_EQ(kDefaultSandboxedPageCSP,
CSPInfo::GetSandboxContentSecurityPolicy(extension.get()));
EXPECT_EQ(kDefaultSecureCSP,
CSPInfo::GetExtensionPagesCSP(extension.get()));
EXPECT_EQ(
CSPHandler::GetMinimumUnpackedMV3CSPForTesting(),
*CSPInfo::GetMinimumCSPToAppend(*extension, "not_sandboxed.html"));
}
}
// Ensure the CSP dictionary is disallowed for mv2 extensions.
TEST_F(CSPInfoUnitTest, CSPDictionaryDisallowedForV2) {
LoadAndExpectError("csp_dictionary_mv2.json",
GetInvalidManifestKeyError(keys::kContentSecurityPolicy));
}
} // namespace extensions
|