1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
#pragma allow_unsafe_buffers
#endif
#include "net/spdy/buffered_spdy_framer.h"
#include <algorithm>
#include <string_view>
#include <utility>
#include "base/logging.h"
#include "net/log/net_log_with_source.h"
#include "net/spdy/spdy_test_util_common.h"
#include "net/third_party/quiche/src/quiche/common/http/http_header_block.h"
#include "testing/platform_test.h"
namespace net {
namespace {
class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
public:
TestBufferedSpdyVisitor()
: buffered_spdy_framer_(kMaxHeaderListSizeForTest, NetLogWithSource()),
header_stream_id_(static_cast<spdy::SpdyStreamId>(-1)),
promised_stream_id_(static_cast<spdy::SpdyStreamId>(-1)) {}
void OnError(
http2::Http2DecoderAdapter::SpdyFramerError spdy_framer_error) override {
VLOG(1) << "spdy::SpdyFramer Error: " << spdy_framer_error;
error_count_++;
}
void OnStreamError(spdy::SpdyStreamId stream_id,
const std::string& description) override {
VLOG(1) << "spdy::SpdyFramer Error on stream: " << stream_id << " "
<< description;
error_count_++;
}
void OnHeaders(spdy::SpdyStreamId stream_id,
bool has_priority,
int weight,
spdy::SpdyStreamId parent_stream_id,
bool exclusive,
bool fin,
quiche::HttpHeaderBlock headers,
base::TimeTicks recv_first_byte_time) override {
header_stream_id_ = stream_id;
headers_frame_count_++;
headers_ = std::move(headers);
}
void OnDataFrameHeader(spdy::SpdyStreamId stream_id,
size_t length,
bool fin) override {
ADD_FAILURE() << "Unexpected OnDataFrameHeader call.";
}
void OnStreamFrameData(spdy::SpdyStreamId stream_id,
const char* data,
size_t len) override {
LOG(FATAL) << "Unexpected OnStreamFrameData call.";
}
void OnStreamEnd(spdy::SpdyStreamId stream_id) override {
LOG(FATAL) << "Unexpected OnStreamEnd call.";
}
void OnStreamPadding(spdy::SpdyStreamId stream_id, size_t len) override {
LOG(FATAL) << "Unexpected OnStreamPadding call.";
}
void OnSettings() override {}
void OnSettingsAck() override {}
void OnSettingsEnd() override {}
void OnSetting(spdy::SpdySettingsId id, uint32_t value) override {
setting_count_++;
}
void OnPing(spdy::SpdyPingId unique_id, bool is_ack) override {}
void OnRstStream(spdy::SpdyStreamId stream_id,
spdy::SpdyErrorCode error_code) override {}
void OnGoAway(spdy::SpdyStreamId last_accepted_stream_id,
spdy::SpdyErrorCode error_code,
std::string_view debug_data) override {
goaway_count_++;
goaway_last_accepted_stream_id_ = last_accepted_stream_id;
goaway_error_code_ = error_code;
goaway_debug_data_.assign(debug_data.data(), debug_data.size());
}
void OnDataFrameHeader(const spdy::SpdySerializedFrame* frame) {
LOG(FATAL) << "Unexpected OnDataFrameHeader call.";
}
void OnRstStream(const spdy::SpdySerializedFrame& frame) {}
void OnGoAway(const spdy::SpdySerializedFrame& frame) {}
void OnPing(const spdy::SpdySerializedFrame& frame) {}
void OnWindowUpdate(spdy::SpdyStreamId stream_id,
int delta_window_size) override {}
void OnPushPromise(spdy::SpdyStreamId stream_id,
spdy::SpdyStreamId promised_stream_id,
quiche::HttpHeaderBlock headers) override {
header_stream_id_ = stream_id;
push_promise_frame_count_++;
promised_stream_id_ = promised_stream_id;
headers_ = std::move(headers);
}
void OnAltSvc(spdy::SpdyStreamId stream_id,
std::string_view origin,
const spdy::SpdyAltSvcWireFormat::AlternativeServiceVector&
altsvc_vector) override {
altsvc_count_++;
altsvc_stream_id_ = stream_id;
altsvc_origin_.assign(origin.data(), origin.size());
altsvc_vector_ = altsvc_vector;
}
bool OnUnknownFrame(spdy::SpdyStreamId stream_id,
uint8_t frame_type) override {
return true;
}
// Convenience function which runs a framer simulation with particular input.
void SimulateInFramer(const spdy::SpdySerializedFrame& frame) {
const char* input_ptr = frame.data();
size_t input_remaining = frame.size();
buffered_spdy_framer_.set_visitor(this);
while (input_remaining > 0 &&
buffered_spdy_framer_.spdy_framer_error() ==
http2::Http2DecoderAdapter::SPDY_NO_ERROR) {
// To make the tests more interesting, we feed random (amd small) chunks
// into the framer. This simulates getting strange-sized reads from
// the socket.
const size_t kMaxReadSize = 32;
size_t bytes_read =
(rand() % std::min(input_remaining, kMaxReadSize)) + 1;
size_t bytes_processed =
buffered_spdy_framer_.ProcessInput(input_ptr, bytes_read);
input_remaining -= bytes_processed;
input_ptr += bytes_processed;
}
}
BufferedSpdyFramer buffered_spdy_framer_;
// Counters from the visitor callbacks.
int error_count_ = 0;
int setting_count_ = 0;
int headers_frame_count_ = 0;
int push_promise_frame_count_ = 0;
int goaway_count_ = 0;
int altsvc_count_ = 0;
// Header block streaming state:
spdy::SpdyStreamId header_stream_id_;
spdy::SpdyStreamId promised_stream_id_;
// Headers from OnHeaders and OnPushPromise for verification.
quiche::HttpHeaderBlock headers_;
// OnGoAway parameters.
spdy::SpdyStreamId goaway_last_accepted_stream_id_;
spdy::SpdyErrorCode goaway_error_code_;
std::string goaway_debug_data_;
// OnAltSvc parameters.
spdy::SpdyStreamId altsvc_stream_id_;
std::string altsvc_origin_;
spdy::SpdyAltSvcWireFormat::AlternativeServiceVector altsvc_vector_;
};
} // namespace
class BufferedSpdyFramerTest : public PlatformTest {};
TEST_F(BufferedSpdyFramerTest, OnSetting) {
spdy::SpdyFramer framer(spdy::SpdyFramer::ENABLE_COMPRESSION);
spdy::SpdySettingsIR settings_ir;
settings_ir.AddSetting(spdy::SETTINGS_INITIAL_WINDOW_SIZE, 2);
settings_ir.AddSetting(spdy::SETTINGS_MAX_CONCURRENT_STREAMS, 3);
spdy::SpdySerializedFrame control_frame(
framer.SerializeSettings(settings_ir));
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(control_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(2, visitor.setting_count_);
}
TEST_F(BufferedSpdyFramerTest, HeaderListTooLarge) {
quiche::HttpHeaderBlock headers;
std::string long_header_value(256 * 1024, 'x');
headers["foo"] = long_header_value;
spdy::SpdyHeadersIR headers_ir(/*stream_id=*/1, std::move(headers));
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdySerializedFrame control_frame = framer.SerializeFrame(headers_ir);
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(control_frame);
EXPECT_EQ(1, visitor.error_count_);
EXPECT_EQ(0, visitor.headers_frame_count_);
EXPECT_EQ(0, visitor.push_promise_frame_count_);
EXPECT_EQ(quiche::HttpHeaderBlock(), visitor.headers_);
}
TEST_F(BufferedSpdyFramerTest, ValidHeadersAfterInvalidHeaders) {
quiche::HttpHeaderBlock headers;
headers["invalid"] = "\r\n\r\n";
quiche::HttpHeaderBlock headers2;
headers["alpha"] = "beta";
SpdyTestUtil spdy_test_util;
spdy::SpdySerializedFrame headers_frame(
spdy_test_util.ConstructSpdyReply(1, std::move(headers)));
spdy::SpdySerializedFrame headers_frame2(
spdy_test_util.ConstructSpdyReply(2, std::move(headers2)));
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(headers_frame);
EXPECT_EQ(1, visitor.error_count_);
EXPECT_EQ(0, visitor.headers_frame_count_);
visitor.SimulateInFramer(headers_frame2);
EXPECT_EQ(1, visitor.error_count_);
EXPECT_EQ(1, visitor.headers_frame_count_);
}
TEST_F(BufferedSpdyFramerTest, ReadHeadersHeaderBlock) {
quiche::HttpHeaderBlock headers;
headers["alpha"] = "beta";
headers["gamma"] = "delta";
spdy::SpdyHeadersIR headers_ir(/*stream_id=*/1, headers.Clone());
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdySerializedFrame control_frame = framer.SerializeFrame(headers_ir);
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(control_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.headers_frame_count_);
EXPECT_EQ(0, visitor.push_promise_frame_count_);
EXPECT_EQ(headers, visitor.headers_);
}
TEST_F(BufferedSpdyFramerTest, ReadPushPromiseHeaderBlock) {
quiche::HttpHeaderBlock headers;
headers["alpha"] = "beta";
headers["gamma"] = "delta";
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdyPushPromiseIR push_promise_ir(
/*stream_id=*/1, /*promised_stream_id=*/2, headers.Clone());
spdy::SpdySerializedFrame control_frame =
framer.SerializeFrame(push_promise_ir);
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(control_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(0, visitor.headers_frame_count_);
EXPECT_EQ(1, visitor.push_promise_frame_count_);
EXPECT_EQ(headers, visitor.headers_);
EXPECT_EQ(1u, visitor.header_stream_id_);
EXPECT_EQ(2u, visitor.promised_stream_id_);
}
TEST_F(BufferedSpdyFramerTest, GoAwayDebugData) {
spdy::SpdyGoAwayIR go_ir(/*last_good_stream_id=*/2,
spdy::ERROR_CODE_FRAME_SIZE_ERROR, "foo");
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdySerializedFrame goaway_frame = framer.SerializeFrame(go_ir);
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(goaway_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.goaway_count_);
EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_);
EXPECT_EQ(spdy::ERROR_CODE_FRAME_SIZE_ERROR, visitor.goaway_error_code_);
EXPECT_EQ("foo", visitor.goaway_debug_data_);
}
// ALTSVC frame on stream 0 must have an origin.
TEST_F(BufferedSpdyFramerTest, OnAltSvcOnStreamZero) {
const spdy::SpdyStreamId altsvc_stream_id(0);
spdy::SpdyAltSvcIR altsvc_ir(altsvc_stream_id);
spdy::SpdyAltSvcWireFormat::AlternativeService alternative_service(
"quic", "alternative.example.org", 443, 86400,
spdy::SpdyAltSvcWireFormat::VersionVector());
altsvc_ir.add_altsvc(alternative_service);
const char altsvc_origin[] = "https://www.example.org";
altsvc_ir.set_origin(altsvc_origin);
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdySerializedFrame altsvc_frame(framer.SerializeFrame(altsvc_ir));
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(altsvc_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.altsvc_count_);
EXPECT_EQ(altsvc_stream_id, visitor.altsvc_stream_id_);
EXPECT_EQ(altsvc_origin, visitor.altsvc_origin_);
ASSERT_EQ(1u, visitor.altsvc_vector_.size());
EXPECT_EQ(alternative_service, visitor.altsvc_vector_[0]);
}
// ALTSVC frame on a non-zero stream must not have an origin.
TEST_F(BufferedSpdyFramerTest, OnAltSvcOnNonzeroStream) {
const spdy::SpdyStreamId altsvc_stream_id(1);
spdy::SpdyAltSvcIR altsvc_ir(altsvc_stream_id);
spdy::SpdyAltSvcWireFormat::AlternativeService alternative_service(
"quic", "alternative.example.org", 443, 86400,
spdy::SpdyAltSvcWireFormat::VersionVector());
altsvc_ir.add_altsvc(alternative_service);
NetLogWithSource net_log;
BufferedSpdyFramer framer(kMaxHeaderListSizeForTest, net_log);
spdy::SpdySerializedFrame altsvc_frame(framer.SerializeFrame(altsvc_ir));
TestBufferedSpdyVisitor visitor;
visitor.SimulateInFramer(altsvc_frame);
EXPECT_EQ(0, visitor.error_count_);
EXPECT_EQ(1, visitor.altsvc_count_);
EXPECT_EQ(altsvc_stream_id, visitor.altsvc_stream_id_);
EXPECT_TRUE(visitor.altsvc_origin_.empty());
ASSERT_EQ(1u, visitor.altsvc_vector_.size());
EXPECT_EQ(alternative_service, visitor.altsvc_vector_[0]);
}
} // namespace net
|