1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h"
#include <linux/net.h>
#include <sys/socket.h>
#include <sys/syscall.h>
#include "base/check_op.h"
#include "base/strings/safe_sprintf.h"
#include "sandbox/linux/bpf_dsl/bpf_dsl.h"
#include "sandbox/linux/bpf_dsl/policy.h"
#include "sandbox/linux/seccomp-bpf/bpf_tests.h"
#include "sandbox/linux/system_headers/linux_syscalls.h"
#include "sandbox/linux/tests/unit_tests.h"
namespace sandbox {
namespace {
// NOTE: most of the SIGSYS handlers are tested in
// baseline_policy_unittest.cc and syscall_parameters_restrictions_unittests.cc.
using sandbox::bpf_dsl::Allow;
using sandbox::bpf_dsl::Arg;
using sandbox::bpf_dsl::If;
using sandbox::bpf_dsl::ResultExpr;
class DisallowSocketPolicy : public bpf_dsl::Policy {
public:
DisallowSocketPolicy() {
#if defined(__NR_socketcall)
// If the socket(2) syscall isn't available, then socketcall(2) might be
// used which can't be filtered with seccomp.
if (!CanRewriteSocketcall()) {
UnitTests::IgnoreThisTest();
return;
}
#endif // defined(__NR_socketcall)
}
~DisallowSocketPolicy() override = default;
ResultExpr EvaluateSyscall(int sysno) const override {
switch (sysno) {
case __NR_socket: {
const Arg<int> domain(0);
return If(domain == AF_INET, CrashSIGSYSSocket()).Else(Allow());
}
#if defined(__NR_socketcall)
case __NR_socketcall:
return RewriteSocketcallSIGSYS();
#endif // defined(__NR_socketcall)
default:
return Allow();
}
}
};
BPF_DEATH_TEST_C(
SigsysHandlers,
SocketPrintsCorrectMessage,
DEATH_SEGV_MESSAGE(sandbox::GetSocketErrorMessageContentForTests()),
DisallowSocketPolicy) {
socket(AF_INET, 0, 0);
}
class DisallowSockoptPolicy : public bpf_dsl::Policy {
public:
DisallowSockoptPolicy() {
#if defined(__NR_socketcall)
// If the setsockopt(2) or getsockopt(2) syscalls aren't available, then
// socketcall(2) might be used which can't be filtered with seccomp.
if (!CanRewriteSocketcall()) {
UnitTests::IgnoreThisTest();
return;
}
#endif // defined(__NR_socketcall)
}
~DisallowSockoptPolicy() override = default;
ResultExpr EvaluateSyscall(int sysno) const override {
switch (sysno) {
case __NR_setsockopt:
case __NR_getsockopt:
return CrashSIGSYSSockopt();
#if defined(__NR_socketcall)
case __NR_socketcall:
return RewriteSocketcallSIGSYS();
#endif // defined(__NR_socketcall)
default:
return Allow();
}
}
};
BPF_DEATH_TEST_C(
SigsysHandlers,
SetsockoptPrintsCorrectMessage,
DEATH_SEGV_MESSAGE(sandbox::GetSockoptErrorMessageContentForTests()),
DisallowSockoptPolicy) {
setsockopt(0, 0, 0, nullptr, 0);
}
BPF_DEATH_TEST_C(
SigsysHandlers,
GetSockoptPrintsCorrectMessage,
DEATH_SEGV_MESSAGE(sandbox::GetSockoptErrorMessageContentForTests()),
DisallowSockoptPolicy) {
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wnonnull"
getsockopt(0, 0, 0, nullptr, nullptr);
#pragma GCC diagnostic pop
}
const char kSigsysMessage[] =
"nr=0x42 arg1=0xffffffffffffffff arg2=0x0 arg3=0xabcdef arg4=0xffffffff";
SANDBOX_DEATH_TEST(SigsysHandlers,
SigsysErrorDetails,
DEATH_SEGV_MESSAGE(kSigsysMessage)) {
arch_seccomp_data args = {.nr = 0x42,
.args = {static_cast<uint64_t>(-1), 0, 0xabcdef,
static_cast<uint32_t>(-1)}};
CrashSIGSYS_Handler(args, nullptr);
}
#if defined(__NR_socketcall)
// Test the socketcall(2) rewrites below.
const int kDirectSocketSyscallRetVal = 37;
const size_t kNumArgsToCopy = 6;
uint64_t g_syscall_args[kNumArgsToCopy];
int g_syscall_no;
SANDBOX_EXPORT intptr_t
SIGSYSDirectSocketSyscallHandler(const struct arch_seccomp_data& args, void*) {
// Record syscall args.
memcpy(g_syscall_args, args.args, kNumArgsToCopy * sizeof(uint64_t));
g_syscall_no = args.nr;
return kDirectSocketSyscallRetVal;
}
class RewriteSocketcallPolicy : public bpf_dsl::Policy {
public:
RewriteSocketcallPolicy() {
if (!CanRewriteSocketcall()) {
UnitTests::IgnoreThisTest();
return;
}
}
~RewriteSocketcallPolicy() override = default;
ResultExpr EvaluateSyscall(int sysno) const override {
switch (sysno) {
case __NR_socketcall:
return RewriteSocketcallSIGSYS();
case __NR_socket:
case __NR_bind:
case __NR_connect:
case __NR_listen:
case __NR_getsockname:
case __NR_getpeername:
case __NR_socketpair:
case __NR_sendto:
case __NR_recvfrom:
case __NR_shutdown:
case __NR_setsockopt:
case __NR_getsockopt:
case __NR_sendmsg:
case __NR_recvmsg:
case __NR_accept4:
case __NR_recvmmsg:
case __NR_sendmmsg:
return bpf_dsl::Trap(&SIGSYSDirectSocketSyscallHandler, nullptr);
default:
return Allow();
}
}
};
template <size_t N>
void CheckArgsMatch(long current_socketcall,
int sysno,
unsigned long (&expected_args)[N]) {
BPF_ASSERT_EQ(sysno, g_syscall_no);
// If the args don't match, crash to fail the test.
for (size_t i = 0; i < N; i++) {
unsigned long rewritten_socketcall_arg =
*reinterpret_cast<unsigned long*>(&g_syscall_args[i]);
CHECK_EQ(rewritten_socketcall_arg, expected_args[i])
<< "Socketcall " << current_socketcall << " differs at argument " << i;
}
}
BPF_TEST_C(SigsysHandlers,
DirectSocketSyscallArgsMatch,
RewriteSocketcallPolicy) {
// The arguments to every socketcall will be 1,2,3,4,5,6 and the return value
// will always be `kDirectSocketSyscallRetVal`.
// Some socketcalls have fewer than 6 arguments but it doesn't hurt to have a
// longer array, the extra arguments will just be ignored.
unsigned long socketcall_args[6] = {1, 2, 3, 4, 5, 6};
// socketcalls range from SYS_SOCKET (1) to SYS_SENDMMSG (20).
for (long i = 1; i <= 20; i++) {
// For every socketcall, call the __NR_socketcall version and it should call
// the direct version, which our BPF policy will catch and record the
// syscall arguments in `g_syscall_args`. Then check the args are as
// expected.
switch (i) {
case SYS_SOCKET: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_socket, expected_args);
break;
}
case SYS_BIND: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_bind, expected_args);
break;
}
case SYS_CONNECT: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_connect, expected_args);
break;
}
case SYS_LISTEN: {
unsigned long expected_args[2] = {1, 2};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_listen, expected_args);
break;
}
case SYS_ACCEPT: {
// Should call accept4 with flags == 0.
unsigned long expected_args[4] = {1, 2, 3, 0};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_accept4, expected_args);
break;
}
case SYS_GETSOCKNAME: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_getsockname, expected_args);
break;
}
case SYS_GETPEERNAME: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_getpeername, expected_args);
break;
}
case SYS_SOCKETPAIR: {
unsigned long expected_args[4] = {1, 2, 3, 4};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_socketpair, expected_args);
break;
}
case SYS_SEND: {
// Should call sendto() with last two args equal to 0.
unsigned long expected_args[6] = {1, 2, 3, 4, 0, 0};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_sendto, expected_args);
break;
}
case SYS_RECV: {
// Should call recvfrom() with last two args equal to 0.
unsigned long expected_args[6] = {1, 2, 3, 4, 0, 0};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_recvfrom, expected_args);
break;
}
case SYS_SENDTO: {
unsigned long expected_args[6] = {1, 2, 3, 4, 5, 6};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_sendto, expected_args);
break;
}
case SYS_RECVFROM: {
unsigned long expected_args[6] = {1, 2, 3, 4, 5, 6};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_recvfrom, expected_args);
break;
}
case SYS_SHUTDOWN: {
unsigned long expected_args[2] = {1, 2};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_shutdown, expected_args);
break;
}
case SYS_SETSOCKOPT: {
unsigned long expected_args[5] = {1, 2, 3, 4, 5};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_setsockopt, expected_args);
break;
}
case SYS_GETSOCKOPT: {
unsigned long expected_args[5] = {1, 2, 3, 4, 5};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_getsockopt, expected_args);
break;
}
case SYS_SENDMSG: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_sendmsg, expected_args);
break;
}
case SYS_RECVMSG: {
unsigned long expected_args[3] = {1, 2, 3};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_recvmsg, expected_args);
break;
}
case SYS_ACCEPT4: {
unsigned long expected_args[4] = {1, 2, 3, 4};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_accept4, expected_args);
break;
}
case SYS_RECVMMSG: {
unsigned long expected_args[5] = {1, 2, 3, 4, 5};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_recvmmsg, expected_args);
break;
}
case SYS_SENDMMSG: {
unsigned long expected_args[4] = {1, 2, 3, 4};
BPF_ASSERT_EQ(syscall(__NR_socketcall, i, socketcall_args),
kDirectSocketSyscallRetVal);
CheckArgsMatch(i, __NR_sendmmsg, expected_args);
break;
}
}
}
}
#endif // defined(__NR_socketcall)
} // namespace
} // namespace sandbox
|