1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "sandbox/linux/syscall_broker/broker_file_permission.h"
#include <fcntl.h>
#include <string.h>
#include <sys/inotify.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
#include "base/check.h"
#include "base/notreached.h"
#include "sandbox/linux/tests/test_utils.h"
#include "sandbox/linux/tests/unit_tests.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace sandbox {
namespace syscall_broker {
class BrokerFilePermissionTester {
public:
BrokerFilePermissionTester(const BrokerFilePermissionTester&) = delete;
BrokerFilePermissionTester& operator=(const BrokerFilePermissionTester&) =
delete;
static bool ValidatePath(const char* path) {
return BrokerFilePermission::ValidatePath(path);
}
static const char* GetErrorMessage() {
return BrokerFilePermission::GetErrorMessageForTests();
}
};
namespace {
// Creation tests are DEATH tests as a bad permission causes termination.
SANDBOX_TEST(BrokerFilePermission, CreateGood) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
}
SANDBOX_TEST(BrokerFilePermission, CreateGoodRecursive) {
const char kPath[] = "/tmp/good/";
BrokerFilePermission perm = BrokerFilePermission::ReadOnlyRecursive(kPath);
}
// In official builds, CHECK(x) causes a SIGTRAP on the architectures where the
// sanbox is enabled (that are x86, x86_64, arm64 and 32-bit arm processes
// running on a arm64 kernel).
#if defined(OFFICIAL_BUILD)
#define DEATH_BY_CHECK(msg) DEATH_BY_SIGNAL(SIGTRAP)
#else
#define DEATH_BY_CHECK(msg) DEATH_MESSAGE(msg)
#endif
SANDBOX_DEATH_TEST(
BrokerFilePermission,
CreateBad,
DEATH_BY_CHECK(BrokerFilePermissionTester::GetErrorMessage())) {
const char kPath[] = "/tmp/bad/";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
}
SANDBOX_DEATH_TEST(
BrokerFilePermission,
CreateBadRecursive,
DEATH_BY_CHECK(BrokerFilePermissionTester::GetErrorMessage())) {
const char kPath[] = "/tmp/bad";
BrokerFilePermission perm = BrokerFilePermission::ReadOnlyRecursive(kPath);
}
SANDBOX_DEATH_TEST(
BrokerFilePermission,
CreateBadNotAbs,
DEATH_BY_CHECK(BrokerFilePermissionTester::GetErrorMessage())) {
const char kPath[] = "tmp/bad";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
}
SANDBOX_DEATH_TEST(
BrokerFilePermission,
CreateBadEmpty,
DEATH_BY_CHECK(BrokerFilePermissionTester::GetErrorMessage())) {
const char kPath[] = "";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
}
// CheckPerm tests |path| against |perm| given |access_flags|.
// If |create| is true then file creation is tested for success.
void CheckPerm(const BrokerFilePermission& perm,
const char* path,
int access_flags,
bool create) {
ASSERT_FALSE(perm.CheckAccess(path, X_OK));
ASSERT_TRUE(perm.CheckAccess(path, F_OK));
// check bad perms
switch (access_flags) {
case O_RDONLY:
ASSERT_TRUE(perm.CheckOpen(path, O_RDONLY).first);
ASSERT_FALSE(perm.CheckOpen(path, O_WRONLY).first);
ASSERT_FALSE(perm.CheckOpen(path, O_RDWR).first);
ASSERT_TRUE(perm.CheckAccess(path, R_OK));
ASSERT_FALSE(perm.CheckAccess(path, W_OK));
break;
case O_WRONLY:
ASSERT_FALSE(perm.CheckOpen(path, O_RDONLY).first);
ASSERT_TRUE(perm.CheckOpen(path, O_WRONLY).first);
ASSERT_FALSE(perm.CheckOpen(path, O_RDWR).first);
ASSERT_FALSE(perm.CheckAccess(path, R_OK));
ASSERT_TRUE(perm.CheckAccess(path, W_OK));
break;
case O_RDWR:
ASSERT_TRUE(perm.CheckOpen(path, O_RDONLY).first);
ASSERT_TRUE(perm.CheckOpen(path, O_WRONLY).first);
ASSERT_TRUE(perm.CheckOpen(path, O_RDWR).first);
ASSERT_TRUE(perm.CheckAccess(path, R_OK));
ASSERT_TRUE(perm.CheckAccess(path, W_OK));
break;
default:
// Bad test case
NOTREACHED();
}
// O_SYNC can be defined as (__O_SYNC|O_DSYNC)
#ifdef O_DSYNC
const int kSyncFlag = O_SYNC & ~O_DSYNC;
#else
const int kSyncFlag = O_SYNC;
#endif
const int kNumberOfBitsInOAccMode = 2;
static_assert(O_ACCMODE == ((1 << kNumberOfBitsInOAccMode) - 1),
"incorrect number of bits");
// check every possible flag and act accordingly.
// Skipping AccMode bits as they are present in every case.
for (int i = kNumberOfBitsInOAccMode; i < 32; i++) {
int flag = 1 << i;
switch (flag) {
case O_APPEND:
case O_ASYNC:
case O_DIRECT:
case O_DIRECTORY:
#ifdef O_DSYNC
case O_DSYNC:
#endif
case O_EXCL:
case O_LARGEFILE:
case O_NOATIME:
case O_NOCTTY:
case O_NOFOLLOW:
case O_NONBLOCK:
#if (O_NONBLOCK != O_NDELAY)
case O_NDELAY:
#endif
case kSyncFlag:
ASSERT_TRUE(perm.CheckOpen(path, access_flags | flag).first);
break;
case O_TRUNC: {
// The effect of (O_RDONLY | O_TRUNC) is undefined, and in some cases it
// actually truncates, so deny.
const char* result = perm.CheckOpen(path, access_flags | flag).first;
if (access_flags == O_RDONLY) {
ASSERT_FALSE(result);
} else {
ASSERT_TRUE(result);
}
break;
}
case O_CREAT:
continue; // Handled below.
case O_CLOEXEC:
default:
ASSERT_FALSE(perm.CheckOpen(path, access_flags | flag).first);
}
}
if (create) {
const char* result;
bool unlink;
std::tie(result, unlink) =
perm.CheckOpen(path, O_CREAT | O_EXCL | access_flags);
ASSERT_TRUE(result);
ASSERT_FALSE(unlink);
} else {
ASSERT_FALSE(perm.CheckOpen(path, O_CREAT | O_EXCL | access_flags).first);
}
}
TEST(BrokerFilePermission, ReadOnly) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
CheckPerm(perm, kPath, O_RDONLY, false);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
TEST(BrokerFilePermission, ReadOnlyRecursive) {
const char kPath[] = "/tmp/good/";
const char kPathFile[] = "/tmp/good/file";
BrokerFilePermission perm = BrokerFilePermission::ReadOnlyRecursive(kPath);
CheckPerm(perm, kPathFile, O_RDONLY, false);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
// Explicit test for O_RDONLY|O_TRUNC, which should be denied due to
// undefined behavior.
TEST(BrokerFilePermission, ReadOnlyTruncate) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::ReadOnly(kPath);
ASSERT_FALSE(perm.CheckOpen(kPath, O_RDONLY | O_TRUNC).first);
}
TEST(BrokerFilePermission, WriteOnly) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::WriteOnly(kPath);
CheckPerm(perm, kPath, O_WRONLY, false);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
TEST(BrokerFilePermission, ReadWrite) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::ReadWrite(kPath);
CheckPerm(perm, kPath, O_RDWR, false);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
TEST(BrokerFilePermission, ReadWriteCreate) {
const char kPath[] = "/tmp/good";
BrokerFilePermission perm = BrokerFilePermission::ReadWriteCreate(kPath);
CheckPerm(perm, kPath, O_RDWR, true);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
void CheckUnlink(BrokerFilePermission& perm,
const char* path,
int access_flags) {
ASSERT_FALSE(perm.CheckOpen(path, access_flags).first);
const char* result;
bool unlink;
std::tie(result, unlink) =
perm.CheckOpen(path, access_flags | O_CREAT | O_EXCL);
ASSERT_TRUE(result);
ASSERT_TRUE(unlink);
}
TEST(BrokerFilePermission, ReadWriteCreateTemporaryRecursive) {
const char kPath[] = "/tmp/good/";
const char kPathFile[] = "/tmp/good/file";
BrokerFilePermission perm =
BrokerFilePermission::ReadWriteCreateTemporaryRecursive(kPath);
CheckUnlink(perm, kPathFile, O_RDWR);
// Don't do anything here, so that ASSERT works in the subfunction as
// expected.
}
TEST(BrokerFilePermission, StatOnlyWithIntermediateDirs) {
const char kPath[] = "/tmp/good/path";
const char kLeading1[] = "/";
const char kLeading2[] = "/tmp";
const char kLeading3[] = "/tmp/good/path";
const char kBadPrefix[] = "/tmp/good/pa";
const char kTrailing[] = "/tmp/good/path/bad";
BrokerFilePermission perm =
BrokerFilePermission::StatOnlyWithIntermediateDirs(kPath);
// No open or access permission.
ASSERT_FALSE(perm.CheckOpen(kPath, O_RDONLY).first);
ASSERT_FALSE(perm.CheckOpen(kPath, O_WRONLY).first);
ASSERT_FALSE(perm.CheckOpen(kPath, O_RDWR).first);
ASSERT_FALSE(perm.CheckAccess(kPath, R_OK));
ASSERT_FALSE(perm.CheckAccess(kPath, W_OK));
// Stat for all leading paths, but not trailing paths.
ASSERT_TRUE(perm.CheckStatWithIntermediates(kPath));
ASSERT_TRUE(perm.CheckStatWithIntermediates(kLeading1));
ASSERT_TRUE(perm.CheckStatWithIntermediates(kLeading2));
ASSERT_TRUE(perm.CheckStatWithIntermediates(kLeading3));
ASSERT_FALSE(perm.CheckStatWithIntermediates(kBadPrefix));
ASSERT_FALSE(perm.CheckStatWithIntermediates(kTrailing));
}
TEST(BrokerFilePermission, InotifyAddWatchWithIntermediateDirs) {
const char kPath[] = "/tmp/good/path";
const char kLeading1[] = "/";
const char kLeading2[] = "/tmp";
const char kLeading3[] = "/tmp/good/path";
const char kBadPrefix[] = "/tmp/good/pa";
const char kTrailing[] = "/tmp/good/path/bad";
const uint32_t kBadMask =
IN_CREATE | IN_DELETE | IN_CLOSE_WRITE | IN_MOVE | IN_ONLYDIR;
const uint32_t kGoodMask = kBadMask | IN_ATTRIB;
BrokerFilePermission perm =
BrokerFilePermission::InotifyAddWatchWithIntermediateDirs(kPath);
// No open or access permission.
ASSERT_FALSE(perm.CheckOpen(kPath, O_RDONLY).first);
ASSERT_FALSE(perm.CheckOpen(kPath, O_WRONLY).first);
ASSERT_FALSE(perm.CheckOpen(kPath, O_RDWR).first);
ASSERT_FALSE(perm.CheckAccess(kPath, R_OK));
ASSERT_FALSE(perm.CheckAccess(kPath, W_OK));
// Inotify_add_watch for all leading paths, but not trailing paths.
ASSERT_TRUE(perm.CheckInotifyAddWatchWithIntermediates(kPath, kGoodMask));
ASSERT_TRUE(perm.CheckInotifyAddWatchWithIntermediates(kLeading1, kGoodMask));
ASSERT_TRUE(perm.CheckInotifyAddWatchWithIntermediates(kLeading2, kGoodMask));
ASSERT_TRUE(perm.CheckInotifyAddWatchWithIntermediates(kLeading3, kGoodMask));
ASSERT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kBadPrefix, kGoodMask));
ASSERT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kTrailing, kGoodMask));
// Fails without correct mask.
ASSERT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kPath, kBadMask));
}
TEST(BrokerFilePermission, AllPermissions) {
// `kPath` and `kPathDir` get allowlisted with AllPermissions and
// AllPermissionsRecursive, respectively.
static constexpr char kPath[] = "/tmp/good";
static constexpr char kPathDir[] = "/tmp/good/";
static constexpr char kPathFile[] = "/tmp/good/file";
static constexpr char kPathFileExtraStuff[] = "/tmp/good/file/extrastuff";
static constexpr char kLeading1[] = "/";
static constexpr char kLeading2[] = "/tmp";
static constexpr char kBadPrefix[] = "/tmp/go";
static constexpr char kExtraStuff[] = "/tmp/good_extra_stuff";
static constexpr char kExtraStuffFile[] = "/tmp/good_extra_stuff/file";
static constexpr char kDoubleSlash[] = "/tmp//good/file";
static constexpr char kParentRef[] = "/tmp/good/../file";
constexpr uint32_t kBadInotifyMask =
IN_CREATE | IN_DELETE | IN_CLOSE_WRITE | IN_MOVE | IN_ONLYDIR;
constexpr uint32_t kGoodInotifyMask = kBadInotifyMask | IN_ATTRIB;
BrokerFilePermission perm =
BrokerFilePermission::AllPermissionsRecursive(kPathDir);
// Opening and accessing the nested files `kPathFile` and
// `kPathFileExtraStuff` should work.
EXPECT_TRUE(perm.CheckOpen(kPathFile, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_TRUE(perm.CheckOpen(kPathFile, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_TRUE(perm.CheckAccess(kPathFile, R_OK));
EXPECT_TRUE(perm.CheckAccess(kPathFile, W_OK));
EXPECT_TRUE(
perm.CheckOpen(kPathFileExtraStuff, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_TRUE(
perm.CheckOpen(kPathFileExtraStuff, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_TRUE(perm.CheckAccess(kPathFileExtraStuff, R_OK));
EXPECT_TRUE(perm.CheckAccess(kPathFileExtraStuff, W_OK));
// Opening and accessing anything above the path shouldn't work.
EXPECT_FALSE(perm.CheckOpen(kBadPrefix, R_OK).first);
EXPECT_FALSE(perm.CheckAccess(kBadPrefix, R_OK));
EXPECT_FALSE(perm.CheckOpen(kLeading1, R_OK).first);
EXPECT_FALSE(perm.CheckAccess(kLeading1, R_OK));
EXPECT_FALSE(perm.CheckOpen(kLeading2, R_OK).first);
EXPECT_FALSE(perm.CheckAccess(kLeading2, R_OK));
// Stat should work recursively and on intermediates but not on all files.
EXPECT_TRUE(perm.CheckStatWithIntermediates(kPathFile));
EXPECT_TRUE(perm.CheckStatWithIntermediates(kLeading1));
EXPECT_TRUE(perm.CheckStatWithIntermediates(kLeading2));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kBadPrefix));
// InotifyAddWatch should work recursively and on intermediates but not on all
// files.
EXPECT_TRUE(
perm.CheckInotifyAddWatchWithIntermediates(kPathFile, kGoodInotifyMask));
EXPECT_TRUE(
perm.CheckInotifyAddWatchWithIntermediates(kLeading1, kGoodInotifyMask));
EXPECT_TRUE(
perm.CheckInotifyAddWatchWithIntermediates(kLeading2, kGoodInotifyMask));
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kBadPrefix, kGoodInotifyMask));
// InotifyAddWatch should still fail without the correct mask.
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kPathFile, kBadInotifyMask));
EXPECT_TRUE(perm.CheckStatWithIntermediates(kPath));
EXPECT_TRUE(
perm.CheckInotifyAddWatchWithIntermediates(kPath, kGoodInotifyMask));
// Empty string should always fail
EXPECT_FALSE(perm.CheckOpen("", O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen("", O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess("", R_OK));
EXPECT_FALSE(perm.CheckAccess("", W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(""));
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates("", kGoodInotifyMask));
// Extra characters on the allowlisted path shouldn't pass:
EXPECT_FALSE(perm.CheckOpen(kExtraStuff, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen(kExtraStuff, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kExtraStuff, R_OK));
EXPECT_FALSE(perm.CheckAccess(kExtraStuff, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kExtraStuff));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kExtraStuff,
kGoodInotifyMask));
// Extra characters and an extra filename on the allowlisted path shouldn't
// pass:
EXPECT_FALSE(
perm.CheckOpen(kExtraStuffFile, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(
perm.CheckOpen(kExtraStuffFile, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kExtraStuffFile, R_OK));
EXPECT_FALSE(perm.CheckAccess(kExtraStuffFile, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kExtraStuffFile));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kExtraStuffFile,
kGoodInotifyMask));
// The sandbox doesn't bother parsing multiple separators in a row:
EXPECT_FALSE(perm.CheckOpen(kDoubleSlash, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen(kDoubleSlash, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kDoubleSlash, R_OK));
EXPECT_FALSE(perm.CheckAccess(kDoubleSlash, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kDoubleSlash));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kDoubleSlash,
kGoodInotifyMask));
// The sandbox auto-rejects paths with parent references:
EXPECT_FALSE(perm.CheckOpen(kParentRef, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen(kParentRef, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kParentRef, R_OK));
EXPECT_FALSE(perm.CheckAccess(kParentRef, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kParentRef));
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kParentRef, kGoodInotifyMask));
// This permission should allow all access to `kPath` specifically.
perm = BrokerFilePermission::AllPermissions(kPath);
EXPECT_TRUE(perm.CheckOpen(kPath, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_TRUE(perm.CheckOpen(kPath, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_TRUE(perm.CheckAccess(kPath, R_OK));
EXPECT_TRUE(perm.CheckAccess(kPath, W_OK));
EXPECT_TRUE(perm.CheckStatWithIntermediates(kPath));
EXPECT_TRUE(
perm.CheckInotifyAddWatchWithIntermediates(kPath, kGoodInotifyMask));
// InotifyAddWatch should still fail without the correct mask.
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates(kPath, kBadInotifyMask));
// Empty string should always fail
EXPECT_FALSE(perm.CheckOpen("", O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen("", O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess("", R_OK));
EXPECT_FALSE(perm.CheckAccess("", W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(""));
EXPECT_FALSE(
perm.CheckInotifyAddWatchWithIntermediates("", kGoodInotifyMask));
// Extra characters on the allowlisted path shouldn't pass:
EXPECT_FALSE(perm.CheckOpen(kExtraStuff, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen(kExtraStuff, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kExtraStuff, R_OK));
EXPECT_FALSE(perm.CheckAccess(kExtraStuff, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kExtraStuff));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kExtraStuff,
kGoodInotifyMask));
// Extra characters and an extra filename on the allowlisted path shouldn't
// pass:
EXPECT_FALSE(
perm.CheckOpen(kExtraStuffFile, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(
perm.CheckOpen(kExtraStuffFile, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kExtraStuffFile, R_OK));
EXPECT_FALSE(perm.CheckAccess(kExtraStuffFile, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kExtraStuffFile));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kExtraStuffFile,
kGoodInotifyMask));
// The sandbox doesn't bother parsing multiple separators in a row:
EXPECT_FALSE(perm.CheckOpen(kDoubleSlash, O_CREAT | O_EXCL | O_RDONLY).first);
EXPECT_FALSE(perm.CheckOpen(kDoubleSlash, O_CREAT | O_EXCL | O_RDWR).first);
EXPECT_FALSE(perm.CheckAccess(kDoubleSlash, R_OK));
EXPECT_FALSE(perm.CheckAccess(kDoubleSlash, W_OK));
EXPECT_FALSE(perm.CheckStatWithIntermediates(kDoubleSlash));
EXPECT_FALSE(perm.CheckInotifyAddWatchWithIntermediates(kDoubleSlash,
kGoodInotifyMask));
}
TEST(BrokerFilePermission, ValidatePath) {
EXPECT_TRUE(BrokerFilePermissionTester::ValidatePath("/path"));
EXPECT_TRUE(BrokerFilePermissionTester::ValidatePath("/"));
EXPECT_TRUE(BrokerFilePermissionTester::ValidatePath("/..path"));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath(""));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("bad"));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("/bad/"));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("bad/"));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("/bad/.."));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("/bad/../bad"));
EXPECT_FALSE(BrokerFilePermissionTester::ValidatePath("/../bad"));
}
} // namespace
} // namespace syscall_broker
} // namespace sandbox
|
