1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/351564777): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "sandbox/linux/syscall_broker/broker_simple_message.h"
#include <linux/kcmp.h>
#include <unistd.h>
#include <algorithm>
#include <array>
#include "base/files/scoped_file.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/logging.h"
#include "base/run_loop.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/thread_pool.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "base/threading/thread.h"
#include "sandbox/linux/syscall_broker/broker_channel.h"
#include "sandbox/linux/syscall_broker/broker_simple_message.h"
#include "sandbox/linux/system_headers/linux_syscalls.h"
#include "sandbox/linux/tests/test_utils.h"
#include "sandbox/linux/tests/unit_tests.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace sandbox {
namespace syscall_broker {
namespace {
void PostWaitableEventToThread(base::Thread* thread,
base::WaitableEvent* wait_event) {
thread->task_runner()->PostTask(FROM_HERE,
base::BindOnce(&base::WaitableEvent::Signal,
base::Unretained(wait_event)));
}
} // namespace
class ExpectedResultValue {
public:
virtual bool NextMessagePieceMatches(BrokerSimpleMessage* message) = 0;
virtual size_t Size() = 0;
};
class ExpectedResultDataValue : public ExpectedResultValue {
public:
ExpectedResultDataValue(const char* data, size_t length);
bool NextMessagePieceMatches(BrokerSimpleMessage* message) override;
size_t Size() override;
private:
const char* data_;
size_t length_;
ExpectedResultDataValue();
};
class ExpectedResultIntValue : public ExpectedResultValue {
public:
explicit ExpectedResultIntValue(int value);
bool NextMessagePieceMatches(BrokerSimpleMessage* message) override;
size_t Size() override;
private:
int value_;
ExpectedResultIntValue();
};
class BrokerSimpleMessageTestHelper {
public:
static bool MessageContentMatches(const BrokerSimpleMessage& message,
const uint8_t* content,
size_t length);
static void SendMsg(int write_fd, BrokerSimpleMessage* message, int fd);
static void RecvMsg(BrokerChannel::EndPoint* ipc_reader,
ExpectedResultValue** expected_values,
int expected_values_length);
static void RecvMsgAndReply(BrokerChannel::EndPoint* ipc_reader,
ExpectedResultValue** expected_values,
int expected_values_length,
const char* response_msg,
int fd);
static void RecvMsgBadRead(BrokerChannel::EndPoint* ipc_reader, int fd);
// Helper functions to write the respective BrokerSimpleMessage::EntryType to
// a buffer. Returns the pointer to the memory right after where the value
// was written to in |dst|.
static uint8_t* WriteDataType(uint8_t* dst);
static uint8_t* WriteIntType(uint8_t* dst);
static size_t entry_type_size() {
return sizeof(BrokerSimpleMessage::EntryType);
}
};
ExpectedResultDataValue::ExpectedResultDataValue() {}
ExpectedResultDataValue::ExpectedResultDataValue(const char* data,
size_t length)
: data_(data), length_(length) {}
bool ExpectedResultDataValue::NextMessagePieceMatches(
BrokerSimpleMessage* message) {
const char* next_data;
size_t next_length;
if (!message->ReadData(&next_data, &next_length))
return false;
if (next_length != length_)
return false;
return strncmp(data_, next_data, length_) == 0;
}
size_t ExpectedResultDataValue::Size() {
return sizeof(size_t) + length_ * sizeof(char) +
BrokerSimpleMessageTestHelper::entry_type_size();
}
ExpectedResultIntValue::ExpectedResultIntValue() {}
ExpectedResultIntValue::ExpectedResultIntValue(int value) : value_(value) {}
bool ExpectedResultIntValue::NextMessagePieceMatches(
BrokerSimpleMessage* message) {
int next_value;
if (!message->ReadInt(&next_value))
return false;
return next_value == value_;
}
size_t ExpectedResultIntValue::Size() {
return sizeof(int) + BrokerSimpleMessageTestHelper::entry_type_size();
}
// static
bool BrokerSimpleMessageTestHelper::MessageContentMatches(
const BrokerSimpleMessage& message,
const uint8_t* content,
size_t length) {
return length == message.length_ &&
memcmp(message.message_, content, length) == 0;
}
// static
void BrokerSimpleMessageTestHelper::SendMsg(int write_fd,
BrokerSimpleMessage* message,
int fd) {
EXPECT_NE(-1, message->SendMsg(write_fd, fd));
}
// static
void BrokerSimpleMessageTestHelper::RecvMsg(
BrokerChannel::EndPoint* ipc_reader,
ExpectedResultValue** expected_values,
int expected_values_length) {
base::ScopedFD return_fd;
BrokerSimpleMessage message;
ssize_t len = message.RecvMsgWithFlags(ipc_reader->get(), 0, &return_fd);
EXPECT_LE(0, len) << "RecvMsgWithFlags response invalid";
size_t expected_message_size = 0;
for (int i = 0; i < expected_values_length; i++) {
ExpectedResultValue* expected_result = expected_values[i];
EXPECT_TRUE(expected_result->NextMessagePieceMatches(&message));
expected_message_size += expected_result->Size();
}
EXPECT_EQ(static_cast<ssize_t>(expected_message_size), len);
}
// static
void BrokerSimpleMessageTestHelper::RecvMsgBadRead(
BrokerChannel::EndPoint* ipc_reader,
int fd) {
base::ScopedFD return_fd;
BrokerSimpleMessage message;
ssize_t len = message.RecvMsgWithFlags(ipc_reader->get(), 0, &return_fd);
EXPECT_LE(0, len) << "RecvMSgWithFlags response invalid";
// Try to read a string instead of the int.
const char* bad_str;
EXPECT_FALSE(message.ReadString(&bad_str));
// Now try to read the int, the message should be marked as broken at this
// point.
int expected_int;
EXPECT_FALSE(message.ReadInt(&expected_int));
// Now try to read the actual string.
const char* expected_str;
EXPECT_FALSE(message.ReadString(&expected_str));
BrokerSimpleMessage response_message;
SendMsg(return_fd.get(), &response_message, -1);
}
// static
void BrokerSimpleMessageTestHelper::RecvMsgAndReply(
BrokerChannel::EndPoint* ipc_reader,
ExpectedResultValue** expected_values,
int expected_values_length,
const char* response_msg,
int fd) {
base::ScopedFD return_fd;
BrokerSimpleMessage message;
ssize_t len = message.RecvMsgWithFlags(ipc_reader->get(), 0, &return_fd);
EXPECT_LT(0, len);
size_t expected_message_size = 0;
for (int i = 0; i < expected_values_length; i++) {
ExpectedResultValue* expected_result = expected_values[i];
EXPECT_TRUE(expected_result->NextMessagePieceMatches(&message));
expected_message_size += expected_result->Size();
}
EXPECT_EQ(expected_message_size, static_cast<size_t>(len));
BrokerSimpleMessage response_message;
response_message.AddDataToMessage(response_msg, strlen(response_msg) + 1);
SendMsg(return_fd.get(), &response_message, -1);
}
// static
uint8_t* BrokerSimpleMessageTestHelper::WriteDataType(uint8_t* dst) {
BrokerSimpleMessage::EntryType type = BrokerSimpleMessage::EntryType::DATA;
memcpy(dst, &type, sizeof(BrokerSimpleMessage::EntryType));
return dst + sizeof(BrokerSimpleMessage::EntryType);
}
// static
uint8_t* BrokerSimpleMessageTestHelper::WriteIntType(uint8_t* dst) {
BrokerSimpleMessage::EntryType type = BrokerSimpleMessage::EntryType::INT;
memcpy(dst, &type, sizeof(BrokerSimpleMessage::EntryType));
return dst + sizeof(BrokerSimpleMessage::EntryType);
}
TEST(BrokerSimpleMessage, AddData) {
const char data1[] = "hello, world";
const char data2[] = "foobar";
const int int1 = 42;
const int int2 = 24;
uint8_t message_content[BrokerSimpleMessage::kMaxMessageLength];
uint8_t* next;
size_t len;
// Simple string
{
BrokerSimpleMessage message;
message.AddDataToMessage(data1, strlen(data1));
next = BrokerSimpleMessageTestHelper::WriteDataType(message_content);
len = strlen(data1);
memcpy(next, &len, sizeof(len));
next = next + sizeof(len);
memcpy(next, data1, strlen(data1));
next = next + strlen(data1);
EXPECT_TRUE(BrokerSimpleMessageTestHelper::MessageContentMatches(
message, message_content, next - message_content));
}
// Simple int
{
BrokerSimpleMessage message;
message.AddIntToMessage(int1);
next = BrokerSimpleMessageTestHelper::WriteIntType(message_content);
memcpy(next, &int1, sizeof(int));
next = next + sizeof(int);
EXPECT_TRUE(BrokerSimpleMessageTestHelper::MessageContentMatches(
message, message_content, next - message_content));
}
// string then int
{
BrokerSimpleMessage message;
message.AddDataToMessage(data1, strlen(data1));
message.AddIntToMessage(int1);
// string
next = BrokerSimpleMessageTestHelper::WriteDataType(message_content);
len = strlen(data1);
memcpy(next, &len, sizeof(len));
next = next + sizeof(len);
memcpy(next, data1, strlen(data1));
next = next + strlen(data1);
// int
next = BrokerSimpleMessageTestHelper::WriteIntType(next);
memcpy(next, &int1, sizeof(int));
next = next + sizeof(int);
EXPECT_TRUE(BrokerSimpleMessageTestHelper::MessageContentMatches(
message, message_content, next - message_content));
}
// int then string
{
BrokerSimpleMessage message;
message.AddIntToMessage(int1);
message.AddDataToMessage(data1, strlen(data1));
// int
next = BrokerSimpleMessageTestHelper::WriteIntType(message_content);
memcpy(next, &int1, sizeof(int));
next = next + sizeof(int);
// string
next = BrokerSimpleMessageTestHelper::WriteDataType(next);
len = strlen(data1);
memcpy(next, &len, sizeof(len));
next = next + sizeof(len);
memcpy(next, data1, strlen(data1));
next = next + strlen(data1);
EXPECT_TRUE(BrokerSimpleMessageTestHelper::MessageContentMatches(
message, message_content, next - message_content));
}
// string int string int
{
BrokerSimpleMessage message;
message.AddDataToMessage(data1, strlen(data1));
message.AddIntToMessage(int1);
message.AddDataToMessage(data2, strlen(data2));
message.AddIntToMessage(int2);
// string
next = BrokerSimpleMessageTestHelper::WriteDataType(message_content);
len = strlen(data1);
memcpy(next, &len, sizeof(len));
next = next + sizeof(len);
memcpy(next, data1, strlen(data1));
next = next + strlen(data1);
// int
next = BrokerSimpleMessageTestHelper::WriteIntType(next);
memcpy(next, &int1, sizeof(int));
next = next + sizeof(int);
// string
next = BrokerSimpleMessageTestHelper::WriteDataType(next);
len = strlen(data2);
memcpy(next, &len, sizeof(len));
next = next + sizeof(len);
memcpy(next, data2, strlen(data2));
next = next + strlen(data2);
// int
next = BrokerSimpleMessageTestHelper::WriteIntType(next);
memcpy(next, &int2, sizeof(int));
next = next + sizeof(int);
EXPECT_TRUE(BrokerSimpleMessageTestHelper::MessageContentMatches(
message, message_content, next - message_content));
}
// Add too much data
{
BrokerSimpleMessage message;
std::array<char, 8192> foo;
std::fill(foo.begin(), foo.end(), 'x');
EXPECT_FALSE(message.AddDataToMessage(foo.data(), sizeof(foo)));
}
}
TEST(BrokerSimpleMessage, SendAndRecvMsg) {
const char data1[] = "hello, world";
const char data2[] = "foobar";
const int int1 = 42;
const int int2 = 24;
base::Thread message_thread("SendMessageThread");
ASSERT_TRUE(message_thread.Start());
base::WaitableEvent wait_event(
base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED);
// Empty message case
{
SCOPED_TRACE("Empty message case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
BrokerSimpleMessage send_message;
message_thread.task_runner()->PostTask(
FROM_HERE, base::BindOnce(&BrokerSimpleMessageTestHelper::SendMsg,
ipc_writer.get(), &send_message, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessageTestHelper::RecvMsg(&ipc_reader, nullptr, 0);
wait_event.Wait();
}
// Simple string case
{
SCOPED_TRACE("Simple string case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
BrokerSimpleMessage send_message;
send_message.AddDataToMessage(data1, strlen(data1) + 1);
message_thread.task_runner()->PostTask(
FROM_HERE, base::BindOnce(&BrokerSimpleMessageTestHelper::SendMsg,
ipc_writer.get(), &send_message, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultValue* expected_results[] = {&data1_value};
BrokerSimpleMessageTestHelper::RecvMsg(&ipc_reader, expected_results,
std::size(expected_results));
wait_event.Wait();
}
// Simple int case
{
SCOPED_TRACE("Simple int case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
BrokerSimpleMessage send_message;
send_message.AddIntToMessage(int1);
message_thread.task_runner()->PostTask(
FROM_HERE, base::BindOnce(&BrokerSimpleMessageTestHelper::SendMsg,
ipc_writer.get(), &send_message, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
ExpectedResultIntValue int1_value(int1);
ExpectedResultValue* expected_results[] = {&int1_value};
BrokerSimpleMessageTestHelper::RecvMsg(&ipc_reader, expected_results,
std::size(expected_results));
wait_event.Wait();
}
// Mixed message 1
{
SCOPED_TRACE("Mixed message 1");
base::Thread message_thread_2("SendMessageThread");
ASSERT_TRUE(message_thread_2.Start());
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
BrokerSimpleMessage send_message;
send_message.AddDataToMessage(data1, strlen(data1) + 1);
send_message.AddIntToMessage(int1);
message_thread_2.task_runner()->PostTask(
FROM_HERE, base::BindOnce(&BrokerSimpleMessageTestHelper::SendMsg,
ipc_writer.get(), &send_message, -1));
PostWaitableEventToThread(&message_thread_2, &wait_event);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultIntValue int1_value(int1);
ExpectedResultValue* expected_results[] = {&data1_value, &int1_value};
BrokerSimpleMessageTestHelper::RecvMsg(&ipc_reader, expected_results,
std::size(expected_results));
wait_event.Wait();
}
// Mixed message 2
{
SCOPED_TRACE("Mixed message 2");
base::Thread message_thread_2("SendMessageThread");
ASSERT_TRUE(message_thread_2.Start());
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
BrokerSimpleMessage send_message;
send_message.AddIntToMessage(int1);
send_message.AddDataToMessage(data1, strlen(data1) + 1);
send_message.AddDataToMessage(data2, strlen(data2) + 1);
send_message.AddIntToMessage(int2);
message_thread_2.task_runner()->PostTask(
FROM_HERE, base::BindOnce(&BrokerSimpleMessageTestHelper::SendMsg,
ipc_writer.get(), &send_message, -1));
PostWaitableEventToThread(&message_thread_2, &wait_event);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultDataValue data2_value(data2, strlen(data2) + 1);
ExpectedResultIntValue int1_value(int1);
ExpectedResultIntValue int2_value(int2);
ExpectedResultValue* expected_results[] = {&int1_value, &data1_value,
&data2_value, &int2_value};
BrokerSimpleMessageTestHelper::RecvMsg(&ipc_reader, expected_results,
std::size(expected_results));
wait_event.Wait();
}
}
TEST(BrokerSimpleMessage, SendRecvMsgSynchronous) {
const char data1[] = "hello, world";
const char data2[] = "foobar";
const int int1 = 42;
const int int2 = 24;
const char reply_data1[] = "baz";
base::Thread message_thread("SendMessageThread");
ASSERT_TRUE(message_thread.Start());
base::WaitableEvent wait_event(
base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED);
// Simple string case
{
SCOPED_TRACE("Simple string case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultValue* expected_results[] = {&data1_value};
message_thread.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BrokerSimpleMessageTestHelper::RecvMsgAndReply,
&ipc_reader, expected_results,
std::size(expected_results), reply_data1, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessage send_message;
send_message.AddDataToMessage(data1, strlen(data1) + 1);
BrokerSimpleMessage reply_message;
base::ScopedFD returned_fd;
ssize_t len = send_message.SendRecvMsgWithFlags(
ipc_writer.get(), 0, &returned_fd, &reply_message);
ExpectedResultDataValue response_value(reply_data1,
strlen(reply_data1) + 1);
EXPECT_TRUE(response_value.NextMessagePieceMatches(&reply_message));
EXPECT_EQ(len, static_cast<ssize_t>(response_value.Size()));
wait_event.Wait();
}
// Simple int case
{
SCOPED_TRACE("Simple int case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
ExpectedResultIntValue int1_value(int1);
ExpectedResultValue* expected_results[] = {&int1_value};
message_thread.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BrokerSimpleMessageTestHelper::RecvMsgAndReply,
&ipc_reader, expected_results,
std::size(expected_results), reply_data1, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessage send_message;
send_message.AddIntToMessage(int1);
BrokerSimpleMessage reply_message;
base::ScopedFD returned_fd;
ssize_t len = send_message.SendRecvMsgWithFlags(
ipc_writer.get(), 0, &returned_fd, &reply_message);
ExpectedResultDataValue response_value(reply_data1,
strlen(reply_data1) + 1);
EXPECT_TRUE(response_value.NextMessagePieceMatches(&reply_message));
EXPECT_EQ(len, static_cast<ssize_t>(response_value.Size()));
wait_event.Wait();
}
// Mixed message 1
{
SCOPED_TRACE("Mixed message 1");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultIntValue int1_value(int1);
ExpectedResultValue* expected_results[] = {&data1_value, &int1_value};
message_thread.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BrokerSimpleMessageTestHelper::RecvMsgAndReply,
&ipc_reader, expected_results,
std::size(expected_results), reply_data1, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessage send_message;
send_message.AddDataToMessage(data1, strlen(data1) + 1);
send_message.AddIntToMessage(int1);
BrokerSimpleMessage reply_message;
base::ScopedFD returned_fd;
ssize_t len = send_message.SendRecvMsgWithFlags(
ipc_writer.get(), 0, &returned_fd, &reply_message);
ExpectedResultDataValue response_value(reply_data1,
strlen(reply_data1) + 1);
EXPECT_TRUE(response_value.NextMessagePieceMatches(&reply_message));
EXPECT_EQ(len, static_cast<ssize_t>(response_value.Size()));
wait_event.Wait();
}
// Mixed message 2
{
SCOPED_TRACE("Mixed message 2");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
ExpectedResultDataValue data1_value(data1, strlen(data1) + 1);
ExpectedResultIntValue int1_value(int1);
ExpectedResultIntValue int2_value(int2);
ExpectedResultDataValue data2_value(data2, strlen(data2) + 1);
ExpectedResultValue* expected_results[] = {&data1_value, &int1_value,
&int2_value, &data2_value};
message_thread.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BrokerSimpleMessageTestHelper::RecvMsgAndReply,
&ipc_reader, expected_results,
std::size(expected_results), reply_data1, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessage send_message;
send_message.AddDataToMessage(data1, strlen(data1) + 1);
send_message.AddIntToMessage(int1);
send_message.AddIntToMessage(int2);
send_message.AddDataToMessage(data2, strlen(data2) + 1);
BrokerSimpleMessage reply_message;
base::ScopedFD returned_fd;
ssize_t len = send_message.SendRecvMsgWithFlags(
ipc_writer.get(), 0, &returned_fd, &reply_message);
ExpectedResultDataValue response_value(reply_data1,
strlen(reply_data1) + 1);
EXPECT_TRUE(response_value.NextMessagePieceMatches(&reply_message));
EXPECT_EQ(len, static_cast<ssize_t>(response_value.Size()));
wait_event.Wait();
}
// Bad read case
{
SCOPED_TRACE("Bad read case");
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
message_thread.task_runner()->PostTask(
FROM_HERE,
base::BindOnce(&BrokerSimpleMessageTestHelper::RecvMsgBadRead,
&ipc_reader, -1));
PostWaitableEventToThread(&message_thread, &wait_event);
BrokerSimpleMessage send_message;
EXPECT_TRUE(send_message.AddIntToMessage(5));
EXPECT_TRUE(send_message.AddStringToMessage("test"));
BrokerSimpleMessage reply_message;
base::ScopedFD returned_fd;
ssize_t len = send_message.SendRecvMsgWithFlags(
ipc_writer.get(), 0, &returned_fd, &reply_message);
EXPECT_GE(len, 0);
wait_event.Wait();
}
}
namespace {
// Adds a gtest failure and returns false iff any of the following conditions
// are true:
// 1. |fd1| or |fd2| are invalid fds
// 2. Kcmp fails
// 3. fd1 and fd2 do not compare equal under kcmp.
bool CheckKcmpResult(int fd1, int fd2) {
if (fd1 < 0) {
ADD_FAILURE() << "fd1 invalid";
return false;
}
if (fd2 < 0) {
ADD_FAILURE() << "fd2 invalid";
return false;
}
pid_t pid = getpid();
int ret = syscall(__NR_kcmp, pid, pid, KCMP_FILE, fd1, fd2);
if (ret < 0) {
ADD_FAILURE() << "Kcmp failed, errno = " << errno;
return false;
}
if (ret != 0) {
ADD_FAILURE() << "File description did not compare equal to stdout. Kcmp("
<< fd1 << ", " << fd2 << ") = " << ret;
return false;
}
return true;
}
// Receives an fd over |ipc_reader|, and if it does not point to the same
// description as stdout, prints a message and returns false.
// On any other error, also prints a message and returns false.
void ReceiveStdoutDupFd(BrokerChannel::EndPoint* ipc_reader) {
// Receive an fd from |ipc_reader|.
base::ScopedFD recv_fd;
BrokerSimpleMessage msg;
ssize_t len = msg.RecvMsgWithFlags(ipc_reader->get(), 0, &recv_fd);
ASSERT_GE(len, 0) << "Error on RecvMsgWithFlags, errno = " << errno;
CheckKcmpResult(STDOUT_FILENO, recv_fd.get());
}
void ReceiveTwoDupFds(BrokerChannel::EndPoint* ipc_reader) {
// Receive two fds from |ipc_reader|.
BrokerSimpleMessage msg;
std::array<base::ScopedFD, 2> recv_fds;
ssize_t len =
msg.RecvMsgWithFlagsMultipleFds(ipc_reader->get(), 0, {recv_fds});
ASSERT_GE(len, 0) << "Error on RecvMsgWithFlags, errno = " << errno;
CheckKcmpResult(STDOUT_FILENO, recv_fds[0].get());
CheckKcmpResult(STDIN_FILENO, recv_fds[1].get());
}
void ReceiveThreeFdsSendTwoBack(BrokerChannel::EndPoint* ipc_reader) {
// Receive two fds from |ipc_reader|.
BrokerSimpleMessage msg;
std::array<base::ScopedFD, 3> recv_fds;
ssize_t len =
msg.RecvMsgWithFlagsMultipleFds(ipc_reader->get(), 0, {recv_fds});
ASSERT_GE(len, 0) << "Error on RecvMsgWithFlags, errno = " << errno;
ASSERT_TRUE(recv_fds[0].is_valid());
if (!CheckKcmpResult(STDOUT_FILENO, recv_fds[1].get()) ||
!CheckKcmpResult(STDIN_FILENO, recv_fds[2].get())) {
return;
}
BrokerSimpleMessage resp;
std::array<int, 2> send_fds;
send_fds[0] = recv_fds[1].get();
send_fds[1] = recv_fds[2].get();
resp.AddIntToMessage(0); // Dummy int to send message
ASSERT_TRUE(resp.SendMsgMultipleFds(recv_fds[0].get(), {send_fds}));
}
} // namespace
class BrokerSimpleMessageFdTest : public testing::Test {
public:
void SetUp() override {
task_environment_ = std::make_unique<base::test::TaskEnvironment>();
}
bool SkipIfKcmpNotSupported() {
pid_t pid = getpid();
if (syscall(__NR_kcmp, pid, pid, KCMP_FILE, STDOUT_FILENO, STDOUT_FILENO) <
0) {
LOG(INFO) << "Skipping test, kcmp not supported.";
return false;
}
return true;
}
private:
std::unique_ptr<base::test::TaskEnvironment> task_environment_;
};
// Passes one fd with RecvMsg, SendMsg.
TEST_F(BrokerSimpleMessageFdTest, PassOneFd) {
if (!SkipIfKcmpNotSupported())
return;
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
base::RunLoop run_loop;
base::ThreadPool::PostTaskAndReply(
FROM_HERE, base::BindOnce(&ReceiveStdoutDupFd, &ipc_reader),
run_loop.QuitClosure());
BrokerSimpleMessage msg;
msg.AddIntToMessage(0); // Must add a dummy value to send the message.
ASSERT_TRUE(msg.SendMsg(ipc_writer.get(), STDOUT_FILENO));
run_loop.Run();
}
TEST_F(BrokerSimpleMessageFdTest, PassTwoFds) {
if (!SkipIfKcmpNotSupported())
return;
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
base::RunLoop run_loop;
base::ThreadPool::PostTaskAndReply(
FROM_HERE, base::BindOnce(&ReceiveTwoDupFds, &ipc_reader),
run_loop.QuitClosure());
BrokerSimpleMessage msg;
msg.AddIntToMessage(0); // Must add a dummy value to send the message.
std::array<int, 2> send_fds;
send_fds[0] = STDOUT_FILENO;
send_fds[1] = STDIN_FILENO;
ASSERT_TRUE(msg.SendMsgMultipleFds(ipc_writer.get(), {send_fds}));
run_loop.Run();
}
TEST_F(BrokerSimpleMessageFdTest, SynchronousPassTwoFds) {
if (!SkipIfKcmpNotSupported())
return;
BrokerChannel::EndPoint ipc_reader;
BrokerChannel::EndPoint ipc_writer;
BrokerChannel::CreatePair(&ipc_reader, &ipc_writer);
base::RunLoop run_loop;
base::ThreadPool::PostTaskAndReply(
FROM_HERE, base::BindOnce(&ReceiveThreeFdsSendTwoBack, &ipc_reader),
run_loop.QuitClosure());
BrokerSimpleMessage msg, reply;
msg.AddIntToMessage(0); // Must add a dummy value to send the message.
std::array<int, 2> send_fds;
send_fds[0] = STDOUT_FILENO;
send_fds[1] = STDIN_FILENO;
std::array<base::ScopedFD, 2> result_fds;
msg.SendRecvMsgWithFlagsMultipleFds(ipc_writer.get(), 0, {send_fds},
{result_fds}, &reply);
run_loop.Run();
ASSERT_TRUE(CheckKcmpResult(STDOUT_FILENO, result_fds[0].get()));
ASSERT_TRUE(CheckKcmpResult(STDIN_FILENO, result_fds[1].get()));
}
} // namespace syscall_broker
} // namespace sandbox
|