1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "CheckTraceVisitor.h"
#include <vector>
#include "Config.h"
#include "Edge.h"
#include "RecordInfo.h"
using namespace clang;
CheckTraceVisitor::CheckTraceVisitor(CXXMethodDecl* trace,
RecordInfo* info,
RecordCache* cache)
: trace_(trace), info_(info), cache_(cache) {}
bool CheckTraceVisitor::VisitMemberExpr(MemberExpr* member) {
// In weak callbacks, consider any occurrence as a correct usage.
// TODO: We really want to require that isAlive is checked on manually
// processed weak fields.
if (IsWeakCallback()) {
if (FieldDecl* field = dyn_cast<FieldDecl>(member->getMemberDecl()))
FoundField(field, false);
}
return true;
}
bool CheckTraceVisitor::VisitCallExpr(CallExpr* call) {
// In weak callbacks we don't check calls (see VisitMemberExpr).
if (IsWeakCallback())
return true;
Expr* callee = call->getCallee();
// Trace calls from a templated derived class result in a
// DependentScopeMemberExpr because the concrete trace call depends on the
// instantiation of any shared template parameters. In this case the call is
// "unresolved" and we resort to comparing the syntactic type names.
if (DependentScopeDeclRefExpr* expr =
dyn_cast<DependentScopeDeclRefExpr>(callee)) {
CheckDependentScopeDeclRefExpr(call, expr);
return true;
}
if (ImplicitCastExpr* expr = dyn_cast<ImplicitCastExpr>(callee)) {
if (CheckImplicitCastExpr(call, expr))
return true;
}
// A Trace call will have either a |visitor| or a |m_field| argument.
// A RegisterWeakMembers call will have a |this| argument.
// A TraceMultiple will have a |m_field| and a |len| arguments.
// A TraceEphemeron will have a |key| and a |value| arguments.
if ((call->getNumArgs() != 1) && (call->getNumArgs() != 2)) {
return true;
}
Expr* arg = call->getArg(0);
if (UnresolvedMemberExpr* expr = dyn_cast<UnresolvedMemberExpr>(callee)) {
// This could be a trace call of a base class, as explained in the
// comments of CheckTraceBaseCall().
if (CheckTraceBaseCall(call))
return true;
if (expr->getMemberName().getAsString() == kRegisterWeakMembersName)
MarkAllWeakMembersTraced();
QualType base = expr->getBaseType();
if (!base->isPointerType())
return true;
CXXRecordDecl* decl = base->getPointeeType()->getAsCXXRecordDecl();
if (decl)
CheckTraceFieldCall(expr->getMemberName().getAsString(), decl, arg,
call->getNumArgs() > 1 ? call->getArg(1) : nullptr);
return true;
}
if (CXXMemberCallExpr* expr = dyn_cast<CXXMemberCallExpr>(call)) {
if (CheckTraceFieldMemberCall(expr) || CheckRegisterWeakMembers(expr))
return true;
}
CheckTraceBaseCall(call);
return true;
}
bool CheckTraceVisitor::IsTraceCallName(const std::string& name) {
// Currently, a manually dispatched class cannot have mixin bases (having
// one would add a vtable which we explicitly check against). This means
// that we can only make calls to a trace method of the same name. Revisit
// this if our mixin/vtable assumption changes.
return name == trace_->getName();
}
CXXRecordDecl* CheckTraceVisitor::GetDependentTemplatedDecl(
DependentScopeDeclRefExpr* expr) {
NestedNameSpecifier* qual = expr->getQualifier();
if (!qual)
return 0;
const Type* type = qual->getAsType();
if (!type)
return 0;
return RecordInfo::GetDependentTemplatedDecl(*type);
}
namespace {
class FindFieldVisitor : public RecursiveASTVisitor<FindFieldVisitor> {
public:
FindFieldVisitor();
FieldDecl* field() const;
bool TraverseMemberExpr(MemberExpr* member);
private:
FieldDecl* field_;
};
FindFieldVisitor::FindFieldVisitor() : field_(0) {}
FieldDecl* FindFieldVisitor::field() const {
return field_;
}
bool FindFieldVisitor::TraverseMemberExpr(MemberExpr* member) {
if (FieldDecl* field = dyn_cast<FieldDecl>(member->getMemberDecl())) {
field_ = field;
return false;
}
return true;
}
} // namespace
void CheckTraceVisitor::CheckDependentScopeDeclRefExpr(
CallExpr* call,
DependentScopeDeclRefExpr* expr) {
std::string fn_name = expr->getDeclName().getAsString();
// Check for T::Trace(visitor).
if (NestedNameSpecifier* qual = expr->getQualifier()) {
if (const Type* type = qual->getAsType()) {
if (const TemplateTypeParmType* tmpl_parm_type =
type->getAs<TemplateTypeParmType>()) {
const unsigned param_index = tmpl_parm_type->getIndex();
if (param_index >= info_->GetBases().size())
return;
info_->GetBases()[param_index].second.MarkTraced();
}
}
}
CXXRecordDecl* tmpl = GetDependentTemplatedDecl(expr);
if (!tmpl)
return;
// Check for Super<T>::trace(visitor)
if (call->getNumArgs() == 1 && IsTraceCallName(fn_name)) {
RecordInfo::Bases::iterator it = info_->GetBases().begin();
for (; it != info_->GetBases().end(); ++it) {
if (it->first->getName() == tmpl->getName())
it->second.MarkTraced();
}
}
// Check for TraceIfNeeded<T>::trace(visitor, &field) where T cannot be
// resolved
if (call->getNumArgs() == 2 && fn_name == kTraceName &&
tmpl->getName() == kTraceIfNeededName) {
FindFieldVisitor finder;
finder.TraverseStmt(call->getArg(1));
if (finder.field())
FoundField(finder.field(), true);
}
}
bool CheckTraceVisitor::CheckTraceBaseCall(CallExpr* call) {
// Checks for "Base::trace(visitor)"-like calls.
// Checking code for these two variables is shared among MemberExpr* case
// and UnresolvedMemberCase* case below.
//
// For example, if we've got "Base::trace(visitor)" as |call|,
// callee_record will be "Base", and func_name will be "trace".
CXXRecordDecl* callee_record = nullptr;
std::string func_name;
if (MemberExpr* callee = dyn_cast<MemberExpr>(call->getCallee())) {
if (!callee->hasQualifier())
return false;
FunctionDecl* trace_decl =
dyn_cast<FunctionDecl>(callee->getMemberDecl());
if (!trace_decl || !Config::IsTraceMethod(trace_decl))
return false;
const Type* type = callee->getQualifier()->getAsType();
if (!type)
return false;
callee_record = type->getAsCXXRecordDecl();
func_name = std::string(trace_decl->getName());
} else if (UnresolvedMemberExpr* callee =
dyn_cast<UnresolvedMemberExpr>(call->getCallee())) {
// Callee part may become unresolved if the type of the argument
// ("visitor") is a template parameter and the called function is
// overloaded.
//
// Here, we try to find a function that looks like trace() from the
// candidate overloaded functions, and if we find one, we assume it is
// called here.
CXXMethodDecl* trace_decl = nullptr;
for (NamedDecl* named_decl : callee->decls()) {
if (CXXMethodDecl* method_decl = dyn_cast<CXXMethodDecl>(named_decl)) {
if (Config::IsTraceMethod(method_decl)) {
trace_decl = method_decl;
break;
}
}
}
if (!trace_decl)
return false;
// Check if the passed argument is named "visitor".
if (call->getNumArgs() != 1)
return false;
DeclRefExpr* arg = dyn_cast<DeclRefExpr>(call->getArg(0));
if (!arg || arg->getNameInfo().getAsString() != kVisitorVarName)
return false;
callee_record = trace_decl->getParent();
func_name = callee->getMemberName().getAsString();
}
if (!callee_record)
return false;
if (!IsTraceCallName(func_name))
return false;
for (auto& base : info_->GetBases()) {
// We want to deal with omitted trace() function in an intermediary
// class in the class hierarchy, e.g.:
// class A : public GarbageCollected<A> { trace() { ... } };
// class B : public A { /* No trace(); have nothing to trace. */ };
// class C : public B { trace() { B::trace(visitor); } }
// where, B::trace() is actually A::trace(), and in some cases we get
// A as |callee_record| instead of B. We somehow need to mark B as
// traced if we find A::trace() call.
//
// To solve this, here we keep going up the class hierarchy as long as
// they are not required to have a trace method. The implementation is
// a simple DFS, where |base_records| represents the set of base classes
// we need to visit.
std::vector<CXXRecordDecl*> base_records;
base_records.push_back(base.first);
while (!base_records.empty()) {
CXXRecordDecl* base_record = base_records.back();
base_records.pop_back();
if (base_record == callee_record) {
// If we find a matching trace method, pretend the user has written
// a correct trace() method of the base; in the example above, we
// find A::trace() here and mark B as correctly traced.
base.second.MarkTraced();
return true;
}
if (RecordInfo* base_info = cache_->Lookup(base_record)) {
if (!base_info->RequiresTraceMethod()) {
// If this base class is not required to have a trace method, then
// the actual trace method may be defined in an ancestor.
for (auto& inner_base : base_info->GetBases())
base_records.push_back(inner_base.first);
}
}
}
}
return false;
}
bool CheckTraceVisitor::CheckTraceFieldMemberCall(CXXMemberCallExpr* call) {
return CheckTraceFieldCall(
call->getMethodDecl()->getNameAsString(), call->getRecordDecl(),
call->getArg(0), call->getNumArgs() > 1 ? call->getArg(1) : nullptr);
}
bool CheckTraceVisitor::CheckTraceFieldCall(const std::string& name,
CXXRecordDecl* callee,
Expr* arg1,
Expr* arg2) {
if (!Config::IsVisitor(callee->getName())) {
return false;
}
if (name == kTraceName || name == kTraceMultipleName) {
FindFieldVisitor finder;
finder.TraverseStmt(arg1);
if (finder.field()) {
FoundField(finder.field(), false);
}
return true;
}
if (name == kTraceEphemeronName) {
FindFieldVisitor finder1;
finder1.TraverseStmt(arg1);
if (finder1.field()) {
FoundField(finder1.field(), false);
}
assert(arg2);
FindFieldVisitor finder2;
finder2.TraverseStmt(arg2);
if (finder2.field()) {
FoundField(finder2.field(), false);
}
return true;
}
return false;
}
bool CheckTraceVisitor::CheckRegisterWeakMembers(CXXMemberCallExpr* call) {
CXXMethodDecl* fn = call->getMethodDecl();
if (fn->getName() != kRegisterWeakMembersName)
return false;
if (fn->isTemplateInstantiation()) {
const TemplateArgumentList& args =
*fn->getTemplateSpecializationInfo()->TemplateArguments;
// The second template argument is the callback method.
if (args.size() > 1 &&
args[1].getKind() == TemplateArgument::Declaration) {
if (FunctionDecl* callback =
dyn_cast<FunctionDecl>(args[1].getAsDecl())) {
if (callback->hasBody()) {
CheckTraceVisitor nested_visitor(nullptr, info_, nullptr);
nested_visitor.TraverseStmt(callback->getBody());
}
}
// TODO: mark all WeakMember<>s as traced even if
// the body isn't available?
}
}
return true;
}
bool CheckTraceVisitor::IsWeakCallback() const {
return !trace_;
}
void CheckTraceVisitor::MarkTraced(RecordInfo::Fields::iterator it) {
// In a weak callback we can't mark strong fields as traced.
if (IsWeakCallback() && !it->second.edge()->IsWeakMember())
return;
it->second.MarkTraced();
}
void CheckTraceVisitor::MarkTracedIfNeeded(RecordInfo::Fields::iterator it) {
// In a weak callback we can't mark strong fields as traced.
if (IsWeakCallback() && !it->second.edge()->IsWeakMember()) {
return;
}
it->second.MarkTracedIfNeeded();
}
namespace {
RecordInfo::Fields::iterator FindField(RecordInfo* info, FieldDecl* field) {
if (Config::IsTemplateInstantiation(info->record())) {
// Pointer equality on fields does not work for template instantiations.
// The trace method refers to fields of the template definition which
// are different from the instantiated fields that need to be traced.
const std::string& name = field->getNameAsString();
for (RecordInfo::Fields::iterator it = info->GetFields().begin();
it != info->GetFields().end(); ++it) {
if (it->first->getNameAsString() == name) {
return it;
}
}
return info->GetFields().end();
} else {
return info->GetFields().find(field);
}
}
} // namespace
void CheckTraceVisitor::FoundField(FieldDecl* field, bool is_trace_if_needed) {
RecordInfo::Fields::iterator it = FindField(info_, field);
if (it != info_->GetFields().end()) {
if (is_trace_if_needed) {
MarkTracedIfNeeded(it);
} else {
MarkTraced(it);
}
}
}
void CheckTraceVisitor::MarkAllWeakMembersTraced() {
// If we find a call to registerWeakMembers which is unresolved we
// unsoundly consider all weak members as traced.
// TODO: Find out how to validate weak member tracing for unresolved call.
for (auto& field : info_->GetFields()) {
if (field.second.edge()->IsWeakMember())
field.second.MarkTraced();
}
}
bool CheckTraceVisitor::CheckImplicitCastExpr(CallExpr* call,
ImplicitCastExpr* expr) {
DeclRefExpr* sub_expr = dyn_cast<DeclRefExpr>(expr->getSubExpr());
if (!sub_expr)
return false;
NestedNameSpecifier* qualifier = sub_expr->getQualifier();
if (!qualifier)
return false;
CXXRecordDecl* class_decl = qualifier->getAsRecordDecl();
if (!class_decl)
return false;
NamedDecl* found_decl = sub_expr->getFoundDecl();
std::string fn_name = found_decl->getNameAsString();
// Check for TraceIfNeeded<T>::trace(visitor, &field) where T can be resolved
if (call->getNumArgs() == 2 && fn_name == kTraceName &&
class_decl->getName() == kTraceIfNeededName) {
FindFieldVisitor finder;
finder.TraverseStmt(call->getArg(1));
if (finder.field())
FoundField(finder.field(), true);
return true;
}
return false;
}
namespace {
FieldDecl* GetRangeField(CXXForRangeStmt* for_range_stmt) {
DeclStmt* decl_stmt = for_range_stmt->getRangeStmt();
if (!decl_stmt->isSingleDecl()) {
return nullptr;
}
VarDecl* var_decl = dyn_cast<VarDecl>(decl_stmt->getSingleDecl());
if (!var_decl) {
return nullptr;
}
MemberExpr* member_expr = dyn_cast<MemberExpr>(var_decl->getInit());
if (!member_expr) {
return nullptr;
}
FieldDecl* field_decl = dyn_cast<FieldDecl>(member_expr->getMemberDecl());
if (!field_decl) {
return nullptr;
}
return field_decl;
}
} // namespace
bool CheckTraceVisitor::VisitStmt(Stmt* stmt) {
CXXForRangeStmt* for_range = dyn_cast<CXXForRangeStmt>(stmt);
if (!for_range) {
return true;
}
// Array tracing could be phrased as a for-range statement over the array.
FieldDecl* field_decl = GetRangeField(for_range);
if (!field_decl) {
return true;
}
// The range of the for-range statement references a field. If that field
// is an array, assume the array is being traced.
RecordInfo::Fields::iterator it = FindField(info_, field_decl);
if (it == info_->GetFields().end()) {
return true;
}
Edge* field_edge = it->second.edge();
if (field_edge->IsArray()) {
MarkTraced(it);
}
if (field_edge->IsCollection()) {
Collection* collection = static_cast<Collection*>(field_edge);
if (collection->IsSTDCollection() &&
(collection->GetCollectionName() == "array")) {
MarkTraced(it);
}
}
return true;
}
|