1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <tuple>
#include <vector>
#include "base/memory/raw_ptr.h"
// Regression tests about `base::span` not supporting operator bool()
// This is based on `WaitMany` from mojo/public/cpp/system/wait.cc.
using Handle = int;
// Expected rewrite:
// void f(const base::span<Handle>& handles, size_t num_handles) {
void f(Handle* handles, size_t num_handles) {
// Expected rewrite:
// if (handles.empty() || !num_handles)
if (!handles || !num_handles) {
return;
}
for (size_t i = 0; i < num_handles; ++i) {
// Do something with handles[i]
handles[i]++;
}
}
void g() {
Handle handles[2] = {1, 2};
f(handles, 2);
f(nullptr, 0);
f(nullptr, 2);
f(handles, 0);
}
// Regression tests to ensure `!` won't be added into a macro definition.
// `!` should be added before the macro argument.
// The following code pattern is actually used in CHECK macro family.
// No rewrite expected.
#define IMPLICITLY_CONVERT_TO_BOOL(expr) \
if ((expr) ? true : false) { \
}
void implicit_cast_to_bool() {
// Expected rewrite:
// base::span<int> buf = {};
int* buf = nullptr;
std::ignore = buf[0];
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(!buf.empty());
IMPLICITLY_CONVERT_TO_BOOL(buf);
}
void implicit_call_to_operator_bool() {
// Expected rewrite:
// base::raw_span<int> buf = {};
raw_ptr<int> buf = nullptr;
// Expected rewrite:
// base::span<int> ptr = buf;
int* ptr = buf.get();
std::ignore = ptr[0];
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(!buf.empty());
IMPLICITLY_CONVERT_TO_BOOL(buf);
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(buf.empty());
IMPLICITLY_CONVERT_TO_BOOL(!buf);
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(!buf.empty());
IMPLICITLY_CONVERT_TO_BOOL(!!buf);
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(!ptr.empty());
IMPLICITLY_CONVERT_TO_BOOL(ptr);
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(ptr.empty());
IMPLICITLY_CONVERT_TO_BOOL(!ptr);
// Expected rewrite:
// IMPLICITLY_CONVERT_TO_BOOL(!ptr.empty());
IMPLICITLY_CONVERT_TO_BOOL(!!ptr);
}
// A function that will return a base::span.
// Expected rewrite:
// base::span<int> get_span() {
int* get_span() {
static int buf[] = {1, 2, 3};
return buf;
}
void test_get_span() {
// Expected rewrite:
// base::span<int> buf = get_span();
int* buf = get_span();
buf[0] = 0;
// Expected rewrite:
// if (!get_span().empty()) {
if (get_span()) {
}
// Expected rewrite:
// if (get_span().empty()) {
if (!get_span()) {
}
// Expected rewrite:
// if (!get_span().empty()) {
if (!!get_span()) {
}
}
|
