1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
int UnsafeIndex();
unsigned int UnsafeUnsignedIndex();
// Expected rewrite:
// void UnsafelyModifyIntSlice(base::span<int> slice) {
void UnsafelyModifyIntSlice(int* slice) {
slice[UnsafeIndex()] = 0;
}
void SubspanIntoCStyleArrayIsUnsigned() {
// Expected rewrite:
// static auto ints = std::to_array<int>({0, 1, 2});
static int ints[] = {0, 1, 2};
// Unsigned integer literal -> propagate it as written.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(1u));
UnsafelyModifyIntSlice(&ints[1u]);
// Expression that evaluates unsigned -> propagate it as written.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(UnsafeUnsignedIndex()));
UnsafelyModifyIntSlice(&ints[UnsafeUnsignedIndex()]);
// Signed integer literal -> postfix `u`.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(2u));
UnsafelyModifyIntSlice(&ints[2]);
// 1. Different signedness
// 2. `3` is promoted to unsigned
// 3. We can see that the expression is unsigned
// 4. Propagate it as written.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(2u - 1));
UnsafelyModifyIntSlice(&ints[2u - 1]);
// Indexing expression is not integer literal and is signed
// -> wrap the expression in `checked_cast`.
//
// Incidentally, this triggers arrayification of `ints`.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(
// base::span<int>(ints).subspan(base::checked_cast<size_t>(UnsafeIndex())));
UnsafelyModifyIntSlice(&ints[UnsafeIndex()]);
// Compound version of the preceding
// -> wrap the expression in `checked_cast`.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(
// base::span<int>(ints).subspan(base::checked_cast<size_t>(UnsafeIndex()
// + 1)));
UnsafelyModifyIntSlice(&ints[UnsafeIndex() + 1]);
}
// The same test cases as `SubspanIntoCStyleArrayIsUnsigned`.
void SubspanIntoContainerishArrayIsUnsigned() {
static std::vector<int> ints = {0, 1, 2};
// Unsigned integer literal -> propagate it as written.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(1u));
UnsafelyModifyIntSlice(&ints[1u]);
// Expression that evaluates unsigned -> propagate it as written.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(UnsafeUnsignedIndex()));
UnsafelyModifyIntSlice(&ints[UnsafeUnsignedIndex()]);
// Signed integer literal -> postfix `u`.
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(2u));
UnsafelyModifyIntSlice(&ints[2]);
// 1. Different signedness
// 2. `3` is promoted to unsigned
// 3. We can see that the expression is unsigned
// 4. Propagate it as written.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(2u - 1));
UnsafelyModifyIntSlice(&ints[2u - 1]);
// Indexing expression is not integer literal and is signed
// -> wrap the expression in `checked_cast`.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(
// base::span<int>(ints).subspan(base::checked_cast<size_t>(UnsafeIndex())));
UnsafelyModifyIntSlice(&ints[UnsafeIndex()]);
// Compound version of the preceding
// -> wrap the expression in `checked_cast`.
//
// Expected rewrite:
// UnsafelyModifyIntSlice(base::span<int>(ints).subspan(
// base::checked_cast<size_t>(UnsafeIndex() + 1)));
UnsafelyModifyIntSlice(&ints[UnsafeIndex() + 1]);
}
|
