1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/dialogs/settings_overridden_dialog.h"
#include <algorithm>
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/strings/string_util.h"
#include "base/time/time.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/scoped_test_mv2_enabler.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/extensions/extensions_dialogs.h"
#include "chrome/browser/ui/extensions/settings_api_bubble_helpers.h"
#include "chrome/browser/ui/extensions/settings_overridden_dialog_controller.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/test/base/search_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/search_engines/search_engines_test_util.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
#include "components/vector_icons/vector_icons.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
using DialogResult = SettingsOverriddenDialogController::DialogResult;
namespace {
// A stub dialog controller that displays the dialog with the supplied params.
class TestDialogController : public SettingsOverriddenDialogController {
public:
TestDialogController(ShowParams show_params,
std::optional<DialogResult>* dialog_result_out)
: show_params_(std::move(show_params)),
dialog_result_out_(dialog_result_out) {
DCHECK(dialog_result_out_);
}
TestDialogController(const TestDialogController&) = delete;
TestDialogController& operator=(const TestDialogController&) = delete;
~TestDialogController() override = default;
private:
bool ShouldShow() override { return true; }
ShowParams GetShowParams() override { return show_params_; }
void OnDialogShown() override {}
void HandleDialogResult(DialogResult result) override {
ASSERT_FALSE(dialog_result_out_->has_value());
*dialog_result_out_ = result;
}
const ShowParams show_params_;
// The result to populate. Must outlive this object.
const raw_ptr<std::optional<DialogResult>> dialog_result_out_;
};
} // namespace
class SettingsOverriddenDialogViewBrowserTest : public DialogBrowserTest {
public:
enum class DefaultSearch {
kUseDefault,
kUseNonGoogleFromDefaultList,
kUseNewSearch,
};
SettingsOverriddenDialogViewBrowserTest() = default;
~SettingsOverriddenDialogViewBrowserTest() override = default;
void SetUpOnMainThread() override {
DialogBrowserTest::SetUpOnMainThread();
search_test_utils::WaitForTemplateURLServiceToLoad(
TemplateURLServiceFactory::GetForProfile(browser()->profile()));
}
void ShowUi(const std::string& name) override {
test_name_ = name;
if (name == "SimpleDialog") {
ShowSimpleDialog(false, browser());
} else if (name == "SimpleDialogWithIcon") {
ShowSimpleDialog(true, browser());
} else if (name == "NtpOverriddenDialog_BackToDefault") {
ShowNtpOverriddenDefaultDialog();
} else if (name == "NtpOverriddenDialog_Generic") {
ShowNtpOverriddenGenericDialog();
} else if (name == "SearchOverriddenDialog_BackToGoogle") {
ShowSearchOverriddenDialog(DefaultSearch::kUseDefault);
} else if (name == "SearchOverriddenDialog_BackToOther") {
ShowSearchOverriddenDialog(DefaultSearch::kUseNonGoogleFromDefaultList);
} else {
CHECK_EQ(name, "SearchOverriddenDialog_Generic");
ShowSearchOverriddenDialog(DefaultSearch::kUseNewSearch);
}
}
// Creates, shows, and returns a dialog anchored to the given `browser`. The
// dialog is owned by the views framework.
views::Widget* ShowSimpleDialog(bool show_icon, Browser* browser) {
SettingsOverriddenDialogController::ShowParams params{
u"Settings overridden dialog title",
u"Settings overriden dialog body, which is quite a bit "
u"longer than the title alone"};
if (show_icon) {
params.icon = &vector_icons::kProductIcon;
}
views::NamedWidgetShownWaiter waiter(
views::test::AnyWidgetTestPasskey{},
kExtensionSettingsOverriddenDialogName);
extensions::ShowSettingsOverriddenDialog(
std::make_unique<TestDialogController>(std::move(params),
&dialog_result_),
browser);
return waiter.WaitIfNeededAndGet();
}
void ShowNtpOverriddenDefaultDialog() {
// Load an extension overriding the NTP and open a new tab to trigger the
// dialog.
LoadExtensionOverridingNewTab();
NavigateToNewTab();
}
void ShowNtpOverriddenGenericDialog() {
SetNewSearchProvider(DefaultSearch::kUseNonGoogleFromDefaultList);
LoadExtensionOverridingNewTab();
NavigateToNewTab();
}
void ShowSearchOverriddenDialog(DefaultSearch search) {
SetNewSearchProvider(search);
LoadExtensionOverridingSearch();
PerformSearchFromOmnibox();
}
bool VerifyUi() override {
if (!DialogBrowserTest::VerifyUi()) {
return false;
}
if (base::StartsWith(test_name_, "SearchOverriddenDialog",
base::CompareCase::SENSITIVE)) {
// Note: Because this is a test, we don't actually expect this navigation
// to succeed. But we can still check that the user was sent to
// example.com (the new search engine).
EXPECT_EQ("www.example.com", browser()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL()
.host_piece());
}
return true;
}
std::optional<DialogResult> dialog_result() const { return dialog_result_; }
private:
void LoadExtensionOverridingNewTab() {
base::FilePath test_root_path;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_root_path));
Profile* const profile = browser()->profile();
scoped_refptr<const extensions::Extension> extension =
extensions::ChromeTestExtensionLoader(profile).LoadExtension(
test_root_path.AppendASCII("extensions/api_test/override/newtab"));
ASSERT_TRUE(extension);
}
void LoadExtensionOverridingSearch() {
base::FilePath test_root_path;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &test_root_path));
Profile* const profile = browser()->profile();
scoped_refptr<const extensions::Extension> extension =
extensions::ChromeTestExtensionLoader(profile).LoadExtension(
test_root_path.AppendASCII("extensions/search_provider_override"));
ASSERT_TRUE(extension);
}
void NavigateToNewTab() {
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(chrome::kChromeUINewTabURL),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
}
void SetNewSearchProvider(DefaultSearch search) {
if (search == DefaultSearch::kUseDefault) {
return;
}
TemplateURLService* const template_url_service =
TemplateURLServiceFactory::GetForProfile(browser()->profile());
bool new_search_shows_in_default_list = true;
// If the test requires a search engine that doesn't show in the default
// list, we need to add one.
if (search == DefaultSearch::kUseNewSearch) {
new_search_shows_in_default_list = false;
template_url_service->Add(
std::make_unique<TemplateURL>(*GenerateDummyTemplateURLData("test")));
}
TemplateURLService::TemplateURLVector template_urls =
template_url_service->GetTemplateURLs();
auto iter = std::ranges::find_if(
template_urls, [template_url_service, new_search_shows_in_default_list](
const TemplateURL* turl) {
return !turl->HasGoogleBaseURLs(
template_url_service->search_terms_data()) &&
template_url_service->ShowInDefaultList(turl) ==
new_search_shows_in_default_list;
});
ASSERT_TRUE(iter != template_urls.end());
template_url_service->SetUserSelectedDefaultSearchProvider(*iter);
}
void PerformSearchFromOmnibox() {
ui_test_utils::SendToOmniboxAndSubmit(browser(), "Penguin",
base::TimeTicks::Now());
content::WaitForLoadStop(
browser()->tab_strip_model()->GetActiveWebContents());
}
std::string test_name_;
std::optional<DialogResult> dialog_result_;
// TODO(https://crbug.com/40804030): Remove this when updated to use MV3.
extensions::ScopedTestMV2Enabler mv2_enabler_;
};
////////////////////////////////////////////////////////////////////////////////
// UI Browser Tests
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_SimpleDialog) {
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_SimpleDialogWithIcon) {
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_NtpOverriddenDialog_BackToDefault) {
// Force the post-install NTP UI to be enabled, so that we can test on all
// platforms.
extensions::SetNtpPostInstallUiEnabledForTesting(true);
ShowAndVerifyUi();
extensions::SetNtpPostInstallUiEnabledForTesting(false);
}
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_NtpOverriddenDialog_Generic) {
// Force the post-install NTP UI to be enabled, so that we can test on all
// platforms.
extensions::SetNtpPostInstallUiEnabledForTesting(true);
ShowAndVerifyUi();
extensions::SetNtpPostInstallUiEnabledForTesting(false);
}
// The chrome_settings_overrides API that allows extensions to override the
// default search provider is only available on Windows and Mac.
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_SearchOverriddenDialog_BackToGoogle) {
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_SearchOverriddenDialog_BackToOther) {
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
InvokeUi_SearchOverriddenDialog_Generic) {
ShowAndVerifyUi();
}
#endif // BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
////////////////////////////////////////////////////////////////////////////////
// Functional Browser Tests
// Verify that if the parent window is closed, the dialog notifies the
// controller that it was closed without any user action.
IN_PROC_BROWSER_TEST_F(SettingsOverriddenDialogViewBrowserTest,
DialogWindowClosed) {
Browser* second_browser = CreateBrowser(browser()->profile());
ASSERT_TRUE(second_browser);
views::Widget* dialog = ShowSimpleDialog(false, second_browser);
views::test::WidgetDestroyedWaiter widget_destroyed_waiter(dialog);
CloseBrowserSynchronously(second_browser);
widget_destroyed_waiter.Wait();
ASSERT_TRUE(dialog_result());
EXPECT_EQ(DialogResult::kDialogClosedWithoutUserAction, *dialog_result());
}
|