1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/numerics/clamped_math.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser_element_identifiers.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/toolbar/bookmark_sub_menu_model.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_button.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/multi_contents_drop_target_view.h"
#include "chrome/browser/ui/views/frame/multi_contents_resize_area.h"
#include "chrome/browser/ui/views/frame/multi_contents_view.h"
#include "chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller.h"
#include "chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.h"
#include "chrome/browser/ui/views/test/split_tabs_interactive_test_mixin.h"
#include "chrome/browser/ui/views/test/tab_strip_interactive_test_mixin.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/interaction/interactive_browser_test.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/common/bookmark_pref_names.h"
#include "components/tabs/public/split_tab_collection.h"
#include "components/tabs/public/split_tab_visual_data.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "third_party/blink/public/common/input/web_mouse_event.h"
#include "ui/events/base_event_utils.h"
#include "ui/events/event_modifiers.h"
#include "ui/events/keycodes/keyboard_codes.h"
#include "ui/views/test/views_test_utils.h"
namespace {
class MultiContentsViewBoundsChangedObserver
: public views::ViewObserver,
public ui::test::StateObserver<int> {
public:
explicit MultiContentsViewBoundsChangedObserver(Browser* browser) {
auto* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
CHECK(browser_view);
observation_.Observe(browser_view->multi_contents_view());
}
// ui::test::StateObserver:
int GetStateObserverInitialState() const override {
return bounds_changed_count_;
}
// views::ViewObserver:
void OnViewBoundsChanged(views::View* view) override {
bounds_changed_count_++;
OnStateObserverStateChanged(bounds_changed_count_);
}
void OnViewIsDeleting(views::View* view) override { observation_.Reset(); }
private:
raw_ptr<Browser> browser_;
int bounds_changed_count_ = 0;
base::ScopedObservation<views::View, views::ViewObserver> observation_{this};
};
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kNewTab);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kSecondTab);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kThirdTab);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kFourthTab);
} // namespace
class MultiContentsViewUiTest
: public SplitTabsInteractiveTestMixin<
TabStripInteractiveTestMixin<InteractiveBrowserTest>> {
public:
void SetUpOnMainThread() override {
SplitTabsInteractiveTestMixin::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
}
protected:
TabStripModel* tab_strip_model() { return browser()->tab_strip_model(); }
GURL GetTestUrl() { return embedded_test_server()->GetURL("/title1.html"); }
auto CreateTabsAndEnterSplitView() {
auto result = Steps(
AddInstrumentedTab(kNewTab, GURL(chrome::kChromeUISettingsURL), 0),
CheckResult([=, this]() { return tab_strip_model()->count(); }, 2u),
EnterSplitView(0, 1));
AddDescriptionPrefix(result, "CreateTabsAndEnterSplitView()");
return result;
}
auto CheckResizeValues(base::RepeatingCallback<bool(double, double)> check) {
// MultiContentsView overrides Layout, causing an edge case where resizes
// don't take effect until the next layout pass. Use PollView and
// WaitForState to wait for the expected layout pass to be completed.
using MultiContentsViewLayoutObserver =
views::test::PollingViewObserver<bool, MultiContentsView>;
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(MultiContentsViewLayoutObserver,
kMultiContentsViewLayoutObserver);
auto result = Steps(
PollView(kMultiContentsViewLayoutObserver,
MultiContentsView::kMultiContentsViewElementId,
[check](const MultiContentsView* multi_contents_view) -> bool {
double start_width =
multi_contents_view->start_contents_view_for_testing()
->parent()
->size()
.width();
double end_width =
multi_contents_view->end_contents_view_for_testing()
->parent()
->size()
.width();
return check.Run(start_width, end_width);
}),
WaitForState(kMultiContentsViewLayoutObserver, true));
AddDescriptionPrefix(result, "CheckResizeValues()");
return result;
}
// Perform a check on the contents view sizes following a direct resize call
auto CheckResize(int resize_amount,
base::RepeatingCallback<bool(double, double)> check) {
auto result = Steps(Do([resize_amount, this]() {
multi_contents_view()->OnResize(resize_amount, true);
}),
CheckResizeValues(check));
AddDescriptionPrefix(result, "CheckResize()");
return result;
}
// Perform a check on the contents view sizes following a keyboard-triggered
// resize
auto CheckResizeKey(ui::KeyboardCode key_code,
base::RepeatingCallback<bool(double, double)> check) {
auto result = Steps(
FocusElement(
MultiContentsResizeHandle::kMultiContentsResizeHandleElementId),
SendKeyPress(
MultiContentsResizeHandle::kMultiContentsResizeHandleElementId,
key_code),
CheckResizeValues(check));
AddDescriptionPrefix(result, "CheckResizeKey()");
return result;
}
auto ResizeWindow(int width) {
auto result = Steps(Do([width, this]() {
BrowserView::GetBrowserViewForBrowser(browser())->SetContentsSize(
gfx::Size(width, 1000));
}));
AddDescriptionPrefix(result, "ResizeWindow()");
return result;
}
auto SetMinWidth(int width) {
auto result = Steps(Do([width, this]() {
multi_contents_view()->set_min_contents_width_for_testing(width);
}));
AddDescriptionPrefix(result, "SetMinWidth()");
return result;
}
auto CheckActiveContentsHasFocus() {
return CheckView(
MultiContentsView::kMultiContentsViewElementId,
[](MultiContentsView* multi_contents_view) -> bool {
return multi_contents_view->GetActiveContentsView()->HasFocus();
});
}
};
// Check that MultiContentsView exists when the side by side flag is enabled
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, ExistsWithFlag) {
RunTestSequence(
EnsurePresent(MultiContentsView::kMultiContentsViewElementId));
}
// Create a new split and exit the split view and ensure only 1 contents view is
// visible
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, EnterAndExitSplitViews) {
RunTestSequence(
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
ExitSplitView(0), WaitForActiveTabChange(0),
CheckResult([this]() { return tab_strip_model()->count(); }, 2u));
}
// Tests switching tabs with split views. This also adds coverage to ensuring
// that there isn't any unnecessary re-layout during tab switching.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, TabSwitchWithSplitView) {
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(MultiContentsViewBoundsChangedObserver,
kMultiContentsViewBoundsChangedObserver);
RunTestSequence(
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
AddInstrumentedTab(kSecondTab, GURL(chrome::kChromeUISettingsURL), 2),
WaitForActiveTabChange(2),
SelectTab(kTabStripElementId, 0, InputType::kMouse),
// Check if there is just one resizing event that happens when switching
// between a split view to a regular tab.
WaitForActiveTabChange(0),
ObserveState(kMultiContentsViewBoundsChangedObserver, browser()),
SelectTab(kTabStripElementId, 2, InputType::kMouse),
WaitForActiveTabChange(2),
CheckState(kMultiContentsViewBoundsChangedObserver, 1),
StopObservingState(kMultiContentsViewBoundsChangedObserver));
}
// Check that MultiContentsView changes its active view when inactive view is
// focused using mouse click.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ActivatesInactiveViewUsingMouseClick) {
RunTestSequence(CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
FocusInactiveTabInSplit(), WaitForActiveTabChange(1),
CheckActiveContentsHasFocus());
}
// Check that MultiContentsView changes its active view when inactive view is
// focused using keyboard.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ActivatesInactiveViewUsingKeyboard) {
RunTestSequence(
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
// The second contents view should be next in the focus order after
// the resize handle so send a TAB key event to move focus to inactive tab
FocusElement(
MultiContentsResizeHandle::kMultiContentsResizeHandleElementId),
SendKeyPress(
MultiContentsResizeHandle::kMultiContentsResizeHandleElementId,
ui::VKEY_TAB),
WaitForActiveTabChange(1), CheckActiveContentsHasFocus());
}
// Check that MultiContentsView changes its active view when the tab shortcut
// is used and the active view has focus.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ActivatesInactiveViewUsingAccelerator) {
const int kControlCommandModifier =
#if BUILDFLAG(IS_MAC)
ui::EF_COMMAND_DOWN;
#else
ui::EF_CONTROL_DOWN;
#endif
RunTestSequence(
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
FocusWebContents(kNewTab),
SendAccelerator(kBrowserViewElementId,
ui::Accelerator(ui::VKEY_2, kControlCommandModifier)),
WaitForActiveTabChange(1), CheckActiveContentsHasFocus());
}
// Check focus for the MultiContentView when in split view
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, ActiveContentsViewHasFocus) {
RunTestSequence(
AddInstrumentedTab(kNewTab, GURL(chrome::kChromeUISettingsURL), 1),
FocusWebContents(kNewTab),
AddInstrumentedTab(kSecondTab, GURL(chrome::kChromeUISettingsURL), 2),
FocusWebContents(kSecondTab),
CheckResult([this]() { return tab_strip_model()->count(); }, 3u),
EnterSplitView(2, 0), WaitForActiveTabChange(2),
CheckActiveContentsHasFocus());
}
// Split view active tab change while browser window doesn't have focus. This
// is used to simulate tab switching scenarios using Tab Search
// TODO(https://crbug.com/422941990): Flaky (times out) on Linux and Windows
// debug bots.
#if !defined(NDEBUG) && (BUILDFLAG(IS_WIN) || BUILDFLAG(IS_LINUX))
#define MAYBE_TabChangeInSplitViewWithInactiveBrowserWindow \
DISABLED_TabChangeInSplitViewWithInactiveBrowserWindow
#else
#define MAYBE_TabChangeInSplitViewWithInactiveBrowserWindow \
TabChangeInSplitViewWithInactiveBrowserWindow
#endif
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
MAYBE_TabChangeInSplitViewWithInactiveBrowserWindow) {
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kFirstTab);
RunTestSequence(
InstrumentTab(kFirstTab, 0),
NavigateWebContents(kFirstTab, GURL(chrome::kChromeUISettingsURL)),
FocusWebContents(kFirstTab),
AddInstrumentedTab(kNewTab, GURL(chrome::kChromeUISettingsURL), 1),
FocusWebContents(kNewTab),
AddInstrumentedTab(kSecondTab, GURL(chrome::kChromeUISettingsURL), 2),
FocusWebContents(kSecondTab),
CheckResult([this]() { return tab_strip_model()->count(); }, 3u),
EnterSplitView(2, 0), WaitForActiveTabChange(2),
PressButton(kTabSearchButtonElementId),
WaitForShow(kTabSearchBubbleElementId),
Do([this]() { browser()->tab_strip_model()->ActivateTabAt(1); }),
WaitForHide(kTabSearchBubbleElementId), WaitForActiveTabChange(1),
CheckActiveContentsHasFocus());
}
// Switch to the not last used tab inside a split view from a not split tab
// while the browser is inactive. This is used to simulate tab switching
// scenarios using Tab Search
// TODO(https://crbug.com/422941990): Flaky (times out) on Linux and Windows
// debug bots.
#if !defined(NDEBUG) && (BUILDFLAG(IS_WIN) || BUILDFLAG(IS_LINUX))
#define MAYBE_SwitchToSplitViewWithInactiveBrowserWindow \
DISABLED_SwitchToSplitViewWithInactiveBrowserWindow
#else
#define MAYBE_SwitchToSplitViewWithInactiveBrowserWindow \
SwitchToSplitViewWithInactiveBrowserWindow
#endif
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
MAYBE_SwitchToSplitViewWithInactiveBrowserWindow) {
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kFirstTab);
RunTestSequence(
InstrumentTab(kFirstTab, 0),
NavigateWebContents(kFirstTab, GURL(chrome::kChromeUISettingsURL)),
FocusWebContents(kFirstTab),
AddInstrumentedTab(kNewTab, GURL(chrome::kChromeUISettingsURL), 1),
FocusWebContents(kNewTab),
AddInstrumentedTab(kSecondTab, GURL(chrome::kChromeUISettingsURL), 2),
FocusWebContents(kSecondTab),
CheckResult([this]() { return tab_strip_model()->count(); }, 3u),
EnterSplitView(2, 0), WaitForActiveTabChange(2),
// Switch from the split view to a regular tab
SelectTab(kTabStripElementId, 0, InputType::kMouse),
WaitForActiveTabChange(0), FocusWebContents(kNewTab),
// Launch the tab search bubble using the tab search button
PressButton(kTabSearchButtonElementId),
WaitForShow(kTabSearchBubbleElementId),
// Switch from a regular tab directly to an inactive tab, which is on
// the left side of a split with the TabSearch bubble dialog opened.
Do([this]() { browser()->tab_strip_model()->ActivateTabAt(1); }),
WaitForHide(kTabSearchBubbleElementId), WaitForActiveTabChange(1),
CheckActiveContentsHasFocus(),
// Switch out of the split view back to the regular tab
SelectTab(kTabStripElementId, 0, InputType::kMouse),
WaitForActiveTabChange(0), FocusWebContents(kNewTab),
// Launch the tab search bubble using the tab search button
PressButton(kTabSearchButtonElementId),
WaitForShow(kTabSearchBubbleElementId),
// Switch from a regular tab directly to an inactive tab, which is on
// the right side of a split with the TabSearch bubble dialog opened.
Do([this]() { browser()->tab_strip_model()->ActivateTabAt(2); }),
WaitForHide(kTabSearchBubbleElementId), WaitForActiveTabChange(2),
CheckActiveContentsHasFocus());
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, ResizesToMinWidth) {
RunTestSequence(
CreateTabsAndEnterSplitView(), ResizeWindow(1000),
// Artificially lower min width so that testing on smaller devices does
// not affect results.
SetMinWidth(60),
CheckResize(
10000, base::BindRepeating([](double start_width, double end_width) {
// On large window, uses flat min width.
return end_width == 60 - MultiContentsView::kSplitViewContentInset;
})));
}
// TODO(crbug.com/399212996): Flaky on linux_chromium_asan_rel_ng, linux-rel
// and linux-chromeos-rel.
#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS))
#define MAYBE_ResizesToMinWidthPercentage DISABLED_ResizesToMinWidthPercentage
#else
#define MAYBE_ResizesToMinWidthPercentage ResizesToMinWidthPercentage
#endif
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
MAYBE_ResizesToMinWidthPercentage) {
RunTestSequence(
CreateTabsAndEnterSplitView(), ResizeWindow(500), SetMinWidth(60),
CheckResize(
10000, base::BindRepeating([](double start_width, double end_width) {
// On small window, uses percentage of window size vs. flat width
// for min. Don't check exact number to avoid rounding issues.
return end_width <
(60 - MultiContentsView::kSplitViewContentInset) &&
end_width > 0;
})));
}
// TODO(crbug.com/399212996): Flaky on linux_chromium_asan_rel_ng and
// chromium/ci/Linux Chromium OS ASan LSan Tests (1).
#if (defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER)) && \
(BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS))
#define MAYBE_ResizesViaKeyboard DISABLED_ResizesViaKeyboard
#else
#define MAYBE_ResizesViaKeyboard ResizesViaKeyboard
#endif
// Check that the MultiContentsView resize area correctly resizes the start and
// end contents views via left and right key events.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, MAYBE_ResizesViaKeyboard) {
RunTestSequence(
CreateTabsAndEnterSplitView(), Check([&]() {
double start_width = multi_contents_view()
->start_contents_view_for_testing()
->size()
.width();
double end_width = multi_contents_view()
->end_contents_view_for_testing()
->size()
.width();
return start_width == end_width;
}),
CheckResizeKey(ui::VKEY_RIGHT, base::BindRepeating([](double start_width,
double end_width) {
return start_width > end_width;
})),
CheckResizeKey(ui::VKEY_LEFT, base::BindRepeating([](double start_width,
double end_width) {
return start_width == end_width;
})),
CheckResizeKey(ui::VKEY_LEFT, base::BindRepeating([](double start_width,
double end_width) {
return start_width > end_width;
})));
}
// Check that MultiContentsView only has insets on the contents views when in a
// split, verify this by checking that the sum of the contents views and resize
// area is less than the total width.
// TODO(crbug.com/397777917): Once this bug is resolved, if MultiContentsView is
// update to use interior margins then we should check whether those are set
// here instead of checking widths.
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, InsetsOnlyInSplit) {
RunTestSequence(
Check([&]() {
return multi_contents_view()
->GetActiveContentsView()
->bounds()
.width() == multi_contents_view()->bounds().width();
}),
CreateTabsAndEnterSplitView(), Check([&]() {
int contents_and_resize_width =
multi_contents_view()->GetActiveContentsView()->bounds().width() +
multi_contents_view()->GetInactiveContentsView()->bounds().width() +
multi_contents_view()->resize_area_for_testing()->bounds().width();
return contents_and_resize_width <
multi_contents_view()->bounds().width();
}));
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ActivatesMostRecentlyActiveTabInSplit) {
RunTestSequence(
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
AddInstrumentedTab(kSecondTab, GURL(chrome::kChromeUISettingsURL), 2),
WaitForActiveTabChange(2),
// Since tab 0 and 1 are part of a split view and tab 0 was the most
// recently focused half of the split it should become the active tab, but
// both tabs will be visible.
SelectTab(kTabStripElementId, 1, InputType::kMouse, 0),
WaitForActiveTabChange(0),
// Select another tab in the split view and ensure the active index
// doesn't change since it isn't the currently focused tab.
SelectTab(kTabStripElementId, 1, InputType::kMouse, 0),
WaitForActiveTabChange(0));
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ResizeMouseDoubleClickSwapsSplitViews) {
using MultiContentsViewSwapObserver =
views::test::PollingViewObserver<bool, MultiContentsView>;
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(MultiContentsViewSwapObserver,
kMultiContentsViewSwapObserver);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kWebContentsId);
RunTestSequence(
// Create a split view with and verify web contents are as expected and
// the active index is correct.
InstrumentTab(kWebContentsId),
NavigateWebContents(kWebContentsId, GURL(chrome::kChromeUINewTabURL)),
CreateTabsAndEnterSplitView(), Check([&]() {
return multi_contents_view()
->start_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUISettingsURL);
}),
Check([&]() {
return multi_contents_view()
->end_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL);
}),
CheckResult([this]() { return tab_strip_model()->active_index(); }, 0),
// Simulate a double click on the resize area to trigger the split tabs to
// swap.
Do([&]() {
auto* resize_area = multi_contents_view()->resize_area_for_testing();
gfx::Point center(resize_area->width() / 2, resize_area->height() / 2);
ui::MouseEvent press_event(
ui::EventType::kMousePressed, center, center, ui::EventTimeForNow(),
ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);
ui::MouseEvent release_event(ui::EventType::kMouseReleased, center,
center, ui::EventTimeForNow(),
ui::EF_LEFT_MOUSE_BUTTON,
ui::EF_LEFT_MOUSE_BUTTON);
press_event.SetClickCount(2);
release_event.SetClickCount(2);
resize_area->OnMousePressed(press_event);
resize_area->OnMouseReleased(release_event);
}),
// Verify the web contents in the split have swapped and the active index
// is correct.
PollView(kMultiContentsViewSwapObserver,
MultiContentsView::kMultiContentsViewElementId,
[&](const MultiContentsView* multi_contents_view) -> bool {
bool first_web_contents_set =
multi_contents_view->start_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL);
bool second_web_contents_set =
multi_contents_view->end_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() ==
GURL(chrome::kChromeUISettingsURL);
return first_web_contents_set && second_web_contents_set;
}),
WaitForState(kMultiContentsViewSwapObserver, true),
WaitForActiveTabChange(1), CheckActiveContentsHasFocus());
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ResizeGestureDoubleTapSwapsSplitViews) {
using MultiContentsViewSwapObserver =
views::test::PollingViewObserver<bool, MultiContentsView>;
DEFINE_LOCAL_STATE_IDENTIFIER_VALUE(MultiContentsViewSwapObserver,
kMultiContentsViewSwapObserver);
DEFINE_LOCAL_ELEMENT_IDENTIFIER_VALUE(kWebContentsId);
RunTestSequence(
// Create a split view with and verify web contents are as expected and
// the active index is correct.
InstrumentTab(kWebContentsId),
NavigateWebContents(kWebContentsId, GURL(chrome::kChromeUINewTabURL)),
CreateTabsAndEnterSplitView(), Check([&]() {
return multi_contents_view()
->start_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUISettingsURL);
}),
Check([&]() {
return multi_contents_view()
->end_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL);
}),
CheckResult([this]() { return tab_strip_model()->active_index(); }, 0),
// Simulate a double press gesture event on the resize area to trigger the
// split tabs to swap.
Do([&]() {
auto* resize_area = multi_contents_view()->resize_area_for_testing();
gfx::Point center(resize_area->width() / 2, resize_area->height() / 2);
ui::GestureEventDetails details(ui::EventType::kGestureTap);
details.set_tap_count(2);
ui::GestureEvent gesture_event(center.x(), center.y(), ui::EF_NONE,
ui::EventTimeForNow(), details);
resize_area->OnGestureEvent(&gesture_event);
}),
// Verify the web contents in the split have swapped and the active index
// is correct.
PollView(kMultiContentsViewSwapObserver,
MultiContentsView::kMultiContentsViewElementId,
[&](const MultiContentsView* multi_contents_view) -> bool {
bool first_web_contents_set =
multi_contents_view->start_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL);
bool second_web_contents_set =
multi_contents_view->end_contents_view_for_testing()
->GetWebContents()
->GetVisibleURL() ==
GURL(chrome::kChromeUISettingsURL);
return first_web_contents_set && second_web_contents_set;
}),
WaitForState(kMultiContentsViewSwapObserver, true),
WaitForActiveTabChange(1), CheckActiveContentsHasFocus());
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ContentsDividersHiddenInSplitView) {
RunTestSequence(
// Open the bookmarks side panel.
PressButton(kToolbarAppMenuButtonElementId),
SelectMenuItem(AppMenuModel::kBookmarksMenuItem),
SelectMenuItem(BookmarkSubMenuModel::kShowBookmarkSidePanelItem),
WaitForShow(kSidePanelElementId),
// Verify expected contents separators are visible. Note, only one side
// panel separator should be visible and the side panel is right aligned
// by default.
WaitForShow(kContentsSeparatorViewElementId),
WaitForShow(kRightAlignedSidePanelSeparatorViewElementId),
WaitForHide(kLeftAlignedSidePanelSeparatorViewElementId),
WaitForShow(kSidePanelRoundedCornerViewElementId),
// Open split view.
CreateTabsAndEnterSplitView(),
// Verify no contents separators are visible.
WaitForHide(kContentsSeparatorViewElementId),
WaitForHide(kRightAlignedSidePanelSeparatorViewElementId),
WaitForHide(kLeftAlignedSidePanelSeparatorViewElementId),
WaitForHide(kSidePanelRoundedCornerViewElementId));
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
MiniToolbarShownForInactiveContents) {
RunTestSequence(
// Open split view.
CreateTabsAndEnterSplitView(), WaitForActiveTabChange(0),
// Verify the mini toolbar is only visible for the inactive contents.
Check([&]() {
return !multi_contents_view()
->mini_toolbar_for_testing(0)
->GetVisible();
}),
Check([&]() {
return multi_contents_view()->mini_toolbar_for_testing(1)->GetVisible();
}),
// Focus inactive contents and verify active tab.
FocusInactiveTabInSplit(), WaitForActiveTabChange(1),
// Verify the mini toolbar is only visile for the newly inactive contents.
Check([&]() {
return multi_contents_view()->mini_toolbar_for_testing(0)->GetVisible();
}),
Check([&]() {
return !multi_contents_view()
->mini_toolbar_for_testing(1)
->GetVisible();
}));
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest, ShowScrimOnOmniboxFocus) {
RunTestSequence(
InstrumentTab(kNewTab), AddInstrumentedTab(kSecondTab, GetTestUrl()),
SelectTab(kTabStripElementId, 0), EnterSplitView(0, 1),
FocusElement(kNewTab),
WaitForHide(MultiContentsView::kEndContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId),
FocusElement(kOmniboxElementId),
WaitForShow(MultiContentsView::kEndContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId),
// Move focus to the inactive tab and trigger scrim on the start tab
FocusInactiveTabInSplit(),
WaitForHide(MultiContentsView::kEndContainerViewScrimElementId),
FocusElement(kOmniboxElementId),
WaitForShow(MultiContentsView::kStartContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kEndContainerViewScrimElementId));
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewUiTest,
ScrimUpdatesForMultipleSplitTabs) {
RunTestSequence(
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kEndContainerViewScrimElementId),
// Create a split tab and verify that the scrim shows
AddInstrumentedTab(kSecondTab, GetTestUrl()),
SelectTab(kTabStripElementId, 0), FocusElement(kOmniboxElementId),
EnterSplitView(0, 1),
WaitForShow(MultiContentsView::kEndContainerViewScrimElementId),
// Create a second split tab
AddInstrumentedTab(kThirdTab, GetTestUrl()),
AddInstrumentedTab(kFourthTab, GetTestUrl()),
SelectTab(kTabStripElementId, 2), FocusElement(kOmniboxElementId),
EnterSplitView(2, 3),
WaitForShow(MultiContentsView::kEndContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId),
// Remove focus from the omnibox split to ensure the second split
// isn't showing a scrim
FocusElement(kThirdTab),
WaitForHide(MultiContentsView::kEndContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId),
// Ensure the scrim is showing when the first split tab is selected
// because it had the omnibox focus
SelectTab(kTabStripElementId, 0),
WaitForShow(MultiContentsView::kEndContainerViewScrimElementId),
EnsureNotPresent(MultiContentsView::kStartContainerViewScrimElementId));
}
// TODO(crbug.com/414590951): There's limited support for testing drag and drop
// on various platforms. These should be re-enabled as support is added.
#if !BUILDFLAG(IS_LINUX) && !BUILDFLAG(IS_WIN) && !BUILDFLAG(IS_CHROMEOS)
gfx::Point PointForDropTargetFromView(views::View* view) {
return view->GetBoundsInScreen().right_center() - gfx::Vector2d(10, 0);
}
class MultiContentsViewDragEntrypointsUiTest : public MultiContentsViewUiTest {
public:
using MultiContentsViewUiTest::MultiContentsViewUiTest;
void SetUp() override {
http_server_.ServeFilesFromSourceDirectory(GetChromeTestDataDir());
ASSERT_TRUE(http_server_.InitializeAndListen());
MultiContentsViewUiTest::SetUp();
}
void SetUpOnMainThread() override {
http_server_.StartAcceptingConnections();
InteractiveBrowserTest::SetUpOnMainThread();
}
GURL GetURL(std::string path) { return http_server_.GetURL(path); }
auto PointForDropTarget() const {
return base::BindLambdaForTesting(
[](views::View* view) { return PointForDropTargetFromView(view); });
}
// The standard DragMouseTo verb waits for the mouse to reach the
// destination. This version does not, since the mouse position sometimes
// doesn't get reported immediately (see `WaitForDropTargetVisible`).
auto DragMouseToWithoutWait(
ElementSpecifier target_view,
base::RepeatingCallback<gfx::Point(views::View*)> pos) {
return WithView(target_view, [pos = std::move(pos)](views::View* view) {
base::RunLoop press_loop(base::RunLoop::Type::kNestableTasksAllowed);
EXPECT_TRUE(ui_controls::SendMouseEventsNotifyWhenDone(
ui_controls::MouseButton::LEFT, ui_controls::MouseButtonState::DOWN,
press_loop.QuitClosure()));
press_loop.Run();
gfx::Point target_location = std::move(pos).Run(view);
EXPECT_TRUE(
ui_controls::SendMouseMove(target_location.x(), target_location.y()));
});
}
auto WaitForDropTargetVisible() {
// This method waits for the drop target to be visible, but also sends
// periodic mouse movement events while waiting. The mouse movements are
// needed to deflake this test on some Mac platforms: in the normal case,
// the initial mouse movement initiates a drag session, which later
// receives "drag updated" events from the OS. However, for some of the
// flakes, these updates are never sent by the OS. Manually generating
// the events seems to fix this.
// We really only need one event timed to execute after the drag session
// starts; an alternative approach would be to add observation to the
// Mac DnD client. Until then, periodic events does the trick.
//
// Note, both branches of AnyOf end with WaitForShow to ensure that the
// only way this step terminates successfully is if the view is shown.
return AnyOf(
RunSubsequence(WaitForShow(
MultiContentsDropTargetView::kMultiContentsDropTargetElementId)),
RunSubsequence(
Steps(
// Programmatically generate a list of mouse movement steps.
[]() {
constexpr int kMouseMovements = 20;
constexpr base::TimeDelta kMovementDelay =
base::Milliseconds(250);
MultiStep mouse_moves;
// Jitter applied to the mouse move destination to ensure it
// changes between each step.
int jitter = 3;
for (int mouse_move_events = 0;
mouse_move_events < kMouseMovements;
++mouse_move_events) {
jitter *= -1;
AddStep(mouse_moves, Do([kMovementDelay] {
base::PlatformThread::Sleep(kMovementDelay);
}));
AddStep(
mouse_moves,
WithView(MultiContentsView::kMultiContentsViewElementId,
[jitter](views::View* view) {
gfx::Point target =
PointForDropTargetFromView(view);
EXPECT_TRUE(ui_controls::SendMouseMove(
target.x() + jitter, target.y()));
}));
}
return mouse_moves;
}()),
// This branch also waits for visibility to prevent it from exiting
// prematurely.
WaitForShow(MultiContentsDropTargetView::
kMultiContentsDropTargetElementId)));
}
private:
net::EmbeddedTestServer http_server_;
};
// TODO(crbug.com/414590951): This test has been flaky on some MacOS versions,
// and DnD testing isn't well-supported for other platforms.
IN_PROC_BROWSER_TEST_F(MultiContentsViewDragEntrypointsUiTest,
DISABLED_ShowsDropTargetOnLinkDragged) {
RunTestSequence(
AddInstrumentedTab(kNewTab, GetURL("/links.html"), 0),
WaitForActiveTabChange(0),
// Drag an href element to the drop target area. The drop
// target should be shown.
MoveMouseTo(kNewTab, DeepQuery{"#title1"}),
DragMouseToWithoutWait(MultiContentsView::kMultiContentsViewElementId,
PointForDropTarget()),
WaitForDropTargetVisible());
}
IN_PROC_BROWSER_TEST_F(MultiContentsViewDragEntrypointsUiTest,
DoesNotShowDropTargetOnNonURLDragged) {
RunTestSequence(
AddInstrumentedTab(kNewTab, GetURL("/button.html"), 0),
WaitForActiveTabChange(0),
// Dragging a non-url to the drop target area should have no
// effect.
MoveMouseTo(kNewTab, DeepQuery{"#button"}),
DragMouseToWithoutWait(MultiContentsView::kMultiContentsViewElementId,
PointForDropTarget()),
WaitForHide(
MultiContentsDropTargetView::kMultiContentsDropTargetElementId));
}
class MultiContentsViewBookmarkDragEntrypointsUiTest
: public MultiContentsViewDragEntrypointsUiTest {
public:
using MultiContentsViewDragEntrypointsUiTest::
MultiContentsViewDragEntrypointsUiTest;
void SetUpOnMainThread() override {
MultiContentsViewDragEntrypointsUiTest::SetUpOnMainThread();
browser()->profile()->GetPrefs()->SetBoolean(
bookmarks::prefs::kShowBookmarkBar, true);
}
// Names the bookmark bar button for the given bookmark folder.
auto NameBookmarkButton(std::string assigned_name,
std::u16string node_title) {
return NameViewRelative(
kBookmarkBarElementId, assigned_name,
base::BindLambdaForTesting([=](views::View* view) -> views::View* {
auto* const bookmark_bar = views::AsViewClass<BookmarkBarView>(view);
CHECK(bookmark_bar);
for (views::View* child : bookmark_bar->children()) {
auto* bookmark_button = views::AsViewClass<BookmarkButton>(child);
if (bookmark_button && bookmark_button->GetText() == node_title) {
return bookmark_button;
}
}
NOTREACHED() << "Bookmark button with title " << node_title
<< " not found.";
}));
}
};
// TODO(crbug.com/414590951): This test has been flaky on some MacOS versions,
// and DnD testing isn't well-supported for other platforms.
IN_PROC_BROWSER_TEST_F(MultiContentsViewBookmarkDragEntrypointsUiTest,
DISABLED_ShowsDropTargetOnBookmarkedLinkDragged) {
bookmarks::BookmarkModel* const model =
BookmarkModelFactory::GetForBrowserContext(browser()->profile());
const std::u16string bookmark_title = u"Bookmark";
model->AddNewURL(model->bookmark_bar_node(), 0, u"Bookmark",
GetURL("/links.html"));
const std::string kBookmarkButtonId = "bookmark_button";
RunTestSequence(
AddInstrumentedTab(kNewTab, GURL(chrome::kChromeUISettingsURL), 0),
WaitForActiveTabChange(0), WaitForShow(kBookmarkBarElementId),
NameBookmarkButton(kBookmarkButtonId, bookmark_title),
MoveMouseTo(kBookmarkButtonId),
DragMouseToWithoutWait(MultiContentsView::kMultiContentsViewElementId,
PointForDropTarget()),
WaitForDropTargetVisible());
}
#endif // !BUILDFLAG(IS_LINUX) && !BUILDFLAG(IS_WIN) && !BUILDFLAG(IS_CHROMEOS)
|