1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view.h"
#include <tuple>
#include "base/files/file_util.h"
#include "base/memory/raw_ptr.h"
#include "base/test/test_future.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/color/chrome_color_id.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h"
#include "chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_test_helper.h"
#include "chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_view.h"
#include "chrome/browser/ui/views/web_apps/frame_toolbar/web_app_toolbar_button_container.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/ui/web_applications/web_app_browsertest_base.h"
#include "chrome/browser/web_applications/mojom/user_display_mode.mojom.h"
#include "chrome/browser/web_applications/test/os_integration_test_override_impl.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "ui/base/hit_test.h"
#include "ui/gfx/color_utils.h"
#include "ui/views/accessibility/view_accessibility.h"
#include "ui/views/test/test_views.h"
#include "ui/views/view_utils.h"
#if BUILDFLAG(IS_LINUX)
#include "ui/linux/linux_ui.h"
#include "ui/linux/linux_ui_factory.h"
#include "ui/linux/linux_ui_getter.h"
class FakeLinuxUiGetter : public ui::LinuxUiGetter {
public:
explicit FakeLinuxUiGetter(bool use_system_theme)
: use_system_theme_(use_system_theme) {}
ui::LinuxUiTheme* GetForWindow(aura::Window* window) override {
return GetForProfile(nullptr);
}
ui::LinuxUiTheme* GetForProfile(Profile* profile) override {
return use_system_theme_ ? ui::GetDefaultLinuxUiTheme() : nullptr;
}
private:
const bool use_system_theme_;
};
#endif
// Tests web-app windows that use the OpaqueBrowserFrameView implementation
// for their non client frames.
class WebAppOpaqueBrowserFrameViewTest : public web_app::WebAppBrowserTestBase {
public:
WebAppOpaqueBrowserFrameViewTest() = default;
WebAppOpaqueBrowserFrameViewTest(const WebAppOpaqueBrowserFrameViewTest&) =
delete;
WebAppOpaqueBrowserFrameViewTest& operator=(
const WebAppOpaqueBrowserFrameViewTest&) = delete;
~WebAppOpaqueBrowserFrameViewTest() override = default;
GURL GetAppURL() {
// The page shouldn't have a manifest so no updating will occur to override
// our settings.
return embedded_https_test_server().GetURL("/web_apps/no_manifest.html");
}
void SetUpOnMainThread() override {
web_app::WebAppBrowserTestBase::SetUpOnMainThread();
CHECK(embedded_https_test_server().Start());
SetThemeMode(ThemeMode::kDefault);
#if BUILDFLAG(IS_LINUX)
ui::LinuxUiGetter::set_instance(nullptr);
#endif
}
bool InstallAndLaunchWebApp(
std::optional<SkColor> theme_color = std::nullopt) {
auto web_app_info =
web_app::WebAppInstallInfo::CreateWithStartUrlForTesting(GetAppURL());
web_app_info->scope = GetAppURL().GetWithoutFilename();
web_app_info->theme_color = theme_color;
webapps::AppId app_id = web_app::test::InstallWebApp(
browser()->profile(), std::move(web_app_info));
Browser* app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
browser_view_ = BrowserView::GetBrowserViewForBrowser(app_browser);
views::NonClientFrameView* frame_view =
browser_view_->GetWidget()->non_client_view()->frame_view();
// Not all platform configurations use OpaqueBrowserFrameView for their
// browser windows, see |CreateBrowserNonClientFrameView()|.
bool is_opaque_browser_frame_view =
views::IsViewClass<OpaqueBrowserFrameView>(frame_view);
#if BUILDFLAG(IS_LINUX)
DCHECK(is_opaque_browser_frame_view);
#else
if (!is_opaque_browser_frame_view) {
return false;
}
#endif
opaque_browser_frame_view_ =
static_cast<OpaqueBrowserFrameView*>(frame_view);
web_app_frame_toolbar_ = browser_view_->web_app_frame_toolbar_for_testing();
DCHECK(web_app_frame_toolbar_);
DCHECK(web_app_frame_toolbar_->GetVisible());
return true;
}
int GetRestoredTitleBarHeight() {
return opaque_browser_frame_view_->layout()->NonClientTopHeight(true);
}
enum class ThemeMode {
kSystem,
kDefault,
};
void SetThemeMode(ThemeMode theme_mode) {
#if BUILDFLAG(IS_LINUX)
bool use_system_theme = theme_mode == ThemeMode::kSystem;
linux_ui_getter_ = std::make_unique<FakeLinuxUiGetter>(use_system_theme);
#endif
ThemeService* theme_service =
ThemeServiceFactory::GetForProfile(browser()->profile());
if (theme_mode == ThemeMode::kSystem) {
theme_service->UseSystemTheme();
} else {
theme_service->UseDefaultTheme();
}
ASSERT_EQ(theme_service->UsingDefaultTheme(),
theme_mode == ThemeMode::kDefault);
}
raw_ptr<BrowserView, AcrossTasksDanglingUntriaged> browser_view_ = nullptr;
raw_ptr<OpaqueBrowserFrameView, AcrossTasksDanglingUntriaged>
opaque_browser_frame_view_ = nullptr;
raw_ptr<WebAppFrameToolbarView, AcrossTasksDanglingUntriaged>
web_app_frame_toolbar_ = nullptr;
#if BUILDFLAG(IS_LINUX)
std::unique_ptr<ui::LinuxUiGetter> linux_ui_getter_;
#endif
};
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, NoThemeColor) {
if (!InstallAndLaunchWebApp()) {
GTEST_SKIP();
}
EXPECT_EQ(web_app_frame_toolbar_->active_color_for_testing(),
web_app_frame_toolbar_->GetColorProvider()->GetColor(
kColorFrameCaptionActive));
}
#if BUILDFLAG(IS_LINUX)
// The app theme color should be ignored in system theme mode.
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, SystemThemeColor) {
SetThemeMode(ThemeMode::kSystem);
// Read unthemed native frame color.
SkColor native_frame_color =
BrowserView::GetBrowserViewForBrowser(browser())
->frame()
->GetFrameView()
->GetFrameColor(BrowserFrameActiveState::kActive);
SkColor expected_caption_color =
color_utils::GetColorWithMaxContrast(native_frame_color);
// Install web app with theme color contrasting against native frame color.
SkColor theme_color =
color_utils::GetColorWithMaxContrast(native_frame_color);
EXPECT_NE(color_utils::IsDark(theme_color),
color_utils::IsDark(native_frame_color));
ASSERT_TRUE(InstallAndLaunchWebApp(theme_color));
// App theme color should be ignored in favor of native system theme.
EXPECT_EQ(opaque_browser_frame_view_->GetFrameColor(
BrowserFrameActiveState::kActive),
native_frame_color);
EXPECT_EQ(opaque_browser_frame_view_->GetCaptionColor(
BrowserFrameActiveState::kActive),
expected_caption_color);
EXPECT_EQ(web_app_frame_toolbar_->active_color_for_testing(),
expected_caption_color);
}
#endif // BUILDFLAG(IS_LINUX)
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, LightThemeColor) {
if (!InstallAndLaunchWebApp(SK_ColorYELLOW)) {
GTEST_SKIP();
}
EXPECT_EQ(web_app_frame_toolbar_->active_color_for_testing(),
web_app_frame_toolbar_->GetColorProvider()->GetColor(
kColorFrameCaptionActive));
EXPECT_TRUE(
color_utils::IsDark(*web_app_frame_toolbar_->active_color_for_testing()));
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, DarkThemeColor) {
if (!InstallAndLaunchWebApp(SK_ColorBLUE)) {
GTEST_SKIP();
}
EXPECT_EQ(web_app_frame_toolbar_->active_color_for_testing(),
web_app_frame_toolbar_->GetColorProvider()->GetColor(
kColorFrameCaptionActive));
EXPECT_FALSE(
color_utils::IsDark(*web_app_frame_toolbar_->active_color_for_testing()));
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, MediumThemeColor) {
// Use the theme color for Gmail.
if (!InstallAndLaunchWebApp(SkColorSetRGB(0xD6, 0x49, 0x3B))) {
GTEST_SKIP();
}
EXPECT_EQ(web_app_frame_toolbar_->active_color_for_testing(),
web_app_frame_toolbar_->GetColorProvider()->GetColor(
kColorFrameCaptionActive));
EXPECT_FALSE(
color_utils::IsDark(*web_app_frame_toolbar_->active_color_for_testing()));
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, StaticTitleBarHeight) {
if (!InstallAndLaunchWebApp()) {
GTEST_SKIP();
}
RunScheduledLayouts();
const int title_bar_height = GetRestoredTitleBarHeight();
EXPECT_GT(title_bar_height, 0);
// Add taller children to the web app frame toolbar RHS.
const int container_height = web_app_frame_toolbar_->height();
web_app_frame_toolbar_->get_right_container_for_testing()->AddChildViewRaw(
new views::StaticSizedView(gfx::Size(1, title_bar_height * 2)));
RunScheduledLayouts();
// The height of the web app frame toolbar and title bar should not be
// affected.
EXPECT_EQ(container_height, web_app_frame_toolbar_->height());
EXPECT_EQ(title_bar_height, GetRestoredTitleBarHeight());
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, Fullscreen) {
if (!InstallAndLaunchWebApp()) {
GTEST_SKIP();
}
opaque_browser_frame_view_->frame()->SetFullscreen(true);
browser_view_->GetWidget()->LayoutRootViewIfNecessary();
// Verify that all children except the ClientView are hidden when the window
// is fullscreened.
for (views::View* child : opaque_browser_frame_view_->children()) {
EXPECT_EQ(views::IsViewClass<views::ClientView>(child),
child->GetVisible());
}
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewTest, AccessibleProperties) {
if (!InstallAndLaunchWebApp()) {
GTEST_SKIP();
}
ui::AXNodeData data;
opaque_browser_frame_view_->GetViewAccessibility().GetAccessibleNodeData(
&data);
EXPECT_EQ(data.role, ax::mojom::Role::kPane);
}
#if BUILDFLAG(IS_WIN)
class WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest
: public InProcessBrowserTest {
public:
WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest() = default;
WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest(
const WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest&) = delete;
WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest& operator=(
const WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest&) = delete;
~WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest() override = default;
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
embedded_test_server()->ServeFilesFromDirectory(temp_dir_.GetPath());
ASSERT_TRUE(embedded_test_server()->Start());
InProcessBrowserTest::SetUp();
}
bool InstallAndLaunchWebAppWithWindowControlsOverlay() {
GURL start_url = web_app_frame_toolbar_helper_
.LoadWindowControlsOverlayTestPageWithDataAndGetURL(
embedded_test_server(), &temp_dir_);
auto web_app_info =
web_app::WebAppInstallInfo::CreateWithStartUrlForTesting(start_url);
web_app_info->scope = start_url.GetWithoutFilename();
web_app_info->display_mode = blink::mojom::DisplayMode::kStandalone;
web_app_info->user_display_mode =
web_app::mojom::UserDisplayMode::kStandalone;
web_app_info->title = u"A Web App";
web_app_info->display_override = {
blink::mojom::DisplayMode::kWindowControlsOverlay};
webapps::AppId app_id = web_app::test::InstallWebApp(
browser()->profile(), std::move(web_app_info));
Browser* app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
web_app::NavigateViaLinkClickToURLAndWait(app_browser, start_url);
browser_view_ = BrowserView::GetBrowserViewForBrowser(app_browser);
views::NonClientFrameView* frame_view =
browser_view_->GetWidget()->non_client_view()->frame_view();
// Not all platform configurations use OpaqueBrowserFrameView for their
// browser windows, see |CreateBrowserNonClientFrameView()|.
bool is_opaque_browser_frame_view =
views::IsViewClass<OpaqueBrowserFrameView>(frame_view);
if (!is_opaque_browser_frame_view) {
return false;
}
opaque_browser_frame_view_ =
static_cast<OpaqueBrowserFrameView*>(frame_view);
auto* web_app_frame_toolbar =
browser_view_->web_app_frame_toolbar_for_testing();
DCHECK(web_app_frame_toolbar);
DCHECK(web_app_frame_toolbar->GetVisible());
return true;
}
void ToggleWindowControlsOverlayEnabledAndWait() {
auto* web_contents = browser_view_->GetActiveWebContents();
web_app_frame_toolbar_helper_.SetupGeometryChangeCallback(web_contents);
base::test::TestFuture<void> future;
browser_view_->ToggleWindowControlsOverlayEnabled(future.GetCallback());
EXPECT_TRUE(future.Wait());
content::TitleWatcher title_watcher(web_contents, u"ongeometrychange");
std::ignore = title_watcher.WaitAndGetTitle();
}
raw_ptr<BrowserView, AcrossTasksDanglingUntriaged> browser_view_ = nullptr;
raw_ptr<OpaqueBrowserFrameView, AcrossTasksDanglingUntriaged>
opaque_browser_frame_view_ = nullptr;
WebAppFrameToolbarTestHelper web_app_frame_toolbar_helper_;
private:
web_app::OsIntegrationTestOverrideBlockingRegistration faked_os_integration_;
base::ScopedTempDir temp_dir_;
};
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest,
CaptionButtonsTooltip) {
if (!InstallAndLaunchWebAppWithWindowControlsOverlay()) {
GTEST_SKIP() << "Skip test if it is not a OpaqueBrowserFrameView";
}
auto* minimize_button = static_cast<const views::Button*>(
opaque_browser_frame_view_->GetViewByID(VIEW_ID_MINIMIZE_BUTTON));
auto* maximize_button = static_cast<const views::Button*>(
opaque_browser_frame_view_->GetViewByID(VIEW_ID_MAXIMIZE_BUTTON));
auto* restore_button = static_cast<const views::Button*>(
opaque_browser_frame_view_->GetViewByID(VIEW_ID_RESTORE_BUTTON));
auto* close_button = static_cast<const views::Button*>(
opaque_browser_frame_view_->GetViewByID(VIEW_ID_CLOSE_BUTTON));
// Verify tooltip text was first empty.
EXPECT_EQ(minimize_button->GetTooltipText(), u"");
EXPECT_EQ(maximize_button->GetTooltipText(), u"");
EXPECT_EQ(restore_button->GetTooltipText(), u"");
EXPECT_EQ(close_button->GetTooltipText(), u"");
ToggleWindowControlsOverlayEnabledAndWait();
// Verify tooltip text has been updated.
EXPECT_EQ(minimize_button->GetTooltipText(),
minimize_button->GetViewAccessibility().GetCachedName());
EXPECT_EQ(maximize_button->GetTooltipText(),
maximize_button->GetViewAccessibility().GetCachedName());
EXPECT_EQ(restore_button->GetTooltipText(),
restore_button->GetViewAccessibility().GetCachedName());
EXPECT_EQ(close_button->GetTooltipText(),
close_button->GetViewAccessibility().GetCachedName());
ToggleWindowControlsOverlayEnabledAndWait();
// Verify tooltip text has been cleared when the feature is toggled off.
EXPECT_EQ(minimize_button->GetTooltipText(), u"");
EXPECT_EQ(maximize_button->GetTooltipText(), u"");
EXPECT_EQ(restore_button->GetTooltipText(), u"");
EXPECT_EQ(close_button->GetTooltipText(), u"");
}
IN_PROC_BROWSER_TEST_F(WebAppOpaqueBrowserFrameViewWindowControlsOverlayTest,
CaptionButtonHitTest) {
if (!InstallAndLaunchWebAppWithWindowControlsOverlay()) {
GTEST_SKIP() << "Skip test if it is not a OpaqueBrowserFrameView";
}
opaque_browser_frame_view_->GetWidget()->LayoutRootViewIfNecessary();
// Avoid the top right resize corner.
constexpr int kInset = 10;
const gfx::Point kPoint(opaque_browser_frame_view_->width() - kInset, kInset);
EXPECT_EQ(opaque_browser_frame_view_->NonClientHitTest(kPoint), HTCLOSE);
ToggleWindowControlsOverlayEnabledAndWait();
// Verify the component updates on toggle.
EXPECT_EQ(opaque_browser_frame_view_->NonClientHitTest(kPoint), HTCLIENT);
ToggleWindowControlsOverlayEnabledAndWait();
// Verify the component clears when the feature is turned off.
EXPECT_EQ(opaque_browser_frame_view_->NonClientHitTest(kPoint), HTCLOSE);
}
#endif
|