1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
|
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/enterprise/browser/reporting/user_security_signals_service.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/device_signals/core/common/signals_features.h"
#include "components/enterprise/browser/reporting/common_pref_names.h"
#include "components/enterprise/browser/reporting/report_util.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "google_apis/gaia/gaia_constants.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/cookies/cookie_change_dispatcher.h"
#include "services/network/public/mojom/cookie_manager.mojom.h"
#include "services/network/test/test_cookie_manager.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace enterprise_reporting {
using testing::_;
using testing::Mock;
using testing::Return;
namespace {
constexpr char kReportTriggerMetricName[] =
"Enterprise.SecurityReport.User.Trigger";
class MockUserSecuritySignalsServiceDelegate
: public UserSecuritySignalsService::Delegate {
public:
MockUserSecuritySignalsServiceDelegate() = default;
~MockUserSecuritySignalsServiceDelegate() = default;
MOCK_METHOD(void,
OnReportEventTriggered,
(SecurityReportTrigger),
(override));
MOCK_METHOD(network::mojom::CookieManager*, GetCookieManager, (), (override));
};
net::CanonicalCookie GetTestCookie(const GURL& url, const std::string& name) {
std::unique_ptr<net::CanonicalCookie> cookie =
net::CanonicalCookie::CreateSanitizedCookie(
url, name, /*value=*/"cookie_value", /*domain=*/"." + url.host(),
/*path=*/"/", /*creation_time=*/base::Time(),
/*expiration_time=*/base::Time(), /*last_access_time=*/base::Time(),
/*secure=*/true, /*http_only=*/false,
net::CookieSameSite::NO_RESTRICTION, net::COOKIE_PRIORITY_DEFAULT,
/*partition_key=*/std::nullopt, /*status=*/nullptr);
return *cookie;
}
} // namespace
class UserSecuritySignalsServiceTest : public testing::Test {
protected:
UserSecuritySignalsServiceTest() {
testing_prefs_.registry()->RegisterBooleanPref(
kUserSecuritySignalsReporting, false);
testing_prefs_.registry()->RegisterBooleanPref(
kUserSecurityAuthenticatedReporting, false);
}
void SetUp() override {
ON_CALL(delegate_, OnReportEventTriggered(_))
.WillByDefault(
[&](SecurityReportTrigger) { service_->OnReportUploaded(); });
ON_CALL(delegate_, GetCookieManager())
.WillByDefault(Return(&test_cookie_manager_));
}
void SetEnabledPolicy(bool enabled) {
testing_prefs_.SetBoolean(kUserSecuritySignalsReporting, enabled);
}
void SetUseAuthPolicy(bool use_auth) {
testing_prefs_.SetBoolean(kUserSecurityAuthenticatedReporting, use_auth);
}
void CreateAndRunSignalsService(bool expect_reporting_enabled = true,
bool expect_using_cookie = false) {
// Creation of the service with the pref value already enabled will trigger
// an upload.
EXPECT_CALL(delegate_, OnReportEventTriggered(_))
.Times(expect_reporting_enabled ? 1 : 0);
if (expect_using_cookie) {
EXPECT_CALL(delegate_, GetCookieManager());
}
service_ = std::make_unique<UserSecuritySignalsService>(&testing_prefs_,
&delegate_);
service_->Start();
task_environment_.RunUntilIdle();
ASSERT_EQ(service_->IsSecuritySignalsReportingEnabled(),
expect_reporting_enabled);
ASSERT_EQ(service_->ShouldUseCookies(), expect_using_cookie);
}
void FastForwardTimeToTrigger() {
task_environment_.FastForwardBy(
UserSecuritySignalsService::GetSecurityUploadCadence());
}
void FastForwardByHalfTimeToTrigger() {
// Adding a second to remove rounding errors.
task_environment_.FastForwardBy(
UserSecuritySignalsService::GetSecurityUploadCadence() / 2 +
base::Seconds(1));
}
void FastForwardCustomTime(base::TimeDelta time) {
task_environment_.FastForwardBy(time);
}
void TriggerValidCookieInsert() {
test_cookie_manager_.DispatchCookieChange(net::CookieChangeInfo(
GetTestCookie(GaiaUrls::GetInstance()->secure_google_url(),
GaiaConstants::kGaiaSigninCookieName),
net::CookieAccessResult(), net::CookieChangeCause::INSERTED));
}
void FlushForTesting() {
if (service_ && service_->cookie_listener_receiver_.is_bound()) {
service_->cookie_listener_receiver_.FlushForTesting();
}
}
// Note: Cadence unit is hours.
void OverrideSecurityUploadCadence(base::TimeDelta new_cadence) {
feature_list_.InitAndEnableFeatureWithParameters(
enterprise_signals::features::kProfileSignalsReportingEnabled,
{{enterprise_signals::features::kProfileSignalsReportingInterval.name,
base::ToString(new_cadence.InHours()) + "h"}});
}
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
TestingPrefServiceSimple testing_prefs_;
std::unique_ptr<UserSecuritySignalsService> service_ = nullptr;
testing::StrictMock<MockUserSecuritySignalsServiceDelegate> delegate_;
network::TestCookieManager test_cookie_manager_;
base::HistogramTester histogram_tester_;
base::test::ScopedFeatureList feature_list_;
};
TEST_F(UserSecuritySignalsServiceTest, NotStarted) {
service_ =
std::make_unique<UserSecuritySignalsService>(&testing_prefs_, &delegate_);
EXPECT_FALSE(service_->IsSecuritySignalsReportingEnabled());
EXPECT_FALSE(service_->ShouldUseCookies());
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
// Pref values should be available even if the service was not started.
EXPECT_TRUE(service_->IsSecuritySignalsReportingEnabled());
EXPECT_TRUE(service_->ShouldUseCookies());
// No trigger should occur even if we fast forward.
FastForwardTimeToTrigger();
histogram_tester_.ExpectTotalCount(kReportTriggerMetricName, 0);
}
TEST_F(UserSecuritySignalsServiceTest, PolicyDefault) {
EXPECT_CALL(delegate_, OnReportEventTriggered(_)).Times(0);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/false);
// No trigger should occur even if we fast forward.
FastForwardTimeToTrigger();
histogram_tester_.ExpectTotalCount(kReportTriggerMetricName, 0);
}
TEST_F(UserSecuritySignalsServiceTest, PolicyEnabledWithoutCookies) {
SetEnabledPolicy(true);
CreateAndRunSignalsService();
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
}
TEST_F(UserSecuritySignalsServiceTest, PolicyEnabledWithCookies_FastForwards) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/true,
/*expect_using_cookie=*/true);
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forwarding should trigger another upload.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardTimeToTrigger();
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forwarding again should trigger another upload.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardTimeToTrigger();
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 3);
}
// Test case to simulate when a security signals report is uploaded by a
// different service. For example, Chrome profile reporting can send a full
// report with security signals on its own schedule.
TEST_F(UserSecuritySignalsServiceTest,
PolicyEnabledWithCookies_ExternalTriggerDelays) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/true,
/*expect_using_cookie=*/true);
Mock::VerifyAndClearExpectations(&delegate_);
// Signaling that a report was uploaded after waiting a halftime means waiting
// another halftime should not result in a second report being triggered.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(0);
FastForwardByHalfTimeToTrigger();
service_->OnReportUploaded();
FastForwardByHalfTimeToTrigger();
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
}
TEST_F(UserSecuritySignalsServiceTest, PolicyBecomesEnabledWithoutCookies) {
CreateAndRunSignalsService(/*expect_reporting_enabled=*/false);
EXPECT_FALSE(service_->IsSecuritySignalsReportingEnabled());
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(0);
// No trigger should occur even if we fast forward.
FastForwardTimeToTrigger();
Mock::VerifyAndClearExpectations(&delegate_);
// A report should be triggered when the policy becomes enabled.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
SetEnabledPolicy(true);
task_environment_.RunUntilIdle();
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
}
TEST_F(UserSecuritySignalsServiceTest,
PolicyEnabledWithCookies_NullCookieManager) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
// A upload should occur first on service creation.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
// Having a broken cookie manager should not cause crashes.
EXPECT_CALL(delegate_, GetCookieManager()).WillOnce(Return(nullptr));
service_ =
std::make_unique<UserSecuritySignalsService>(&testing_prefs_, &delegate_);
service_->Start();
task_environment_.RunUntilIdle();
EXPECT_TRUE(service_->IsSecuritySignalsReportingEnabled());
EXPECT_TRUE(service_->ShouldUseCookies());
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
}
TEST_F(UserSecuritySignalsServiceTest,
PolicyEnabledWithCookies_ValidCookieAdded) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/true,
/*expect_using_cookie=*/true);
EXPECT_CALL(delegate_,
OnReportEventTriggered(SecurityReportTrigger::kCookieChange))
.Times(1);
// Fake that the first-party authentication cookie was inserted for the first
// time.
TriggerValidCookieInsert();
FlushForTesting();
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kCookieChange, 1);
}
TEST_F(UserSecuritySignalsServiceTest,
PolicyEnabledWithCookies_ValidCookieUpdated) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/true,
/*expect_using_cookie=*/true);
EXPECT_CALL(delegate_,
OnReportEventTriggered(SecurityReportTrigger::kCookieChange))
.Times(1);
// Fake that the first-party authentication cookie was updated. When there
// already is an existing cookie, this triggers two events:
// - An overwrite with the old cookie,
// - A insert with the new cookie.
test_cookie_manager_.DispatchCookieChange(net::CookieChangeInfo(
GetTestCookie(GaiaUrls::GetInstance()->secure_google_url(),
GaiaConstants::kGaiaSigninCookieName),
net::CookieAccessResult(), net::CookieChangeCause::OVERWRITE));
TriggerValidCookieInsert();
FlushForTesting();
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kCookieChange, 1);
}
TEST_F(UserSecuritySignalsServiceTest,
PolicyEnabledWithCookies_DifferentCookieEvents) {
SetEnabledPolicy(true);
SetUseAuthPolicy(true);
CreateAndRunSignalsService(/*expect_reporting_enabled=*/true,
/*expect_using_cookie=*/true);
// Fake that various cookie change events were triggered, none with "INSERT".
// This means no additional report should be triggered.
const auto kCases = std::to_array<net::CookieChangeCause>({
net::CookieChangeCause::EXPLICIT,
net::CookieChangeCause::UNKNOWN_DELETION,
net::CookieChangeCause::OVERWRITE,
net::CookieChangeCause::EXPIRED,
net::CookieChangeCause::EVICTED,
net::CookieChangeCause::EXPIRED_OVERWRITE,
net::CookieChangeCause::INSERTED_NO_CHANGE_OVERWRITE,
});
for (const auto& cause : kCases) {
test_cookie_manager_.DispatchCookieChange(net::CookieChangeInfo(
GetTestCookie(GaiaUrls::GetInstance()->secure_google_url(),
GaiaConstants::kGaiaSigninCookieName),
net::CookieAccessResult(), cause));
}
// Fake an insert event for unrelated cookies.
test_cookie_manager_.DispatchCookieChange(net::CookieChangeInfo(
GetTestCookie(GaiaUrls::GetInstance()->secure_google_url(),
"OTHER_1P_COOKIE"),
net::CookieAccessResult(), net::CookieChangeCause::INSERTED));
test_cookie_manager_.DispatchCookieChange(net::CookieChangeInfo(
GetTestCookie(GURL("https://example.com"),
GaiaConstants::kGaiaSigninCookieName),
net::CookieAccessResult(), net::CookieChangeCause::INSERTED));
FlushForTesting();
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kCookieChange, 2);
}
TEST_F(UserSecuritySignalsServiceTest,
DelayedAuthPolicy_AffectsCookieWatching) {
SetEnabledPolicy(true);
SetUseAuthPolicy(false);
CreateAndRunSignalsService();
// Auth policy is not enabled, so this should not trigger any report.
TriggerValidCookieInsert();
FlushForTesting();
// Turning the policy on, which will trigger a report when the cookie changes.
EXPECT_CALL(delegate_, GetCookieManager());
SetUseAuthPolicy(true);
EXPECT_CALL(delegate_,
OnReportEventTriggered(SecurityReportTrigger::kCookieChange))
.Times(1);
TriggerValidCookieInsert();
FlushForTesting();
// Turn it back off, should again not trigger an update.
SetUseAuthPolicy(false);
TriggerValidCookieInsert();
FlushForTesting();
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 1);
histogram_tester_.ExpectBucketCount(kReportTriggerMetricName,
SecurityReportTrigger::kCookieChange, 1);
}
// Test that verifies if the feature flag param overrides the upload cadence
// correctly.
TEST_F(UserSecuritySignalsServiceTest, FlagOverrideCadence) {
auto default_security_upload_cadence =
UserSecuritySignalsService::GetSecurityUploadCadence();
// Overwrite the feature flag parameter to double the upload interval.
OverrideSecurityUploadCadence(default_security_upload_cadence * 2);
SetEnabledPolicy(true);
CreateAndRunSignalsService();
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forwarding should not trigger another upload, since the internval is
// overwritten.
EXPECT_CALL(delegate_, OnReportEventTriggered(_)).Times(0);
FastForwardCustomTime(default_security_upload_cadence);
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forwarding again should trigger another upload.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardCustomTime(default_security_upload_cadence);
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 2);
}
// Test that verifies if the feature flag param overrides the upload cadence
// correctly, even when the timer has already started. Note that this affects
// the timer on next upload while the currently running timer is unaffected.
TEST_F(UserSecuritySignalsServiceTest, FlagOverrideCadenceWhileRunning) {
auto default_security_upload_cadence =
UserSecuritySignalsService::GetSecurityUploadCadence();
SetEnabledPolicy(true);
CreateAndRunSignalsService();
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forwarding should trigger another upload, since the interval is still
// at default value.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardCustomTime(default_security_upload_cadence);
Mock::VerifyAndClearExpectations(&delegate_);
// Overwrite the feature flag parameter to double the upload interval.
OverrideSecurityUploadCadence(default_security_upload_cadence * 2);
// Fast forwarding should trigger another upload because the timer started
// before we overwrite the interval, so it would be using the old value (i.e
// not doubled).
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardCustomTime(default_security_upload_cadence);
Mock::VerifyAndClearExpectations(&delegate_);
// No upload trigger on first fast forward because interval is already
// doubled now.
EXPECT_CALL(delegate_, OnReportEventTriggered(_)).Times(0);
FastForwardCustomTime(default_security_upload_cadence);
Mock::VerifyAndClearExpectations(&delegate_);
// Fast forward again should trigger an upload since we reached the new,
// doubled upload deadline.
EXPECT_CALL(delegate_, OnReportEventTriggered(SecurityReportTrigger::kTimer))
.Times(1);
FastForwardCustomTime(default_security_upload_cadence);
histogram_tester_.ExpectUniqueSample(kReportTriggerMetricName,
SecurityReportTrigger::kTimer, 4);
}
} // namespace enterprise_reporting
|