1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/history_clusters/core/clusterer.h"
#include "base/test/task_environment.h"
#include "components/history_clusters/core/clustering_test_utils.h"
#include "components/history_clusters/core/config.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace history_clusters {
namespace {
using ::testing::ElementsAre;
class ClustererTest : public ::testing::Test {
public:
void SetUp() override {
config_.use_host_for_visit_deduping = false;
SetConfigForTesting(config_);
clusterer_ = std::make_unique<Clusterer>();
}
void TearDown() override { clusterer_.reset(); }
std::vector<history::Cluster> CreateInitialClustersFromVisits(
std::vector<history::ClusterVisit> visits) {
return clusterer_->CreateInitialClustersFromVisits(std::move(visits));
}
private:
Config config_;
std::unique_ptr<Clusterer> clusterer_;
base::test::TaskEnvironment task_environment_;
};
TEST_F(ClustererTest, ClusterOneVisit) {
std::vector<history::ClusterVisit> visits;
// Fill in the visits vector with 1 visit.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://google.com/"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0))));
}
TEST_F(ClustererTest, ClusterTwoVisitsTiedByReferringVisit) {
std::vector<history::ClusterVisit> visits;
// Visit2's referrer is visit 1 and are close together.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://google.com/"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://google.com/next"), base::Time::FromTimeT(2));
visit2.referring_visit_of_redirect_chain_start = 1;
visits.push_back(testing::CreateClusterVisit(visit2));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0))));
}
TEST_F(ClustererTest, ClusterTwoVisitsTiedByOpenerVisitOverReferrer) {
std::vector<history::ClusterVisit> visits;
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://google.com/"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
// Visit2's referrer is visit 5 and are close together. Have the visit IDs be
// misordered to ensure that the visits are sorted by visit time rather than
// by ID.
history::AnnotatedVisit visit5 = testing::CreateDefaultAnnotatedVisit(
5, GURL("https://google.com/somepage"), base::Time::FromTimeT(2));
visits.push_back(testing::CreateClusterVisit(visit5));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://google.com/next"), base::Time::FromTimeT(3));
visit2.referring_visit_of_redirect_chain_start = 1;
visit2.opener_visit_of_redirect_chain_start = 5;
visits.push_back(testing::CreateClusterVisit(visit2));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0)),
ElementsAre(testing::VisitResult(5, 1.0),
testing::VisitResult(2, 1.0))));
}
TEST_F(ClustererTest, ClusterTwoVisitsTiedByOpenerVisit) {
std::vector<history::ClusterVisit> visits;
// Visit2's referrer is visit 5 and are close together. Have the visit IDs be
// misordered to ensure that the visits are sorted by visit time rather than
// by ID.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
5, GURL("https://google.com/"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://google.com/next"), base::Time::FromTimeT(2));
visit2.opener_visit_of_redirect_chain_start = 5;
visits.push_back(testing::CreateClusterVisit(visit2));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(5, 1.0),
testing::VisitResult(2, 1.0))));
}
TEST_F(ClustererTest, ClusterTwoVisitsTiedBySimilarVisit) {
std::vector<history::ClusterVisit> visits;
// Visit2 has the same URL as Visit1.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://google.com/#stripped"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://google.com/"), base::Time::FromTimeT(2));
visits.push_back(testing::CreateClusterVisit(visit2));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0))));
}
TEST_F(ClustererTest, ClusterTwoVisitsTiedByNormalizedURL) {
std::vector<history::ClusterVisit> visits;
// Visit2 has the same URL as Visit1.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://example.com/normalized?q=whatever"),
base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(
visit, GURL("https://example.com/normalized")));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://example.com/normalized"), base::Time::FromTimeT(2));
visits.push_back(testing::CreateClusterVisit(visit2));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0))));
}
TEST_F(ClustererTest, MultipleClusters) {
std::vector<history::ClusterVisit> visits;
// Visit2's referrer is visit 1 and visit 4 is a back navigation from visit 2.
// Visit 3 is a different journey altogether. Visit 10 is referring to a
// missing visit and should be considered as in its own cluster.
// Also, make sure these aren't sorted so we test that we are sorting the
// visits by time.
history::AnnotatedVisit visit = testing::CreateDefaultAnnotatedVisit(
1, GURL("https://github.com/"), base::Time::FromTimeT(1));
visits.push_back(testing::CreateClusterVisit(visit));
history::AnnotatedVisit visit2 = testing::CreateDefaultAnnotatedVisit(
2, GURL("https://google.com/"), base::Time::FromTimeT(2));
visit2.referring_visit_of_redirect_chain_start = 1;
// Set the visit duration to be 2x the default so it has the same duration
// after |visit| and |visit4| are deduped.
visit2.visit_row.visit_duration = base::Seconds(20);
visits.push_back(testing::CreateClusterVisit(visit2));
history::AnnotatedVisit visit4 = testing::CreateDefaultAnnotatedVisit(
4, GURL("https://github.com/"), base::Time::FromTimeT(4));
visits.push_back(testing::CreateClusterVisit(visit4));
history::AnnotatedVisit visit5 = testing::CreateDefaultAnnotatedVisit(
10, GURL("https://nonexistentreferrer.com/"), base::Time::FromTimeT(10));
visit5.referring_visit_of_redirect_chain_start = 6;
visits.push_back(testing::CreateClusterVisit(visit5));
history::AnnotatedVisit visit3 = testing::CreateDefaultAnnotatedVisit(
3, GURL("https://whatever.com/"), base::Time::FromTimeT(3));
visits.push_back(testing::CreateClusterVisit(visit3));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0),
testing::VisitResult(4, 1.0)),
ElementsAre(testing::VisitResult(3, 1.0)),
ElementsAre(testing::VisitResult(10, 1.0))));
}
TEST_F(ClustererTest, SplitClusterOnNavigationTime) {
std::vector<history::ClusterVisit> visits;
history::AnnotatedVisit visit =
testing::CreateDefaultAnnotatedVisit(1, GURL("https://google.com/"));
visit.visit_row.visit_time = base::Time::Now();
visits.push_back(testing::CreateClusterVisit(visit));
// Visit2 has a different URL but is linked by referring id to visit.
history::AnnotatedVisit visit2 =
testing::CreateDefaultAnnotatedVisit(2, GURL("https://bar.com/"));
visit2.referring_visit_of_redirect_chain_start = 1;
visit2.visit_row.visit_time = base::Time::Now() + base::Minutes(5);
visits.push_back(testing::CreateClusterVisit(visit2));
// Visit3 has a different URL but is linked by referring id to visit but the
// cutoff has passed so it should be in a different cluster.
history::AnnotatedVisit visit3 =
testing::CreateDefaultAnnotatedVisit(3, GURL("https://foo.com/"));
visit3.referring_visit_of_redirect_chain_start = 1;
visit3.visit_row.visit_time = base::Time::Now() + base::Hours(2);
visits.push_back(testing::CreateClusterVisit(visit3));
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(testing::ToVisitResults(result_clusters),
ElementsAre(ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0)),
ElementsAre(testing::VisitResult(3, 1.0))));
}
TEST_F(ClustererTest, SplitClusterOnSearchVisit) {
std::vector<history::ClusterVisit> visits;
history::AnnotatedVisit visit =
testing::CreateDefaultAnnotatedVisit(1, GURL("https://google.com/"));
visit.visit_row.visit_time = base::Time::Now();
visits.push_back(testing::CreateClusterVisit(visit));
// Visit2 has a different URL but is linked by referring id to visit.
history::AnnotatedVisit visit2 =
testing::CreateDefaultAnnotatedVisit(2, GURL("https://bar.com/"));
visit2.referring_visit_of_redirect_chain_start = 1;
visit2.visit_row.visit_time = base::Time::Now() + base::Minutes(5);
visits.push_back(testing::CreateClusterVisit(visit2));
// Visit3 has a different URL but is linked by referring id to visit but the
// cutoff has passed so it should be in a different cluster.
history::AnnotatedVisit visit3 =
testing::CreateDefaultAnnotatedVisit(3, GURL("https://foo.com/"));
visit3.referring_visit_of_redirect_chain_start = 1;
visit3.visit_row.visit_time = base::Time::Now() + base::Hours(2);
visits.push_back(testing::CreateClusterVisit(visit3));
// Visit4 was referred by visit 3 but is a search visit.
history::AnnotatedVisit visit4 =
testing::CreateDefaultAnnotatedVisit(4, GURL("https://search.com/"));
visit4.referring_visit_of_redirect_chain_start = 3;
visit4.visit_row.visit_time =
base::Time::Now() + base::Hours(2) + base::Minutes(1);
history::ClusterVisit cluster_visit4 = testing::CreateClusterVisit(visit4);
cluster_visit4.annotated_visit.content_annotations.search_terms = u"whatever";
visits.push_back(cluster_visit4);
// Visit5 was referred by visit 4.
history::AnnotatedVisit visit5 =
testing::CreateDefaultAnnotatedVisit(5, GURL("https://resultlink.com/"));
visit5.referring_visit_of_redirect_chain_start = 4;
visit5.visit_row.visit_time =
base::Time::Now() + base::Hours(2) + base::Minutes(1);
visits.push_back(testing::CreateClusterVisit(visit5));
// Visit6 is a search visit (back-forward) and has the same search terms as
// visit 4.
history::AnnotatedVisit visit6 =
testing::CreateDefaultAnnotatedVisit(6, GURL("https://search.com/"));
visit6.visit_row.visit_time =
base::Time::Now() + base::Hours(2) + base::Minutes(2);
history::ClusterVisit cluster_visit6 = testing::CreateClusterVisit(visit6);
cluster_visit6.annotated_visit.content_annotations.search_terms = u"whatever";
visits.push_back(cluster_visit6);
// Visit7 was referred by visit 6, is a search visit but has different search
// terms as visit 6.
history::AnnotatedVisit visit7 =
testing::CreateDefaultAnnotatedVisit(7, GURL("https://search.com/"));
visit7.referring_visit_of_redirect_chain_start = 6;
visit7.visit_row.visit_time =
base::Time::Now() + base::Hours(2) + base::Minutes(3);
history::ClusterVisit cluster_visit7 = testing::CreateClusterVisit(visit7);
cluster_visit7.annotated_visit.content_annotations.search_terms =
u"different";
visits.push_back(cluster_visit7);
std::vector<history::Cluster> result_clusters =
CreateInitialClustersFromVisits(visits);
EXPECT_THAT(
testing::ToVisitResults(result_clusters),
ElementsAre(
ElementsAre(testing::VisitResult(1, 1.0),
testing::VisitResult(2, 1.0)),
ElementsAre(testing::VisitResult(3, 1.0)),
ElementsAre(testing::VisitResult(4, 1.0, /*duplicate_visits=*/{},
u"whatever"),
testing::VisitResult(5, 1.0),
testing::VisitResult(6, 1.0, /*duplicate_visits=*/{},
u"whatever")),
ElementsAre(testing::VisitResult(7, 1.0, /*duplicate_visits=*/{},
u"different"))));
}
} // namespace
} // namespace history_clusters
|
