1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/metrics/structured/structured_metrics_recorder.h"
#include <cstdint>
#include <memory>
#include <utility>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/scoped_refptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/threading/scoped_blocking_call.h"
#include "components/metrics/structured/event.h"
#include "components/metrics/structured/proto/event_storage.pb.h"
#include "components/metrics/structured/recorder.h"
#include "components/metrics/structured/structured_events.h"
#include "components/metrics/structured/structured_metrics_client.h"
#include "components/metrics/structured/structured_metrics_features.h"
#include "components/metrics/structured/test/test_event_storage.h"
#include "components/metrics/structured/test/test_key_data_provider.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/metrics_proto/chrome_user_metrics_extension.pb.h"
namespace metrics::structured {
namespace {
// These project, event, and metric names are used for testing.
// The name hash of "TestProjectOne".
constexpr uint64_t kProjectOneHash = UINT64_C(16881314472396226433);
// The name hash of "TestProjectTwo".
constexpr uint64_t kProjectTwoHash = UINT64_C(5876808001962504629);
// The name hash of "TestProjectThree".
constexpr uint64_t kProjectThreeHash = UINT64_C(10860358748803291132);
// The name hash of "TestProjectFour".
constexpr uint64_t kProjectFourHash = UINT64_C(6801665881746546626);
// The name hash of "TestProjectFive"
constexpr uint64_t kProjectFiveHash = UINT64_C(3960582687892677139);
// The name hash of "TestProjectSix"
constexpr uint64_t kProjectSixHash = UINT64_C(6972396123792667134);
// The name hash of "CrOSEvents"
constexpr uint64_t kCrOSEventsProjectHash = UINT64_C(12657197978410187837);
// The name hash of "chrome::TestProjectOne::TestEventOne".
constexpr uint64_t kEventOneHash = UINT64_C(13593049295042080097);
// The name hash of "chrome::TestProjectTwo::TestEventTwo".
constexpr uint64_t kEventTwoHash = UINT64_C(8995967733561999410);
// The name hash of "chrome::TestProjectTwo::TestEventThree".
constexpr uint64_t kEventThreeHash = UINT64_C(5848687377041124372);
// The name hash of "chrome::TestProjectFour::TestEventFive".
constexpr uint64_t kEventFiveHash = UINT64_C(7045523601811399253);
// The name hash of "chrome::TestProjectFour::TestEventSix".
constexpr uint64_t kEventSixHash = UINT64_C(2873337042686447043);
// The name hash of "chrome::TestProjectSix::TestEventSeven".
constexpr uint64_t kEventSevenHash = UINT64_C(16749091071228286247);
// The name hash of "chrome::TestProjectSix::TestEnum".
constexpr uint64_t kEventEnumHash = UINT64_C(14837072141472316574);
// The name hash of "chrome::CrOSEvents::NoMetricsEvent".
constexpr uint64_t kNoMetricsEventHash = UINT64_C(5106854608989380457);
// The name has for "chrome::TestProjectSevent::TestEventEight".
const uint64_t kEventEightHash = UINT64_C(16290206418240617738);
// The name hash of "TestMetricOne".
constexpr uint64_t kMetricOneHash = UINT64_C(637929385654885975);
// The name hash of "TestMetricTwo".
constexpr uint64_t kMetricTwoHash = UINT64_C(14083999144141567134);
// The name hash of "TestMetricThree".
constexpr uint64_t kMetricThreeHash = UINT64_C(13469300759843809564);
// The name hash of "TestMetricFive".
constexpr uint64_t kMetricFiveHash = UINT64_C(8665976921794972190);
// The name hash of "TestMetricSix".
constexpr uint64_t kMetricSixHash = UINT64_C(3431522567539822144);
// The name hash of "TestMetricSeven".
constexpr uint64_t kMetricSevenHash = UINT64_C(8395865158198697574);
// The name hash of "TestEnumMetric".
constexpr uint64_t kMetricEnumHash = UINT64_C(16584986597633634829);
// The hex-encoded first 8 bytes of SHA256("aaa...a")
constexpr char kProjectOneId[] = "3BA3F5F43B926026";
// The hex-encoded first 8 bytes of SHA256("bbb...b")
constexpr char kProjectTwoId[] = "BDB339768BC5E4FE";
// The hex-encoded first 8 bytes of SHA256("ddd...d")
constexpr char kProjectFourId[] = "FBBBB6DE2AA74C3C";
// Test values.
constexpr char kValueOne[] = "value one";
constexpr char kValueTwo[] = "value two";
std::string HashToHex(const uint64_t hash) {
return base::HexEncode(&hash, sizeof(uint64_t));
}
class TestRecorder : public StructuredMetricsClient::RecordingDelegate {
public:
TestRecorder() = default;
TestRecorder(const TestRecorder& recorder) = delete;
TestRecorder& operator=(const TestRecorder& recorder) = delete;
~TestRecorder() override = default;
void RecordEvent(Event&& event) override {
Recorder::GetInstance()->RecordEvent(std::move(event));
}
bool IsReadyToRecord() const override { return true; }
};
class TestSMRecorder : public StructuredMetricsRecorder {
public:
TestSMRecorder(const base::FilePath& device_key_path,
const base::FilePath& profile_key_path)
: StructuredMetricsRecorder(
std::make_unique<TestKeyDataProvider>(device_key_path,
profile_key_path),
std::make_unique<TestEventStorage>()) {
test_key_data_provider_ =
static_cast<TestKeyDataProvider*>(key_data_provider());
}
void OnProfileAdded(const base::FilePath& profile_path) {
test_key_data_provider_->OnProfileAdded(profile_path);
}
private:
~TestSMRecorder() override = default;
raw_ptr<TestKeyDataProvider> test_key_data_provider_;
};
} // namespace
class StructuredMetricsRecorderTest : public testing::Test {
protected:
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
// Fixed paths to store keys for test.
device_key_path_ = temp_dir_.GetPath()
.Append(FILE_PATH_LITERAL("structured_metrics"))
.Append(FILE_PATH_LITERAL("device_keys"));
profile_key_path_ = temp_dir_.GetPath()
.Append(FILE_PATH_LITERAL("structured_metrics"))
.Append(FILE_PATH_LITERAL("profile_keys"));
Recorder::GetInstance()->SetUiTaskRunner(
task_environment_.GetMainThreadTaskRunner());
StructuredMetricsClient::Get()->SetDelegate(&test_recorder_);
// Move the mock date forward from day 0, because KeyData assumes that day 0
// is a bug.
task_environment_.AdvanceClock(base::Days(1000));
}
base::FilePath TempDirPath() { return temp_dir_.GetPath(); }
base::FilePath ProfileKeyFilePath() { return profile_key_path_; }
base::FilePath DeviceKeyFilePath() { return device_key_path_; }
void TearDown() override { StructuredMetricsClient::Get()->UnsetDelegate(); }
void Wait() { task_environment_.RunUntilIdle(); }
// Adds a project to the disallowed projects list.
void AddDisallowedProject(uint64_t project_name_hash) {
recorder_->AddDisallowedProjectForTest(project_name_hash);
}
void WriteTestingProfileKeys() {
const int today = (base::Time::Now() - base::Time::UnixEpoch()).InDays();
KeyDataProto proto;
KeyProto& key_one = (*proto.mutable_keys())[kProjectOneHash];
key_one.set_key("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
key_one.set_last_rotation(today);
key_one.set_rotation_period(90);
KeyProto& key_two = (*proto.mutable_keys())[kProjectTwoHash];
key_two.set_key("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");
key_two.set_last_rotation(today);
key_two.set_rotation_period(90);
KeyProto& key_three = (*proto.mutable_keys())[kProjectThreeHash];
key_three.set_key("cccccccccccccccccccccccccccccccc");
key_three.set_last_rotation(today);
key_three.set_rotation_period(90);
KeyProto& cros_events = (*proto.mutable_keys())[kCrOSEventsProjectHash];
cros_events.set_key("cccccccccccccccccccccccccccccccc");
cros_events.set_last_rotation(today);
cros_events.set_rotation_period(90);
base::CreateDirectory(ProfileKeyFilePath().DirName());
ASSERT_TRUE(
base::WriteFile(ProfileKeyFilePath(), proto.SerializeAsString()));
Wait();
}
void WriteTestingDeviceKeys() {
const int today = (base::Time::Now() - base::Time::UnixEpoch()).InDays();
KeyDataProto proto;
KeyProto& key = (*proto.mutable_keys())[kProjectFourHash];
key.set_key("dddddddddddddddddddddddddddddddd");
key.set_last_rotation(today);
key.set_rotation_period(90);
base::CreateDirectory(DeviceKeyFilePath().DirName());
ASSERT_TRUE(
base::WriteFile(DeviceKeyFilePath(), proto.SerializeAsString()));
Wait();
}
KeyDataProto ReadKeys(const base::FilePath& filepath) {
base::ScopedBlockingCall scoped_blocking_call(
FROM_HERE, base::BlockingType::MAY_BLOCK);
Wait();
CHECK(base::PathExists(filepath));
std::string proto_str;
CHECK(base::ReadFileToString(filepath, &proto_str));
KeyDataProto proto;
CHECK(proto.ParseFromString(proto_str));
return proto;
}
// Simulates the three external events that the structure metrics system cares
// about: the metrics service initializing and enabling its providers, and a
// user logging in.
void Init() {
// Create the provider, normally done by the ChromeMetricsServiceClient.
recorder_ = base::MakeRefCounted<TestSMRecorder>(device_key_path_,
profile_key_path_);
// Enable recording, normally done after the metrics service has checked
// consent allows recording.
recorder_->EnableRecording();
// Add a profile, normally done by the ChromeMetricsServiceClient after a
// user logs in.
recorder_->OnProfileAdded(TempDirPath());
Wait();
}
// Enables recording without adding a profile.
void InitWithoutLogin() {
// Create the provider, normally done by the ChromeMetricsServiceClient.
recorder_ = base::MakeRefCounted<TestSMRecorder>(device_key_path_,
profile_key_path_);
// Enable recording, normally done after the metrics service has checked
// consent allows recording.
recorder_->EnableRecording();
}
// Sets up StructuredMetricsRecorder.
void InitWithoutEnabling() {
// Create the provider, normally done by the ChromeMetricsServiceClient.
recorder_ = base::MakeRefCounted<TestSMRecorder>(device_key_path_,
profile_key_path_);
}
bool is_initialized() { return recorder_->IsInitialized(); }
bool is_recording_enabled() { return recorder_->recording_enabled_; }
void OnRecordingEnabled() { recorder_->EnableRecording(); }
void OnRecordingDisabled() { recorder_->DisableRecording(); }
void OnProfileAdded(const base::FilePath& path) {
recorder_->OnProfileAdded(path);
}
StructuredDataProto GetUMAEventMetrics() {
ChromeUserMetricsExtension uma_proto;
recorder_->ProvideUmaEventMetrics(uma_proto);
Wait();
return uma_proto.structured_data();
}
StructuredDataProto GetEventMetrics() {
ChromeUserMetricsExtension uma_proto;
recorder_->ProvideEventMetrics(uma_proto);
recorder_->ProvideLogMetadata(uma_proto);
Wait();
return uma_proto.structured_data();
}
void ExpectNoErrors() {
histogram_tester_.ExpectTotalCount("UMA.StructuredMetrics.InternalError",
0);
}
protected:
scoped_refptr<TestSMRecorder> recorder_;
// Feature list should be constructed before task environment.
base::test::ScopedFeatureList scoped_feature_list_;
base::test::TaskEnvironment task_environment_{
base::test::TaskEnvironment::MainThreadType::UI,
base::test::TaskEnvironment::ThreadPoolExecutionMode::QUEUED,
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
base::HistogramTester histogram_tester_;
base::ScopedTempDir temp_dir_;
private:
TestRecorder test_recorder_;
base::FilePath device_key_path_;
base::FilePath profile_key_path_;
};
// Simple test to ensure initialization works correctly in the case of a
// first-time run.
TEST_F(StructuredMetricsRecorderTest, RecorderInitializesFromBlankSlate) {
Init();
EXPECT_TRUE(is_initialized());
EXPECT_TRUE(is_recording_enabled());
ExpectNoErrors();
}
// Ensure a call to OnRecordingDisabled prevents reporting.
TEST_F(StructuredMetricsRecorderTest, EventsNotReportedWhenRecordingDisabled) {
Init();
OnRecordingDisabled();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_three::TestEventFour().SetTestMetricFour(1)));
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
ExpectNoErrors();
}
// Ensure that disabling the structured metrics feature flag prevents all
// structured metrics reporting.
TEST_F(StructuredMetricsRecorderTest, EventsNotReportedWhenFeatureDisabled) {
scoped_feature_list_.InitAndDisableFeature(features::kStructuredMetrics);
Init();
// OnRecordingEnabled should not actually enable recording because the flag is
// disabled.
OnRecordingEnabled();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_three::TestEventFour().SetTestMetricFour(1)));
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
ExpectNoErrors();
}
// Ensure that, if recording is disabled part-way through initialization, the
// initialization still completes correctly, but recording is correctly set to
// disabled.
TEST_F(StructuredMetricsRecorderTest, RecordingDisabledDuringInitialization) {
InitWithoutEnabling();
OnProfileAdded(TempDirPath());
OnRecordingDisabled();
EXPECT_FALSE(is_initialized());
EXPECT_FALSE(is_recording_enabled());
Wait();
EXPECT_TRUE(is_initialized());
EXPECT_FALSE(is_recording_enabled());
ExpectNoErrors();
}
// Ensure that recording is disabled until explicitly enabled with a call to
// OnRecordingEnabled.
TEST_F(StructuredMetricsRecorderTest, RecordingDisabledByDefault) {
InitWithoutEnabling();
OnProfileAdded(TempDirPath());
Wait();
EXPECT_TRUE(is_initialized());
EXPECT_FALSE(is_recording_enabled());
OnRecordingEnabled();
EXPECT_TRUE(is_recording_enabled());
ExpectNoErrors();
}
TEST_F(StructuredMetricsRecorderTest, RecordedEventAppearsInReport) {
Init();
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()
.SetTestMetricOne("a string")
.SetTestMetricTwo(12345)));
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()
.SetTestMetricOne("a string")
.SetTestMetricTwo(12345)));
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()
.SetTestMetricOne("a string")
.SetTestMetricTwo(12345)));
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 3);
ExpectNoErrors();
}
TEST_F(StructuredMetricsRecorderTest, EventMetricsReportedCorrectly) {
WriteTestingProfileKeys();
Init();
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()
.SetTestMetricOne(kValueOne)
.SetTestMetricTwo(12345)));
StructuredMetricsClient::Record(
std::move(events::v2::test_project_two::TestEventTwo().SetTestMetricThree(
kValueTwo)));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 2);
{ // First event
const auto& event = data.events(0);
EXPECT_EQ(event.event_name_hash(), kEventOneHash);
EXPECT_EQ(event.project_name_hash(), kProjectOneHash);
EXPECT_EQ(HashToHex(event.profile_event_id()), kProjectOneId);
ASSERT_EQ(event.metrics_size(), 2);
{ // First metric
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.name_hash(), kMetricOneHash);
EXPECT_EQ(HashToHex(metric.value_hmac()),
// Value of HMAC_256("aaa...a", concat(hex(kMetricOneHash),
// kValueOne))
"8C2469269D142715");
}
{ // Second metric
const auto& metric = event.metrics(1);
EXPECT_EQ(metric.name_hash(), kMetricTwoHash);
EXPECT_EQ(metric.value_int64(), 12345);
}
}
{ // Second event
const auto& event = data.events(1);
EXPECT_EQ(event.event_name_hash(), kEventTwoHash);
EXPECT_EQ(event.project_name_hash(), kProjectTwoHash);
EXPECT_EQ(HashToHex(event.profile_event_id()), kProjectTwoId);
ASSERT_EQ(event.metrics_size(), 1);
{ // First metric
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.name_hash(), kMetricThreeHash);
EXPECT_EQ(HashToHex(metric.value_hmac()),
// Value of HMAC_256("bbb...b", concat(hex(kProjectTwoHash),
// kValueTwo))
"86F0169868588DC7");
}
}
histogram_tester_.ExpectTotalCount("UMA.StructuredMetrics.InternalError", 0);
}
// Ensure that events containing raw string metrics are reported correctly.
TEST_F(StructuredMetricsRecorderTest, RawStringMetricsReportedCorrectly) {
Init();
const std::string test_string = "a raw string value";
StructuredMetricsClient::Record(
std::move(events::v2::test_project_five::TestEventSix().SetTestMetricSix(
test_string)));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 1);
const auto& event = data.events(0);
EXPECT_EQ(event.event_name_hash(), kEventSixHash);
EXPECT_EQ(event.project_name_hash(), kProjectFiveHash);
EXPECT_FALSE(event.has_profile_event_id());
EXPECT_EQ(event.event_type(), StructuredEventProto_EventType_RAW_STRING);
ASSERT_EQ(event.metrics_size(), 1);
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.name_hash(), kMetricSixHash);
EXPECT_EQ(metric.value_string(), test_string);
}
TEST_F(StructuredMetricsRecorderTest, FloatMetricsReportedCorrectly) {
Init();
const float test_float = 3.4;
const float test_float2 = 3.14e-8;
StructuredMetricsClient::Record(std::move(
events::v2::test_project_six::TestEventSeven().SetTestMetricSeven(
test_float)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_six::TestEventSeven().SetTestMetricSeven(
test_float2)));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 2);
const auto& event = data.events(0);
EXPECT_EQ(event.event_name_hash(), kEventSevenHash);
EXPECT_EQ(event.project_name_hash(), kProjectSixHash);
EXPECT_FALSE(event.has_profile_event_id());
ASSERT_EQ(event.metrics_size(), 1);
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.name_hash(), kMetricSevenHash);
EXPECT_EQ(metric.value_double(), test_float);
const auto& event2 = data.events(1);
EXPECT_EQ(event2.event_name_hash(), kEventSevenHash);
EXPECT_EQ(event2.project_name_hash(), kProjectSixHash);
EXPECT_FALSE(event2.has_profile_event_id());
ASSERT_EQ(event2.metrics_size(), 1);
const auto& metric2 = event2.metrics(0);
EXPECT_EQ(metric2.name_hash(), kMetricSevenHash);
EXPECT_EQ(metric2.value_double(), test_float2);
}
// TODO: Test copied in AshStructuredMetricsRecorder unit tests, remove this one
// once the test key provider is simplified.
TEST_F(StructuredMetricsRecorderTest, DeviceKeysUsedForDeviceScopedProjects) {
WriteTestingProfileKeys();
WriteTestingDeviceKeys();
Init();
// This event's project has device scope set, so should use the per-device
// keys set by WriteTestingDeviceKeys. In this case the expected key is
// "ddd...d", which we observe by checking the ID and HMAC have the correct
// value given that key.
StructuredMetricsClient::Record(std::move(
events::v2::test_project_four::TestEventFive().SetTestMetricFive(
"value")));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 1);
const auto& event = data.events(0);
EXPECT_EQ(event.event_name_hash(), kEventFiveHash);
EXPECT_EQ(event.project_name_hash(), kProjectFourHash);
// The hex-encoded first 8 bytes of SHA256("ddd...d").
EXPECT_EQ(HashToHex(event.profile_event_id()), kProjectFourId);
ASSERT_EQ(event.metrics_size(), 1);
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.name_hash(), kMetricFiveHash);
EXPECT_EQ(HashToHex(metric.value_hmac()),
// Value of HMAC_256("ddd...d", concat(hex(kMetricFiveHash),
// "value"))
"4CC202FAA78FDC7A");
histogram_tester_.ExpectTotalCount("UMA.StructuredMetrics.InternalError", 0);
}
// Check that a full int64 can be recorded, and is not truncated to an int32.
TEST_F(StructuredMetricsRecorderTest, Int64MetricsNotTruncated) {
Init();
const int64_t big = 1ll << 60;
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(big)));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 1);
const auto& event = data.events(0);
ASSERT_EQ(event.metrics_size(), 1);
const auto& metric = event.metrics(0);
EXPECT_EQ(metric.value_int64(), big);
}
TEST_F(StructuredMetricsRecorderTest, EventsWithinProjectReportedWithSameID) {
WriteTestingProfileKeys();
Init();
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()));
StructuredMetricsClient::Record(
std::move(events::v2::test_project_two::TestEventTwo()));
StructuredMetricsClient::Record(
std::move(events::v2::test_project_two::TestEventThree()));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 3);
const auto& event_one = data.events(0);
const auto& event_two = data.events(1);
const auto& event_three = data.events(2);
// Check events are in the right order.
EXPECT_EQ(event_one.event_name_hash(), kEventOneHash);
EXPECT_EQ(event_two.event_name_hash(), kEventTwoHash);
EXPECT_EQ(event_three.event_name_hash(), kEventThreeHash);
// Events two and three share a project, so should have the same project
// name hash. Event one should have its own project name hash.
EXPECT_EQ(event_one.project_name_hash(), kProjectOneHash);
EXPECT_EQ(event_two.project_name_hash(), kProjectTwoHash);
EXPECT_EQ(event_three.project_name_hash(), kProjectTwoHash);
// Events two and three share a project, so should have the same ID. Event
// one should have its own ID.
EXPECT_EQ(HashToHex(event_one.profile_event_id()), kProjectOneId);
EXPECT_EQ(HashToHex(event_two.profile_event_id()), kProjectTwoId);
EXPECT_EQ(HashToHex(event_three.profile_event_id()), kProjectTwoId);
histogram_tester_.ExpectTotalCount("UMA.StructuredMetrics.InternalError", 0);
}
TEST_F(StructuredMetricsRecorderTest, EventWithoutMetricsReportCorrectly) {
Init();
const int test_time = 50;
events::v2::cr_os_events::NoMetricsEvent test_event;
EXPECT_TRUE(test_event.IsEventSequenceType());
test_event.SetEventSequenceMetadata(Event::EventSequenceMetadata(1));
test_event.SetRecordedTimeSinceBoot(base::Milliseconds(test_time));
StructuredMetricsClient::Record(std::move(test_event));
const auto data = GetEventMetrics();
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(data.events_size(), 1);
const auto& event = data.events(0);
EXPECT_EQ(event.project_name_hash(), kCrOSEventsProjectHash);
EXPECT_EQ(event.event_name_hash(), kNoMetricsEventHash);
}
// Test that events reported before recording is enabled are ignored.
TEST_F(StructuredMetricsRecorderTest, EventsNotRecordedBeforeRecordingEnabled) {
// Manually create and initialize the provider, adding recording calls between
// each step. All of these events should be ignored.
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
InitWithoutEnabling();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
OnRecordingEnabled();
Wait();
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
ExpectNoErrors();
}
// Test that events reported after recording is enabled but before the keys are
// loaded are hashed and stored after keys are loaded.
TEST_F(StructuredMetricsRecorderTest, EventsRecordedBeforeKeysInitialized) {
InitWithoutLogin();
// Emulate metric before login.
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
OnProfileAdded(TempDirPath());
// Called before user key is loaded.
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
Wait();
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 2);
ExpectNoErrors();
}
// Ensure a call to OnRecordingDisabled not only prevents the reporting of new
// events, but also clears the cache of any existing events that haven't yet
// been reported.
TEST_F(StructuredMetricsRecorderTest,
ExistingEventsClearedWhenRecordingDisabled) {
Init();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_three::TestEventFour().SetTestMetricFour(1)));
OnRecordingDisabled();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_three::TestEventFour().SetTestMetricFour(1)));
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
ExpectNoErrors();
}
// Ensure that recording and reporting is re-enabled after recording is disabled
// and then enabled again.
TEST_F(StructuredMetricsRecorderTest, ReportingResumesWhenEnabled) {
Init();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_two::TestEventThree().SetTestMetricFour(
"test-string")));
OnRecordingDisabled();
OnRecordingEnabled();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_two::TestEventThree().SetTestMetricFour(
"test-string")));
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 6);
ExpectNoErrors();
}
// Ensure that a call to ProvideCurrentSessionData before initialization
// completes returns no events.
TEST_F(StructuredMetricsRecorderTest,
ReportsNothingBeforeInitializationComplete) {
InitWithoutEnabling();
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
OnRecordingEnabled();
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
OnProfileAdded(TempDirPath());
EXPECT_EQ(GetUMAEventMetrics().events_size(), 0);
EXPECT_EQ(GetEventMetrics().events_size(), 0);
}
TEST_F(StructuredMetricsRecorderTest, EventsClone) {
Init();
events::v2::cr_os_events::Test1 event;
const int test_time = 50;
const double test_metric = 1.0;
event.SetEventSequenceMetadata(Event::EventSequenceMetadata(1));
event.SetRecordedTimeSinceBoot(base::Milliseconds(test_time));
event.SetMetric1(test_metric);
auto cloned_event = event.Clone();
EXPECT_EQ(event.event_sequence_metadata().reset_counter,
cloned_event.event_sequence_metadata().reset_counter);
EXPECT_EQ(event.project_name(), cloned_event.project_name());
EXPECT_EQ(event.event_name(), cloned_event.event_name());
EXPECT_EQ(event.is_event_sequence(), cloned_event.is_event_sequence());
EXPECT_EQ(event.recorded_time_since_boot(),
cloned_event.recorded_time_since_boot());
EXPECT_EQ(event.metric_values(), cloned_event.metric_values());
}
TEST_F(StructuredMetricsRecorderTest, DisallowedProjectAreDropped) {
Init();
AddDisallowedProject(kProjectOneHash);
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_two::TestEventThree().SetTestMetricFour(
"value")));
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 1);
ASSERT_EQ(data.events(0).project_name_hash(), kProjectTwoHash);
}
class TestProcessor : public EventsProcessorInterface {
bool ShouldProcessOnEventRecord(const Event& event) override { return true; }
// no-op
void OnEventsRecord(Event* event) override {}
void OnEventRecorded(StructuredEventProto* event) override {}
void OnProvideIndependentMetrics(
ChromeUserMetricsExtension* uma_proto) override {
uma_proto->mutable_structured_data()->set_is_device_enrolled(true);
}
};
TEST_F(StructuredMetricsRecorderTest, AppliesProcessorCorrectly) {
Init();
// Processor that sets |is_device_enrolled| to true.
Recorder::GetInstance()->AddEventsProcessor(
std::make_unique<TestProcessor>());
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
const auto data = GetEventMetrics();
EXPECT_TRUE(data.is_device_enrolled());
}
TEST_F(StructuredMetricsRecorderTest, ForceRecordedEvents) {
// Init and disable recorder.
Init();
OnRecordingDisabled();
StructuredMetricsClient::Record(
std::move(events::v2::test_project_seven::TestEventEight()));
OnRecordingEnabled();
const auto data = GetEventMetrics();
ASSERT_EQ(data.events_size(), 1);
ASSERT_EQ(data.events(0).event_name_hash(), kEventEightHash);
}
TEST_F(StructuredMetricsRecorderTest, EventMetadataLookupCorrectly) {
constexpr std::string_view kProjectName = "TestProjectOne";
constexpr std::string_view kEventName = "TestEventOne";
constexpr std::string_view kMetricOneName = "TestMetricOne";
constexpr std::string_view kMetricTwoName = "TestMetricTwo";
const validator::Validators* validators = validator::Validators::Get();
ASSERT_EQ(validators->GetProjectName(kProjectOneHash), kProjectName);
const auto* project_validator = validators->GetProjectValidator(kProjectName);
ASSERT_NE(project_validator, nullptr);
ASSERT_EQ(project_validator->GetEventName(kEventOneHash), kEventName);
const auto* event_validator =
project_validator->GetEventValidator(kEventName);
ASSERT_NE(event_validator, nullptr);
ASSERT_EQ(event_validator->GetMetricName(kMetricOneHash), kMetricOneName);
ASSERT_EQ(event_validator->GetMetricName(kMetricTwoHash), kMetricTwoName);
}
class TestWatcher : public StructuredMetricsRecorder::Observer {
public:
TestWatcher(uint64_t expected_event) : expected_event_(expected_event) {}
void OnEventRecorded(const StructuredEventProto& event) override {
EXPECT_EQ(event.event_name_hash(), expected_event_);
++event_count_;
}
int EventCount() { return event_count_; }
private:
const uint64_t expected_event_;
int event_count_ = 0;
};
TEST_F(StructuredMetricsRecorderTest, WatcherTest) {
Init();
TestWatcher watcher(kEventOneHash);
recorder_->AddEventsObserver(&watcher);
StructuredMetricsClient::Record(
std::move(events::v2::test_project_one::TestEventOne()
.SetTestMetricOne(kValueOne)
.SetTestMetricTwo(12345)));
Wait();
EXPECT_EQ(watcher.EventCount(), 1);
recorder_->RemoveEventsObserver(&watcher);
}
TEST_F(StructuredMetricsRecorderTest, EnumRecordedCorrectly) {
Init();
// Processor that sets |is_device_enrolled| to true.
StructuredMetricsClient::Record(
std::move(events::v2::test_project_six::TestEnum().SetTestEnumMetric(
events::v2::test_project_six::Enum1::VARIANT2)));
const auto data = GetEventMetrics();
EXPECT_EQ(data.events_size(), 1);
EXPECT_EQ(data.events(0).project_name_hash(), kProjectSixHash);
EXPECT_EQ(data.events(0).event_name_hash(), kEventEnumHash);
EXPECT_EQ(data.events(0).metrics_size(), 1);
EXPECT_EQ(data.events(0).metrics(0).name_hash(), kMetricEnumHash);
EXPECT_EQ(data.events(0).metrics(0).value_int64(),
(int64_t)events::v2::test_project_six::Enum1::VARIANT2);
}
TEST_F(StructuredMetricsRecorderTest, MultipleReports) {
Init();
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_two::TestEventThree().SetTestMetricFour(
"test-string")));
const auto data1 = GetEventMetrics();
EXPECT_EQ(data1.events_size(), 3);
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_one::TestEventOne().SetTestMetricTwo(1)));
StructuredMetricsClient::Record(std::move(
events::v2::test_project_two::TestEventThree().SetTestMetricFour(
"test-string")));
const auto data2 = GetEventMetrics();
EXPECT_EQ(data2.events_size(), 3);
}
} // namespace metrics::structured
|