1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/titled_url_match_utils.h"
#include <algorithm>
#include <memory>
#include <string_view>
#include "base/memory/scoped_refptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/to_string.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "components/bookmarks/browser/titled_url_match.h"
#include "components/bookmarks/browser/titled_url_node.h"
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/autocomplete_provider.h"
#include "components/omnibox/browser/fake_autocomplete_provider.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "components/omnibox/common/omnibox_features.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/metrics_proto/omnibox_event.pb.h"
#include "url/gurl.h"
using bookmarks::TitledUrlMatchToAutocompleteMatch;
namespace {
class MockTitledUrlNode : public bookmarks::TitledUrlNode {
public:
MockTitledUrlNode(const std::u16string& title,
const GURL& url,
std::vector<std::u16string> ancestors = {})
: title_(title), url_(url), ancestors_(ancestors) {}
// TitledUrlNode
const std::u16string& GetTitledUrlNodeTitle() const override {
return title_;
}
const GURL& GetTitledUrlNodeUrl() const override { return url_; }
std::vector<std::u16string_view> GetTitledUrlNodeAncestorTitles()
const override {
std::vector<std::u16string_view> ancestors;
std::ranges::transform(
ancestors_, std::back_inserter(ancestors),
[](auto& ancestor) { return std::u16string_view(ancestor); });
return ancestors;
}
private:
std::u16string title_;
GURL url_;
std::vector<std::u16string> ancestors_;
};
std::string ACMatchClassificationsAsString(
const ACMatchClassifications& classifications) {
std::string position_string("{");
for (auto classification : classifications) {
position_string +=
"{offset " + base::NumberToString(classification.offset) + ", style " +
base::NumberToString(classification.style) + "}, ";
}
position_string += "}\n";
return position_string;
}
// Use a test fixture to ensure that any scoped settings that are set during the
// test are cleared after the test is terminated.
class TitledUrlMatchUtilsTest : public testing::Test {
protected:
void TearDown() override {
RichAutocompletionParams::ClearParamsForTesting();
}
};
} // namespace
TEST_F(TitledUrlMatchUtilsTest, TitledUrlMatchToAutocompleteMatch) {
std::u16string input_text(u"goo");
std::u16string match_title(u"Google Search");
GURL match_url("https://www.google.com/");
AutocompleteMatchType::Type type = AutocompleteMatchType::BOOKMARK_TITLE;
int relevance = 123;
int bookmark_count = 3;
MockTitledUrlNode node(match_title, match_url);
bookmarks::TitledUrlMatch titled_url_match;
titled_url_match.node = &node;
titled_url_match.title_match_positions = {{0, 3}};
titled_url_match.url_match_positions = {{12, 15}};
scoped_refptr<FakeAutocompleteProvider> provider =
new FakeAutocompleteProvider(AutocompleteProvider::Type::TYPE_BOOKMARK);
TestSchemeClassifier classifier;
AutocompleteInput input(input_text, metrics::OmniboxEventProto::NTP,
classifier);
const std::u16string fixed_up_input(input_text);
AutocompleteMatch autocomplete_match = TitledUrlMatchToAutocompleteMatch(
titled_url_match, type, relevance, bookmark_count, provider.get(),
classifier, input, fixed_up_input);
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL | ACMatchClassification::MATCH},
{3, ACMatchClassification::URL},
};
ACMatchClassifications expected_description_class = {
{0, ACMatchClassification::MATCH},
{3, ACMatchClassification::NONE},
};
std::u16string expected_inline_autocompletion(u"gle.com");
EXPECT_EQ(provider.get(), autocomplete_match.provider);
EXPECT_EQ(type, autocomplete_match.type);
EXPECT_EQ(relevance, autocomplete_match.relevance);
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(u"google.com", autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_EQ(match_title, autocomplete_match.description);
EXPECT_TRUE(std::ranges::equal(expected_description_class,
autocomplete_match.description_class));
EXPECT_EQ(u"https://www.google.com", autocomplete_match.fill_into_edit);
EXPECT_TRUE(autocomplete_match.allowed_to_be_default_match);
EXPECT_EQ(expected_inline_autocompletion,
autocomplete_match.inline_autocompletion);
}
AutocompleteMatch BuildTestAutocompleteMatch(
scoped_refptr<FakeAutocompleteProvider> provider,
const std::string& input_text_s,
const GURL& match_url,
const bookmarks::TitledUrlMatch::MatchPositions& match_positions) {
std::u16string input_text(base::ASCIIToUTF16(input_text_s));
std::u16string match_title(u"The Facebook");
AutocompleteMatchType::Type type = AutocompleteMatchType::BOOKMARK_TITLE;
int relevance = 123;
int bookmark_count = 3;
MockTitledUrlNode node(match_title, match_url);
bookmarks::TitledUrlMatch titled_url_match;
titled_url_match.node = &node;
titled_url_match.title_match_positions = {{0, 3}};
// Don't capture the scheme, so that it doesn't match.
titled_url_match.url_match_positions = match_positions;
TestSchemeClassifier classifier;
AutocompleteInput input(input_text, metrics::OmniboxEventProto::NTP,
classifier);
const std::u16string fixed_up_input(input_text);
return TitledUrlMatchToAutocompleteMatch(titled_url_match, type, relevance,
bookmark_count, provider.get(),
classifier, input, fixed_up_input);
}
TEST_F(TitledUrlMatchUtilsTest, DoTrimHttpScheme) {
scoped_refptr<FakeAutocompleteProvider> provider =
base::MakeRefCounted<FakeAutocompleteProvider>(
AutocompleteProvider::Type::TYPE_BOOKMARK);
GURL match_url("http://www.facebook.com/");
AutocompleteMatch autocomplete_match =
BuildTestAutocompleteMatch(provider, "face", match_url, {{11, 15}});
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL | ACMatchClassification::MATCH},
{4, ACMatchClassification::URL},
};
std::u16string expected_contents(u"facebook.com");
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(expected_contents, autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_TRUE(autocomplete_match.allowed_to_be_default_match);
}
TEST_F(TitledUrlMatchUtilsTest, DontTrimHttpSchemeIfInputHasScheme) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature({omnibox::kRichAutocompletion});
RichAutocompletionParams::ClearParamsForTesting();
scoped_refptr<FakeAutocompleteProvider> provider =
base::MakeRefCounted<FakeAutocompleteProvider>(
AutocompleteProvider::Type::TYPE_BOOKMARK);
GURL match_url("http://www.facebook.com/");
AutocompleteMatch autocomplete_match = BuildTestAutocompleteMatch(
provider, "http://face", match_url, {{11, 15}});
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL | ACMatchClassification::MATCH},
{11, ACMatchClassification::URL},
};
std::u16string expected_contents(u"http://facebook.com");
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(expected_contents, autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_FALSE(autocomplete_match.allowed_to_be_default_match);
}
TEST_F(TitledUrlMatchUtilsTest, DoTrimHttpsScheme) {
scoped_refptr<FakeAutocompleteProvider> provider =
base::MakeRefCounted<FakeAutocompleteProvider>(
AutocompleteProvider::Type::TYPE_BOOKMARK);
GURL match_url("https://www.facebook.com/");
AutocompleteMatch autocomplete_match =
BuildTestAutocompleteMatch(provider, "face", match_url, {{12, 16}});
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL | ACMatchClassification::MATCH},
{4, ACMatchClassification::URL},
};
std::u16string expected_contents(u"facebook.com");
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(expected_contents, autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_TRUE(autocomplete_match.allowed_to_be_default_match);
}
TEST_F(TitledUrlMatchUtilsTest, DontTrimHttpsSchemeIfInputHasScheme) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndDisableFeature({omnibox::kRichAutocompletion});
RichAutocompletionParams::ClearParamsForTesting();
scoped_refptr<FakeAutocompleteProvider> provider =
base::MakeRefCounted<FakeAutocompleteProvider>(
AutocompleteProvider::Type::TYPE_BOOKMARK);
GURL match_url("https://www.facebook.com/");
AutocompleteMatch autocomplete_match = BuildTestAutocompleteMatch(
provider, "https://face", match_url, {{12, 16}});
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL | ACMatchClassification::MATCH},
{12, ACMatchClassification::URL},
};
std::u16string expected_contents(u"https://facebook.com");
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(expected_contents, autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_FALSE(autocomplete_match.allowed_to_be_default_match);
}
TEST_F(TitledUrlMatchUtilsTest, EmptyInlineAutocompletion) {
// Since there is no URL prefix match, the inline autocompletion string will
// be empty.
std::u16string input_text(u"goo");
std::u16string match_title(u"Email by Google");
GURL match_url("http://www.gmail.com/google");
AutocompleteMatchType::Type type = AutocompleteMatchType::BOOKMARK_TITLE;
int relevance = 123;
int bookmark_count = 3;
MockTitledUrlNode node(match_title, match_url);
bookmarks::TitledUrlMatch titled_url_match;
titled_url_match.node = &node;
titled_url_match.title_match_positions = {{9, 12}};
titled_url_match.url_match_positions = {{21, 24}};
titled_url_match.has_ancestor_match = false;
scoped_refptr<FakeAutocompleteProvider> provider =
new FakeAutocompleteProvider(AutocompleteProvider::Type::TYPE_BOOKMARK);
TestSchemeClassifier classifier;
AutocompleteInput input(input_text, metrics::OmniboxEventProto::NTP,
classifier);
const std::u16string fixed_up_input(input_text);
AutocompleteMatch autocomplete_match = TitledUrlMatchToAutocompleteMatch(
titled_url_match, type, relevance, bookmark_count, provider.get(),
classifier, input, fixed_up_input);
// 'goo' in 'gmail.com/google'
ACMatchClassifications expected_contents_class = {
{0, ACMatchClassification::URL},
{10, ACMatchClassification::URL | ACMatchClassification::MATCH},
{13, ACMatchClassification::URL},
};
// 'goo' in 'Email by Google'
ACMatchClassifications expected_description_class = {
{0, ACMatchClassification::NONE},
{9, ACMatchClassification::MATCH},
{12, ACMatchClassification::NONE},
};
EXPECT_EQ(provider.get(), autocomplete_match.provider);
EXPECT_EQ(type, autocomplete_match.type);
EXPECT_EQ(relevance, autocomplete_match.relevance);
EXPECT_EQ(match_url, autocomplete_match.destination_url);
EXPECT_EQ(u"gmail.com/google", autocomplete_match.contents);
EXPECT_TRUE(std::ranges::equal(expected_contents_class,
autocomplete_match.contents_class))
<< "EXPECTED: " << ACMatchClassificationsAsString(expected_contents_class)
<< "ACTUAL: "
<< ACMatchClassificationsAsString(autocomplete_match.contents_class);
EXPECT_EQ(match_title, autocomplete_match.description);
EXPECT_TRUE(std::ranges::equal(expected_description_class,
autocomplete_match.description_class));
EXPECT_EQ(u"www.gmail.com/google", autocomplete_match.fill_into_edit);
EXPECT_FALSE(autocomplete_match.allowed_to_be_default_match);
EXPECT_TRUE(autocomplete_match.inline_autocompletion.empty());
}
TEST_F(TitledUrlMatchUtilsTest, PathsInContentsAndDescription) {
scoped_refptr<FakeAutocompleteProvider> provider =
new FakeAutocompleteProvider(AutocompleteProvider::Type::TYPE_BOOKMARK);
TestSchemeClassifier classifier;
std::vector<std::u16string> ancestors = {u"parent", u"grandparent"};
// Verifies contents and description of the AutocompleteMatch returned from
// |bookmarks::TitledUrlMatchToAutocompleteMatch()|.
auto test = [&](std::string title, std::string url, bool has_url_match,
bool has_ancestor_match, std::string expected_contents,
std::string expected_description) {
SCOPED_TRACE("title [" + title + "], url [" + url + "], has_url_match [" +
base::ToString(has_url_match) + "], has_ancestor_match [" +
base::ToString(has_ancestor_match) + "].");
MockTitledUrlNode node(base::UTF8ToUTF16(title), GURL(url), ancestors);
bookmarks::TitledUrlMatch titled_url_match;
titled_url_match.node = &node;
if (has_url_match)
titled_url_match.url_match_positions.push_back(
{8, 8}); // 8 in order to be after 'https://'
titled_url_match.has_ancestor_match = has_ancestor_match;
AutocompleteInput input(std::u16string(), metrics::OmniboxEventProto::NTP,
classifier);
AutocompleteMatch autocomplete_match = TitledUrlMatchToAutocompleteMatch(
titled_url_match, AutocompleteMatchType::BOOKMARK_TITLE, 1,
/*bookmark_count=*/3, provider.get(), classifier, input,
std::u16string());
EXPECT_EQ(base::UTF16ToUTF8(autocomplete_match.contents),
expected_contents);
EXPECT_EQ(base::UTF16ToUTF8(autocomplete_match.description),
expected_description);
};
test("title", "https://url.com", false, false, "grandparent/parent", "title");
test("title", "https://url.com", true, false, "url.com", "title");
test("title", "https://url.com", false, true, "grandparent/parent", "title");
test("title", "https://url.com", true, true, "grandparent/parent", "title");
}
|
