1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/performance_manager/resource_attribution/memory_measurement_provider.h"
#include <map>
#include <memory>
#include <utility>
#include "base/command_line.h"
#include "base/functional/callback.h"
#include "base/test/test_future.h"
#include "build/build_config.h"
#include "components/performance_manager/public/graph/graph.h"
#include "components/performance_manager/public/resource_attribution/query_results.h"
#include "components/performance_manager/public/resource_attribution/resource_contexts.h"
#include "components/performance_manager/resource_attribution/performance_manager_aliases.h"
#include "components/performance_manager/test_support/performance_manager_browsertest_harness.h"
#include "components/performance_manager/test_support/resource_attribution/gtest_util.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "content/shell/browser/shell.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
namespace resource_attribution {
namespace {
using ::testing::_;
using ::testing::AllOf;
using ::testing::Eq;
using ::testing::Field;
using ::testing::Gt;
using ::testing::IsEmpty;
using ::testing::IsSupersetOf;
using ::testing::Lt;
using ::testing::Pair;
class ResourceAttrMemoryMeasurementProviderBrowserTest
: public performance_manager::PerformanceManagerBrowserTestHarness {
protected:
using Super = performance_manager::PerformanceManagerBrowserTestHarness;
void OnGraphCreated(Graph* graph) override {
memory_provider_ = std::make_unique<MemoryMeasurementProvider>(graph);
Super::OnGraphCreated(graph);
}
void TearDownOnMainThread() override {
// Delete MemoryMeasurementProvider before tearing down the graph to avoid
// dangling pointers.
memory_provider_.reset();
Super::TearDownOnMainThread();
}
// Calls MemoryMeasurementProvider::RequestMemorySummary, waits for its result
// callback to fire, and returns the result map passed to the callback.
QueryResultMap WaitForMemorySummary() {
base::test::TestFuture<QueryResultMap> results_future;
base::OnceCallback<void(QueryResultMap)> results_callback =
results_future.GetSequenceBoundCallback();
memory_provider_->RequestMemorySummary(std::move(results_callback));
return results_future.Take();
}
private:
std::unique_ptr<MemoryMeasurementProvider> memory_provider_;
};
// GMock matcher expecting that a given QueryResults object contains a
// MemorySummaryResult with the metadata filled in and all memory measurements
// >0. `expected_algorithm` is the measurement algorithm that should be used.
auto MemorySummaryResultIsPositive(MeasurementAlgorithm expected_algorithm) {
// Expect any positive measurement time in the past.
auto expected_measurement_time_matcher =
AllOf(Gt(base::TimeTicks()), Lt(base::TimeTicks::Now()));
return QueryResultsMatch<MemorySummaryResult>(AllOf(
#if BUILDFLAG(IS_IOS)
// TODO(crbug.com/40947218): iOS doesn't support private_memory_footprint,
// so it's always 0.
Field("private_footprint_kb", &MemorySummaryResult::private_footprint_kb,
Eq(0u)),
#else
Field("private_footprint_kb", &MemorySummaryResult::private_footprint_kb,
Gt(0u)),
#endif
Field("resident_set_size_kb", &MemorySummaryResult::resident_set_size_kb,
Gt(0u)),
ResultMetadataMatches<MemorySummaryResult>(
expected_measurement_time_matcher, expected_algorithm)));
}
IN_PROC_BROWSER_TEST_F(ResourceAttrMemoryMeasurementProviderBrowserTest,
TwoFramesOneProcess) {
// Navigate to an initial URL that will load 2 frames in the same process.
ASSERT_TRUE(NavigateAndWaitForConsoleMessage(
shell()->web_contents(),
embedded_test_server()->GetURL("a.com", "/a_embeds_a.html"),
"a.html loaded"));
content::RenderFrameHost* main_rfh =
shell()->web_contents()->GetPrimaryMainFrame();
ASSERT_TRUE(main_rfh);
content::RenderFrameHost* child_rfh = ChildFrameAt(main_rfh, 0);
ASSERT_TRUE(child_rfh);
ASSERT_TRUE(main_rfh->GetProcess());
ASSERT_EQ(main_rfh->GetProcess(), child_rfh->GetProcess());
const ResourceContext main_frame_context =
FrameContext::FromRenderFrameHost(main_rfh).value();
const ResourceContext child_frame_context =
FrameContext::FromRenderFrameHost(child_rfh).value();
const ResourceContext process_context =
ProcessContext::FromRenderProcessHost(main_rfh->GetProcess()).value();
const ResourceContext page_context =
PageContext::FromWebContents(shell()->web_contents()).value();
// Measure the memory of all processes. Results will include the browser and
// utility processes.
QueryResultMap results = WaitForMemorySummary();
EXPECT_THAT(
results,
IsSupersetOf({
Pair(process_context, MemorySummaryResultIsPositive(
MeasurementAlgorithm::kDirectMeasurement)),
Pair(main_frame_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSplit)),
Pair(child_frame_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSplit)),
Pair(page_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSum)),
}));
// The process memory should be split between frames in the process.
const auto main_frame_result =
results.at(main_frame_context).memory_summary_result.value();
const auto child_frame_result =
results.at(child_frame_context).memory_summary_result.value();
const auto process_result =
results.at(process_context).memory_summary_result.value();
EXPECT_LE(main_frame_result.resident_set_size_kb,
process_result.resident_set_size_kb);
EXPECT_LE(main_frame_result.private_footprint_kb,
process_result.private_footprint_kb);
EXPECT_LE(child_frame_result.resident_set_size_kb,
process_result.resident_set_size_kb);
EXPECT_LE(child_frame_result.private_footprint_kb,
process_result.private_footprint_kb);
// The page memory should be the sum of all its frames, from any process.
const auto page_result =
results.at(page_context).memory_summary_result.value();
EXPECT_EQ(page_result.resident_set_size_kb,
main_frame_result.resident_set_size_kb +
child_frame_result.resident_set_size_kb);
EXPECT_EQ(page_result.private_footprint_kb,
main_frame_result.private_footprint_kb +
child_frame_result.private_footprint_kb);
}
IN_PROC_BROWSER_TEST_F(ResourceAttrMemoryMeasurementProviderBrowserTest,
TwoFramesSeparateProcesses) {
// Navigate to an initial URL that will load 2 frames in separate processes.
content::IsolateAllSitesForTesting(base::CommandLine::ForCurrentProcess());
ASSERT_TRUE(NavigateAndWaitForConsoleMessage(
shell()->web_contents(),
embedded_test_server()->GetURL("a.com", "/a_embeds_b.html"),
"b.html loaded"));
content::RenderFrameHost* main_rfh =
shell()->web_contents()->GetPrimaryMainFrame();
ASSERT_TRUE(main_rfh);
content::RenderFrameHost* child_rfh = ChildFrameAt(main_rfh, 0);
ASSERT_TRUE(child_rfh);
ASSERT_TRUE(main_rfh->GetProcess());
ASSERT_NE(main_rfh->GetProcess(), child_rfh->GetProcess());
const ResourceContext main_frame_context =
FrameContext::FromRenderFrameHost(main_rfh).value();
const ResourceContext child_frame_context =
FrameContext::FromRenderFrameHost(child_rfh).value();
const ResourceContext process_a_context =
ProcessContext::FromRenderProcessHost(main_rfh->GetProcess()).value();
const ResourceContext process_b_context =
ProcessContext::FromRenderProcessHost(child_rfh->GetProcess()).value();
const ResourceContext page_context =
PageContext::FromWebContents(shell()->web_contents()).value();
// Measure the memory of all processes. Results will include the browser and
// utility processes.
QueryResultMap results = WaitForMemorySummary();
EXPECT_THAT(
results,
IsSupersetOf({
Pair(process_a_context,
MemorySummaryResultIsPositive(
MeasurementAlgorithm::kDirectMeasurement)),
Pair(process_b_context,
MemorySummaryResultIsPositive(
MeasurementAlgorithm::kDirectMeasurement)),
Pair(main_frame_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSplit)),
Pair(child_frame_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSplit)),
Pair(page_context,
MemorySummaryResultIsPositive(MeasurementAlgorithm::kSum)),
}));
// Each process memory should be assigned entirely to the frame in the
// process.
const auto main_frame_result =
results.at(main_frame_context).memory_summary_result.value();
const auto child_frame_result =
results.at(child_frame_context).memory_summary_result.value();
const auto process_a_result =
results.at(process_a_context).memory_summary_result.value();
const auto process_b_result =
results.at(process_b_context).memory_summary_result.value();
EXPECT_EQ(main_frame_result.resident_set_size_kb,
process_a_result.resident_set_size_kb);
EXPECT_EQ(main_frame_result.private_footprint_kb,
process_a_result.private_footprint_kb);
EXPECT_EQ(child_frame_result.resident_set_size_kb,
process_b_result.resident_set_size_kb);
EXPECT_EQ(child_frame_result.private_footprint_kb,
process_b_result.private_footprint_kb);
// The page memory should be the sum of all its frames, from any process.
const auto page_result =
results.at(page_context).memory_summary_result.value();
EXPECT_EQ(page_result.resident_set_size_kb,
main_frame_result.resident_set_size_kb +
child_frame_result.resident_set_size_kb);
EXPECT_EQ(page_result.private_footprint_kb,
main_frame_result.private_footprint_kb +
child_frame_result.private_footprint_kb);
}
} // namespace
} // namespace resource_attribution
|
