1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/sync/engine/cycle/nudge_tracker.h"
#include <stdint.h>
#include <memory>
#include <string>
#include "base/test/scoped_feature_list.h"
#include "components/sync/base/features.h"
#include "components/sync/protocol/data_type_progress_marker.pb.h"
#include "components/sync/protocol/sync_enums.pb.h"
#include "components/sync/test/mock_invalidation.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
namespace {
testing::AssertionResult DataTypeSetEquals(DataTypeSet a, DataTypeSet b) {
if (a == b) {
return testing::AssertionSuccess();
} else {
return testing::AssertionFailure()
<< "Left side " << DataTypeSetToDebugString(a)
<< ", does not match rigth side: " << DataTypeSetToDebugString(b);
}
}
} // namespace
class NudgeTrackerTest : public ::testing::Test {
public:
NudgeTrackerTest() {
// Override this limit so tests know when it is surpassed.
SetInvalidationsInSync();
}
bool InvalidationsOutOfSync() const {
// We don't currently track invalidations out of sync on a per-type basis.
sync_pb::GetUpdateTriggers gu_trigger;
nudge_tracker_.FillProtoMessage(BOOKMARKS, &gu_trigger);
return gu_trigger.invalidations_out_of_sync();
}
int ProtoLocallyModifiedCount(DataType type) const {
sync_pb::GetUpdateTriggers gu_trigger;
nudge_tracker_.FillProtoMessage(type, &gu_trigger);
return gu_trigger.local_modification_nudges();
}
int ProtoRefreshRequestedCount(DataType type) const {
sync_pb::GetUpdateTriggers gu_trigger;
nudge_tracker_.FillProtoMessage(type, &gu_trigger);
return gu_trigger.datatype_refresh_nudges();
}
void SetInvalidationsInSync() {
nudge_tracker_.OnInvalidationsEnabled();
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked({});
}
std::unique_ptr<SyncInvalidation> BuildInvalidation(
int64_t version,
const std::string& payload) {
return MockInvalidation::Build(version, payload);
}
static std::unique_ptr<SyncInvalidation> BuildUnknownVersionInvalidation() {
return MockInvalidation::BuildUnknownVersion();
}
bool IsTypeThrottled(DataType type) {
return nudge_tracker_.GetTypeBlockingMode(type) ==
WaitInterval::BlockingMode::kThrottled;
}
bool IsTypeBackedOff(DataType type) {
return nudge_tracker_.GetTypeBlockingMode(type) ==
WaitInterval::BlockingMode::kExponentialBackoff;
}
protected:
NudgeTracker nudge_tracker_;
};
// Exercise an empty NudgeTracker.
// Use with valgrind to detect uninitialized members.
TEST_F(NudgeTrackerTest, EmptyNudgeTracker) {
// Now we're at the normal, "idle" state.
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
EXPECT_EQ(sync_pb::SyncEnums::UNKNOWN_ORIGIN, nudge_tracker_.GetOrigin());
sync_pb::GetUpdateTriggers gu_trigger;
nudge_tracker_.FillProtoMessage(BOOKMARKS, &gu_trigger);
EXPECT_EQ(sync_pb::SyncEnums::UNKNOWN_ORIGIN, nudge_tracker_.GetOrigin());
}
// Checks the behaviour of the invalidations-out-of-sync flag.
TEST_F(NudgeTrackerTest, EnableDisableInvalidations) {
// Start with invalidations offline.
nudge_tracker_.OnInvalidationsDisabled();
EXPECT_TRUE(InvalidationsOutOfSync());
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Simply enabling invalidations does not bring us back into sync.
nudge_tracker_.OnInvalidationsEnabled();
EXPECT_TRUE(InvalidationsOutOfSync());
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// We must successfully complete a sync cycle while invalidations are enabled
// to be sure that we're in sync.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(InvalidationsOutOfSync());
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// If the invalidator malfunctions, we go become unsynced again.
nudge_tracker_.OnInvalidationsDisabled();
EXPECT_TRUE(InvalidationsOutOfSync());
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// A sync cycle while invalidations are disabled won't reset the flag.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_TRUE(InvalidationsOutOfSync());
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Nor will the re-enabling of invalidations be sufficient, even now that
// we've had a successful sync cycle.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_TRUE(InvalidationsOutOfSync());
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
}
// Tests that locally modified types are correctly written out to the
// GetUpdateTriggers proto.
TEST_F(NudgeTrackerTest, WriteLocallyModifiedTypesToProto) {
// Should not be locally modified by default.
EXPECT_EQ(0, ProtoLocallyModifiedCount(PREFERENCES));
// Record a local bookmark change. Verify it was registered correctly.
nudge_tracker_.RecordLocalChange(PREFERENCES, false);
EXPECT_EQ(1, ProtoLocallyModifiedCount(PREFERENCES));
// Record a successful sync cycle. Verify the count is cleared.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_EQ(0, ProtoLocallyModifiedCount(PREFERENCES));
}
// Tests that refresh requested types are correctly written out to the
// GetUpdateTriggers proto.
TEST_F(NudgeTrackerTest, WriteRefreshRequestedTypesToProto) {
// There should be no refresh requested by default.
EXPECT_EQ(0, ProtoRefreshRequestedCount(SESSIONS));
// Record a local refresh request. Verify it was registered correctly.
nudge_tracker_.RecordLocalRefreshRequest({SESSIONS});
EXPECT_EQ(1, ProtoRefreshRequestedCount(SESSIONS));
// Record a successful sync cycle. Verify the count is cleared.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_EQ(0, ProtoRefreshRequestedCount(SESSIONS));
}
// Basic tests for the IsSyncRequired() flag.
TEST_F(NudgeTrackerTest, IsSyncRequired) {
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Initial sync request.
nudge_tracker_.RecordInitialSyncRequired(BOOKMARKS);
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Note: The initial sync happens as part of a configuration cycle, not a
// normal cycle, so here we need to use RecordInitialSyncDone() rather than
// RecordSuccessfulSyncCycleIfNotBlocked().
// A finished initial sync for a different data type doesn't affect us.
nudge_tracker_.RecordInitialSyncDone({EXTENSIONS});
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
nudge_tracker_.RecordInitialSyncDone({BOOKMARKS});
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Sync request for resolve conflict.
nudge_tracker_.RecordCommitConflict(BOOKMARKS);
// Now a sync is required for BOOKMARKS.
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
EXPECT_TRUE(nudge_tracker_.IsSyncRequired({BOOKMARKS}));
// But not for SESSIONS.
EXPECT_FALSE(nudge_tracker_.IsSyncRequired({SESSIONS}));
// A successful cycle for SESSIONS doesn't change anything.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked({SESSIONS});
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// A successful cycle for all types resolves things.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Local changes.
nudge_tracker_.RecordLocalChange(SESSIONS, false);
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Refresh requests.
nudge_tracker_.RecordLocalRefreshRequest({SESSIONS});
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Invalidations.
nudge_tracker_.SetHasPendingInvalidations(PREFERENCES, true);
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// Invalidation is "added" to GetUpdates trigger message and "processed", so
// after RecordSuccessfulSyncCycleIfNotBlocked() it'll be deleted.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
nudge_tracker_.SetHasPendingInvalidations(PREFERENCES, false);
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
}
// Basic tests for the IsGetUpdatesRequired() flag.
TEST_F(NudgeTrackerTest, IsGetUpdatesRequired) {
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Initial sync request.
// TODO(crbug.com/40611499): This is probably wrong; a missing initial sync
// should not cause IsGetUpdatesRequired(): The former happens during config
// cycles, but the latter refers to normal cycles.
nudge_tracker_.RecordInitialSyncRequired(BOOKMARKS);
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
nudge_tracker_.RecordInitialSyncDone(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Local changes.
nudge_tracker_.RecordLocalChange(SESSIONS, false);
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Refresh requests.
nudge_tracker_.RecordLocalRefreshRequest({SESSIONS});
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Invalidations.
nudge_tracker_.SetHasPendingInvalidations(PREFERENCES, true);
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// Invalidation is "added" to GetUpdates trigger message and "processed", so
// after RecordSuccessfulSyncCycleIfNotBlocked() it'll be deleted.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
nudge_tracker_.SetHasPendingInvalidations(PREFERENCES, false);
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
}
// Test IsSyncRequired() responds correctly to data type throttling and backoff.
TEST_F(NudgeTrackerTest, IsSyncRequired_Throttling_Backoff) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta throttle_length = base::Minutes(0);
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// A local change to sessions enables the flag.
nudge_tracker_.RecordLocalChange(SESSIONS, false);
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// But the throttling of sessions unsets it.
nudge_tracker_.SetTypesThrottledUntil({SESSIONS}, throttle_length, now);
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// A refresh request for bookmarks means we have reason to sync again.
nudge_tracker_.RecordLocalRefreshRequest({BOOKMARKS});
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// But the backoff of bookmarks unsets it.
nudge_tracker_.SetTypeBackedOff(BOOKMARKS, throttle_length, now);
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(BOOKMARKS));
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// A refresh request for preferences means we have reason to sync again.
nudge_tracker_.RecordLocalRefreshRequest({PREFERENCES});
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// A successful sync cycle means we took care of preferences.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
// But we still haven't dealt with sessions and bookmarks. We'll need to
// remember that sessions and bookmarks are out of sync and re-enable the flag
// when their throttling and backoff interval expires.
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(SESSIONS));
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(BOOKMARKS));
EXPECT_TRUE(nudge_tracker_.IsSyncRequired(DataTypeSet::All()));
}
// Test IsGetUpdatesRequired() responds correctly to data type throttling and
// backoff.
TEST_F(NudgeTrackerTest, IsGetUpdatesRequired_Throttling_Backoff) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta throttle_length = base::Minutes(0);
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// A refresh request to sessions enables the flag.
nudge_tracker_.RecordLocalRefreshRequest({SESSIONS});
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// But the throttling of sessions unsets it.
nudge_tracker_.SetTypesThrottledUntil({SESSIONS}, throttle_length, now);
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// A refresh request for bookmarks means we have reason to sync again.
nudge_tracker_.RecordLocalRefreshRequest({BOOKMARKS});
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// But the backoff of bookmarks unsets it.
nudge_tracker_.SetTypeBackedOff(BOOKMARKS, throttle_length, now);
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(BOOKMARKS));
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// A refresh request for preferences means we have reason to sync again.
nudge_tracker_.RecordLocalRefreshRequest({PREFERENCES});
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// A successful sync cycle means we took care of preferences.
nudge_tracker_.RecordSuccessfulSyncCycleIfNotBlocked(DataTypeSet::All());
EXPECT_FALSE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
// But we still haven't dealt with sessions and bookmarks. We'll need to
// remember that sessions and bookmarks are out of sync and re-enable the flag
// when their throttling and backoff interval expires.
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(SESSIONS));
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(BOOKMARKS));
EXPECT_TRUE(nudge_tracker_.IsGetUpdatesRequired(DataTypeSet::All()));
}
// Tests blocking-related getter functions when no types are blocked.
TEST_F(NudgeTrackerTest, NoTypesBlocked) {
EXPECT_FALSE(nudge_tracker_.IsAnyTypeBlocked());
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(SESSIONS));
EXPECT_TRUE(nudge_tracker_.GetBlockedTypes().empty());
}
// Tests throttling-related getter functions when some types are throttled.
TEST_F(NudgeTrackerTest, ThrottleAndUnthrottle) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta throttle_length = base::Minutes(0);
nudge_tracker_.SetTypesThrottledUntil({SESSIONS, PREFERENCES},
throttle_length, now);
EXPECT_TRUE(nudge_tracker_.IsAnyTypeBlocked());
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeThrottled(PREFERENCES));
EXPECT_FALSE(nudge_tracker_.GetBlockedTypes().empty());
EXPECT_EQ(throttle_length, nudge_tracker_.GetTimeUntilNextUnblock());
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
EXPECT_FALSE(nudge_tracker_.IsAnyTypeBlocked());
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(SESSIONS));
EXPECT_TRUE(nudge_tracker_.GetBlockedTypes().empty());
}
// Tests backoff-related getter functions when some types are backed off.
TEST_F(NudgeTrackerTest, BackoffAndUnbackoff) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta backoff_length = base::Minutes(0);
nudge_tracker_.SetTypeBackedOff(SESSIONS, backoff_length, now);
nudge_tracker_.SetTypeBackedOff(PREFERENCES, backoff_length, now);
EXPECT_TRUE(nudge_tracker_.IsAnyTypeBlocked());
EXPECT_TRUE(IsTypeBackedOff(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(PREFERENCES));
EXPECT_FALSE(nudge_tracker_.GetBlockedTypes().empty());
EXPECT_EQ(backoff_length, nudge_tracker_.GetTimeUntilNextUnblock());
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
EXPECT_FALSE(nudge_tracker_.IsAnyTypeBlocked());
EXPECT_FALSE(nudge_tracker_.IsTypeBlocked(SESSIONS));
EXPECT_TRUE(nudge_tracker_.GetBlockedTypes().empty());
}
TEST_F(NudgeTrackerTest, OverlappingThrottleIntervals) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta throttle1_length = base::Minutes(0);
const base::TimeDelta throttle2_length = base::Minutes(20);
// Setup the longer of two intervals.
nudge_tracker_.SetTypesThrottledUntil({SESSIONS, PREFERENCES},
throttle2_length, now);
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeThrottled(PREFERENCES));
EXPECT_GE(throttle2_length, nudge_tracker_.GetTimeUntilNextUnblock());
// Setup the shorter interval.
nudge_tracker_.SetTypesThrottledUntil({SESSIONS, BOOKMARKS}, throttle1_length,
now);
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES, BOOKMARKS},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeThrottled(PREFERENCES));
EXPECT_TRUE(IsTypeThrottled(BOOKMARKS));
EXPECT_GE(throttle1_length, nudge_tracker_.GetTimeUntilNextUnblock());
// Expire the first interval.
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
// SESSIONS appeared in both intervals. We expect it will be throttled for
// the longer of the two, so it's still throttled at time t1.
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeThrottled(SESSIONS));
EXPECT_TRUE(IsTypeThrottled(PREFERENCES));
EXPECT_FALSE(IsTypeThrottled(BOOKMARKS));
EXPECT_GE(throttle2_length - throttle1_length,
nudge_tracker_.GetTimeUntilNextUnblock());
}
TEST_F(NudgeTrackerTest, OverlappingBackoffIntervals) {
const base::TimeTicks now = base::TimeTicks::Now();
const base::TimeDelta backoff1_length = base::Minutes(0);
const base::TimeDelta backoff2_length = base::Minutes(20);
// Setup the longer of two intervals.
nudge_tracker_.SetTypeBackedOff(SESSIONS, backoff2_length, now);
nudge_tracker_.SetTypeBackedOff(PREFERENCES, backoff2_length, now);
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeBackedOff(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(PREFERENCES));
EXPECT_GE(backoff2_length, nudge_tracker_.GetTimeUntilNextUnblock());
// Setup the shorter interval.
nudge_tracker_.SetTypeBackedOff(SESSIONS, backoff1_length, now);
nudge_tracker_.SetTypeBackedOff(BOOKMARKS, backoff1_length, now);
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES, BOOKMARKS},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeBackedOff(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(PREFERENCES));
EXPECT_TRUE(IsTypeBackedOff(BOOKMARKS));
EXPECT_GE(backoff1_length, nudge_tracker_.GetTimeUntilNextUnblock());
// Expire the first interval.
nudge_tracker_.UpdateTypeThrottlingAndBackoffState();
// SESSIONS appeared in both intervals. We expect it will be backed off for
// the longer of the two, so it's still backed off at time t1.
EXPECT_TRUE(DataTypeSetEquals({SESSIONS, PREFERENCES},
nudge_tracker_.GetBlockedTypes()));
EXPECT_TRUE(IsTypeBackedOff(SESSIONS));
EXPECT_TRUE(IsTypeBackedOff(PREFERENCES));
EXPECT_FALSE(IsTypeBackedOff(BOOKMARKS));
EXPECT_GE(backoff2_length - backoff1_length,
nudge_tracker_.GetTimeUntilNextUnblock());
}
// Test the default nudge delays for various types.
TEST_F(NudgeTrackerTest, NudgeDelayTest) {
// Most data types have a medium delay.
EXPECT_EQ(nudge_tracker_.RecordLocalChange(CONTACT_INFO, false),
nudge_tracker_.RecordLocalChange(PASSWORDS, false));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(CONTACT_INFO, false),
nudge_tracker_.RecordLocalChange(EXTENSIONS, false));
// Bookmarks and preferences sometimes have automatic changes (not directly
// caused by a user actions), so they have bigger delays.
EXPECT_GT(nudge_tracker_.RecordLocalChange(BOOKMARKS, false),
nudge_tracker_.RecordLocalChange(CONTACT_INFO, false));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(BOOKMARKS, false),
nudge_tracker_.RecordLocalChange(PREFERENCES, false));
// Sessions and history have an even bigger delay.
EXPECT_GT(nudge_tracker_.RecordLocalChange(SESSIONS, false),
nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
EXPECT_GT(nudge_tracker_.RecordLocalChange(HISTORY, false),
nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
// Autofill and UserEvents are "accompany types" that rely on nudges from
// other types. They have the longest delay of all, which really only acts as
// a last-resort fallback.
EXPECT_GT(nudge_tracker_.RecordLocalChange(AUTOFILL, false),
nudge_tracker_.RecordLocalChange(SESSIONS, false));
EXPECT_GT(nudge_tracker_.RecordLocalChange(AUTOFILL, false), base::Hours(1));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(AUTOFILL, false),
nudge_tracker_.RecordLocalChange(USER_EVENTS, false));
}
// Test that custom nudge delays are used over the defaults.
TEST_F(NudgeTrackerTest, CustomDelayTest) {
// Set some custom delays.
nudge_tracker_.SetLocalChangeDelayIgnoringMinForTest(BOOKMARKS,
base::Seconds(10));
nudge_tracker_.SetLocalChangeDelayIgnoringMinForTest(SESSIONS,
base::Seconds(2));
// Only those with custom delays should be affected, not another type.
EXPECT_NE(nudge_tracker_.RecordLocalChange(BOOKMARKS, false),
nudge_tracker_.RecordLocalChange(PREFERENCES, false));
EXPECT_EQ(base::Seconds(10),
nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
EXPECT_EQ(base::Seconds(2),
nudge_tracker_.RecordLocalChange(SESSIONS, false));
}
TEST_F(NudgeTrackerTest, DoNotUpdateDelayIfTooSmall) {
base::TimeDelta initial_delay =
nudge_tracker_.RecordLocalChange(BOOKMARKS, false);
// The tracker should enforce a minimum threshold that prevents setting a
// delay too small.
nudge_tracker_.UpdateLocalChangeDelay(BOOKMARKS, base::Microseconds(100));
EXPECT_EQ(initial_delay, nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
}
// Test the default nudge delays for various types.
TEST_F(NudgeTrackerTest, NudgeDelaysForSingleClientUser_FeatureDisabled) {
base::test::ScopedFeatureList feature_disabled;
feature_disabled.InitAndDisableFeature(
kSyncIncreaseNudgeDelayForSingleClient);
// With the feature disabled, it shouldn't matter whether it's a single-client
// user or not.
EXPECT_EQ(nudge_tracker_.RecordLocalChange(SESSIONS, true),
nudge_tracker_.RecordLocalChange(SESSIONS, false));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(HISTORY, true),
nudge_tracker_.RecordLocalChange(HISTORY, false));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(PASSWORDS, true),
nudge_tracker_.RecordLocalChange(PASSWORDS, false));
EXPECT_EQ(nudge_tracker_.RecordLocalChange(BOOKMARKS, true),
nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
}
// Test the default nudge delays for various types.
TEST_F(NudgeTrackerTest, NudgeDelaysForSingleClientUser_FeatureEnabled) {
base::test::ScopedFeatureList feature_enabled;
feature_enabled.InitAndEnableFeature(kSyncIncreaseNudgeDelayForSingleClient);
// With the feature enabled, the nudge delays for single-client users should
// be increased.
EXPECT_GT(nudge_tracker_.RecordLocalChange(SESSIONS, true),
nudge_tracker_.RecordLocalChange(SESSIONS, false));
EXPECT_GT(nudge_tracker_.RecordLocalChange(HISTORY, true),
nudge_tracker_.RecordLocalChange(HISTORY, false));
EXPECT_GT(nudge_tracker_.RecordLocalChange(PASSWORDS, true),
nudge_tracker_.RecordLocalChange(PASSWORDS, false));
EXPECT_GT(nudge_tracker_.RecordLocalChange(BOOKMARKS, true),
nudge_tracker_.RecordLocalChange(BOOKMARKS, false));
}
} // namespace syncer
|