1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/sync/base/account_pref_utils.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "components/signin/public/base/gaia_id_hash.h"
#include "google_apis/gaia/gaia_id.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
namespace {
// Note that while the per-Gaia-ID values are scalar, the pref itself is still
// a dictionary.
constexpr char kPrefPathScalar[] = "pref_path.scalar";
constexpr char kPrefPathDict[] = "pref_path.dict";
TEST(AccountPrefUtils, ShouldGetAndSetScalarPref) {
TestingPrefServiceSimple pref_service;
pref_service.registry()->RegisterDictionaryPref(kPrefPathScalar);
const signin::GaiaIdHash gaia_id_hash =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id"));
ASSERT_FALSE(
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash));
SetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash,
base::Value("value"));
{
const base::Value* value =
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash);
ASSERT_TRUE(value);
EXPECT_EQ(*value, base::Value("value"));
}
ClearAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash);
EXPECT_FALSE(
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash));
}
TEST(AccountPrefUtils, ShouldKeepGaiaIdsSeparateForScalarPref) {
TestingPrefServiceSimple pref_service;
pref_service.registry()->RegisterDictionaryPref(kPrefPathScalar);
const signin::GaiaIdHash gaia_id_hash_1 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_1"));
const signin::GaiaIdHash gaia_id_hash_2 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_2"));
SetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_1,
base::Value("value_1"));
SetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_2,
base::Value("value_2"));
// Setting the same pref for the second GaiaID shouldn't have affected the
// first one's value.
{
const base::Value* value_1 = GetAccountKeyedPrefValue(
&pref_service, kPrefPathScalar, gaia_id_hash_1);
ASSERT_TRUE(value_1);
EXPECT_EQ(*value_1, base::Value("value_1"));
}
}
TEST(AccountPrefUtils, ShouldGetAndSetDictPrefEntries) {
TestingPrefServiceSimple pref_service;
pref_service.registry()->RegisterDictionaryPref(kPrefPathDict);
const signin::GaiaIdHash gaia_id_hash =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id"));
const char kKey1[] = "key1";
const char kKey2[] = "key2";
ASSERT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash, kKey1));
ASSERT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash, kKey2));
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash,
kKey1, base::Value("value_1"));
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash,
kKey2, base::Value(123));
{
const base::Value* value_1 = GetAccountKeyedPrefDictEntry(
&pref_service, kPrefPathDict, gaia_id_hash, kKey1);
ASSERT_TRUE(value_1);
EXPECT_EQ(*value_1, base::Value("value_1"));
}
{
const base::Value* value_2 = GetAccountKeyedPrefDictEntry(
&pref_service, kPrefPathDict, gaia_id_hash, kKey2);
ASSERT_TRUE(value_2);
EXPECT_EQ(*value_2, base::Value(123));
}
ClearAccountKeyedPrefValue(&pref_service, kPrefPathDict, gaia_id_hash);
EXPECT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash, kKey1));
EXPECT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash, kKey2));
}
TEST(AccountPrefUtils, ShouldKeepGaiaIdsSeparateForDictPref) {
TestingPrefServiceSimple pref_service;
pref_service.registry()->RegisterDictionaryPref(kPrefPathDict);
const signin::GaiaIdHash gaia_id_hash_1 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_1"));
const signin::GaiaIdHash gaia_id_hash_2 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_2"));
const char kKey[] = "key";
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash_1,
kKey, base::Value("value_1"));
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash_2,
kKey, base::Value("value_2"));
// Setting the same pref key for the second GaiaID shouldn't have affected the
// first one's value.
{
const base::Value* value_1 = GetAccountKeyedPrefDictEntry(
&pref_service, kPrefPathDict, gaia_id_hash_1, kKey);
ASSERT_TRUE(value_1);
EXPECT_EQ(*value_1, base::Value("value_1"));
}
}
TEST(AccountPrefUtils, ShouldClearValuesForUnlistedAccounts) {
TestingPrefServiceSimple pref_service;
pref_service.registry()->RegisterDictionaryPref(kPrefPathScalar);
pref_service.registry()->RegisterDictionaryPref(kPrefPathDict);
const signin::GaiaIdHash gaia_id_hash_1 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_1"));
const signin::GaiaIdHash gaia_id_hash_2 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_2"));
const signin::GaiaIdHash gaia_id_hash_3 =
signin::GaiaIdHash::FromGaiaId(GaiaId("gaia_id_3"));
const char kKey[] = "key";
// There are values set for the first two Gaia IDs.
SetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_1,
base::Value("value_1"));
SetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_2,
base::Value("value_2"));
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash_1,
kKey, base::Value("value_3"));
SetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict, gaia_id_hash_2,
kKey, base::Value("value_4"));
// The first Gaia ID is not available anymore.
KeepAccountKeyedPrefValuesOnlyForUsers(&pref_service, kPrefPathScalar,
{gaia_id_hash_2, gaia_id_hash_3});
// The first Gaia ID's value should've been cleared, the second one should
// still be there, and the third was never there in the first place.
EXPECT_FALSE(
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_1));
EXPECT_TRUE(
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_2));
EXPECT_FALSE(
GetAccountKeyedPrefValue(&pref_service, kPrefPathScalar, gaia_id_hash_3));
// Same for the dictionary-valued pref.
KeepAccountKeyedPrefValuesOnlyForUsers(&pref_service, kPrefPathDict,
{gaia_id_hash_2, gaia_id_hash_3});
EXPECT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash_1, kKey));
EXPECT_TRUE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash_2, kKey));
EXPECT_FALSE(GetAccountKeyedPrefDictEntry(&pref_service, kPrefPathDict,
gaia_id_hash_3, kKey));
}
} // namespace
} // namespace syncer
|
