File: controlled_frame_contextmenus_browsertest.cc

package info (click to toggle)
chromium 140.0.7339.127-1
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 6,192,880 kB
  • sloc: cpp: 35,093,808; ansic: 7,161,670; javascript: 4,199,694; python: 1,441,797; asm: 949,904; xml: 747,503; pascal: 187,748; perl: 88,691; sh: 88,248; objc: 79,953; sql: 52,714; cs: 44,599; fortran: 24,137; makefile: 22,114; tcl: 15,277; php: 13,980; yacc: 9,000; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (512 lines) | stat: -rw-r--r-- 19,315 bytes parent folder | download | duplicates (4)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
// Copyright 2025 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <memory>
#include <string>

#include "chrome/browser/controlled_frame/controlled_frame_test_base.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
#include "chrome/browser/web_applications/isolated_web_apps/isolated_web_app_url_info.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/context_menu_interceptor.h"
#include "content/public/test/hit_test_region_observer.h"
#include "extensions/browser/guest_view/web_view/web_view_guest.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/input/web_input_event.h"
#include "third_party/blink/public/common/input/web_mouse_event.h"

namespace controlled_frame {

using testing::Each;
using testing::Eq;

constexpr char kEvalSuccessStr[] = "SUCCESS";

class ControlledFrameContextMenusTest : public ControlledFrameTestBase {
 public:
  ControlledFrameContextMenusTest()
      : ControlledFrameTestBase(
            /*channel=*/version_info::Channel::STABLE,
            /*feature_setting=*/FeatureSetting::ENABLED,
            /*flag_setting=*/FlagSetting::CONTROLLED_FRAME) {}

  void SetUpOnMainThread() override {
    ControlledFrameTestBase::SetUpOnMainThread();
    StartContentServer("web_apps/simple_isolated_app");
  }

  const extensions::MenuItem::Id CreateMenuItemId(
      const extensions::MenuItem::ExtensionKey& extension_key,
      const std::string& string_uid) {
    extensions::MenuItem::Id id;
    id.extension_key = extension_key;
    id.string_uid = string_uid;
    return id;
  }

  void ExpectMenuItemWithIdAndTitle(
      const extensions::MenuItem::ExtensionKey& extension_key,
      const std::string& expected_id,
      const std::string& expected_title) {
    auto* menu_manager = extensions::MenuManager::Get(profile());
    extensions::MenuItem* menu_item =
        menu_manager->GetItemById(CreateMenuItemId(extension_key, expected_id));

    ASSERT_TRUE(menu_item);
    EXPECT_EQ(expected_title, menu_item->title());
  }

  const content::EvalJsResult CreateContextMenuItem(
      content::RenderFrameHost* app_frame,
      const std::string& id,
      const std::string& title) {
    return content::EvalJs(app_frame, content::JsReplace(R"(
      new Promise(async (resolve, reject) => {
        const frame = document.getElementsByTagName('controlledframe')[0];
        if (!frame || !frame.contextMenus || !frame.contextMenus.create) {
          reject('FAIL: frame, frame.contextMenus, or ' +
              'frame.contextMenus.create is undefined');
          return;
        }
        await frame.contextMenus.create({ title: $2, id: $1 });
        resolve('SUCCESS');
      });
    )",
                                                         id, title));
  }

  const content::EvalJsResult UpdateContextMenuItemTitle(
      content::RenderFrameHost* app_frame,
      const std::string& id,
      const std::string& new_title) {
    return content::EvalJs(app_frame, content::JsReplace(R"(
      new Promise(async (resolve, reject) => {
        const frame = document.getElementsByTagName('controlledframe')[0];
        if (!frame || !frame.contextMenus || !frame.contextMenus.update) {
          reject('FAIL: frame, frame.contextMenus, or ' +
              'frame.contextMenus.update is undefined');
          return;
        }

        await frame.contextMenus.update(/*id=*/$1, { title: $2 });
        resolve('SUCCESS');
      });
  )",
                                                         id, new_title));
  }

  const content::EvalJsResult RemoveContextMenuItem(
      content::RenderFrameHost* app_frame,
      const std::string& id) {
    return content::EvalJs(app_frame, content::JsReplace(R"(
      new Promise(async (resolve, reject) => {
        const frame = document.getElementsByTagName('controlledframe')[0];
        if (!frame || !frame.contextMenus || !frame.contextMenus.remove) {
          reject('FAIL: frame, frame.contextMenus, or ' +
              'frame.contextMenus.remove is undefined');
          return;
        }

        await frame.contextMenus.remove(/*id=*/$1);
        resolve('SUCCESS');
      });
  )",
                                                         id));
  }

  const content::EvalJsResult RemoveAllContextMenuItems(
      content::RenderFrameHost* app_frame) {
    return content::EvalJs(app_frame, R"(
      new Promise(async (resolve, reject) => {
        const frame = document.getElementsByTagName('controlledframe')[0];
        if (!frame || !frame.contextMenus || !frame.contextMenus.removeAll) {
          reject('FAIL: frame, frame.contextMenus, or ' +
              'frame.contextMenus.removeAll is undefined');
          return;
        }

        await frame.contextMenus.removeAll();
        resolve('SUCCESS');
      });
  )");
  }

  void SimulateOpenContextMenu(content::RenderFrameHost* controlled_frame) {
    CHECK(controlled_frame);
    content::WaitForHitTestData(
        content::WebContents::FromRenderFrameHost(controlled_frame));

    auto context_menu_interceptor =
        std::make_unique<content::ContextMenuInterceptor>(controlled_frame);
    gfx::Point click_pos(1, 1);
    content::SimulateMouseClickAt(
        content::WebContents::FromRenderFrameHost(controlled_frame),
        blink::WebInputEvent::kNoModifiers,
        blink::WebMouseEvent::Button::kRight, click_pos);
    context_menu_interceptor->Wait();
  }

  void SimulateClickContextMenuItem(
      content::RenderFrameHost* controlled_frame) {
    CHECK(controlled_frame);
    // Create and build our test context menu.
    std::unique_ptr<TestRenderViewContextMenu> menu(
        TestRenderViewContextMenu::Create(
            controlled_frame, controlled_frame->GetLastCommittedURL()));
    // Look for the extension item in the menu, and execute it.
    int command_id =
        extensions::ContextMenuMatcher::ConvertToExtensionsCustomCommandId(0);
    CHECK(menu->IsCommandIdEnabled(command_id));
    menu->ExecuteCommand(command_id, /*event_flags=*/0);
  }
};

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, Create) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));
  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  auto* menu_manager = extensions::MenuManager::Get(profile());

  const extensions::MenuItem::ExtensionKey extension_key(
      /*extension_id=*/"",
      web_view_guest->owner_rfh()->GetProcess()->GetDeprecatedID(),
      web_view_guest->owner_rfh()->GetRoutingID(),
      web_view_guest->view_instance_id());
  EXPECT_EQ(0u, menu_manager->MenuItemsSize(extension_key));

  static constexpr std::string kItem1ID = "1";
  static constexpr std::string kItem1Title = "Test";
  EXPECT_EQ(kEvalSuccessStr,
            CreateContextMenuItem(app_frame, kItem1ID, kItem1Title));
  ASSERT_EQ(1u, menu_manager->MenuItemsSize(extension_key));
  ExpectMenuItemWithIdAndTitle(extension_key, kItem1ID, kItem1Title);

  static constexpr std::string kItem2ID = "2";
  static constexpr std::string kItem2Title = "Test2";
  EXPECT_EQ(kEvalSuccessStr,
            CreateContextMenuItem(app_frame, kItem2ID, kItem2Title));
  ASSERT_EQ(2u, menu_manager->MenuItemsSize(extension_key));
  ExpectMenuItemWithIdAndTitle(extension_key, kItem2ID, kItem2Title);

  static constexpr std::string kItem3ID = "3";
  static constexpr std::string kItem3Title = "Test3";
  EXPECT_EQ(kEvalSuccessStr,
            CreateContextMenuItem(app_frame, kItem3ID, kItem3Title));
  ASSERT_EQ(3u, menu_manager->MenuItemsSize(extension_key));
  ExpectMenuItemWithIdAndTitle(extension_key, kItem3ID, kItem3Title);
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, Update) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));
  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  auto* menu_manager = extensions::MenuManager::Get(profile());

  static constexpr std::string kItem1ID = "1";
  static constexpr std::string kItem1Title = "Test";
  EXPECT_EQ(kEvalSuccessStr,
            CreateContextMenuItem(app_frame, kItem1ID, kItem1Title));

  const extensions::MenuItem::ExtensionKey extension_key(
      /*extension_id=*/"",
      web_view_guest->owner_rfh()->GetProcess()->GetDeprecatedID(),
      web_view_guest->owner_rfh()->GetRoutingID(),
      web_view_guest->view_instance_id());
  ASSERT_EQ(1u, menu_manager->MenuItemsSize(extension_key));
  ExpectMenuItemWithIdAndTitle(extension_key, kItem1ID, kItem1Title);

  static constexpr std::string kItem1NewTitle = "Test1";
  EXPECT_EQ(kEvalSuccessStr,
            UpdateContextMenuItemTitle(app_frame, kItem1ID, kItem1NewTitle));

  ASSERT_EQ(1u, menu_manager->MenuItemsSize(extension_key));
  ExpectMenuItemWithIdAndTitle(extension_key, kItem1ID, kItem1NewTitle);
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, Remove) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));
  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  auto* menu_manager = extensions::MenuManager::Get(profile());

  static constexpr std::string kItem1ID = "1";
  static constexpr std::string kItem1Title = "Test1";
  EXPECT_EQ(kEvalSuccessStr,
            CreateContextMenuItem(app_frame, kItem1ID, kItem1Title));
  EXPECT_EQ(kEvalSuccessStr, CreateContextMenuItem(app_frame, /*id=*/"2",
                                                   /*title=*/"Test2"));

  EXPECT_EQ(kEvalSuccessStr, RemoveContextMenuItem(app_frame, kItem1ID));

  const extensions::MenuItem::ExtensionKey extension_key(
      /*extension_id=*/"",
      web_view_guest->owner_rfh()->GetProcess()->GetDeprecatedID(),
      web_view_guest->owner_rfh()->GetRoutingID(),
      web_view_guest->view_instance_id());
  ASSERT_EQ(1u, menu_manager->MenuItemsSize(extension_key));

  extensions::MenuItem* deleted_item =
      menu_manager->GetItemById(CreateMenuItemId(extension_key, kItem1ID));
  EXPECT_FALSE(deleted_item);
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, RemoveAll) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));
  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  auto* menu_manager = extensions::MenuManager::Get(profile());

  EXPECT_EQ(kEvalSuccessStr, CreateContextMenuItem(app_frame, /*id=*/"1",
                                                   /*title=*/"Test1"));
  EXPECT_EQ(kEvalSuccessStr, CreateContextMenuItem(app_frame, /*id=*/"2",
                                                   /*title=*/"Test2"));

  EXPECT_EQ(kEvalSuccessStr, RemoveAllContextMenuItems(app_frame));

  const extensions::MenuItem::ExtensionKey extension_key(
      /*extension_id=*/"",
      web_view_guest->owner_rfh()->GetProcess()->GetDeprecatedID(),
      web_view_guest->owner_rfh()->GetRoutingID(),
      web_view_guest->view_instance_id());
  ASSERT_EQ(0u, menu_manager->MenuItemsSize(extension_key));
}

// TODO(crbug.com/392208013): Fix and enable on Mac.
#if BUILDFLAG(IS_MAC)
#define MAYBE_ShowEvent DISABLED_ShowEvent
#else
#define MAYBE_ShowEvent ShowEvent
#endif  // BUILDFLAG(IS_MAC)
IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, MAYBE_ShowEvent) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));

  auto add_handler_script = content::JsReplace(
      R"(
document.onShowHandler = function() {
  document.onShowCount = (document.onShowCount ?? 0) + 1;
};

(function() {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    return ('FAIL: frame or frame.contextMenus is undefined');
  }

  frame.contextMenus.addEventListener('show', document.onShowHandler);
  return $1;
})();
)",
      kEvalSuccessStr);

  // Add a listener for 'show' then simulate right click and expect the
  // listener to be triggered.
  ASSERT_EQ(content::EvalJs(app_frame, add_handler_script), kEvalSuccessStr);

  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  ASSERT_TRUE(web_view_guest);
  content::RenderFrameHost* controlled_frame =
      web_view_guest->GetGuestMainFrame();
  ASSERT_TRUE(controlled_frame);
  SimulateOpenContextMenu(controlled_frame);
  ASSERT_EQ(content::EvalJs(app_frame, "document.onShowCount"), 1);

  auto remove_handler_script = content::JsReplace(
      R"(
(function() {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    return ('FAIL: frame or frame.contextMenus is undefined');
  }

  frame.contextMenus.removeEventListener('show', document.onShowHandler);
  return $1;
})();
)",
      kEvalSuccessStr);

  // Remove the listener for 'onShow' then simulate right click and expect the
  // listener to not be triggered.
  ASSERT_EQ(content::EvalJs(app_frame, remove_handler_script), kEvalSuccessStr);

  SimulateOpenContextMenu(controlled_frame);
  ASSERT_EQ(content::EvalJs(app_frame, "document.onShowCount"), 1);
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, NoLegacyOnShowEvent) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));

  const auto* check_legacy_event_script = R"(
new Promise(async (resolve, reject) => {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    reject('FAIL: frame or frame.contextMenus is undefined');
    return;
  }

  if (frame.contextMenus.onShow) {
    reject('FAIL: contextMenus object contains an onShow attribute');
    return;
  }
  resolve('SUCCESS');
});
    )";

  ASSERT_EQ(content::EvalJs(app_frame, check_legacy_event_script),
            kEvalSuccessStr);
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, ClickEvent) {
  constexpr std::string kItemID = "107";

  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));

  auto create_context_menu_script = content::JsReplace(R"(
new Promise(async (resolve, reject) => {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus || !frame.contextMenus.create) {
    reject('FAIL: frame, frame.contextMenus, or ' +
        'frame.contextMenus.create is undefined');
    return;
  }
  await frame.contextMenus.create(
  {
    title: 'test_title',
    id: $1,
  });
  resolve('SUCCESS');
});
    )",
                                                       kItemID);

  // Create a ContextMenu item with a inline listener.
  ASSERT_EQ(content::EvalJs(app_frame, create_context_menu_script),
            kEvalSuccessStr);

  auto add_handler_script = content::JsReplace(
      R"(
document.onClickedHandler = function(info) {
  document.clickedMenuItemId =
      [...(document.clickedMenuItemId ?? []), info.menuItem.id];
  document.globalOnClickedCount = (document.globalOnClickedCount ?? 0) + 1;
};

(function() {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    return ('FAIL: frame or frame.contextMenus is undefined');
  }

  frame.contextMenus.addEventListener('click', document.onClickedHandler);
  return $1;
})();
)",
      kEvalSuccessStr);

  // Add a global listener for the 'clicked' event, then simulate clicking on
  // menu item.
  ASSERT_EQ(content::EvalJs(app_frame, add_handler_script), kEvalSuccessStr);

  extensions::WebViewGuest* web_view_guest = GetWebViewGuest(app_frame);
  ASSERT_TRUE(web_view_guest);
  content::RenderFrameHost* controlled_frame =
      web_view_guest->GetGuestMainFrame();
  ASSERT_TRUE(controlled_frame);
  SimulateClickContextMenuItem(controlled_frame);

  EXPECT_EQ(content::EvalJs(app_frame, "document.globalOnClickedCount"), 1);
  EXPECT_THAT(content::EvalJs(app_frame, "document.clickedMenuItemId")
                  .TakeValue()
                  .TakeList(),
              Each(Eq(kItemID)));

  auto remove_handler_script = content::JsReplace(
      R"(
(function() {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    return ('FAIL: frame or frame.contextMenus is undefined');
  }

  frame.contextMenus.removeEventListener('click', document.onClickedHandler);
  return $1;
})();
)",
      kEvalSuccessStr);

  // Remove the global listener for 'click' then simulate clicking on menu
  // item.
  ASSERT_EQ(content::EvalJs(app_frame, remove_handler_script), kEvalSuccessStr);

  SimulateClickContextMenuItem(controlled_frame);
  EXPECT_EQ(content::EvalJs(app_frame, "document.globalOnClickedCount"), 1);
  EXPECT_THAT(
      content::EvalJs(app_frame, "document.clickedMenuItemId").ExtractList(),
      Each(Eq(kItemID)));
}

IN_PROC_BROWSER_TEST_F(ControlledFrameContextMenusTest, NoLegacyOnClickEvent) {
  web_app::IsolatedWebAppUrlInfo url_info =
      CreateAndInstallEmptyApp(web_app::ManifestBuilder());
  content::RenderFrameHost* app_frame = OpenApp(url_info.app_id());

  ASSERT_TRUE(CreateControlledFrame(
      app_frame, embedded_https_test_server().GetURL("/index.html")));

  const auto* check_legacy_event_script = R"(
new Promise(async (resolve, reject) => {
  const frame = document.getElementsByTagName('controlledframe')[0];
  if (!frame || !frame.contextMenus) {
    reject('FAIL: frame or frame.contextMenus is undefined');
    return;
  }

  if (frame.contextMenus.onClick) {
    reject('FAIL: contextMenus object contains an onClick attribute');
    return;
  }
  resolve('SUCCESS');
});
    )";

  ASSERT_EQ(content::EvalJs(app_frame, check_legacy_event_script),
            kEvalSuccessStr);
}

}  // namespace controlled_frame