1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689
|
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "modules/rtp_rtcp/include/flexfec_receiver.h"
#include <cstddef>
#include <cstdint>
#include <limits>
#include <list>
#include <memory>
#include <utility>
#include "modules/include/module_fec_types.h"
#include "modules/rtp_rtcp/include/recovered_packet_receiver.h"
#include "modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h"
#include "modules/rtp_rtcp/source/fec_test_helper.h"
#include "modules/rtp_rtcp/source/forward_error_correction.h"
#include "modules/rtp_rtcp/source/rtp_packet_received.h"
#include "modules/rtp_rtcp/source/ulpfec_receiver.h"
#include "rtc_base/checks.h"
#include "test/gmock.h"
#include "test/gtest.h"
namespace webrtc {
namespace {
using ::testing::_;
using ::testing::Eq;
using ::testing::Property;
using test::fec::FlexfecPacketGenerator;
using Packet = ForwardErrorCorrection::Packet;
using PacketList = ForwardErrorCorrection::PacketList;
constexpr size_t kPayloadLength = 500;
constexpr uint32_t kFlexfecSsrc = 42984;
constexpr uint32_t kMediaSsrc = 8353;
RtpPacketReceived ParsePacket(const Packet& packet) {
RtpPacketReceived parsed_packet;
EXPECT_TRUE(parsed_packet.Parse(packet.data));
return parsed_packet;
}
} // namespace
class FlexfecReceiverForTest : public FlexfecReceiver {
public:
FlexfecReceiverForTest(uint32_t ssrc,
uint32_t protected_media_ssrc,
RecoveredPacketReceiver* recovered_packet_receiver)
: FlexfecReceiver(Clock::GetRealTimeClock(),
ssrc,
protected_media_ssrc,
recovered_packet_receiver) {}
// Expose methods for tests.
using FlexfecReceiver::AddReceivedPacket;
using FlexfecReceiver::ProcessReceivedPacket;
};
class FlexfecReceiverTest : public ::testing::Test {
protected:
FlexfecReceiverTest()
: receiver_(kFlexfecSsrc, kMediaSsrc, &recovered_packet_receiver_),
erasure_code_(
ForwardErrorCorrection::CreateFlexfec(kFlexfecSsrc, kMediaSsrc)),
packet_generator_(kMediaSsrc, kFlexfecSsrc) {}
// Generates `num_media_packets` corresponding to a single frame.
void PacketizeFrame(size_t num_media_packets,
size_t frame_offset,
PacketList* media_packets);
// Generates `num_fec_packets` FEC packets, given `media_packets`.
std::list<Packet*> EncodeFec(const PacketList& media_packets,
size_t num_fec_packets);
FlexfecReceiverForTest receiver_;
std::unique_ptr<ForwardErrorCorrection> erasure_code_;
FlexfecPacketGenerator packet_generator_;
::testing::StrictMock<MockRecoveredPacketReceiver> recovered_packet_receiver_;
};
void FlexfecReceiverTest::PacketizeFrame(size_t num_media_packets,
size_t frame_offset,
PacketList* media_packets) {
packet_generator_.NewFrame(num_media_packets);
for (size_t i = 0; i < num_media_packets; ++i) {
auto next_packet = std::make_unique<Packet>();
next_packet->data =
packet_generator_.NextPacket(frame_offset + i, kPayloadLength).Buffer();
media_packets->push_back(std::move(next_packet));
}
}
std::list<Packet*> FlexfecReceiverTest::EncodeFec(
const PacketList& media_packets,
size_t num_fec_packets) {
const uint8_t protection_factor =
num_fec_packets * 255 / media_packets.size();
constexpr int kNumImportantPackets = 0;
constexpr bool kUseUnequalProtection = false;
constexpr FecMaskType kFecMaskType = kFecMaskRandom;
std::list<Packet*> fec_packets;
EXPECT_EQ(0, erasure_code_->EncodeFec(
media_packets, protection_factor, kNumImportantPackets,
kUseUnequalProtection, kFecMaskType, &fec_packets));
EXPECT_EQ(num_fec_packets, fec_packets.size());
return fec_packets;
}
TEST_F(FlexfecReceiverTest, ReceivesMediaPacket) {
packet_generator_.NewFrame(1);
RtpPacketReceived media_packet =
packet_generator_.NextPacket<RtpPacketReceived>(0, kPayloadLength);
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(media_packet);
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
}
TEST_F(FlexfecReceiverTest, ReceivesMediaAndFecPackets) {
const size_t kNumMediaPackets = 1;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
const auto& media_packet = media_packets.front();
auto fec_packet = packet_generator_.BuildFlexfecPacket(*fec_packets.front());
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(ParsePacket(*media_packet));
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
received_packet = receiver_.AddReceivedPacket(fec_packet);
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
}
TEST_F(FlexfecReceiverTest, FailsOnTruncatedFecPacket) {
const size_t kNumMediaPackets = 1;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
const auto& media_packet = media_packets.front();
// Simulate truncated FlexFEC payload.
fec_packets.front()->data.SetSize(1);
auto fec_packet = packet_generator_.BuildFlexfecPacket(*fec_packets.front());
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(ParsePacket(*media_packet));
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
EXPECT_FALSE(receiver_.AddReceivedPacket(fec_packet));
}
TEST_F(FlexfecReceiverTest, FailsOnUnknownMediaSsrc) {
const size_t kNumMediaPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
auto& media_packet = media_packets.front();
// Corrupt the SSRC.
media_packet->data.MutableData()[8] = 0;
media_packet->data.MutableData()[9] = 1;
media_packet->data.MutableData()[10] = 2;
media_packet->data.MutableData()[11] = 3;
EXPECT_FALSE(receiver_.AddReceivedPacket(ParsePacket(*media_packet)));
}
TEST_F(FlexfecReceiverTest, FailsOnUnknownFecSsrc) {
const size_t kNumMediaPackets = 1;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
const auto& media_packet = media_packets.front();
auto fec_packet = packet_generator_.BuildFlexfecPacket(*fec_packets.front());
// Corrupt the SSRC.
fec_packet.SetSsrc(0x04050607);
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(ParsePacket(*media_packet));
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
EXPECT_FALSE(receiver_.AddReceivedPacket(fec_packet));
}
TEST_F(FlexfecReceiverTest, ReceivesMultiplePackets) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive all media packets.
for (const auto& media_packet : media_packets) {
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(ParsePacket(*media_packet));
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
}
// Receive FEC packet.
auto* fec_packet = fec_packets.front();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(*fec_packet);
std::unique_ptr<ForwardErrorCorrection::ReceivedPacket> received_packet =
receiver_.AddReceivedPacket(packet_with_rtp_header);
ASSERT_TRUE(received_packet);
receiver_.ProcessReceivedPacket(*received_packet);
}
TEST_F(FlexfecReceiverTest, RecoversFromSingleMediaLoss) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive first media packet but drop second.
auto media_it = media_packets.begin();
receiver_.OnRtpPacket(ParsePacket(**media_it));
// Receive FEC packet and ensure recovery of lost media packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
media_it++;
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
}
TEST_F(FlexfecReceiverTest, RecoversFromDoubleMediaLoss) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 2;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Drop both media packets.
// Receive first FEC packet and recover first lost media packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
auto media_it = media_packets.begin();
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
// Receive second FEC packet and recover second lost media packet.
fec_it++;
packet_with_rtp_header = packet_generator_.BuildFlexfecPacket(**fec_it);
media_it++;
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
}
TEST_F(FlexfecReceiverTest, DoesNotRecoverFromMediaAndFecLoss) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive first media packet.
auto media_it = media_packets.begin();
receiver_.OnRtpPacket(ParsePacket(**media_it));
// Drop second media packet and FEC packet. Do not expect call back.
}
TEST_F(FlexfecReceiverTest, DoesNotCallbackTwice) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive first media packet but drop second.
auto media_it = media_packets.begin();
receiver_.OnRtpPacket(ParsePacket(**media_it));
// Receive FEC packet and ensure recovery of lost media packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
media_it++;
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
// Receive the FEC packet again, but do not call back.
receiver_.OnRtpPacket(packet_with_rtp_header);
// Receive the first media packet again, but do not call back.
media_it = media_packets.begin();
receiver_.OnRtpPacket(ParsePacket(**media_it));
// Receive the second media packet again (the one recovered above),
// but do not call back again.
media_it++;
receiver_.OnRtpPacket(ParsePacket(**media_it));
}
// Here we are implicitly assuming packet masks that are suitable for
// this type of 50% correlated loss. If we are changing our precomputed
// packet masks, this test might need to be updated.
TEST_F(FlexfecReceiverTest, RecoversFrom50PercentLoss) {
const size_t kNumFecPackets = 5;
const size_t kNumFrames = 2 * kNumFecPackets;
const size_t kNumMediaPacketsPerFrame = 1;
PacketList media_packets;
for (size_t i = 0; i < kNumFrames; ++i) {
PacketizeFrame(kNumMediaPacketsPerFrame, i, &media_packets);
}
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Drop every second media packet.
auto media_it = media_packets.begin();
while (media_it != media_packets.end()) {
receiver_.OnRtpPacket(ParsePacket(**media_it));
++media_it;
if (media_it == media_packets.end()) {
break;
}
++media_it;
}
// Receive all FEC packets.
media_it = media_packets.begin();
for (const auto* fec_packet : fec_packets) {
RtpPacketReceived fec_packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(*fec_packet);
++media_it;
if (media_it == media_packets.end()) {
break;
}
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(Property(&RtpPacketReceived::Buffer,
Eq((*media_it)->data))));
receiver_.OnRtpPacket(fec_packet_with_rtp_header);
++media_it;
}
}
TEST_F(FlexfecReceiverTest, DelayedFecPacketDoesHelp) {
// These values need to be updated if the underlying erasure code
// implementation changes.
// Delay FEC packet by maximum number of media packets tracked by receiver.
const size_t kNumFrames = 192;
const size_t kNumMediaPacketsPerFrame = 1;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPacketsPerFrame, 0, &media_packets);
PacketizeFrame(kNumMediaPacketsPerFrame, 1, &media_packets);
// Protect two first frames.
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
for (size_t i = 2; i < kNumFrames; ++i) {
PacketizeFrame(kNumMediaPacketsPerFrame, i, &media_packets);
}
// Drop first media packet and delay FEC packet.
auto media_it = media_packets.begin();
++media_it;
// Receive all other media packets.
while (media_it != media_packets.end()) {
receiver_.OnRtpPacket(ParsePacket(**media_it));
++media_it;
}
// Receive FEC packet and recover first media packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
media_it = media_packets.begin();
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
}
TEST_F(FlexfecReceiverTest, TooDelayedFecPacketDoesNotHelp) {
// These values need to be updated if the underlying erasure code
// implementation changes.
// Delay FEC packet by one more than maximum number of media packets
// tracked by receiver.
const size_t kNumFrames = 193;
const size_t kNumMediaPacketsPerFrame = 1;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPacketsPerFrame, 0, &media_packets);
PacketizeFrame(kNumMediaPacketsPerFrame, 1, &media_packets);
// Protect first two frames.
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
for (size_t i = 2; i < kNumFrames; ++i) {
PacketizeFrame(kNumMediaPacketsPerFrame, i, &media_packets);
}
// Drop first media packet and delay FEC packet.
auto media_it = media_packets.begin();
++media_it;
// Receive all other media packets.
while (media_it != media_packets.end()) {
receiver_.OnRtpPacket(ParsePacket(**media_it));
++media_it;
}
// Receive FEC packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
receiver_.OnRtpPacket(packet_with_rtp_header);
// Do not expect a call back.
}
TEST_F(FlexfecReceiverTest, SurvivesOldRecoveredPacketBeingReinserted) {
// Simulates the behaviour of the
// Call->FlexfecReceiveStream->FlexfecReceiver->Call loop in production code.
class LoopbackRecoveredPacketReceiver : public RecoveredPacketReceiver {
public:
LoopbackRecoveredPacketReceiver() : receiver_(nullptr) {}
void SetReceiver(FlexfecReceiver* receiver) { receiver_ = receiver; }
// Implements RecoveredPacketReceiver.
void OnRecoveredPacket(const RtpPacketReceived& packet) override {
EXPECT_TRUE(packet.recovered());
RTC_DCHECK(receiver_);
receiver_->OnRtpPacket(packet);
}
private:
FlexfecReceiver* receiver_;
} loopback_recovered_packet_receiver;
// Feed recovered packets back into `receiver`.
FlexfecReceiver receiver(Clock::GetRealTimeClock(), kFlexfecSsrc, kMediaSsrc,
&loopback_recovered_packet_receiver);
loopback_recovered_packet_receiver.SetReceiver(&receiver);
// Receive first set of packets.
PacketList first_media_packets;
for (int i = 0; i < 46; ++i) {
PacketizeFrame(1, 0, &first_media_packets);
}
for (const auto& media_packet : first_media_packets) {
receiver.OnRtpPacket(ParsePacket(*media_packet));
}
// Protect one media packet. Lose the media packet,
// but do not receive FEC packet yet.
PacketList protected_media_packet;
PacketizeFrame(1, 0, &protected_media_packet);
const std::list<Packet*> fec_packets = EncodeFec(protected_media_packet, 1);
EXPECT_EQ(1u, fec_packets.size());
RtpPacketReceived fec_packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(*fec_packets.front());
// Lose some packets, thus introducing a sequence number gap.
PacketList lost_packets;
for (int i = 0; i < 100; ++i) {
PacketizeFrame(1, 0, &lost_packets);
}
// Receive one more packet.
PacketList second_media_packets;
PacketizeFrame(1, 0, &second_media_packets);
for (const auto& media_packet : second_media_packets) {
receiver.OnRtpPacket(ParsePacket(*media_packet));
}
// Receive delayed FEC packet.
receiver.OnRtpPacket(fec_packet_with_rtp_header);
// Expect no crash.
}
TEST_F(FlexfecReceiverTest, RecoversWithMediaPacketsOutOfOrder) {
const size_t kNumMediaPackets = 6;
const size_t kNumFecPackets = 2;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Lose two media packets, and receive the others out of order.
auto media_it = media_packets.begin();
auto media_packet0 = media_it++;
auto media_packet1 = media_it++;
auto media_packet2 = media_it++;
auto media_packet3 = media_it++;
auto media_packet4 = media_it++;
auto media_packet5 = media_it++;
receiver_.OnRtpPacket(ParsePacket(**media_packet5));
receiver_.OnRtpPacket(ParsePacket(**media_packet2));
receiver_.OnRtpPacket(ParsePacket(**media_packet3));
receiver_.OnRtpPacket(ParsePacket(**media_packet0));
// Expect to recover lost media packets.
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(Property(&RtpPacketReceived::Buffer,
Eq((*media_packet1)->data))));
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(Property(&RtpPacketReceived::Buffer,
Eq((*media_packet4)->data))));
// Add FEC packets.
for (Packet* fec_packet : fec_packets) {
receiver_.OnRtpPacket(packet_generator_.BuildFlexfecPacket(*fec_packet));
}
}
// Recovered media packets may be fed back into the FlexfecReceiver by the
// callback. This test ensures the idempotency of such a situation.
TEST_F(FlexfecReceiverTest, RecoveryCallbackDoesNotLoopInfinitely) {
class LoopbackRecoveredPacketReceiver : public RecoveredPacketReceiver {
public:
const int kMaxRecursionDepth = 10;
LoopbackRecoveredPacketReceiver()
: receiver_(nullptr),
did_receive_call_back_(false),
recursion_depth_(0),
deep_recursion_(false) {}
void SetReceiver(FlexfecReceiver* receiver) { receiver_ = receiver; }
bool DidReceiveCallback() const { return did_receive_call_back_; }
bool DeepRecursion() const { return deep_recursion_; }
// Implements RecoveredPacketReceiver.
void OnRecoveredPacket(const RtpPacketReceived& packet) override {
did_receive_call_back_ = true;
if (recursion_depth_ > kMaxRecursionDepth) {
deep_recursion_ = true;
return;
}
++recursion_depth_;
RTC_DCHECK(receiver_);
receiver_->OnRtpPacket(packet);
--recursion_depth_;
}
private:
FlexfecReceiver* receiver_;
bool did_receive_call_back_;
int recursion_depth_;
bool deep_recursion_;
} loopback_recovered_packet_receiver;
// Feed recovered packets back into `receiver`.
FlexfecReceiver receiver(Clock::GetRealTimeClock(), kFlexfecSsrc, kMediaSsrc,
&loopback_recovered_packet_receiver);
loopback_recovered_packet_receiver.SetReceiver(&receiver);
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive first media packet but drop second.
auto media_it = media_packets.begin();
receiver.OnRtpPacket(ParsePacket(**media_it));
// Receive FEC packet and verify that a packet was recovered.
auto fec_it = fec_packets.begin();
receiver.OnRtpPacket(packet_generator_.BuildFlexfecPacket(**fec_it));
EXPECT_TRUE(loopback_recovered_packet_receiver.DidReceiveCallback());
EXPECT_FALSE(loopback_recovered_packet_receiver.DeepRecursion());
}
TEST_F(FlexfecReceiverTest, CalculatesNumberOfPackets) {
const size_t kNumMediaPackets = 2;
const size_t kNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kNumMediaPackets, 0, &media_packets);
std::list<Packet*> fec_packets = EncodeFec(media_packets, kNumFecPackets);
// Receive first media packet but drop second.
auto media_it = media_packets.begin();
receiver_.OnRtpPacket(ParsePacket(**media_it));
// Receive FEC packet and ensure recovery of lost media packet.
auto fec_it = fec_packets.begin();
RtpPacketReceived packet_with_rtp_header =
packet_generator_.BuildFlexfecPacket(**fec_it);
media_it++;
EXPECT_CALL(recovered_packet_receiver_,
OnRecoveredPacket(
Property(&RtpPacketReceived::Buffer, Eq((*media_it)->data))));
receiver_.OnRtpPacket(packet_with_rtp_header);
// Check stats calculations.
FecPacketCounter packet_counter = receiver_.GetPacketCounter();
EXPECT_EQ(2U, packet_counter.num_packets);
EXPECT_EQ(1U, packet_counter.num_fec_packets);
EXPECT_EQ(1U, packet_counter.num_recovered_packets);
}
TEST_F(FlexfecReceiverTest, DoesNotDecodeWrappedMediaSequenceUsingOldFec) {
const size_t kFirstFrameNumMediaPackets = 2;
const size_t kFirstFrameNumFecPackets = 1;
PacketList media_packets;
PacketizeFrame(kFirstFrameNumMediaPackets, 0, &media_packets);
// Protect first frame (sequences 0 and 1) with 1 FEC packet.
std::list<Packet*> fec_packets =
EncodeFec(media_packets, kFirstFrameNumFecPackets);
// Generate enough media packets to simulate media sequence number wraparound.
// Use no FEC for these frames to make sure old FEC is not purged due to age.
const size_t kNumFramesSequenceWrapAround =
std::numeric_limits<uint16_t>::max();
const size_t kNumMediaPacketsPerFrame = 1;
for (size_t i = 1; i <= kNumFramesSequenceWrapAround; ++i) {
PacketizeFrame(kNumMediaPacketsPerFrame, i, &media_packets);
}
// Receive first (`kFirstFrameNumMediaPackets` + 192) media packets.
// Simulate an old FEC packet by separating it from its encoded media
// packets by at least 192 packets.
auto media_it = media_packets.begin();
for (size_t i = 0; i < (kFirstFrameNumMediaPackets + 192); i++) {
if (i == 1) {
// Drop the second packet of the first frame.
media_it++;
} else {
receiver_.OnRtpPacket(ParsePacket(**media_it++));
}
}
// Receive FEC packet. Although a protected packet was dropped,
// expect no recovery callback since it is delayed from first frame
// by more than 192 packets.
auto fec_it = fec_packets.begin();
receiver_.OnRtpPacket(packet_generator_.BuildFlexfecPacket(**fec_it));
// Receive remaining media packets.
// NOTE: Because we sent enough to simulate wrap around, sequence 0 is
// received again, but is a different packet than the original first
// packet of first frame.
while (media_it != media_packets.end()) {
receiver_.OnRtpPacket(ParsePacket(**media_it++));
}
// Do not expect a recovery callback, the FEC packet is old
// and should not decode wrapped around media sequences.
}
} // namespace webrtc
|